)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"c1254ca7da7585e3dd3f5012511609720a5b72cb","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Factor out a mixin class for candidate aware filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"blueprint: pci-device-tracking-in-placement"},{"line_number":10,"context_line":"Change-Id: Id044131162e582cef41e424aa751e3cd3618ed0c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"552cf2ee_6cc079b9","line":9,"updated":"2023-02-02 05:56:27.000000000","message":"Could not see/find the blueprint","commit_id":"87c0602537688c3da2291792a98caf9d9faf9d6c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c92832b29cac70847e58e4fc612638970c196ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9dbe97a9_96f0b53d","updated":"2022-12-20 17:00:52.000000000","message":"I\u0027m not actually a fan of this. If increases LOC by ~200 lines and IMO makes the filters harder to read, not easier. I don\u0027t want to hold up the rest of the series for this alone but I will hold off +2 until I see whether we do any more with filters to warrant this","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"872cb3b0e82573a89c916742d1a3ebd20d2adcab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7d9b99bc_eb3bd073","in_reply_to":"5920c34b_e987b3ec","updated":"2023-01-05 14:43:51.000000000","message":"maybe instead of doing this via inheritance a mixin might be better?\n\nthat way we get to share code but only incude it in the filters that need it.","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29415014e0e3b825a2c4c37ae578cc95a71d9093","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6fc0f7d3_e46363e7","in_reply_to":"7d9b99bc_eb3bd073","updated":"2023-01-05 18:35:03.000000000","message":"I have a mixin class based proposal","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0cde0fdf436e8a0ea3fa18733fb8fcb7f5dbc4b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5920c34b_e987b3ec","in_reply_to":"9dbe97a9_96f0b53d","updated":"2022-12-21 15:42:01.000000000","message":"I moved this patch to the top of the series so we don\u0027t need to block the series while we discuss it next year.","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"872cb3b0e82573a89c916742d1a3ebd20d2adcab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"63c0cfd9_e07b9900","updated":"2023-01-05 14:43:51.000000000","message":"droping +2 so we can chat about the design","commit_id":"3ff007c2a13c24d5e3123908e158b69196e83144"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"7c4bb1d63ed06bc3b4f10dcc1b5bb38dab2ac713","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1f2e0000_47da20eb","updated":"2023-01-12 19:21:48.000000000","message":"Oh man, this is so much better. Thanks 🙏 Holding off +2 since there are failing CI jobs here that look valid (pep8 mainly) but please assume +2 once fixed.","commit_id":"48beb4660bb1a1348801fb00a6d3fb37de85934c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7e5c83d1abdcb5c6d1fac05db0f5710352240f7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"a9959790_f198af6d","updated":"2023-01-20 15:15:59.000000000","message":"fixed the pep8 failure and rebased on recent master","commit_id":"cb98e406bc92ffd783163675228084365129f5a8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"dac129296a32313bab8c88db42a8aad394703e36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e8341179_d3a1956a","updated":"2023-01-26 09:50:44.000000000","message":"recheck bug 2002782","commit_id":"87c0602537688c3da2291792a98caf9d9faf9d6c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"47ffb00edf97d39f5713447afc8ab713434deecf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"e728e8fc_2531eab6","updated":"2023-01-27 13:25:35.000000000","message":"recheck grenade keystone issue?\n\n2023-01-26 10:42:52.330331 | compute1 | + functions:wait_for_compute:495           :   openstack --os-cloud devstack-admin --os-region RegionOne compute service list\n\n2023-01-26 10:42:53.856705 | compute1 | Failed to discover available identity versions when contacting http://10.208.225.224/identity. Attempting to parse version from URL.\n\n2023-01-26 10:42:53.856950 | compute1 | Could not find versioned identity endpoints when attempting to authenticate. Please check that your auth_url is correct. Not Found (HTTP 404)","commit_id":"87c0602537688c3da2291792a98caf9d9faf9d6c"}],"nova/scheduler/filters/__init__.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4aa219d23062828a84b5ee208c1d56cdb2bbaa81","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        is needed. None is the default if not implemented."},{"line_number":86,"context_line":"        Override this in a subclass."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        return None"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def log_for_removed_host(self, host_state, spec_obj):"},{"line_number":91,"context_line":"        \"\"\"Override this to log a filter specific message when the host"}],"source_content_type":"text/x-python","patch_set":7,"id":"033eef4e_7bb1fe4e","line":88,"updated":"2022-11-03 13:03:25.000000000","message":"you are returning None to avoid using excpetions as controlfloww in host_passes correct?\n——-later——\nah None is also used later to signal that the generic host_passes imple should be used.","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2547f48a38c0030fa2f631859b8dd36d98736f9b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        is needed. None is the default if not implemented."},{"line_number":86,"context_line":"        Override this in a subclass."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        return None"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def log_for_removed_host(self, host_state, spec_obj):"},{"line_number":91,"context_line":"        \"\"\"Override this to log a filter specific message when the host"}],"source_content_type":"text/x-python","patch_set":7,"id":"88b5cd63_ca890512","line":88,"in_reply_to":"033eef4e_7bb1fe4e","updated":"2022-11-05 15:10:19.000000000","message":"Ack","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c92832b29cac70847e58e4fc612638970c196ad","unresolved":true,"context_lines":[{"line_number":101,"context_line":"            host_state, spec_obj)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # the filter was able to decide without look at the candidates so"},{"line_number":104,"context_line":"        # don\u0027t brother iterating on the candidates"},{"line_number":105,"context_line":"        if decision is not None:"},{"line_number":106,"context_line":"            return decision"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"b9fce51b_c60e04ee","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":23},"updated":"2022-12-20 17:00:52.000000000","message":"bother","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29415014e0e3b825a2c4c37ae578cc95a71d9093","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            host_state, spec_obj)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        # the filter was able to decide without look at the candidates so"},{"line_number":104,"context_line":"        # don\u0027t brother iterating on the candidates"},{"line_number":105,"context_line":"        if decision is not None:"},{"line_number":106,"context_line":"            return decision"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"967e925d_27552b05","line":104,"range":{"start_line":104,"start_character":16,"end_line":104,"end_character":23},"in_reply_to":"b9fce51b_c60e04ee","updated":"2023-01-05 18:35:03.000000000","message":"Ack","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"}],"nova/scheduler/filters/numa_topology_filter.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4aa219d23062828a84b5ee208c1d56cdb2bbaa81","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        if not host_topology:"},{"line_number":46,"context_line":"            return True"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if fields.CPUAllocationPolicy.DEDICATED not in cpu_policy:"},{"line_number":49,"context_line":"            return True"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        if fields.CPUThreadAllocationPolicy.REQUIRE not in cpu_thread_policy:"}],"source_content_type":"text/x-python","patch_set":7,"id":"0d2017f6_cc8dbd68","line":48,"updated":"2022-11-03 13:03:25.000000000","message":"this is a latent bug\nit does not account for mixed cpus or requesting pinned cpus via resouces:pcpus\n\nthis is just an optimisation since we actully validate the cpu constraits via numa_fit_instance_to_host call.","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"2547f48a38c0030fa2f631859b8dd36d98736f9b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if not host_topology:"},{"line_number":46,"context_line":"            return True"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if fields.CPUAllocationPolicy.DEDICATED not in cpu_policy:"},{"line_number":49,"context_line":"            return True"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        if fields.CPUThreadAllocationPolicy.REQUIRE not in cpu_thread_policy:"}],"source_content_type":"text/x-python","patch_set":7,"id":"91f3348e_8111f9cd","line":48,"in_reply_to":"0d2017f6_cc8dbd68","updated":"2022-11-05 15:10:19.000000000","message":"Ack","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2c92832b29cac70847e58e4fc612638970c196ad","unresolved":true,"context_lines":[{"line_number":118,"context_line":"        if network_metadata:"},{"line_number":119,"context_line":"            limits.network_metadata \u003d network_metadata"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        instance_topology \u003d (hardware.numa_fit_instance_to_host("},{"line_number":122,"context_line":"            host_topology, requested_topology,"},{"line_number":123,"context_line":"            limits\u003dlimits,"},{"line_number":124,"context_line":"            pci_requests\u003dpci_requests,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7e808aad_968bb80e","line":121,"range":{"start_line":121,"start_character":28,"end_line":121,"end_character":29},"updated":"2022-12-20 17:00:52.000000000","message":"nit: you don\u0027t need these brackets?","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"29415014e0e3b825a2c4c37ae578cc95a71d9093","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        if network_metadata:"},{"line_number":119,"context_line":"            limits.network_metadata \u003d network_metadata"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        instance_topology \u003d (hardware.numa_fit_instance_to_host("},{"line_number":122,"context_line":"            host_topology, requested_topology,"},{"line_number":123,"context_line":"            limits\u003dlimits,"},{"line_number":124,"context_line":"            pci_requests\u003dpci_requests,"}],"source_content_type":"text/x-python","patch_set":7,"id":"e69fdc68_a5b84493","line":121,"range":{"start_line":121,"start_character":28,"end_line":121,"end_character":29},"in_reply_to":"7e808aad_968bb80e","updated":"2023-01-05 18:35:03.000000000","message":"Done","commit_id":"f1c2d70f6678e78c70145761b214bac1a3ce40e0"}]}