)]}'
{"id":"openstack%2Fnova~855024","triplet_id":"openstack%2Fnova~stable%2Fyoga~I3998d0d49583806ac1c3ae64f1b1fe343cefd20d","project":"openstack/nova","branch":"stable/yoga","topic":"bug/1970467","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2022-12-01 14:15:20.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3998d0d49583806ac1c3ae64f1b1fe343cefd20d","subject":"Remove double mocking","status":"MERGED","created":"2022-08-29 12:59:07.000000000","updated":"2022-12-01 14:15:20.000000000","submitted":"2022-12-01 14:15:20.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":7,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"855024-bug/1970467","meta_rev_id":"f58131afbb2dfb3579ab52f62ed6192e3df1ccff","_number":855024,"virtual_id_number":855024,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-12-01 14:15:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-11-17 15:15:56.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2022-11-30 17:05:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":1,"date":"2022-11-30 17:05:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"}],"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-08-29 12:59:07.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"CC"},{"updated":"2022-08-29 13:29:09.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2022-08-29 13:36:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-08-29 13:59:30.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"CC"},{"updated":"2022-08-29 14:10:30.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2022-08-29 18:59:28.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-08-29 23:05:53.000000000","updated_by":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"reviewer":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"state":"CC"},{"updated":"2022-11-17 15:15:56.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"CC"},{"updated":"2022-11-30 17:05:55.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"}],"messages":[{"id":"e5536e896e241373761238aa20ac7675b9e33e17","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-08-29 12:59:07.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2eed0968632fd614713065b0947c83bd53669308","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-08-29 13:10:35.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"4bb96b62fa7c39b20d6b6f8cd9b187a473ec7fa3","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-08-29 13:29:09.000000000","message":"Patch Set 2: Code-Review-1\n\n(5 comments)","accounts_in_message":[],"_revision_number":2},{"id":"7d7051c37d7abd10f4f2169872b8600009945781","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-29 13:36:11.000000000","message":"Patch Set 2: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/602e587cef304b7d885f349ff65d06c7\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a61916a77c534454b7b2714684d54664 : SUCCESS in 14m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f8cd7b3d5f334cb49c7daa2754a56629 : FAILURE in 11m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ff4ab7ac1c0d4d72915b01e9eb4fdd1e : SUCCESS in 11m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6e7fb39e364c459e97acd93299d3b89c : FAILURE in 11m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fef54fd76d1d4e0da267aa6f23a009fe : SUCCESS in 9m 10s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/bc46b8c0c0a04d0db43bfffc8d5a27fb : FAILURE in 4m 46s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/82dcc02b990e45b99f9f69050ffcf302 : SUCCESS in 22m 44s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a6455cb07d3a4e04900099eaad43d78e : SUCCESS in 23m 16s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/a4d91a261ec34ba4830524bec7f921f0 : SUCCESS in 20m 01s","accounts_in_message":[],"_revision_number":2},{"id":"2dbb5768a1b288fd5151d6a81383af57aac894aa","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-08-29 13:59:30.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"3b03e2856a011fe811edaf24d37a39d2dacceb90","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-08-29 14:10:30.000000000","message":"Patch Set 3: Code-Review+2","accounts_in_message":[],"_revision_number":3},{"id":"21b25d36fee2d16dfd7e8eff6cf3f55d9c3f2ce0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-29 14:30:22.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/ad7ad2c5b095462fb084e2b597764e5f\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/87588b4fb0864edf90c5edbcc2b8d5ce : SUCCESS in 16m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/816c97391fd44e5da390e5e712ce1127 : SUCCESS in 14m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/79df2f56e3d74231861e5dbf2340255b : SUCCESS in 13m 32s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/84804671e4c6468c86dc0dff8297807a : FAILURE in 12m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e3d13eae4a384d9592f694cb657f0822 : SUCCESS in 10m 23s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/b5719c9728844168a0abd50054616a8d : SUCCESS in 5m 38s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/40123df9074e4c49a13fa1f59fc1eb39 : SUCCESS in 28m 20s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/58e5d557df23473baaf1e6ea7f7001b8 : SUCCESS in 20m 39s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/3083876fff0a4440bbf9918682380214 : SUCCESS in 22m 45s","accounts_in_message":[],"_revision_number":3},{"id":"fb62c425dea68eeb1fc23bb1a182bc60460c66b2","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-08-29 14:47:38.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ac04db7b704d49139c1657f8e572cbff\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/af92496eef3545af9f0c6abff0ed0470 : FAILURE in 44m 23s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/0130a1a404c74cac8e089ae1d48a851e : FAILURE in 38m 54s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"8dffff3c97f162db9126a8ac1c98f97d5cfc8df6","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2022-08-29 18:59:28.000000000","message":"Patch Set 3:\n\nBuild failed. Test completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm- recheck. For contact and more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- tempest-dsvm-full-focal-py3 https://oplab9.parqtec.unicamp.br/pub/ppc64el/openstack/nova/24/855024/3/check/tempest-dsvm-full-focal-py3/12348c2/ : FAILURE in 1h 21m 49s","accounts_in_message":[],"_revision_number":3},{"id":"0574869a474eda0434d8ce2e8e54f1d0ada81459","tag":"autogenerated:cloudbase-ci","author":{"_account_id":26515,"name":"Cloudbase Nova Hyper-V CI","email":"nova_hyperv_ci@cloudbasesolutions.com","username":"nova_hyperv_ci"},"date":"2022-08-29 23:05:53.000000000","message":"Patch Set 3:\n\nBuild succeeded. For checking Nova with Ceph, add a comment with run-Cloudbase Nova Ceph Hyper-V CI\n\n- nova http://cloudbase-ci.com/nova/855024/3/iscsi : SUCCESS in 3h 11m 27s","accounts_in_message":[],"_revision_number":3},{"id":"6921e181ea74ac95368819bc3b11643994a53b0a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-11-17 15:15:56.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"f04702b4d6e9884ef7cea2d07723b76ca071f383","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-17 15:46:08.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/995694484d044991bbc273ef7bc2a8e7\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cb20ad721b1a495e90857e9239d57551 : SUCCESS in 17m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/75d5fd0f56af45659c7e1335e0dd146c : SUCCESS in 10m 27s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8dcbd32a0d3f4752901ad3a6354e278f : SUCCESS in 13m 52s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9e086d2fb53548209ba56e5474ae24bb : SUCCESS in 14m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2c4c950883384846bd1c10fc481e9cbc : SUCCESS in 11m 36s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/915d9d3904ce4b5a853bd3e7c50ad6e3 : SUCCESS in 5m 06s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/f7c9c164b40149f59a50034f882138d9 : SUCCESS in 24m 05s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/b8e5d2ea837148b99523f83a6ef0e367 : SUCCESS in 21m 03s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/b417dc68714c4e04b0455f93063dbe48 : SUCCESS in 24m 01s","accounts_in_message":[],"_revision_number":4},{"id":"5b1ff6653ca423aeb24fe59d525fc81e4d36150f","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-17 15:55:47.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5667e2c38a3a432ca201a5bb18817752\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/c02433eb30054070af4695b85b5724bb : SUCCESS in 23m 28s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/700c7bbb3d0e4948a57e9ff31ca69463 : SUCCESS in 29m 17s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"ce351852567b79489a4be2b7858dd3d132b8a36c","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2022-11-30 17:05:55.000000000","message":"Patch Set 4: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":4},{"id":"8e4a16ddff2823f9acbfe3fdc9ef1800e642b558","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-30 17:06:39.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"d440a9a8ecabcf57c9879e239d6f4c5c73b7af9b","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-30 19:05:56.000000000","message":"Patch Set 4: Verified-2\n\nThis change depends on a change that failed to merge.\n\nChange https://review.opendev.org/855023 is needed.","accounts_in_message":[],"_revision_number":4},{"id":"5f92395b3ba2bcf09b9af12d1806c832f7045d0b","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2022-12-01 09:52:12.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"226154eb1274e5af46bdc7398a3637cd44eaa128","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-01 10:22:19.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ce70e1f8f6024c56a31e42283cc3badd\n\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/aea859b2f5674b95a1a11f782d036b07 : SUCCESS in 22m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/53a1d11c925e43c981cf267bd915779c : SUCCESS in 10m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9d44d43f7e8d4d7fad1bfca3a0868633 : SUCCESS in 15m 35s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/91c509da6fa846f89c33472164588ef1 : SUCCESS in 12m 15s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f29e00ae7d104a229fbc484a78d1e85d : SUCCESS in 8m 13s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/4b813ed270e54e40a145d970d25a4166 : SUCCESS in 6m 55s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/24dfa0018b984253a266d0979f2ea110 : SUCCESS in 21m 02s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/8fdc841ae6514cb8b47a4b849ee0679c : SUCCESS in 16m 51s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/ae955ea3f5484709b43ad16b54111d6b : SUCCESS in 27m 49s","accounts_in_message":[],"_revision_number":4},{"id":"22728c92fa00e77eaa69f58d535de5fb10b5a1d9","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-01 11:46:32.000000000","message":"Patch Set 4: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":4},{"id":"d6dcd6e01c79bc50f972f9fe86e00b0282666587","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-01 11:56:24.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/a4166b637b704c77b857964f9a8e03f1\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/0d4eed8879744a1595b447d73a6ecf20 : SUCCESS in 32m 00s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/fa698305b5534faf95101044ece29361 : SUCCESS in 36m 05s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"eb7fdcc10d66a6ee777232b10f342947a1e4c8c8","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-01 14:15:19.000000000","message":"Patch Set 4: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/492ea7b1dcf34e76b679bad3f05c9536\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9ef99e0563f04240adbcb341022600e2 : SUCCESS in 12m 30s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b5ea40ca8fbd4d7188730d8bfd466a87 : SUCCESS in 9m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/cddf9ca457b348f9a3c8c7f20caed0a0 : SUCCESS in 12m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/01164c552a104c6c82a485fd49b94928 : SUCCESS in 9m 03s\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/3d1546f450e346798c1d8805b2322a4e : SUCCESS in 18m 45s\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/bc251ec867c14eb6b954ed421cd757d8 : SUCCESS in 22m 31s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/4cf508843e414cb7badfc4f42fd2bd50 : SUCCESS in 18m 48s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/84f8f7a8a84e44a098ba486811563d76 : SUCCESS in 4m 48s","accounts_in_message":[],"_revision_number":4},{"id":"f58131afbb2dfb3579ab52f62ed6192e3df1ccff","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-01 14:15:20.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"b40bd1bf52c87c31e18caf85d79dd03da6c7cffc","revisions":{"1a302967dcc0b09da06baa6c90756492328afcf5":{"kind":"REWORK","_number":1,"created":"2022-08-29 12:59:07.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/24/855024/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/24/855024/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/24/855024/1"}}},"commit":{"parents":[{"commit":"56a17ada3f5b139ea485df7950539c06681af8c8","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56a17ada3f5b139ea485df7950539c06681af8c8"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-08-29 12:49:18.000000000","tz":60},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1a302967dcc0b09da06baa6c90756492328afcf5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1a302967dcc0b09da06baa6c90756492328afcf5"}]},"branch":"refs/heads/stable/yoga"},"93275465e4ee1f242562ea88c610ef386e66e673":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-08-29 13:10:35.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/24/855024/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/24/855024/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/24/855024/2"}}},"commit":{"parents":[{"commit":"7cd7fbf64b81dff01e8e0716b029c29c85c6749a","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7cd7fbf64b81dff01e8e0716b029c29c85c6749a"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-08-29 13:08:39.000000000","tz":60},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n(cherry picked from commit 1a302967dcc0b09da06baa6c90756492328afcf5)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/93275465e4ee1f242562ea88c610ef386e66e673"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/93275465e4ee1f242562ea88c610ef386e66e673"}]},"branch":"refs/heads/stable/yoga"},"a33304a913644ac8e9cb582efbc973e9151e9f32":{"kind":"REWORK","_number":3,"created":"2022-08-29 13:59:30.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/24/855024/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/24/855024/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/24/855024/3"}}},"commit":{"parents":[{"commit":"c8aacbda97a16e04777fc0b36d725ab1617f4bf5","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c8aacbda97a16e04777fc0b36d725ab1617f4bf5"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-08-29 13:39:28.000000000","tz":60},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nConflicts:\n    nova/tests/functional/regressions/test_bug_1781286.py\n    nova/tests/unit/api/openstack/compute/test_shelve.py\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n(cherry picked from commit f8cf050a1380ae844e0184ed45f4a04fde3b07a9)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a33304a913644ac8e9cb582efbc973e9151e9f32"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a33304a913644ac8e9cb582efbc973e9151e9f32"}]},"branch":"refs/heads/stable/yoga"},"b40bd1bf52c87c31e18caf85d79dd03da6c7cffc":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-11-17 15:15:56.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/24/855024/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/24/855024/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/24/855024/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/24/855024/4"}}},"commit":{"parents":[{"commit":"813377077bd0173bdf128823e46b5df7c0a575b9","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/813377077bd0173bdf128823e46b5df7c0a575b9"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-11-17 15:09:05.000000000","tz":0},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nConflicts:\n    nova/tests/functional/regressions/test_bug_1781286.py\n    nova/tests/unit/api/openstack/compute/test_shelve.py\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n(cherry picked from commit f8cf050a1380ae844e0184ed45f4a04fde3b07a9)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b40bd1bf52c87c31e18caf85d79dd03da6c7cffc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b40bd1bf52c87c31e18caf85d79dd03da6c7cffc"}]},"branch":"refs/heads/stable/yoga"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[]}