)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f510f73fd48f0fb9ba5138e9099479a87aadaa9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a91ade2e_7f4f7926","updated":"2022-09-06 16:44:12.000000000","message":"looking at how this fails in the bug its a side effect of the call to create teh instance domain which is not something we can simulate with a functional tests without effectvly doign fault injection and turning the fucntional test into a unit test.\n\n\nfor that reasoin i think you shoudl instead create a reproducer unit test for this instead.\n\ncan you refactor this into a more granular unit test that demonstrates the broken code path.\n\n","commit_id":"304d52e76429efcaf4d38f816657eaa84341401d"}],"nova/tests/functional/regressions/test_bug_1552777.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e8a053ab5c864caa34e9c66db3e020b29592fef0","unresolved":true,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.api_fixture \u003d self.useFixture(nova_fixtures.OSAPIFixture("},{"line_number":43,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":44,"context_line":"        self.admin_api \u003d self.api_fixture.admin_api"},{"line_number":45,"context_line":"        self.src \u003d self._start_compute(host\u003d\u0027host1\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_favor_resize(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9c58a6dc_9db3c8e7","line":44,"range":{"start_line":44,"start_character":8,"end_line":44,"end_character":51},"updated":"2022-09-05 14:25:26.000000000","message":"i dont think you need this.","commit_id":"7274c406aa47a80c7b625573d0b9a9dd9267480b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9f36b0a62d90295a42965b45884501082b92b097","unresolved":true,"context_lines":[{"line_number":43,"context_line":"            api_version\u003d\u0027v2.1\u0027))"},{"line_number":44,"context_line":"        self.admin_api \u003d self.api_fixture.admin_api"},{"line_number":45,"context_line":"        self.src \u003d self._start_compute(host\u003d\u0027host1\u0027)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_favor_resize(self):"},{"line_number":48,"context_line":"        \"\"\"Resizing server to swap zero flavor"},{"line_number":49,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"c6cccf3b_5a6b4563","line":46,"updated":"2022-09-06 09:34:33.000000000","message":"you need self.api and self.notifier See my fixup in https://review.opendev.org/c/openstack/nova/+/856033 with that the test now fails as the resize does not raise","commit_id":"7274c406aa47a80c7b625573d0b9a9dd9267480b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8bb1f500b9399f97f54c69462470d55caf8c7cfb","unresolved":true,"context_lines":[{"line_number":47,"context_line":"    def test_favor_resize(self):"},{"line_number":48,"context_line":"        \"\"\"Resizing server to swap zero flavor"},{"line_number":49,"context_line":"        \"\"\""},{"line_number":50,"context_line":"        f1_id \u003d self._create_flavor(name\u003d\u0027flavor_swap_1024\u0027, swap\u003d1024)"},{"line_number":51,"context_line":"        f2_id \u003d self._create_flavor(name\u003d\u0027flavor_swap_0\u0027, swap\u003d0)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        server \u003d self._create_server(flavor_id\u003df1_id, networks\u003d[])"}],"source_content_type":"text/x-python","patch_set":1,"id":"e9c2d820_078cf7a4","line":50,"range":{"start_line":50,"start_character":21,"end_line":50,"end_character":35},"updated":"2022-09-05 14:14:36.000000000","message":"This is failing with:\nAttributeError: \u0027ResizeServerToSwapZero\u0027 object has no attribute \u0027api_fixture\u0027","commit_id":"7274c406aa47a80c7b625573d0b9a9dd9267480b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e8a053ab5c864caa34e9c66db3e020b29592fef0","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        f2_id \u003d self._create_flavor(name\u003d\u0027flavor_swap_0\u0027, swap\u003d0)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        server \u003d self._create_server(flavor_id\u003df1_id, networks\u003d[])"},{"line_number":54,"context_line":"        self.api.microversion \u003d \u0027latest\u0027"},{"line_number":55,"context_line":"        server \u003d self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":1,"id":"6bacc870_2c7a4865","line":54,"range":{"start_line":54,"start_character":13,"end_line":54,"end_character":16},"updated":"2022-09-05 14:25:26.000000000","message":"you have not defined this.\n\ndid you mean for this to be self.admin_api","commit_id":"7274c406aa47a80c7b625573d0b9a9dd9267480b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e8a053ab5c864caa34e9c66db3e020b29592fef0","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        server \u003d self._create_server(flavor_id\u003df1_id, networks\u003d[])"},{"line_number":54,"context_line":"        self.api.microversion \u003d \u0027latest\u0027"},{"line_number":55,"context_line":"        server \u003d self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.assertRaises("},{"line_number":58,"context_line":"            libvirt.libvirtError, self._resize_server,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2344087a_f86c0df0","line":55,"range":{"start_line":55,"start_character":6,"end_line":55,"end_character":62},"updated":"2022-09-05 14:25:26.000000000","message":"this is don by _create_server","commit_id":"7274c406aa47a80c7b625573d0b9a9dd9267480b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e8a053ab5c864caa34e9c66db3e020b29592fef0","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        server \u003d self._wait_for_state_change(server, \u0027ACTIVE\u0027)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.assertRaises("},{"line_number":58,"context_line":"            libvirt.libvirtError, self._resize_server,"},{"line_number":59,"context_line":"            server, flavor_id\u003df2_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"69e58a5d_7415148a","line":58,"range":{"start_line":58,"start_character":20,"end_line":58,"end_character":32},"updated":"2022-09-05 14:25:26.000000000","message":"you will not getl libvirt errors in the funtional tests\n\nthis would be an os api error although i suspect what will actully happen is it will fail waiting on the resize notificion end \n\nhttps://github.com/openstack/nova/blob/58be0ca8b8204bce6cbb6747d46ca595c5843a30/nova/tests/functional/integrated_helpers.py#L530","commit_id":"7274c406aa47a80c7b625573d0b9a9dd9267480b"}]}