)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eeb4531288d5b3320c4333457567e12bb1d8d711","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e80b6b29_5348b8d9","updated":"2022-09-09 17:24:16.000000000","message":"ok the unit test failure is just becasue we dont have a test for the new migration and the pep8 issue is just white space so easy to fix.\n\nfuncitonally this is passing the tempest tests including grenade which actully runs it as part of an upgrade so functionlly it looks like this work","commit_id":"cde665dd67ae3c5cfab47d1d6022b48ebcea3617"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"3cefd2efe5843a3427543952b19ccc50476fa64e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8d60369d_3d5b778f","updated":"2022-09-12 15:11:24.000000000","message":"recheck","commit_id":"31ac291f8a327ad3b8f70faf25d8b783038e2a97"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"138abab432fe7f489c984b0b7874ae8b94f69cb6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f70430ec_9d96bc13","updated":"2022-09-16 09:40:06.000000000","message":"recheck nova-next unrelated device taging failure","commit_id":"531e1e8733b8928d262bf3b0b72540dde3ef1dad"}],"nova/db/main/migrations/versions/9d9045c76425_drop_redundant_indexes_in_instances_and_.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"031becf33da7811289e2bf52a2aab5869e2c99d4","unresolved":true,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    with op.batch_alter_table(\u0027instances\u0027, schema\u003dNone) as batch_op:"},{"line_number":36,"context_line":"        batch_op.drop_index(\u0027uuid\u0027)"},{"line_number":37,"context_line":"        batch_op.create_index(\u0027uuid\u0027, [\u0027uuid\u0027], unique\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9e056938_65261aaa","line":37,"range":{"start_line":37,"start_character":7,"end_line":37,"end_character":61},"updated":"2022-09-09 14:29:19.000000000","message":"see commnet on mdoel but i think this is not needed","commit_id":"468029b335ce5c13eabd64355df0296c6bbd4abd"}],"nova/db/main/models.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b21093b81a858bb6a003d01587fb79a650ef798","unresolved":true,"context_lines":[{"line_number":266,"context_line":"    \"\"\"Represents a guest VM.\"\"\""},{"line_number":267,"context_line":"    __tablename__ \u003d \u0027instances\u0027"},{"line_number":268,"context_line":"    __table_args__ \u003d ("},{"line_number":269,"context_line":"        sa.Index(\u0027uuid\u0027, \u0027uuid\u0027, unique\u003dTrue),"},{"line_number":270,"context_line":"        sa.Index(\u0027instances_project_id_idx\u0027, \u0027project_id\u0027),"},{"line_number":271,"context_line":"        sa.Index(\u0027instances_project_id_deleted_idx\u0027,"},{"line_number":272,"context_line":"              \u0027project_id\u0027, \u0027deleted\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"df30aaa2_527dd21e","side":"PARENT","line":269,"range":{"start_line":269,"start_character":7,"end_line":269,"end_character":45},"updated":"2022-09-09 12:09:23.000000000","message":"i would drop this instead.\n\ni woudl prefer on stnadardiise on  using schema.UniqueConstraint in prefernce to this approch","commit_id":"d02d06529c7d8c868c9ceef7baf573ae9285145a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5838a4c6924d2f0296a59f579e7edff223f81b5b","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    \"\"\"Represents a guest VM.\"\"\""},{"line_number":267,"context_line":"    __tablename__ \u003d \u0027instances\u0027"},{"line_number":268,"context_line":"    __table_args__ \u003d ("},{"line_number":269,"context_line":"        sa.Index(\u0027uuid\u0027, \u0027uuid\u0027, unique\u003dTrue),"},{"line_number":270,"context_line":"        sa.Index(\u0027instances_project_id_idx\u0027, \u0027project_id\u0027),"},{"line_number":271,"context_line":"        sa.Index(\u0027instances_project_id_deleted_idx\u0027,"},{"line_number":272,"context_line":"              \u0027project_id\u0027, \u0027deleted\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"277515fd_c2afa1a2","side":"PARENT","line":269,"range":{"start_line":269,"start_character":7,"end_line":269,"end_character":45},"in_reply_to":"8a269f02_049fa827","updated":"2022-09-09 14:32:29.000000000","message":"no worries. \n\nmy understanding is a unique constraint at least at the sql level is always an implicit index\n\nsince  schema.UniqueConstraint(\u0027uuid\u0027, name\u003d\u0027uniq_instances0uuid\u0027)\n\nis defien as just the uuid filed that shoudl mean we get an index on just the uuid filed transitively so instead of just droping the unique\u003dtrue\n\nyou should be able to drop the index line entirly.","commit_id":"d02d06529c7d8c868c9ceef7baf573ae9285145a"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"253f044b09b1b21e39fce5d21f117c40b9682194","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    \"\"\"Represents a guest VM.\"\"\""},{"line_number":267,"context_line":"    __tablename__ \u003d \u0027instances\u0027"},{"line_number":268,"context_line":"    __table_args__ \u003d ("},{"line_number":269,"context_line":"        sa.Index(\u0027uuid\u0027, \u0027uuid\u0027, unique\u003dTrue),"},{"line_number":270,"context_line":"        sa.Index(\u0027instances_project_id_idx\u0027, \u0027project_id\u0027),"},{"line_number":271,"context_line":"        sa.Index(\u0027instances_project_id_deleted_idx\u0027,"},{"line_number":272,"context_line":"              \u0027project_id\u0027, \u0027deleted\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"8a269f02_049fa827","side":"PARENT","line":269,"range":{"start_line":269,"start_character":7,"end_line":269,"end_character":45},"in_reply_to":"df30aaa2_527dd21e","updated":"2022-09-09 12:10:46.000000000","message":"I was considering the exact same thing initially. I shall align this for a follow up PS. I actually am adding a few more cleanups - I was a little fast in pushing this for review.","commit_id":"d02d06529c7d8c868c9ceef7baf573ae9285145a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"031becf33da7811289e2bf52a2aab5869e2c99d4","unresolved":true,"context_lines":[{"line_number":266,"context_line":"    \"\"\"Represents a guest VM.\"\"\""},{"line_number":267,"context_line":"    __tablename__ \u003d \u0027instances\u0027"},{"line_number":268,"context_line":"    __table_args__ \u003d ("},{"line_number":269,"context_line":"        sa.Index(\u0027uuid\u0027, \u0027uuid\u0027),"},{"line_number":270,"context_line":"        sa.Index(\u0027instances_project_id_idx\u0027, \u0027project_id\u0027),"},{"line_number":271,"context_line":"        sa.Index(\u0027instances_project_id_deleted_idx\u0027,"},{"line_number":272,"context_line":"              \u0027project_id\u0027, \u0027deleted\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"ed50b0a5_22723fbc","line":269,"range":{"start_line":269,"start_character":7,"end_line":269,"end_character":33},"updated":"2022-09-09 14:29:19.000000000","message":"you could proably drop this index entirely\nsince the unique contratint wil create one implictly.\nbut if this resovled the duplicate error that is also ok.","commit_id":"468029b335ce5c13eabd64355df0296c6bbd4abd"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"50f691c38832a75c667d350f4dd8b8337709402a","unresolved":false,"context_lines":[{"line_number":266,"context_line":"    \"\"\"Represents a guest VM.\"\"\""},{"line_number":267,"context_line":"    __tablename__ \u003d \u0027instances\u0027"},{"line_number":268,"context_line":"    __table_args__ \u003d ("},{"line_number":269,"context_line":"        sa.Index(\u0027uuid\u0027, \u0027uuid\u0027),"},{"line_number":270,"context_line":"        sa.Index(\u0027instances_project_id_idx\u0027, \u0027project_id\u0027),"},{"line_number":271,"context_line":"        sa.Index(\u0027instances_project_id_deleted_idx\u0027,"},{"line_number":272,"context_line":"              \u0027project_id\u0027, \u0027deleted\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"8c632f00_886bb640","line":269,"range":{"start_line":269,"start_character":7,"end_line":269,"end_character":33},"in_reply_to":"ed50b0a5_22723fbc","updated":"2022-09-09 15:00:58.000000000","message":"You are correct - I just confused myself. See new PS for yet another attempt to only have one index on that uuid field ... originating from the unique constraint.","commit_id":"468029b335ce5c13eabd64355df0296c6bbd4abd"}]}