)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bc598ece70658e01ffaec0a168eab8c112348683","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Nova only supports compute services that are not older than"},{"line_number":11,"context_line":"version N-2. So in 2023.1 Antelope the smallest supported"},{"line_number":12,"context_line":"nova compute version is Yoga and the smallest Yoga service"},{"line_number":13,"context_line":"version is 61."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I4cbe233087577c7754856afcc4e3fe9fdc2d3008"},{"line_number":16,"context_line":"Signed-off-by: Takashi Natsume \u003ctakanattie@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2df8b7a4_af147860","line":13,"updated":"2022-09-13 16:50:11.000000000","message":"TBC, the resolution only says this for Antelope.\nNow, we can merge this patch in the Zed timeframe so we will support only Yoga.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"32b043c558504c14d6dc9d12bb5fd0ab8fee45db","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Nova only supports compute services that are not older than"},{"line_number":11,"context_line":"version N-2. So in 2023.1 Antelope the smallest supported"},{"line_number":12,"context_line":"nova compute version is Yoga and the smallest Yoga service"},{"line_number":13,"context_line":"version is 61."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I4cbe233087577c7754856afcc4e3fe9fdc2d3008"},{"line_number":16,"context_line":"Signed-off-by: Takashi Natsume \u003ctakanattie@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f4091471_a1400474","line":13,"in_reply_to":"2df8b7a4_af147860","updated":"2022-09-13 17:21:37.000000000","message":"Yeah, the words here are overly generic with \"N-2\" as that\u0027s not always the case.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a90ea13518275938997a1e45a4536b296dbff243","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52017fb0_c09c4856","updated":"2022-09-13 17:08:46.000000000","message":"Removing my +2 as we agreed on the fact that we should only consider Zed at the time of this merge.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"bc598ece70658e01ffaec0a168eab8c112348683","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"775ec241_9370930a","updated":"2022-09-13 16:50:11.000000000","message":"just a clarification about the commit msg but OK","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"23f2e7a273e87ef903ad6dd8a98e1cc516e143e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c064bf98_e3ec649d","updated":"2022-09-15 17:45:06.000000000","message":"recheck timeout","commit_id":"a1731927ccd17aeb634c4eed61dce16de16fa7b3"}],"nova/objects/service.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bf202a611fe8f1c9b9e3373c3f3c67c95a8f01ee","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# This is used to raise an error at service startup if older than N-2 computes"},{"line_number":231,"context_line":"# are detected. Update this at the beginning of every release cycle to point to"},{"line_number":232,"context_line":"# the smallest service version that was added in N-2."},{"line_number":233,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":234,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":235,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d7e87ea0_12f2043d","line":232,"range":{"start_line":232,"start_character":49,"end_line":232,"end_character":53},"updated":"2022-09-13 16:58:55.000000000","message":"I don\u0027t know why we need to to move to N-2. I thought we don\u0027t support RPC over N-2 releases even with tick-tock. See point 6 in https://governance.openstack.org/tc/resolutions/20220210-release-cadence-adjustment.html#details","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a9f13a4b035431a16adf146ee9fd1426d34ee1a0","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# This is used to raise an error at service startup if older than N-2 computes"},{"line_number":231,"context_line":"# are detected. Update this at the beginning of every release cycle to point to"},{"line_number":232,"context_line":"# the smallest service version that was added in N-2."},{"line_number":233,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":234,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":235,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f005b130_1db62230","line":232,"range":{"start_line":232,"start_character":49,"end_line":232,"end_character":53},"in_reply_to":"23404c50_6c9832af","updated":"2022-09-14 06:55:44.000000000","message":"I\u0027m OK to support N-2 eventually iff we have some minimal level of testing on it. Also making such decision at Zed RC1 is probably not the appropriate time. :)","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"5a41d82fef77e1782ed06fcfc13cd35dbe99640d","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# This is used to raise an error at service startup if older than N-2 computes"},{"line_number":231,"context_line":"# are detected. Update this at the beginning of every release cycle to point to"},{"line_number":232,"context_line":"# the smallest service version that was added in N-2."},{"line_number":233,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":234,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":235,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"23404c50_6c9832af","line":232,"range":{"start_line":232,"start_character":49,"end_line":232,"end_character":53},"in_reply_to":"9af9ae7f_d497ea75","updated":"2022-09-13 17:29:32.000000000","message":"yep\nin the detials section this is the imporant text\n\n\"\"\"\nRolling Upgrades: This scheme does not necessarily dictate that live or rolling upgrades need to be supported between \"SLURP\" releases. Meaning RPC compatibility between N to N-1 guarantees can remain, resulting in deployments that are on a \"SLURP to SLURP\" release schedule requiring some downtime during an upgrade because components will be spanning more than two actual releases.\"\"\"\n\nwe are required to provide upgrades between the two release but not rooling upgrade.\n\nif we can support it because of rpc compatiably we can and likely should but we are not required to extend rpc to n-2 so we should not imply that we provide that gurentee.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"32b043c558504c14d6dc9d12bb5fd0ab8fee45db","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# This is used to raise an error at service startup if older than N-2 computes"},{"line_number":231,"context_line":"# are detected. Update this at the beginning of every release cycle to point to"},{"line_number":232,"context_line":"# the smallest service version that was added in N-2."},{"line_number":233,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":234,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":235,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9af9ae7f_d497ea75","line":232,"range":{"start_line":232,"start_character":49,"end_line":232,"end_character":53},"in_reply_to":"ad324928_41ff6457","updated":"2022-09-13 17:21:37.000000000","message":"Yeah, we don\u0027t have to, but if we can, it would be good. Given how little RPC change there has been lately, this seems like something we should shoot for (or at least try).\n\nThat said, I don\u0027t agree that we should change \"N-1\" to \"N-2\" here as it doesn\u0027t apply to every N-2 arrangement. I\u0027d propose just not make this change, or else add words to say \"N-1 or the most recent SLURP release\".","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a90ea13518275938997a1e45a4536b296dbff243","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# This is used to raise an error at service startup if older than N-2 computes"},{"line_number":231,"context_line":"# are detected. Update this at the beginning of every release cycle to point to"},{"line_number":232,"context_line":"# the smallest service version that was added in N-2."},{"line_number":233,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":234,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":235,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"af4536e0_e003d04e","line":232,"range":{"start_line":232,"start_character":49,"end_line":232,"end_character":53},"in_reply_to":"d7e87ea0_12f2043d","updated":"2022-09-13 17:08:46.000000000","message":"We agreed on the fact we would accept Yoga computes for Antelope services as a first pass before the way more important next C-\u003eA support.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0cd8c1a6fab6294678a7498543269e9c114ec423","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# This is used to raise an error at service startup if older than N-2 computes"},{"line_number":231,"context_line":"# are detected. Update this at the beginning of every release cycle to point to"},{"line_number":232,"context_line":"# the smallest service version that was added in N-2."},{"line_number":233,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":234,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":235,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ad324928_41ff6457","line":232,"range":{"start_line":232,"start_character":49,"end_line":232,"end_character":53},"in_reply_to":"d7e87ea0_12f2043d","updated":"2022-09-13 17:10:35.000000000","message":"that is at the discression of the indivitual projects\n\nwe can elesct to supprot Tick to tick roling upgrade or offline.\n\ni think nova proably shoudl allow onlien upgrades to we would support n-1 or n-2 based on the current relase as its really currenet to last tick.\n\n\nso we wont support n-2 in all cases.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6b32db0de7caf4ab9b57d1740ec9e678fe3f0a1d","unresolved":true,"context_lines":[{"line_number":229,"context_line":""},{"line_number":230,"context_line":"# This is used to raise an error at service startup if older than N-2 computes"},{"line_number":231,"context_line":"# are detected. Update this at the beginning of every release cycle to point to"},{"line_number":232,"context_line":"# the smallest service version that was added in N-2."},{"line_number":233,"context_line":"OLDEST_SUPPORTED_SERVICE_VERSION \u003d \u0027Yoga\u0027"},{"line_number":234,"context_line":"SERVICE_VERSION_ALIASES \u003d {"},{"line_number":235,"context_line":"    \u0027Victoria\u0027: 52,"}],"source_content_type":"text/x-python","patch_set":1,"id":"484471b4_e4b238b5","line":232,"range":{"start_line":232,"start_character":49,"end_line":232,"end_character":53},"in_reply_to":"f005b130_1db62230","updated":"2022-09-14 11:28:36.000000000","message":"we discussed this at the ptg \nwe agree to \"Bump compute service min version support on tock, don\u0027t bump min version on tick\"\nhttps://etherpad.opendev.org/p/nova-zed-ptg#L268\n\ntechnially the tick tock cadnace start with a but zed would be a tock so if we want\nto use Y to A as a dress rehersal then we should be bumping it to yoga now\nas we wont be bumpig it to Zed in A\n\nwe also agreed to have the grenade skip level job running ro the A cycle with yoga as its base in other converasations to validate thei upgrade path.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"bf202a611fe8f1c9b9e3373c3f3c67c95a8f01ee","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":238,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":239,"context_line":"    \u0027Zed\u0027: 64,"},{"line_number":240,"context_line":"}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# TODO(berrange): Remove NovaObjectDictCompat"}],"source_content_type":"text/x-python","patch_set":1,"id":"4081fd99_70a9034c","line":240,"updated":"2022-09-13 16:58:55.000000000","message":"Did we forget to do the bump when we started Zed? We should have added Yoga as OLDEST_SUPPORTED_SERVICE_VERSION when the master branch was opened for Zed development. This is how we did it for yoga https://review.opendev.org/c/openstack/nova/+/809932 .\n\nSo we need to merge a patch for Zed now, before RC1 to state that Zed only supports Yoga or newer. Then right after RC1 we need a patch that states that Antelope only supports Zed or newer.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a90ea13518275938997a1e45a4536b296dbff243","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":238,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":239,"context_line":"    \u0027Zed\u0027: 64,"},{"line_number":240,"context_line":"}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# TODO(berrange): Remove NovaObjectDictCompat"}],"source_content_type":"text/x-python","patch_set":1,"id":"64c4b197_ad0ad262","line":240,"in_reply_to":"4081fd99_70a9034c","updated":"2022-09-13 17:08:46.000000000","message":"\u003e Did we forget to do the bump when we started Zed? We should have added Yoga as OLDEST_SUPPORTED_SERVICE_VERSION when the master branch was opened for Zed development. This is how we did it for yoga https://review.opendev.org/c/openstack/nova/+/809932 .\n\u003e \n\nI guess so, hence this patch being opportunistic.\n\n\n\u003e So we need to merge a patch for Zed now, before RC1 to state that Zed only supports Yoga or newer. Then right after RC1 we need a patch that states that Antelope only supports Zed or newer.\n\n\nI don\u0027t disagree with you, hence my comment on the commit msg. I was just less firm than you, but you\u0027re right, we need to correctly explain this patch.\n\nTakashi, please respin this patch with a commit msg and an updated docstring that only mentions Zed and not Antelope ?\nThanks.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0cd8c1a6fab6294678a7498543269e9c114ec423","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":238,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":239,"context_line":"    \u0027Zed\u0027: 64,"},{"line_number":240,"context_line":"}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# TODO(berrange): Remove NovaObjectDictCompat"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca8825ce_da55d851","line":240,"in_reply_to":"4081fd99_70a9034c","updated":"2022-09-13 17:10:35.000000000","message":"yes so this is why i t hink we shoudl do it at the end of the cycle not start.\n\nwe shoudl update the min and create the aliase before RC1 to the latest rpc version in a release.\n\nif we want to use this a a dress rehersal Antelope woudl support yoga or newer\nbut that is not required. it is suggested however.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"20948c04c8c63da20036941f87e3870438c6faab","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":238,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":239,"context_line":"    \u0027Zed\u0027: 64,"},{"line_number":240,"context_line":"}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# TODO(berrange): Remove NovaObjectDictCompat"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d9f3c47_dbd266a8","line":240,"in_reply_to":"68b2a8c1_81c0c720","updated":"2022-09-14 11:36:41.000000000","message":"Thank you for your reviews.\n\u003e So we need to merge a patch for Zed now, before RC1 to state that Zed only supports Yoga or newer. \n\n\u003e Takashi, please respin this patch with a commit msg and an updated docstring that only mentions Zed and not Antelope ?\n\nDone.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6b32db0de7caf4ab9b57d1740ec9e678fe3f0a1d","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":238,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":239,"context_line":"    \u0027Zed\u0027: 64,"},{"line_number":240,"context_line":"}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# TODO(berrange): Remove NovaObjectDictCompat"}],"source_content_type":"text/x-python","patch_set":1,"id":"68b2a8c1_81c0c720","line":240,"in_reply_to":"c3f2bbc4_7988b226","updated":"2022-09-14 11:28:36.000000000","message":"yes n-1 means we support all rpc version above the last RPC version in the current release.\n\nthat is how it has always been.\n\nif you deploy master or the milestones its expected that m1 nova-computes can be managed by an m2 nova-conductor.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a9f13a4b035431a16adf146ee9fd1426d34ee1a0","unresolved":true,"context_lines":[{"line_number":237,"context_line":"    \u0027Xena\u0027: 57,"},{"line_number":238,"context_line":"    \u0027Yoga\u0027: 61,"},{"line_number":239,"context_line":"    \u0027Zed\u0027: 64,"},{"line_number":240,"context_line":"}"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"# TODO(berrange): Remove NovaObjectDictCompat"}],"source_content_type":"text/x-python","patch_set":1,"id":"c3f2bbc4_7988b226","line":240,"in_reply_to":"ca8825ce_da55d851","updated":"2022-09-14 06:55:44.000000000","message":"if we do the bump at the end of the cycle that means during the cycle the master branch supports more than N-1, it supports N-1 + the stuff we are adding to master to the release in development. Again, we can make that promise if we verify that it works.","commit_id":"e7787f11018d4f7315c3a5fd38e3ce07a796de66"}]}