)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"7816195f141bf7c29f4bd6225c602823f7e4b2f8","unresolved":true,"context_lines":[{"line_number":13,"context_line":"us the network-vif-plugged event as soon as we updated the port"},{"line_number":14,"context_line":"binding."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"That behaviour has changed with commit 66c7f00e1d9. With that commit,"},{"line_number":17,"context_line":"we started unplugging the vifs on the source compute host when doing a"},{"line_number":18,"context_line":"resize. When reverting the resize, the vifs had to be re-plugged again,"},{"line_number":19,"context_line":"regarldess of the networking backend in use. This renders commit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d077b3ea_16148942","line":16,"range":{"start_line":16,"start_character":39,"end_line":16,"end_character":50},"updated":"2022-12-08 16:33:48.000000000","message":"This mentioned commit [1] was added in wallaby, so reading the commit message we don\u0027t need this in Victoria, or do I miss something?\n\n[1] I2c195df5fcf844c0587933b5b5995bdca1a3ebed","commit_id":"00b43470956339f8ba00a4ddd99ab88a855e84ba"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"c6e66cae91bad6b189851afe7d3101f687444c86","unresolved":true,"context_lines":[{"line_number":13,"context_line":"us the network-vif-plugged event as soon as we updated the port"},{"line_number":14,"context_line":"binding."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"That behaviour has changed with commit 66c7f00e1d9. With that commit,"},{"line_number":17,"context_line":"we started unplugging the vifs on the source compute host when doing a"},{"line_number":18,"context_line":"resize. When reverting the resize, the vifs had to be re-plugged again,"},{"line_number":19,"context_line":"regarldess of the networking backend in use. This renders commit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e43cd621_9558471a","line":16,"range":{"start_line":16,"start_character":39,"end_line":16,"end_character":50},"in_reply_to":"d077b3ea_16148942","updated":"2022-12-09 14:55:23.000000000","message":"Did you see that the linked change-id also has its own backports? When that merges, it will affect victoria too.\n\nIf you agree this comment is not a problem, would you like me to respin this series just because of the commit message nits?","commit_id":"00b43470956339f8ba00a4ddd99ab88a855e84ba"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"2c17f9007e06f44d5bebf2b1f9030db6479d2189","unresolved":false,"context_lines":[{"line_number":13,"context_line":"us the network-vif-plugged event as soon as we updated the port"},{"line_number":14,"context_line":"binding."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"That behaviour has changed with commit 66c7f00e1d9. With that commit,"},{"line_number":17,"context_line":"we started unplugging the vifs on the source compute host when doing a"},{"line_number":18,"context_line":"resize. When reverting the resize, the vifs had to be re-plugged again,"},{"line_number":19,"context_line":"regarldess of the networking backend in use. This renders commit"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"333889d4_42f5d63d","line":16,"range":{"start_line":16,"start_character":39,"end_line":16,"end_character":50},"in_reply_to":"e43cd621_9558471a","updated":"2022-12-13 14:04:27.000000000","message":"Sorry, I must have missed it. You are right, that is backported and even merged in stable/victoria. Probably this patch could have been backported on top of that patch to show that they are related.\n\nNo need to respin the patch just because of the nits, but if you update the patch for any reason, then feel free to fix the nits as well.","commit_id":"00b43470956339f8ba00a4ddd99ab88a855e84ba"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"7816195f141bf7c29f4bd6225c602823f7e4b2f8","unresolved":true,"context_lines":[{"line_number":20,"context_line":"7a7a223602ca5aa0aca8f65a6ab143f1d8f8ec1b. pointless, and it can be"},{"line_number":21,"context_line":"reverted."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Backport is clean from master, and the TODO that was present in the"},{"line_number":24,"context_line":"commit message on master is removed, as its a driver interface change"},{"line_number":25,"context_line":"and can only be done on master."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Closes-bug: 1952003"},{"line_number":28,"context_line":"Change-Id: I3cb39a9ec2c260f422b3c48122b9db512cdd799b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fad53bf3_e0f607d0","line":25,"range":{"start_line":23,"start_character":0,"end_line":25,"end_character":31},"updated":"2022-12-08 16:33:48.000000000","message":"nit: this note is probably not needed as this is valid for the 1st cherry pick from master.","commit_id":"00b43470956339f8ba00a4ddd99ab88a855e84ba"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"7816195f141bf7c29f4bd6225c602823f7e4b2f8","unresolved":true,"context_lines":[{"line_number":29,"context_line":"(cherry picked from commit 0b0f40d1b308b29da537859b72080488560c23d4)"},{"line_number":30,"context_line":"(cherry picked from commit c3ebe0f39e82cf1df6886cfd03fd8de62548fb26)"},{"line_number":31,"context_line":"(cherry picked from commit 36378de1bdfe451d683ed1028ffd5f6c7130c6ee)"},{"line_number":32,"context_line":"    Conflicts:"},{"line_number":33,"context_line":"        zuul.yaml"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"36ae88ce_e2dbf410","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":17},"updated":"2022-12-08 16:33:48.000000000","message":"nit: Usually in Nova we add this in a separate paragraph just above the Change-Id block. Also, to ease the reviewing we tend to add notes what caused the config. In this case the conflict is due to patch Ie42eaa2a39ef097b0eb69b8863bb342bae007fff is not backported. This was originally added exactly for this bugfix. Since this additional job was backported along with the fix, I guess it could be added here too.","commit_id":"00b43470956339f8ba00a4ddd99ab88a855e84ba"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"7816195f141bf7c29f4bd6225c602823f7e4b2f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"23e9ea11_30babb52","updated":"2022-12-08 16:33:48.000000000","message":"The code part of the cherry pick is clean, however I wonder if we really need this in victoria. See my comment inline.","commit_id":"00b43470956339f8ba00a4ddd99ab88a855e84ba"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c2a26af809bbf02599b7c9d88e556f6b8163e202","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c53cad4_016bdb00","updated":"2023-02-02 18:21:23.000000000","message":"This still looks good, and it totally fixed resize revert in the broken Victoria cloud I was just looking at.\n\nFWIW, Ussuri seems fine, so I am not sure if its needed in ussuri?","commit_id":"00b43470956339f8ba00a4ddd99ab88a855e84ba"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"c43171a582b3f1ba540d89dd99a3bf5b4eb5bfbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b6d131a5_10fa0590","updated":"2022-09-14 11:23:27.000000000","message":"recheck: nova-ceph-multistore: keystone errors, but no keystone logs","commit_id":"00b43470956339f8ba00a4ddd99ab88a855e84ba"}]}