)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"835a4d9dfca3f004200e9f8031be76be10711c19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32a5f202_bfb61931","updated":"2022-09-16 16:01:53.000000000","message":"Small nits. Probably not worth blocking on but if you feel like respinning, I\u0027ll revisit this.","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9ba8a18b49ce9ae70c73d687be45310e69e09146","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"018a8627_a3e876df","updated":"2022-09-16 16:26:51.000000000","message":"if we are updating this we proably shoudl document that . _ and - are also allow as is as a space.\n\nin generally you should prefer uuids but i have linked the actul regex inline","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1381f20b682eddcd93bf0d3576763434d9d47cd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8ab472e6_ded3c9ad","updated":"2022-09-19 12:58:51.000000000","message":"thanks this looks good to me","commit_id":"b7356303cdfd9df42b9fea7ab51cb85de7318dad"}],"api-ref/source/flavors.inc":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0a25eb2de51749c578a6645fba465389b83fa5ab","unresolved":true,"context_lines":[{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. warning::"},{"line_number":64,"context_line":"Flavor with flavor id having special characters is not allowed, except hyphen(-)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Normal response codes: 200"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"017dc7a7_54dcd61f","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":81},"updated":"2022-09-16 10:55:28.000000000","message":"the flavor id is ment to be an int or a uuid\n\nwe should say that instead\n\nthat is why - is allowed\n\nwe allow uuid in the serialised string form with - between the groups\n\ne.g. 8cb71dba-07b9-4a26-8c90-ea3554c34be3\n\n\nwe only allow int for backward compatiablity and because we like setting m1.nano to 42 in devstack :)","commit_id":"1a9a00b3e4b70340aec6a7d93c07f5c7ace0736b"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"908623a3ee2936b6b171994ca7ff2ee7bbdd2bab","unresolved":false,"context_lines":[{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. warning::"},{"line_number":64,"context_line":"Flavor with flavor id having special characters is not allowed, except hyphen(-)."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"Normal response codes: 200"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"11d5812c_02a8f2e9","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":81},"in_reply_to":"017dc7a7_54dcd61f","updated":"2022-09-16 13:24:59.000000000","message":"Done","commit_id":"1a9a00b3e4b70340aec6a7d93c07f5c7ace0736b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cf4abf0daea7970c8290f2c322675a37a615193c","unresolved":true,"context_lines":[{"line_number":60,"context_line":"Creating a flavor is typically only available to administrators of a"},{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. warning::"},{"line_number":64,"context_line":"   Flavors with special characters in the flavour id, except the hyphen (-), are not permitted."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   Flavor IDs are meant to be UUIDs. Serialized strings separated/grouped by \"-\" represent the default flavour ID or UUID."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"0946e2be_22647e16","line":63,"range":{"start_line":63,"start_character":3,"end_line":63,"end_character":10},"updated":"2022-09-16 12:34:53.000000000","message":"this is really a note.\n\nyou should proably also update the api ref\nhttps://docs.openstack.org/api-ref/compute/?expanded\u003dcreate-flavor-detail#create-flavor\n\ncurrently it says\n\"\"\"The ID of the flavor. While people often make this look like an int, this is really a string. If not provided, this defaults to a uuid.\"\"\"\n\nso you should add \"special characters in the flavour id, except the hyphen (-), are not permitted\"","commit_id":"c20186f0a9f7990472064303ad733174923970cc"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"908623a3ee2936b6b171994ca7ff2ee7bbdd2bab","unresolved":true,"context_lines":[{"line_number":60,"context_line":"Creating a flavor is typically only available to administrators of a"},{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. warning::"},{"line_number":64,"context_line":"   Flavors with special characters in the flavour id, except the hyphen (-), are not permitted."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   Flavor IDs are meant to be UUIDs. Serialized strings separated/grouped by \"-\" represent the default flavour ID or UUID."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"f35db1ae_ca24c463","line":63,"range":{"start_line":63,"start_character":3,"end_line":63,"end_character":10},"in_reply_to":"0946e2be_22647e16","updated":"2022-09-16 13:24:59.000000000","message":"Updated.\n\ncan we set this as caution, it looks like this.\nhttps://790d9935094baff15714-0bfc8edcfc6151fde7a863fd100cc784.ssl.cf2.rackcdn.com/858094/5/check/build-openstack-api-ref/681ef1c/docs/index.html?expanded\u003dcreate-flavor-detail","commit_id":"c20186f0a9f7990472064303ad733174923970cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"851cc13f7e94a317b64b9fa03ab08ad52d3cddb4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"Creating a flavor is typically only available to administrators of a"},{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. warning::"},{"line_number":64,"context_line":"   Flavors with special characters in the flavour id, except the hyphen (-), are not permitted."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   Flavor IDs are meant to be UUIDs. Serialized strings separated/grouped by \"-\" represent the default flavour ID or UUID."}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ac8efb2d_4de0a283","line":63,"range":{"start_line":63,"start_character":3,"end_line":63,"end_character":10},"in_reply_to":"f35db1ae_ca24c463","updated":"2022-09-19 08:51:50.000000000","message":"Ack","commit_id":"c20186f0a9f7990472064303ad733174923970cc"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"835a4d9dfca3f004200e9f8031be76be10711c19","unresolved":true,"context_lines":[{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":"   Flavors with special characters in the flavor id, except the hyphen (-),"},{"line_number":65,"context_line":"   are not permitted."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   Flavor IDs are meant to be UUIDs. Serialized strings separated/grouped by \"-\""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"c54e98f6_7cc8c503","line":64,"range":{"start_line":64,"start_character":49,"end_line":64,"end_character":51},"updated":"2022-09-16 16:01:53.000000000","message":"ID","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9ba8a18b49ce9ae70c73d687be45310e69e09146","unresolved":true,"context_lines":[{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":"   Flavors with special characters in the flavor id, except the hyphen (-),"},{"line_number":65,"context_line":"   are not permitted."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   Flavor IDs are meant to be UUIDs. Serialized strings separated/grouped by \"-\""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"4c563407_c8462c4e","line":64,"range":{"start_line":64,"start_character":71,"end_line":64,"end_character":74},"updated":"2022-09-16 16:26:51.000000000","message":"strictly speaking the validation is\n\nhttps://opendev.org/openstack/nova/src/branch/master/nova/api/openstack/compute/schemas/flavor_manage.py#L31\n\n\n \u0027minLength\u0027: 1, \u0027maxLength\u0027: 255,\n \u0027pattern\u0027: \u0027^(?! )[a-zA-Z0-9. _-]+(?\u003c! )$\u0027\n \n so we allow \".\" \"_\" \"-\" and alphanumeric (a-z A-Z and 0-9)","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"851cc13f7e94a317b64b9fa03ab08ad52d3cddb4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":"   Flavors with special characters in the flavor id, except the hyphen (-),"},{"line_number":65,"context_line":"   are not permitted."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   Flavor IDs are meant to be UUIDs. Serialized strings separated/grouped by \"-\""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"0b01e4cf_095acfc5","line":64,"range":{"start_line":64,"start_character":71,"end_line":64,"end_character":74},"in_reply_to":"0244d55c_2a945c2c","updated":"2022-09-19 08:51:50.000000000","message":"Ack","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"acf0057593c0d2866b43d2a05341aa87dc4125be","unresolved":true,"context_lines":[{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":"   Flavors with special characters in the flavor id, except the hyphen (-),"},{"line_number":65,"context_line":"   are not permitted."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   Flavor IDs are meant to be UUIDs. Serialized strings separated/grouped by \"-\""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"0244d55c_2a945c2c","line":64,"range":{"start_line":64,"start_character":71,"end_line":64,"end_character":74},"in_reply_to":"4c563407_c8462c4e","updated":"2022-09-17 17:58:40.000000000","message":"Called out for alphanumeric\nadded underscore, spaces and dots.","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"acf0057593c0d2866b43d2a05341aa87dc4125be","unresolved":false,"context_lines":[{"line_number":61,"context_line":"cloud because this has implications for scheduling efficiently in the cloud."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. note::"},{"line_number":64,"context_line":"   Flavors with special characters in the flavor id, except the hyphen (-),"},{"line_number":65,"context_line":"   are not permitted."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   Flavor IDs are meant to be UUIDs. Serialized strings separated/grouped by \"-\""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"02ea69c0_5f5ceaa9","line":64,"range":{"start_line":64,"start_character":49,"end_line":64,"end_character":51},"in_reply_to":"c54e98f6_7cc8c503","updated":"2022-09-17 17:58:40.000000000","message":"Done","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"835a4d9dfca3f004200e9f8031be76be10711c19","unresolved":true,"context_lines":[{"line_number":3129,"context_line":"  max_version: 2.46"},{"line_number":3130,"context_line":"flavor_id_body_create:"},{"line_number":3131,"context_line":"  description: |"},{"line_number":3132,"context_line":"    Special characters in the flavor id string, except the hyphen (-),"},{"line_number":3133,"context_line":"    are not permitted. If an ID is not provided, then a default UUID will be assigned."},{"line_number":3134,"context_line":"  in: body"},{"line_number":3135,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"326fcaab_b9a2e7fe","line":3132,"range":{"start_line":3132,"start_character":37,"end_line":3132,"end_character":39},"updated":"2022-09-16 16:01:53.000000000","message":"ID","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"acf0057593c0d2866b43d2a05341aa87dc4125be","unresolved":false,"context_lines":[{"line_number":3129,"context_line":"  max_version: 2.46"},{"line_number":3130,"context_line":"flavor_id_body_create:"},{"line_number":3131,"context_line":"  description: |"},{"line_number":3132,"context_line":"    Special characters in the flavor id string, except the hyphen (-),"},{"line_number":3133,"context_line":"    are not permitted. If an ID is not provided, then a default UUID will be assigned."},{"line_number":3134,"context_line":"  in: body"},{"line_number":3135,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"9c5b5a20_2b1a6c17","line":3132,"range":{"start_line":3132,"start_character":37,"end_line":3132,"end_character":39},"in_reply_to":"326fcaab_b9a2e7fe","updated":"2022-09-17 17:58:40.000000000","message":"Done","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"835a4d9dfca3f004200e9f8031be76be10711c19","unresolved":true,"context_lines":[{"line_number":3129,"context_line":"  max_version: 2.46"},{"line_number":3130,"context_line":"flavor_id_body_create:"},{"line_number":3131,"context_line":"  description: |"},{"line_number":3132,"context_line":"    Special characters in the flavor id string, except the hyphen (-),"},{"line_number":3133,"context_line":"    are not permitted. If an ID is not provided, then a default UUID will be assigned."},{"line_number":3134,"context_line":"  in: body"},{"line_number":3135,"context_line":"  required: false"},{"line_number":3136,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a355cdcf_14df1865","line":3133,"range":{"start_line":3132,"start_character":4,"end_line":3133,"end_character":22},"updated":"2022-09-16 16:01:53.000000000","message":"nit:\n\n  Only alphanumeric characters hyphens (``-``) are permitted.","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"acf0057593c0d2866b43d2a05341aa87dc4125be","unresolved":false,"context_lines":[{"line_number":3129,"context_line":"  max_version: 2.46"},{"line_number":3130,"context_line":"flavor_id_body_create:"},{"line_number":3131,"context_line":"  description: |"},{"line_number":3132,"context_line":"    Special characters in the flavor id string, except the hyphen (-),"},{"line_number":3133,"context_line":"    are not permitted. If an ID is not provided, then a default UUID will be assigned."},{"line_number":3134,"context_line":"  in: body"},{"line_number":3135,"context_line":"  required: false"},{"line_number":3136,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"96e73220_e640cae8","line":3133,"range":{"start_line":3132,"start_character":4,"end_line":3133,"end_character":22},"in_reply_to":"a355cdcf_14df1865","updated":"2022-09-17 17:58:40.000000000","message":"Done","commit_id":"ba6c8318d07448416c0ab61ee34ee8510caa2db3"}]}