)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"edeba012232bf378388f3210ce0a1d335161ad8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"00237a15_6e89570e","updated":"2022-10-13 07:48:15.000000000","message":"recheck","commit_id":"4d21a5fc9e9e28631c12020f42f60e9a62d4f776"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"b495c2c38363ac827fc3549008aeb7c455c8c7b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"ae42e0f4_e0247af9","updated":"2022-11-29 11:04:41.000000000","message":"recheck unrelated","commit_id":"39fa99b922d1f1b40a6afb7ea2302005026702d3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"982161e3af887a6e5c7dc2314304029f00a12238","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"88543693_e201fd9b","updated":"2022-11-29 12:51:58.000000000","message":"recheck unrelated segfault on python","commit_id":"39fa99b922d1f1b40a6afb7ea2302005026702d3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"fcf9e0242da819a80e111a411bdc9603eab791aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"c1101882_efa06c52","updated":"2022-11-29 16:06:01.000000000","message":"recheck unrelated tempest issue","commit_id":"39fa99b922d1f1b40a6afb7ea2302005026702d3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6e5701d81888df3a2a637d2bcdb14bda10c64d3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"c0cf9f03_a6c60a22","updated":"2023-01-02 14:02:14.000000000","message":"recheck unrelated volume failure","commit_id":"6e4880c5401845089c22353509da882f57a469d5"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"30e77d4c1c5f7e176e91f035469a4d5a3aaaa59c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"cda85dc7_71ec72f7","updated":"2023-01-13 17:01:10.000000000","message":"recheck unrelated POST FAILURE","commit_id":"7a707f47bd073617669a6fbd8d2325c51c99a2aa"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a7d616cfc598206a7961c62db0e05a19e7700636","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"a4f980d9_d60bb161","updated":"2023-01-24 10:42:40.000000000","message":"looking at the result in zuul  this will fail. it fixed your orgingal failing cases but there are 4 tests the check the max version that need to be updated\n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_39a/858384/30/check/nova-tox-functional-py38/39a3253/testr_results.html\n\nonce that is fixed this is proably ready to go","commit_id":"e7dbf5e1e25539298a4b2e39689fc86a6af04e5d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"60b0161d5c62843af91d42b73221ae4f054c0c3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"67ef18e7_15b52225","in_reply_to":"a4f980d9_d60bb161","updated":"2023-01-24 11:05:50.000000000","message":"I should have double tested! sorry for the resource consumption for no reasons...","commit_id":"e7dbf5e1e25539298a4b2e39689fc86a6af04e5d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"09cccd0f1fbeb7f7fe52613e79693bb3240fb9c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"c1bb70b3_04542137","updated":"2023-01-24 15:04:52.000000000","message":"Well, I\u0027m a bit afraid of the upgrade if we don\u0027t correctly explain why an latest evacuation API wouldn\u0027t work if all the computes aren\u0027t yet upgraded.\nI\u0027ve also looked at the spec and I see that Dan had the same thoughts https://review.opendev.org/c/openstack/nova-specs/+/857838/11/specs/2023.1/approved/allowing-target-state-for-evacuate.rst#124 \n\nI don\u0027t really want to say we should not doing this, but at least I\u0027d like to better explain the new behaviour in both the exception we return and in the relnote.","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b96d41934ae3e885ad7509d3c34246ad3e5ec354","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"57d95e81_d2065789","updated":"2023-01-24 15:25:23.000000000","message":"ok i agree with sylvain\n\nlets impoved the release notes and also improve the excpetion mesage to piont operator to using the older microverion.\n\nwe should proably also call this out in the api ref i guess.\n\ni.e. microverion 2.95 required all compute ot have a min compute service version of X\n","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f672b172d49bc7cd4f477b3b3d8b0673a686db0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"cb721479_c5d8587c","updated":"2023-01-24 13:04:18.000000000","message":"so assuming this now passes ci i think we can proceed with this.","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ec06ece53ca5896a784ec9b0cf8996f127dd74f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"3d6f20db_ea2c2727","updated":"2023-01-25 17:34:55.000000000","message":"changing my vote to -1 since the rpcpin can make this situation happening (I thought this was impossible to enter those conditions before)","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ee5ff16f20628be58387d4bbb58ff6dd9677805e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"adef6254_e9880b4f","updated":"2023-01-25 08:16:02.000000000","message":"recheck post failure","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"456d421f8ed98adf2a3771d75adfc1d4a0852814","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"814367a0_b17e0f1b","updated":"2023-01-27 09:08:13.000000000","message":"recheck unrelated tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON","commit_id":"4da5f055e6b1fe1902fd38ebab0f820f0b3722ec"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5978bb6bf7a9bc79c41e5711e2656332488664fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"30e84612_c901b536","updated":"2023-01-31 17:17:02.000000000","message":"Thank you Rajesh","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"483bee486a932c7862aadaf38410f754031dd656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"4238dec7_3060afd4","updated":"2023-01-31 13:17:39.000000000","message":"if sylvain or other are happy with the test coverage then i think we can proceed.\n\n+1 for now while i ping them to confirm","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"488e36ccd04becd7406869efa344faa46115a067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"afdaa2b8_742df98b","updated":"2023-01-31 13:43:56.000000000","message":"some minor nits, otherwise LGTM.","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"daa3c18d859c50b4a0d5cf00dcdb28da93199536","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"67469636_324c0a3f","updated":"2023-02-01 11:09:45.000000000","message":"I have two extra nits to fix in a FUP","commit_id":"d732ee38a1c596ab2720de51e91f83d6dbc727cf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6bffc86ca8282febf556df111cb5486922bf2002","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"4ed047bf_05299b95","updated":"2023-02-01 09:58:27.000000000","message":"Ok, nothing holding this merge, I\u0027m definitely +2/+W on it.\nThanks Sahid for the hard work, very much appreciated. Don\u0027t hesitate to bug me on IRC once you provide the followup, but as I trust you, I don\u0027t wanna hold the merge until I see it.","commit_id":"d732ee38a1c596ab2720de51e91f83d6dbc727cf"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f2d0501c33d1920c369cf4bc1c7a2a2fd773eed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":41,"id":"62b05d70_0203965b","updated":"2023-02-01 05:59:46.000000000","message":"thre are one or two nits inline but i dont see anything that requires a respin so +2\n\nif you do respin please adress sylvains comments inline","commit_id":"d732ee38a1c596ab2720de51e91f83d6dbc727cf"}],"doc/api_samples/os-evacuate/v2.95/server-evacuate-find-host-req.json":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"daa3c18d859c50b4a0d5cf00dcdb28da93199536","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"evacuate\": {"},{"line_number":3,"context_line":"        \"targetState\": \"stopped\""},{"line_number":4,"context_line":"    }"},{"line_number":5,"context_line":"}"}],"source_content_type":"application/json","patch_set":41,"id":"15cb90df_0abc8ba8","line":3,"updated":"2023-02-01 11:09:45.000000000","message":"I think this is not part of the API request.","commit_id":"d732ee38a1c596ab2720de51e91f83d6dbc727cf"}],"doc/api_samples/os-evacuate/v2.95/server-evacuate-req.json":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"daa3c18d859c50b4a0d5cf00dcdb28da93199536","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"evacuate\": {"},{"line_number":3,"context_line":"        \"host\": \"testHost\","},{"line_number":4,"context_line":"        \"targetState\": \"stopped\""},{"line_number":5,"context_line":"    }"},{"line_number":6,"context_line":"}"}],"source_content_type":"application/json","patch_set":41,"id":"66f6c1ab_58913b1f","line":4,"updated":"2023-02-01 11:09:45.000000000","message":"ditto","commit_id":"d732ee38a1c596ab2720de51e91f83d6dbc727cf"}],"nova/api/openstack/api_version_request.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"60006a50406c77389312c1e8621563676cbc7bfe","unresolved":true,"context_lines":[{"line_number":254,"context_line":"             in keypair name."},{"line_number":255,"context_line":"    * 2.93 - Add support for volume backed server rebuild."},{"line_number":256,"context_line":"    * 2.94 - Allow FQDN in server hostname."},{"line_number":257,"context_line":"    * 2.95 - Extend evacuate to support target state."},{"line_number":258,"context_line":"\"\"\""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":28,"id":"d1c0b42a_5ff0b85b","line":257,"updated":"2023-01-23 17:03:52.000000000","message":"You forgot to amend https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/rest_api_version_history.rst","commit_id":"1223ea7f5c1e2ade4f9d012999d076ebddf9e9bc"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"da52d13d2ec842334aeb685c2dd055b624eeb9bc","unresolved":false,"context_lines":[{"line_number":254,"context_line":"             in keypair name."},{"line_number":255,"context_line":"    * 2.93 - Add support for volume backed server rebuild."},{"line_number":256,"context_line":"    * 2.94 - Allow FQDN in server hostname."},{"line_number":257,"context_line":"    * 2.95 - Extend evacuate to support target state."},{"line_number":258,"context_line":"\"\"\""},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":28,"id":"a2c3ad84_874ebff9","line":257,"in_reply_to":"d1c0b42a_5ff0b85b","updated":"2023-01-25 16:16:22.000000000","message":"Done","commit_id":"1223ea7f5c1e2ade4f9d012999d076ebddf9e9bc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ebc9309b1d865b5793a90f64d96daf598ec52150","unresolved":true,"context_lines":[{"line_number":263,"context_line":"# Note(cyeoh): This only applies for the v2.1 API once microversions"},{"line_number":264,"context_line":"# support is fully merged. It does not affect the V2 API."},{"line_number":265,"context_line":"_MIN_API_VERSION \u003d \u00272.1\u0027"},{"line_number":266,"context_line":"_MAX_API_VERSION \u003d \u00272.94\u0027"},{"line_number":267,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# Almost all proxy APIs which are related to network, images and baremetal"}],"source_content_type":"text/x-python","patch_set":29,"id":"8a53c1d0_08ac51bb","line":266,"range":{"start_line":266,"start_character":22,"end_line":266,"end_character":24},"updated":"2023-01-24 00:04:24.000000000","message":"this should be 2.95 now\n\nthis is proably why the api tests are failing","commit_id":"d51fd613d28289e78ec29420db7d17acbc6f3250"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"da52d13d2ec842334aeb685c2dd055b624eeb9bc","unresolved":false,"context_lines":[{"line_number":263,"context_line":"# Note(cyeoh): This only applies for the v2.1 API once microversions"},{"line_number":264,"context_line":"# support is fully merged. It does not affect the V2 API."},{"line_number":265,"context_line":"_MIN_API_VERSION \u003d \u00272.1\u0027"},{"line_number":266,"context_line":"_MAX_API_VERSION \u003d \u00272.94\u0027"},{"line_number":267,"context_line":"DEFAULT_API_VERSION \u003d _MIN_API_VERSION"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"# Almost all proxy APIs which are related to network, images and baremetal"}],"source_content_type":"text/x-python","patch_set":29,"id":"ce20c7f0_037014fb","line":266,"range":{"start_line":266,"start_character":22,"end_line":266,"end_character":24},"in_reply_to":"8a53c1d0_08ac51bb","updated":"2023-01-25 16:16:22.000000000","message":"Done","commit_id":"d51fd613d28289e78ec29420db7d17acbc6f3250"}],"nova/api/openstack/compute/evacuate.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"513769ead42048d2fbb910bcd2336feea396bb4e","unresolved":true,"context_lines":[{"line_number":81,"context_line":"    @validation.schema(evacuate.evacuate, \"2.0\", \"2.13\")"},{"line_number":82,"context_line":"    @validation.schema(evacuate.evacuate_v214, \"2.14\", \"2.28\")"},{"line_number":83,"context_line":"    @validation.schema(evacuate.evacuate_v2_29, \"2.29\", \"2.67\")"},{"line_number":84,"context_line":"    @validation.schema(evacuate.evacuate_v2_68, \"2.68\", \"2.93\")"},{"line_number":85,"context_line":"    @validation.schema(evacuate.evacuate_v2_95, \"2.95\")"},{"line_number":86,"context_line":"    def _evacuate(self, req, id, body):"},{"line_number":87,"context_line":"        \"\"\"Permit admins to evacuate a server from a failed host"}],"source_content_type":"text/x-python","patch_set":28,"id":"cf783bf1_f679cb7a","line":84,"range":{"start_line":84,"start_character":56,"end_line":84,"end_character":63},"updated":"2023-01-23 17:04:27.000000000","message":"this has to be bumped to 2.94 now.","commit_id":"1223ea7f5c1e2ade4f9d012999d076ebddf9e9bc"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ebc9309b1d865b5793a90f64d96daf598ec52150","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    @validation.schema(evacuate.evacuate, \"2.0\", \"2.13\")"},{"line_number":82,"context_line":"    @validation.schema(evacuate.evacuate_v214, \"2.14\", \"2.28\")"},{"line_number":83,"context_line":"    @validation.schema(evacuate.evacuate_v2_29, \"2.29\", \"2.67\")"},{"line_number":84,"context_line":"    @validation.schema(evacuate.evacuate_v2_68, \"2.68\", \"2.93\")"},{"line_number":85,"context_line":"    @validation.schema(evacuate.evacuate_v2_95, \"2.95\")"},{"line_number":86,"context_line":"    def _evacuate(self, req, id, body):"},{"line_number":87,"context_line":"        \"\"\"Permit admins to evacuate a server from a failed host"}],"source_content_type":"text/x-python","patch_set":28,"id":"cad79672_400d4e7e","line":84,"range":{"start_line":84,"start_character":56,"end_line":84,"end_character":63},"in_reply_to":"cf783bf1_f679cb7a","updated":"2023-01-24 00:04:24.000000000","message":"Done","commit_id":"1223ea7f5c1e2ade4f9d012999d076ebddf9e9bc"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"09cccd0f1fbeb7f7fe52613e79693bb3240fb9c9","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            if min_ver \u003c MIN_VER_NOVA_COMPUTE_EVACUATE_STOPPED:"},{"line_number":105,"context_line":"                raise exception.NotSupportedTargetStateEvacuate("},{"line_number":106,"context_line":"                    {\u0027currently\u0027: min_ver,"},{"line_number":107,"context_line":"                     \u0027expected\u0027: MIN_VER_NOVA_COMPUTE_EVACUATE_STOPPED})"},{"line_number":108,"context_line":"            # Starts to 2.95 any evacuated instances will be stopped at"},{"line_number":109,"context_line":"            # destination. Previously an active or stopped instance would have"},{"line_number":110,"context_line":"            # kept its state."}],"source_content_type":"text/x-python","patch_set":31,"id":"f1828c21_345920a2","line":107,"updated":"2023-01-24 15:04:52.000000000","message":"ouch, this would mean that when an operator upgrades their environment to Antelope, an evacuation would return this exception until all of the computes are upgraded too.\n\nGiven evacuations are only for admins, I think this is not really an issue as then the admin can ask for a previous microversion, but here I wonder whether we should rather not asking for a specific target state if all the computes are not yet upgraded.","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7aefadb8f2877519bae5e1307d5a4dfed1b77288","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            if min_ver \u003c MIN_VER_NOVA_COMPUTE_EVACUATE_STOPPED:"},{"line_number":105,"context_line":"                raise exception.NotSupportedTargetStateEvacuate("},{"line_number":106,"context_line":"                    {\u0027currently\u0027: min_ver,"},{"line_number":107,"context_line":"                     \u0027expected\u0027: MIN_VER_NOVA_COMPUTE_EVACUATE_STOPPED})"},{"line_number":108,"context_line":"            # Starts to 2.95 any evacuated instances will be stopped at"},{"line_number":109,"context_line":"            # destination. Previously an active or stopped instance would have"},{"line_number":110,"context_line":"            # kept its state."}],"source_content_type":"text/x-python","patch_set":31,"id":"99e8436f_10324f97","line":107,"in_reply_to":"f1828c21_345920a2","updated":"2023-01-26 16:35:24.000000000","message":"Ack","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"173b6e1cd41c0df2a1d8ee9ebe6281c2adeac02d","unresolved":true,"context_lines":[{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            self.compute_api.evacuate(context, instance, host,"},{"line_number":141,"context_line":"                                      on_shared_storage, password, force,"},{"line_number":142,"context_line":"                                      target_state)"},{"line_number":143,"context_line":"        except exception.InstanceInvalidState as state_error:"},{"line_number":144,"context_line":"            common.raise_http_conflict_for_instance_invalid_state(state_error,"},{"line_number":145,"context_line":"                    \u0027evacuate\u0027, id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"eb7e0a73_2eb2b239","line":142,"updated":"2023-01-25 16:52:27.000000000","message":"see, here you could have somehow managed the NovaException that could have been returned by the other dependent patch","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"16104964128b3fd401743e631d877b433325a7b6","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            self.compute_api.evacuate(context, instance, host,"},{"line_number":141,"context_line":"                                      on_shared_storage, password, force,"},{"line_number":142,"context_line":"                                      target_state)"},{"line_number":143,"context_line":"        except exception.InstanceInvalidState as state_error:"},{"line_number":144,"context_line":"            common.raise_http_conflict_for_instance_invalid_state(state_error,"},{"line_number":145,"context_line":"                    \u0027evacuate\u0027, id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"8d6c0ac2_9f9c9f60","line":142,"in_reply_to":"b13e95e7_367f8ef4","updated":"2023-01-26 14:53:32.000000000","message":"Done","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"ec06ece53ca5896a784ec9b0cf8996f127dd74f2","unresolved":true,"context_lines":[{"line_number":139,"context_line":"        try:"},{"line_number":140,"context_line":"            self.compute_api.evacuate(context, instance, host,"},{"line_number":141,"context_line":"                                      on_shared_storage, password, force,"},{"line_number":142,"context_line":"                                      target_state)"},{"line_number":143,"context_line":"        except exception.InstanceInvalidState as state_error:"},{"line_number":144,"context_line":"            common.raise_http_conflict_for_instance_invalid_state(state_error,"},{"line_number":145,"context_line":"                    \u0027evacuate\u0027, id)"}],"source_content_type":"text/x-python","patch_set":34,"id":"b13e95e7_367f8ef4","line":142,"in_reply_to":"eb7e0a73_2eb2b239","updated":"2023-01-25 17:34:55.000000000","message":"Actually, Sean raised a good point on IRC : if we pin the RPC versions (say, 6.0), the above get_min_versions_all_cells() check would pass but we would return the RPC exception here.\n\nAs this generic NovaException wouldn\u0027t be properly handled, the API would return a terrible HTTP500. Please do some exception handling here, please.","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"}],"nova/api/openstack/compute/rest_api_version_history.rst":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"09cccd0f1fbeb7f7fe52613e79693bb3240fb9c9","unresolved":true,"context_lines":[{"line_number":1242,"context_line":"2.95"},{"line_number":1243,"context_line":"---------------------"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"Any evacuated instances will be now stopped a destination."}],"source_content_type":"text/x-rst","patch_set":31,"id":"e5fe5ccf_655cfd43","line":1245,"range":{"start_line":1245,"start_character":43,"end_line":1245,"end_character":46},"updated":"2023-01-24 15:04:52.000000000","message":"nit: s/a/at the","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"64ce71aa37fd3dc7194619c4ea815ad00f4bc99a","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"2.95"},{"line_number":1243,"context_line":"---------------------"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"Any evacuated instances will be now stopped a destination."}],"source_content_type":"text/x-rst","patch_set":31,"id":"e71f86d9_905f06ef","line":1245,"range":{"start_line":1245,"start_character":43,"end_line":1245,"end_character":46},"in_reply_to":"e5fe5ccf_655cfd43","updated":"2023-01-24 16:45:26.000000000","message":"Done","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7558e4665864980173934c9d85b3d2bb9c8babe1","unresolved":true,"context_lines":[{"line_number":1243,"context_line":"---------------------"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"Any evacuated instances will be now stopped at destination. This"},{"line_number":1246,"context_line":"requires minimun compute version 27.0.0 (antelope 2023.1).  Operators"},{"line_number":1247,"context_line":"can still use previous microversion for older behavior."}],"source_content_type":"text/x-rst","patch_set":34,"id":"8a6cbe7a_b1b5fc52","line":1246,"range":{"start_line":1246,"start_character":33,"end_line":1246,"end_character":57},"updated":"2023-01-25 16:18:06.000000000","message":"nit: technically, the right wording for the OpenStack release is \"2023.1 Antelope\" and the nova package release is 27.0.0.\n\nThat said, I think people will understand that they need to upgrade all their computes before using this microversion.","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f2d0501c33d1920c369cf4bc1c7a2a2fd773eed","unresolved":true,"context_lines":[{"line_number":1243,"context_line":"---------------------"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"Any evacuated instances will be now stopped at destination. This"},{"line_number":1246,"context_line":"requires minimun compute version 27.0.0 (antelope 2023.1).  Operators"},{"line_number":1247,"context_line":"can still use previous microversion for older behavior."}],"source_content_type":"text/x-rst","patch_set":34,"id":"c0967668_0d7f77d1","line":1246,"range":{"start_line":1246,"start_character":33,"end_line":1246,"end_character":57},"in_reply_to":"8a6cbe7a_b1b5fc52","updated":"2023-02-01 05:59:46.000000000","message":"ya your right but i think this is ok\ni would like to land this today if we can.\n\nif there is a respin then this can be updated otherwise we can word smith it in a follow up patch if needed. i think this will be fine however as is.","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6bffc86ca8282febf556df111cb5486922bf2002","unresolved":true,"context_lines":[{"line_number":1243,"context_line":"---------------------"},{"line_number":1244,"context_line":""},{"line_number":1245,"context_line":"Any evacuated instances will be now stopped at destination. This"},{"line_number":1246,"context_line":"requires minimun compute version 27.0.0 (antelope 2023.1).  Operators"},{"line_number":1247,"context_line":"can still use previous microversion for older behavior."}],"source_content_type":"text/x-rst","patch_set":34,"id":"6e95b590_364942f8","line":1246,"range":{"start_line":1246,"start_character":33,"end_line":1246,"end_character":57},"in_reply_to":"c0967668_0d7f77d1","updated":"2023-02-01 09:58:27.000000000","message":"yup, agreed with providing a FUP.","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"}],"nova/api/openstack/compute/schemas/evacuate.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"09cccd0f1fbeb7f7fe52613e79693bb3240fb9c9","unresolved":true,"context_lines":[{"line_number":47,"context_line":"# to v2.14"},{"line_number":48,"context_line":"evacuate_v2_68 \u003d copy.deepcopy(evacuate_v214)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# v2.95 keeps the same shema, evacuating an instance will now result its state"},{"line_number":51,"context_line":"# to be stopped at destination."},{"line_number":52,"context_line":"evacuate_v2_95 \u003d copy.deepcopy(evacuate_v2_68)"}],"source_content_type":"text/x-python","patch_set":31,"id":"c8268a58_304aeffc","line":50,"range":{"start_line":50,"start_character":23,"end_line":50,"end_character":28},"updated":"2023-01-24 15:04:52.000000000","message":"nit: schema","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"64ce71aa37fd3dc7194619c4ea815ad00f4bc99a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"# to v2.14"},{"line_number":48,"context_line":"evacuate_v2_68 \u003d copy.deepcopy(evacuate_v214)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# v2.95 keeps the same shema, evacuating an instance will now result its state"},{"line_number":51,"context_line":"# to be stopped at destination."},{"line_number":52,"context_line":"evacuate_v2_95 \u003d copy.deepcopy(evacuate_v2_68)"}],"source_content_type":"text/x-python","patch_set":31,"id":"12c9b42c_eebb3185","line":50,"range":{"start_line":50,"start_character":23,"end_line":50,"end_character":28},"in_reply_to":"c8268a58_304aeffc","updated":"2023-01-24 16:45:26.000000000","message":"Done","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"}],"nova/exception.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"09cccd0f1fbeb7f7fe52613e79693bb3240fb9c9","unresolved":true,"context_lines":[{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":""},{"line_number":2506,"context_line":"class NotSupportedTargetStateEvacuate(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Minimun version required to use new evacuate \""},{"line_number":2508,"context_line":"                \"feature %(expected)s, currently %(currently)s.\")"}],"source_content_type":"text/x-python","patch_set":31,"id":"833c6c5f_896f55f8","line":2508,"range":{"start_line":2507,"start_character":17,"end_line":2508,"end_character":24},"updated":"2023-01-24 15:04:52.000000000","message":"I\u0027d rather prefer you explain that you can\u0027t evacuate by asking for a target state until the right microversion","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"64ce71aa37fd3dc7194619c4ea815ad00f4bc99a","unresolved":true,"context_lines":[{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":""},{"line_number":2506,"context_line":"class NotSupportedTargetStateEvacuate(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Minimun version required to use new evacuate \""},{"line_number":2508,"context_line":"                \"feature %(expected)s, currently %(currently)s.\")"}],"source_content_type":"text/x-python","patch_set":31,"id":"84842225_6678b555","line":2508,"range":{"start_line":2507,"start_character":17,"end_line":2508,"end_character":24},"in_reply_to":"833c6c5f_896f55f8","updated":"2023-01-24 16:45:26.000000000","message":"Please let me know whether that sounds better now?","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7558e4665864980173934c9d85b3d2bb9c8babe1","unresolved":false,"context_lines":[{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":""},{"line_number":2506,"context_line":"class NotSupportedTargetStateEvacuate(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Minimun version required to use new evacuate \""},{"line_number":2508,"context_line":"                \"feature %(expected)s, currently %(currently)s.\")"}],"source_content_type":"text/x-python","patch_set":31,"id":"331459c3_a91f77fb","line":2508,"range":{"start_line":2507,"start_character":17,"end_line":2508,"end_character":24},"in_reply_to":"84842225_6678b555","updated":"2023-01-25 16:18:06.000000000","message":"That\u0027s well better, indeed. Thanks for the rewording.","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45d5bdceb23fde762a992dbd3d78a4f1560a1cac","unresolved":true,"context_lines":[{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":""},{"line_number":2506,"context_line":"class NotSupportedComputeForEvacuateV295(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Starts to microversion 2.95, evacuate API will stop \""},{"line_number":2508,"context_line":"                \"instance on destination. Required version for compute \""},{"line_number":2509,"context_line":"                \"%(expected), current version %(currently)s\")"}],"source_content_type":"text/x-python","patch_set":32,"id":"f1c5c7cf_c560c18a","line":2507,"range":{"start_line":2507,"start_character":17,"end_line":2507,"end_character":26},"updated":"2023-01-24 16:33:21.000000000","message":"Starting in","commit_id":"6cfcbb5795425df29191d475286a10ab58b38f88"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"64ce71aa37fd3dc7194619c4ea815ad00f4bc99a","unresolved":false,"context_lines":[{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":""},{"line_number":2506,"context_line":"class NotSupportedComputeForEvacuateV295(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Starts to microversion 2.95, evacuate API will stop \""},{"line_number":2508,"context_line":"                \"instance on destination. Required version for compute \""},{"line_number":2509,"context_line":"                \"%(expected), current version %(currently)s\")"}],"source_content_type":"text/x-python","patch_set":32,"id":"36f4926c_a027229c","line":2507,"range":{"start_line":2507,"start_character":17,"end_line":2507,"end_character":26},"in_reply_to":"f1c5c7cf_c560c18a","updated":"2023-01-24 16:45:26.000000000","message":"Done","commit_id":"6cfcbb5795425df29191d475286a10ab58b38f88"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45d5bdceb23fde762a992dbd3d78a4f1560a1cac","unresolved":true,"context_lines":[{"line_number":2506,"context_line":"class NotSupportedComputeForEvacuateV295(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Starts to microversion 2.95, evacuate API will stop \""},{"line_number":2508,"context_line":"                \"instance on destination. Required version for compute \""},{"line_number":2509,"context_line":"                \"%(expected), current version %(currently)s\")"}],"source_content_type":"text/x-python","patch_set":32,"id":"fb2610a7_aef4e95e","line":2509,"updated":"2023-01-24 16:33:21.000000000","message":"... to evacuate before upgrades are complete please use an older microversion.","commit_id":"6cfcbb5795425df29191d475286a10ab58b38f88"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"64ce71aa37fd3dc7194619c4ea815ad00f4bc99a","unresolved":false,"context_lines":[{"line_number":2506,"context_line":"class NotSupportedComputeForEvacuateV295(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Starts to microversion 2.95, evacuate API will stop \""},{"line_number":2508,"context_line":"                \"instance on destination. Required version for compute \""},{"line_number":2509,"context_line":"                \"%(expected), current version %(currently)s\")"}],"source_content_type":"text/x-python","patch_set":32,"id":"ef5b8ade_b68a9287","line":2509,"in_reply_to":"fb2610a7_aef4e95e","updated":"2023-01-24 16:45:26.000000000","message":"Done","commit_id":"6cfcbb5795425df29191d475286a10ab58b38f88"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7558e4665864980173934c9d85b3d2bb9c8babe1","unresolved":true,"context_lines":[{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":""},{"line_number":2506,"context_line":"class NotSupportedComputeForEvacuateV295(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Starting to microversion 2.95, evacuate API will stop \""},{"line_number":2508,"context_line":"                \"instance on destination. To evacuate before upgrades are \""},{"line_number":2509,"context_line":"                \"complete please use an older microversion. Required version \""},{"line_number":2510,"context_line":"                \"for compute %(expected), current version %(currently)s\")"}],"source_content_type":"text/x-python","patch_set":34,"id":"0df17e59_0c7a7a3a","line":2507,"range":{"start_line":2507,"start_character":26,"end_line":2507,"end_character":28},"updated":"2023-01-25 16:18:06.000000000","message":"nit: s/to/with","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f2d0501c33d1920c369cf4bc1c7a2a2fd773eed","unresolved":true,"context_lines":[{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":""},{"line_number":2506,"context_line":"class NotSupportedComputeForEvacuateV295(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Starting to microversion 2.95, evacuate API will stop \""},{"line_number":2508,"context_line":"                \"instance on destination. To evacuate before upgrades are \""},{"line_number":2509,"context_line":"                \"complete please use an older microversion. Required version \""},{"line_number":2510,"context_line":"                \"for compute %(expected), current version %(currently)s\")"}],"source_content_type":"text/x-python","patch_set":34,"id":"551f516d_2776a911","line":2507,"range":{"start_line":2507,"start_character":26,"end_line":2507,"end_character":28},"in_reply_to":"0df17e59_0c7a7a3a","updated":"2023-02-01 05:59:46.000000000","message":"ya this should be with","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6bffc86ca8282febf556df111cb5486922bf2002","unresolved":true,"context_lines":[{"line_number":2504,"context_line":""},{"line_number":2505,"context_line":""},{"line_number":2506,"context_line":"class NotSupportedComputeForEvacuateV295(NotSupported):"},{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Starting to microversion 2.95, evacuate API will stop \""},{"line_number":2508,"context_line":"                \"instance on destination. To evacuate before upgrades are \""},{"line_number":2509,"context_line":"                \"complete please use an older microversion. Required version \""},{"line_number":2510,"context_line":"                \"for compute %(expected), current version %(currently)s\")"}],"source_content_type":"text/x-python","patch_set":34,"id":"2058ec8f_181c9da2","line":2507,"range":{"start_line":2507,"start_character":26,"end_line":2507,"end_character":28},"in_reply_to":"551f516d_2776a911","updated":"2023-02-01 09:58:27.000000000","message":"This nit is still open, please fix it in a FUP.","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7558e4665864980173934c9d85b3d2bb9c8babe1","unresolved":false,"context_lines":[{"line_number":2507,"context_line":"    msg_fmt \u003d _(\"Starting to microversion 2.95, evacuate API will stop \""},{"line_number":2508,"context_line":"                \"instance on destination. To evacuate before upgrades are \""},{"line_number":2509,"context_line":"                \"complete please use an older microversion. Required version \""},{"line_number":2510,"context_line":"                \"for compute %(expected), current version %(currently)s\")"}],"source_content_type":"text/x-python","patch_set":34,"id":"0acab04f_68541d36","line":2510,"updated":"2023-01-25 16:18:06.000000000","message":"++","commit_id":"ac9b763755819ebe990a65824b477f1bf9116cc1"}],"nova/tests/functional/regressions/test_bug_1764883.py":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"488e36ccd04becd7406869efa344faa46115a067","unresolved":true,"context_lines":[{"line_number":22,"context_line":"        test.TestCase, integrated_helpers.InstanceHelperMixin):"},{"line_number":23,"context_line":"    \"\"\"Assert the behaviour of evacuating instances when the src returns early."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    This test asserts that evacuating instances end up in an valable state on"},{"line_number":26,"context_line":"    the destination even when the source host comes back online during an"},{"line_number":27,"context_line":"    evacuation while the migration record is in a pre-migrating state."},{"line_number":28,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":40,"id":"43a976fe_b27ff4e2","line":25,"updated":"2023-01-31 13:43:56.000000000","message":"nit: looks like you changed it by mistake or you mean available state?","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5978bb6bf7a9bc79c41e5711e2656332488664fa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        test.TestCase, integrated_helpers.InstanceHelperMixin):"},{"line_number":23,"context_line":"    \"\"\"Assert the behaviour of evacuating instances when the src returns early."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    This test asserts that evacuating instances end up in an valable state on"},{"line_number":26,"context_line":"    the destination even when the source host comes back online during an"},{"line_number":27,"context_line":"    evacuation while the migration record is in a pre-migrating state."},{"line_number":28,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":40,"id":"48b30dd2_d9c815b3","line":25,"in_reply_to":"43a976fe_b27ff4e2","updated":"2023-01-31 17:17:02.000000000","message":"Done","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"}],"nova/tests/unit/api/openstack/compute/test_evacuate.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7aefadb8f2877519bae5e1307d5a4dfed1b77288","unresolved":true,"context_lines":[{"line_number":434,"context_line":"                          self._get_evacuate_response,"},{"line_number":435,"context_line":"                          {\u0027host\u0027: \u0027my-host\u0027, \u0027adminPass\u0027: \u0027foo\u0027})"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def test_evacuate_unsupported_rpc(self):"},{"line_number":438,"context_line":"        def fake_evacuate(*args, **kwargs):"},{"line_number":439,"context_line":"            raise exception.UnsupportedRPCVersion("},{"line_number":440,"context_line":"                api\u003d\"fakeapi\","}],"source_content_type":"text/x-python","patch_set":36,"id":"1ca36fe3_09ce2a09","line":437,"updated":"2023-01-26 16:35:24.000000000","message":"i was orginaly thinking of a functional test for this to avoid mocking but if others are ok with jsut a unit test then ok.","commit_id":"775722523c0f6ddf86881926cb33dedf791c66ce"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2f2d0501c33d1920c369cf4bc1c7a2a2fd773eed","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                          self._get_evacuate_response,"},{"line_number":435,"context_line":"                          {\u0027host\u0027: \u0027my-host\u0027, \u0027adminPass\u0027: \u0027foo\u0027})"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def test_evacuate_unsupported_rpc(self):"},{"line_number":438,"context_line":"        def fake_evacuate(*args, **kwargs):"},{"line_number":439,"context_line":"            raise exception.UnsupportedRPCVersion("},{"line_number":440,"context_line":"                api\u003d\"fakeapi\","}],"source_content_type":"text/x-python","patch_set":36,"id":"c1dea588_2135d8b2","line":437,"in_reply_to":"1ca36fe3_09ce2a09","updated":"2023-02-01 05:59:46.000000000","message":"Ack","commit_id":"775722523c0f6ddf86881926cb33dedf791c66ce"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"6bffc86ca8282febf556df111cb5486922bf2002","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                          self._get_evacuate_response,"},{"line_number":435,"context_line":"                          {\u0027host\u0027: \u0027my-host\u0027, \u0027adminPass\u0027: \u0027foo\u0027})"},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"    def test_evacuate_unsupported_rpc(self):"},{"line_number":438,"context_line":"        def fake_evacuate(*args, **kwargs):"},{"line_number":439,"context_line":"            raise exception.UnsupportedRPCVersion("},{"line_number":440,"context_line":"                api\u003d\"fakeapi\","}],"source_content_type":"text/x-python","patch_set":36,"id":"df47a15d_114fbb36","line":437,"in_reply_to":"1ca36fe3_09ce2a09","updated":"2023-02-01 09:58:27.000000000","message":"I\u0027m OK with this, seems enough.","commit_id":"775722523c0f6ddf86881926cb33dedf791c66ce"}],"releasenotes/notes/allowing-target-state-for-evacuate-d4c1912c481973d6.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"09cccd0f1fbeb7f7fe52613e79693bb3240fb9c9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":31,"id":"52769935_6c3ebc57","line":6,"updated":"2023-01-24 15:04:52.000000000","message":"here, IMO, we need to add an upgrade section for explaining to the operators that they would have an expection when evacuating with the last microversion unless they either ask for a previous microversion or they upgrade all their compute services.","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7558e4665864980173934c9d85b3d2bb9c8babe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"733dc0e9_00b49e41","line":6,"in_reply_to":"1e2366d9_7a12c421","updated":"2023-01-25 16:18:06.000000000","message":"All good here, thanks !","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"64ce71aa37fd3dc7194619c4ea815ad00f4bc99a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":31,"id":"1e2366d9_7a12c421","line":6,"in_reply_to":"52769935_6c3ebc57","updated":"2023-01-24 16:45:26.000000000","message":"Same, let me know if that sounds like what you have in head.","commit_id":"5389ce3b05fe4c656d046ff0aef90a5d275468a6"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"45d5bdceb23fde762a992dbd3d78a4f1560a1cac","unresolved":true,"context_lines":[{"line_number":7,"context_line":"    microversion below v2.95."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Operators will have to consider upgrading compute hosts to v6.2 in"},{"line_number":11,"context_line":"    order to take advantage of the new evacuate API behavior."}],"source_content_type":"text/x-yaml","patch_set":32,"id":"715de05e_211606d0","line":10,"range":{"start_line":10,"start_character":62,"end_line":10,"end_character":67},"updated":"2023-01-24 16:33:21.000000000","message":"were is 6.2 coiming form the rpc version?\n\nwe should not use that here and above. we should refer to the openstack relese version. \"Nova 27.0.0 (antelope 2023.1)\" something like that","commit_id":"6cfcbb5795425df29191d475286a10ab58b38f88"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"64ce71aa37fd3dc7194619c4ea815ad00f4bc99a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    microversion below v2.95."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Operators will have to consider upgrading compute hosts to v6.2 in"},{"line_number":11,"context_line":"    order to take advantage of the new evacuate API behavior."}],"source_content_type":"text/x-yaml","patch_set":32,"id":"80120211_aa0162ce","line":10,"range":{"start_line":10,"start_character":62,"end_line":10,"end_character":67},"in_reply_to":"715de05e_211606d0","updated":"2023-01-24 16:45:26.000000000","message":"Done","commit_id":"6cfcbb5795425df29191d475286a10ab58b38f88"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"488e36ccd04becd7406869efa344faa46115a067","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting to v2.95 any evacuated instances will be stopped at"},{"line_number":5,"context_line":"    destination. The required minimun version for Nova computes is"},{"line_number":6,"context_line":"    27.0.0 (antelope 2023.1).  Operator can still continue using"},{"line_number":7,"context_line":"    previous behavior by selecting microversion below v2.95."}],"source_content_type":"text/x-yaml","patch_set":40,"id":"80be13fd_74d03528","line":4,"updated":"2023-01-31 13:43:56.000000000","message":"nit: instance ?","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"488e36ccd04becd7406869efa344faa46115a067","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting to v2.95 any evacuated instances will be stopped at"},{"line_number":5,"context_line":"    destination. The required minimun version for Nova computes is"},{"line_number":6,"context_line":"    27.0.0 (antelope 2023.1).  Operator can still continue using"},{"line_number":7,"context_line":"    previous behavior by selecting microversion below v2.95."}],"source_content_type":"text/x-yaml","patch_set":40,"id":"10d29c90_8055372a","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":15},"updated":"2023-01-31 13:43:56.000000000","message":"nit: s/to/with","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5978bb6bf7a9bc79c41e5711e2656332488664fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting to v2.95 any evacuated instances will be stopped at"},{"line_number":5,"context_line":"    destination. The required minimun version for Nova computes is"},{"line_number":6,"context_line":"    27.0.0 (antelope 2023.1).  Operator can still continue using"},{"line_number":7,"context_line":"    previous behavior by selecting microversion below v2.95."}],"source_content_type":"text/x-yaml","patch_set":40,"id":"88938a48_e29de9a9","line":4,"range":{"start_line":4,"start_character":13,"end_line":4,"end_character":15},"in_reply_to":"10d29c90_8055372a","updated":"2023-01-31 17:17:02.000000000","message":"Done","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5978bb6bf7a9bc79c41e5711e2656332488664fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting to v2.95 any evacuated instances will be stopped at"},{"line_number":5,"context_line":"    destination. The required minimun version for Nova computes is"},{"line_number":6,"context_line":"    27.0.0 (antelope 2023.1).  Operator can still continue using"},{"line_number":7,"context_line":"    previous behavior by selecting microversion below v2.95."}],"source_content_type":"text/x-yaml","patch_set":40,"id":"831c4183_c92c8614","line":4,"in_reply_to":"80be13fd_74d03528","updated":"2023-01-31 17:17:02.000000000","message":"Done","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"488e36ccd04becd7406869efa344faa46115a067","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting to v2.95 any evacuated instances will be stopped at"},{"line_number":5,"context_line":"    destination. The required minimun version for Nova computes is"},{"line_number":6,"context_line":"    27.0.0 (antelope 2023.1).  Operator can still continue using"},{"line_number":7,"context_line":"    previous behavior by selecting microversion below v2.95."},{"line_number":8,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"5d337487_fa252379","line":5,"updated":"2023-01-31 13:43:56.000000000","message":"nit:typo minimum","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5978bb6bf7a9bc79c41e5711e2656332488664fa","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting to v2.95 any evacuated instances will be stopped at"},{"line_number":5,"context_line":"    destination. The required minimun version for Nova computes is"},{"line_number":6,"context_line":"    27.0.0 (antelope 2023.1).  Operator can still continue using"},{"line_number":7,"context_line":"    previous behavior by selecting microversion below v2.95."},{"line_number":8,"context_line":"upgrade:"}],"source_content_type":"text/x-yaml","patch_set":40,"id":"8f5b0b93_782ad9f3","line":5,"in_reply_to":"5d337487_fa252379","updated":"2023-01-31 17:17:02.000000000","message":"Done","commit_id":"756ad99ee5feaa36f72175bd32c0975199e04cb4"}]}