)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5d98135830fab115129a4dd27baa4b051999ab0b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Napatech SmartNIC support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These patche enable support Napatech SmartNIC in nova"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Openvswitch driver with Virtio-Forwarder was"},{"line_number":12,"context_line":"extended"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c4238a8c_5166330a","line":9,"updated":"2023-05-05 14:30:15.000000000","message":"This patch enables","commit_id":"b7e4509734aa69b7b86523efc296a18fe211469b"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"70ed7c9b21ea4d11b77b07beebfe53605d24ec56","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Napatech SmartNIC support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"These patche enable support Napatech SmartNIC in nova"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Openvswitch driver with Virtio-Forwarder was"},{"line_number":12,"context_line":"extended"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"b20591c4_02dae802","line":9,"in_reply_to":"c4238a8c_5166330a","updated":"2023-05-08 09:05:32.000000000","message":"Done","commit_id":"b7e4509734aa69b7b86523efc296a18fe211469b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5d98135830fab115129a4dd27baa4b051999ab0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"551df25d_d154039b","updated":"2023-05-05 14:30:15.000000000","message":"Sounds good I guess you are missing at test for it and probably a reno note will be necessary. Thanks","commit_id":"b7e4509734aa69b7b86523efc296a18fe211469b"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"c68fe0974b702064c538c098d344a39c3f4a72fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"61436278_d6d2f3c6","updated":"2023-03-10 15:14:30.000000000","message":"recheck","commit_id":"b7e4509734aa69b7b86523efc296a18fe211469b"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"01567747026cfba1f5c0859a22760d92d8f608ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"057a0527_09cfb62a","in_reply_to":"13678336_9e9c95c4","updated":"2023-05-11 15:59:03.000000000","message":"ACK, Thanks for the heads-up","commit_id":"b7e4509734aa69b7b86523efc296a18fe211469b"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"70ed7c9b21ea4d11b77b07beebfe53605d24ec56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"be213f84_d9abe4a6","in_reply_to":"551df25d_d154039b","updated":"2023-05-08 09:05:32.000000000","message":"Hello, Sahid. Thank you for your review. We had provided this code like PoC for better vision at the PTG meeting. We will resolve all comments.","commit_id":"b7e4509734aa69b7b86523efc296a18fe211469b"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"672a9eb32a6c67f514e83f99543451d6f6cd8a7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"13678336_9e9c95c4","in_reply_to":"be213f84_d9abe4a6","updated":"2023-05-08 13:09:37.000000000","message":"We plan to wait for spec file review from Neutron team and after that start to create unit and functional tests","commit_id":"b7e4509734aa69b7b86523efc296a18fe211469b"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"c43f735ba49f7614fbf0563f207fc0ca117435ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"207f11be_ea821d0c","updated":"2023-05-12 18:46:49.000000000","message":"recheck","commit_id":"490bf089775022e303aa4bb71952c5cb4d3a3c90"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"3e10e51793cbccb3da782a5358750a8aec8e59cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ae4bde6c_09d84769","updated":"2023-05-12 13:02:16.000000000","message":"recheck","commit_id":"490bf089775022e303aa4bb71952c5cb4d3a3c90"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"ba549a85821e902250629fe939b28e041ca6cfdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a421115_d047a288","updated":"2023-07-10 09:07:17.000000000","message":"recheck","commit_id":"6971a5bbcd357bf5cc90259b357551cfaf2cc353"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3aec1720298d2063d8d79656c9f4f09f9f144ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9d7455a2_fc0380f2","updated":"2023-08-14 10:54:49.000000000","message":"+1 for now but we do need to see the thrid party ci\nrunning on this before we merge teh entire feature","commit_id":"4b2a011eb4952b3d6bb477ec394cab76ac31e5b3"}],"nova/network/os_vif_util.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5d98135830fab115129a4dd27baa4b051999ab0b","unresolved":true,"context_lines":[{"line_number":420,"context_line":"        _set_vhostuser_settings(vif, obj)"},{"line_number":421,"context_line":"        return obj"},{"line_number":422,"context_line":"    elif vif[\u0027details\u0027].get(model.VIF_DETAILS_VHOSTUSER_OVS_PLUG, False):"},{"line_number":423,"context_line":"        datapath_type\u003dvif[\u0027details\u0027].get("},{"line_number":424,"context_line":"                    model.VIF_DETAILS_OVS_DATAPATH_TYPE)"},{"line_number":425,"context_line":"        if vif.get(\u0027vnic_type\u0027) \u003d\u003d model.VNIC_TYPE_VIRTIO_FORWARDER:"},{"line_number":426,"context_line":"            obj \u003d _get_vif_instance("}],"source_content_type":"text/x-python","patch_set":5,"id":"5b959bda_d8bd8d3e","line":423,"updated":"2023-05-05 14:30:15.000000000","message":"datapath_type \u003d ...","commit_id":"b7e4509734aa69b7b86523efc296a18fe211469b"},{"author":{"_account_id":35489,"name":"Danylo Vodopianov","email":"dvo-plv@napatech.com","username":"dvo-plv"},"change_message_id":"70ed7c9b21ea4d11b77b07beebfe53605d24ec56","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        _set_vhostuser_settings(vif, obj)"},{"line_number":421,"context_line":"        return obj"},{"line_number":422,"context_line":"    elif vif[\u0027details\u0027].get(model.VIF_DETAILS_VHOSTUSER_OVS_PLUG, False):"},{"line_number":423,"context_line":"        datapath_type\u003dvif[\u0027details\u0027].get("},{"line_number":424,"context_line":"                    model.VIF_DETAILS_OVS_DATAPATH_TYPE)"},{"line_number":425,"context_line":"        if vif.get(\u0027vnic_type\u0027) \u003d\u003d model.VNIC_TYPE_VIRTIO_FORWARDER:"},{"line_number":426,"context_line":"            obj \u003d _get_vif_instance("}],"source_content_type":"text/x-python","patch_set":5,"id":"8a0c9267_3484dea2","line":423,"in_reply_to":"5b959bda_d8bd8d3e","updated":"2023-05-08 09:05:32.000000000","message":"Done","commit_id":"b7e4509734aa69b7b86523efc296a18fe211469b"}],"nova/tests/unit/network/test_os_vif_util.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3aec1720298d2063d8d79656c9f4f09f9f144ce","unresolved":true,"context_lines":[{"line_number":592,"context_line":"            details\u003d{"},{"line_number":593,"context_line":"                model.VIF_DETAILS_VHOSTUSER_MODE: \u0027client\u0027,"},{"line_number":594,"context_line":"                model.VIF_DETAILS_VHOSTUSER_OVS_PLUG: True,"},{"line_number":595,"context_line":"                model.VIF_DETAILS_VHOSTUSER_SOCKET: \u0027/fake/socket\u0027,"},{"line_number":596,"context_line":"                model.VIF_DETAILS_OVS_DATAPATH_TYPE:"},{"line_number":597,"context_line":"                    model.VIF_DETAILS_OVS_DATAPATH_NETDEV,"},{"line_number":598,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":10,"id":"6f5b99f1_7c9e9577","line":595,"updated":"2023-08-14 10:54:49.000000000","message":"i guess its important to note that for this configuration neutron woudl have already calulated the socket pathfor the given device.\nso nova is just passing that forward","commit_id":"4b2a011eb4952b3d6bb477ec394cab76ac31e5b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"f3aec1720298d2063d8d79656c9f4f09f9f144ce","unresolved":true,"context_lines":[{"line_number":616,"context_line":"                    representor_address\u003d\"0000:08:08.5\")),"},{"line_number":617,"context_line":"            preserve_on_delete\u003dFalse,"},{"line_number":618,"context_line":"            vif_name\u003d\"nicdc065497-3c\","},{"line_number":619,"context_line":"            path\u003d\u0027/fake/socket\u0027,"},{"line_number":620,"context_line":"            mode\u003d\u0027client\u0027,"},{"line_number":621,"context_line":"            network\u003dosv_objects.network.Network("},{"line_number":622,"context_line":"                id\u003d\"b82c1929-051e-481d-8110-4669916c7915\","}],"source_content_type":"text/x-python","patch_set":10,"id":"d28b5299_2e381d5c","line":619,"updated":"2023-08-14 10:54:49.000000000","message":"so we expect this to not change.","commit_id":"4b2a011eb4952b3d6bb477ec394cab76ac31e5b3"}]}
