)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"0706a6f9_fba73fe4","updated":"2024-11-05 13:48:30.000000000","message":"My main issue is the missing of detach.error notifications when the detach fails.","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7f4a64351d9f3582c3976e80db948ff1f3f18c17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"b9489a0d_be296bfd","in_reply_to":"0706a6f9_fba73fe4","updated":"2024-11-05 13:50:55.000000000","message":"Ahh that is in the next patch in the series. Then what remains here are small nits.","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"57da3c897e73fb8cf80ce57fc168a9a9d33c5d91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"58d6a7c0_849b6a9d","updated":"2024-11-19 14:12:01.000000000","message":"+1 for a FUP.","commit_id":"7811d0bbc6cf606049d6a9ee7c79f5f23deb5079"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"97ec8c913f838453acde36b195cdda83db224075","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"9f7c115a_bc0c8e8b","updated":"2024-11-15 10:50:11.000000000","message":"There are nits in the functional test. But I won\u0027t hold up the series due to them. Please propose a follow up top of the series.","commit_id":"7811d0bbc6cf606049d6a9ee7c79f5f23deb5079"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"28a852c1afc1504de24b716916c5c2a71f37b6b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"a2b3dfb5_44ab2650","updated":"2024-12-05 09:25:20.000000000","message":"recheck nova-next guest ssh timeout","commit_id":"9f8b05fd90b5f5c8618a470b43fe19a2264a5449"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"21cd44dfb04bdca6e37b901bc991e846c8956580","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"b43325d5_0e66f5be","updated":"2024-12-09 10:29:46.000000000","message":"recheck parent merged","commit_id":"9f8b05fd90b5f5c8618a470b43fe19a2264a5449"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98ecd665acccf4b8ba81ab124c51b5171be01c1a","unresolved":true,"context_lines":[{"line_number":4741,"context_line":"                raise"},{"line_number":4742,"context_line":""},{"line_number":4743,"context_line":"            finally:"},{"line_number":4744,"context_line":"                notify(fields.NotificationPhase.END)"},{"line_number":4745,"context_line":""},{"line_number":4746,"context_line":"        _allow_share(context, instance, share_mapping)"},{"line_number":4747,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"3c15ce2f_6950df58","line":4744,"updated":"2024-08-28 14:24:47.000000000","message":"I think in case of other notifications have a different semantic. The end notification is not sent when nova encountered an error and sent the error notification instead. E.g. https://github.com/openstack/nova/blob/b3a24947288bc50066878c855e5a2db9c794d78e/nova/tests/functional/notification_sample_tests/test_instance.py#L455-L458","commit_id":"1b2bd9ac5f5d50ff47fcb6eb138ff5ded0536752"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":false,"context_lines":[{"line_number":4741,"context_line":"                raise"},{"line_number":4742,"context_line":""},{"line_number":4743,"context_line":"            finally:"},{"line_number":4744,"context_line":"                notify(fields.NotificationPhase.END)"},{"line_number":4745,"context_line":""},{"line_number":4746,"context_line":"        _allow_share(context, instance, share_mapping)"},{"line_number":4747,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"7bec0511_bc62ab35","line":4744,"in_reply_to":"3c15ce2f_6950df58","updated":"2024-11-05 13:48:30.000000000","message":"It is resolved now and the either nova sends an END or an ERROR notification.","commit_id":"1b2bd9ac5f5d50ff47fcb6eb138ff5ded0536752"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":true,"context_lines":[{"line_number":4840,"context_line":"                exception.ShareAccessRemovalError,"},{"line_number":4841,"context_line":"                exception.ShareProtocolNotSupported,"},{"line_number":4842,"context_line":"            ) as e:"},{"line_number":4843,"context_line":"                self._set_share_mapping_status("},{"line_number":4844,"context_line":"                    share_mapping, fields.ShareMappingStatus.ERROR"},{"line_number":4845,"context_line":"                )"},{"line_number":4846,"context_line":"                LOG.error(e.format_message())"},{"line_number":4847,"context_line":"                raise"},{"line_number":4848,"context_line":"            except keystone_exception.http.Unauthorized as e:"},{"line_number":4849,"context_line":"                self._set_share_mapping_status("},{"line_number":4850,"context_line":"                    share_mapping, fields.ShareMappingStatus.ERROR"},{"line_number":4851,"context_line":"                )"},{"line_number":4852,"context_line":"                LOG.error(e)"},{"line_number":4853,"context_line":"                raise"},{"line_number":4854,"context_line":"            except (exception.ShareNotFound, exception.ShareAccessNotFound):"},{"line_number":4855,"context_line":"                # Ignore the error if for any reason there is nothing to"},{"line_number":4856,"context_line":"                # remove from manila, so we can still detach the share."}],"source_content_type":"text/x-python","patch_set":48,"id":"13583999_05306d05","line":4853,"range":{"start_line":4843,"start_character":0,"end_line":4853,"end_character":21},"updated":"2024-11-05 13:48:30.000000000","message":"both cases I would send an ERROR notification as there won\u0027t be any END notification due to the error is being re-raised.","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7f4a64351d9f3582c3976e80db948ff1f3f18c17","unresolved":false,"context_lines":[{"line_number":4840,"context_line":"                exception.ShareAccessRemovalError,"},{"line_number":4841,"context_line":"                exception.ShareProtocolNotSupported,"},{"line_number":4842,"context_line":"            ) as e:"},{"line_number":4843,"context_line":"                self._set_share_mapping_status("},{"line_number":4844,"context_line":"                    share_mapping, fields.ShareMappingStatus.ERROR"},{"line_number":4845,"context_line":"                )"},{"line_number":4846,"context_line":"                LOG.error(e.format_message())"},{"line_number":4847,"context_line":"                raise"},{"line_number":4848,"context_line":"            except keystone_exception.http.Unauthorized as e:"},{"line_number":4849,"context_line":"                self._set_share_mapping_status("},{"line_number":4850,"context_line":"                    share_mapping, fields.ShareMappingStatus.ERROR"},{"line_number":4851,"context_line":"                )"},{"line_number":4852,"context_line":"                LOG.error(e)"},{"line_number":4853,"context_line":"                raise"},{"line_number":4854,"context_line":"            except (exception.ShareNotFound, exception.ShareAccessNotFound):"},{"line_number":4855,"context_line":"                # Ignore the error if for any reason there is nothing to"},{"line_number":4856,"context_line":"                # remove from manila, so we can still detach the share."}],"source_content_type":"text/x-python","patch_set":48,"id":"f9e76c73_4999dffd","line":4853,"range":{"start_line":4843,"start_character":0,"end_line":4853,"end_character":21},"in_reply_to":"13583999_05306d05","updated":"2024-11-05 13:50:55.000000000","message":"it is handled in the next patch in the series.","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"}],"nova/notifications/objects/instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98ecd665acccf4b8ba81ab124c51b5171be01c1a","unresolved":true,"context_lines":[{"line_number":197,"context_line":"    # Version 1.0: Initial version"},{"line_number":198,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":199,"context_line":"    fields \u003d {"},{"line_number":200,"context_line":"        \u0027share_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":201,"context_line":"    }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def __init__(self, context, instance, fault, share_id):"}],"source_content_type":"text/x-python","patch_set":42,"id":"4057e09c_b497e8f4","line":200,"updated":"2024-08-28 14:24:47.000000000","message":"When will be the share_id null?","commit_id":"1b2bd9ac5f5d50ff47fcb6eb138ff5ded0536752"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    # Version 1.0: Initial version"},{"line_number":198,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":199,"context_line":"    fields \u003d {"},{"line_number":200,"context_line":"        \u0027share_id\u0027: fields.UUIDField(nullable\u003dTrue),"},{"line_number":201,"context_line":"    }"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def __init__(self, context, instance, fault, share_id):"}],"source_content_type":"text/x-python","patch_set":42,"id":"62a3feee_a2c3a3b1","line":200,"in_reply_to":"4057e09c_b497e8f4","updated":"2024-11-05 13:48:30.000000000","message":"Done","commit_id":"1b2bd9ac5f5d50ff47fcb6eb138ff5ded0536752"}],"nova/tests/functional/integrated_helpers.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":true,"context_lines":[{"line_number":562,"context_line":"        self.notifier.wait_for_versioned_notifications("},{"line_number":563,"context_line":"            \u0027instance.share_attach.end\u0027)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def _attach_share_with_error(self, server, share_id):"},{"line_number":566,"context_line":"        self.api.post_server_share("},{"line_number":567,"context_line":"            server[\u0027id\u0027], {\"share\": {\"share_id\": share_id}})"},{"line_number":568,"context_line":"        self.notifier.wait_for_versioned_notifications("}],"source_content_type":"text/x-python","patch_set":48,"id":"7ddb22fa_e318e05d","line":565,"updated":"2024-11-05 13:48:30.000000000","message":"I expect to have a variant where the detach results in an ERROR notification instead of an END notification.","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7f4a64351d9f3582c3976e80db948ff1f3f18c17","unresolved":false,"context_lines":[{"line_number":562,"context_line":"        self.notifier.wait_for_versioned_notifications("},{"line_number":563,"context_line":"            \u0027instance.share_attach.end\u0027)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def _attach_share_with_error(self, server, share_id):"},{"line_number":566,"context_line":"        self.api.post_server_share("},{"line_number":567,"context_line":"            server[\u0027id\u0027], {\"share\": {\"share_id\": share_id}})"},{"line_number":568,"context_line":"        self.notifier.wait_for_versioned_notifications("}],"source_content_type":"text/x-python","patch_set":48,"id":"860c309d_5676850e","line":565,"in_reply_to":"7ddb22fa_e318e05d","updated":"2024-11-05 13:50:55.000000000","message":"probably it is in the next patch in the series.","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98ecd665acccf4b8ba81ab124c51b5171be01c1a","unresolved":true,"context_lines":[{"line_number":1961,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], {\u0027os-start\u0027: {}})"},{"line_number":1962,"context_line":"            self._wait_for_state_change(server, expected_status\u003d\u0027ERROR\u0027)"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"            # Notifications are not sorted in a deterministic way as it depends"},{"line_number":1965,"context_line":"            # compute response time. So just check we have a notification"},{"line_number":1966,"context_line":"            # which is an exception from compute."},{"line_number":1967,"context_line":""},{"line_number":1968,"context_line":"            self.assertTrue("},{"line_number":1969,"context_line":"                any("}],"source_content_type":"text/x-python","patch_set":42,"id":"cb33b064_0b91ec08","line":1966,"range":{"start_line":1964,"start_character":0,"end_line":1966,"end_character":49},"updated":"2024-08-28 14:24:47.000000000","message":"that is strange. I think this should be deterministic in the functional test.","commit_id":"1b2bd9ac5f5d50ff47fcb6eb138ff5ded0536752"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"57da3c897e73fb8cf80ce57fc168a9a9d33c5d91","unresolved":false,"context_lines":[{"line_number":1961,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], {\u0027os-start\u0027: {}})"},{"line_number":1962,"context_line":"            self._wait_for_state_change(server, expected_status\u003d\u0027ERROR\u0027)"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"            # Notifications are not sorted in a deterministic way as it depends"},{"line_number":1965,"context_line":"            # compute response time. So just check we have a notification"},{"line_number":1966,"context_line":"            # which is an exception from compute."},{"line_number":1967,"context_line":""},{"line_number":1968,"context_line":"            self.assertTrue("},{"line_number":1969,"context_line":"                any("}],"source_content_type":"text/x-python","patch_set":42,"id":"97508510_b9a480be","line":1966,"range":{"start_line":1964,"start_character":0,"end_line":1966,"end_character":49},"in_reply_to":"643b660b_fcb0ce66","updated":"2024-11-19 14:12:01.000000000","message":"Acknowledged","commit_id":"1b2bd9ac5f5d50ff47fcb6eb138ff5ded0536752"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":true,"context_lines":[{"line_number":1961,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], {\u0027os-start\u0027: {}})"},{"line_number":1962,"context_line":"            self._wait_for_state_change(server, expected_status\u003d\u0027ERROR\u0027)"},{"line_number":1963,"context_line":""},{"line_number":1964,"context_line":"            # Notifications are not sorted in a deterministic way as it depends"},{"line_number":1965,"context_line":"            # compute response time. So just check we have a notification"},{"line_number":1966,"context_line":"            # which is an exception from compute."},{"line_number":1967,"context_line":""},{"line_number":1968,"context_line":"            self.assertTrue("},{"line_number":1969,"context_line":"                any("}],"source_content_type":"text/x-python","patch_set":42,"id":"643b660b_fcb0ce66","line":1966,"range":{"start_line":1964,"start_character":0,"end_line":1966,"end_character":49},"in_reply_to":"cb33b064_0b91ec08","updated":"2024-11-05 13:48:30.000000000","message":"you removed the comment but you kept the logic that the comment explained. Either it is not deterministic and we need both the logic and the comment (and a bit more explanation why it is not deterministic in the functional test) or it is deterministic and then the comment can be removed and the logic can be simplified to expect a compute.exception at a given place in the list.","commit_id":"1b2bd9ac5f5d50ff47fcb6eb138ff5ded0536752"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":true,"context_lines":[{"line_number":1958,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], {\u0027os-start\u0027: {}})"},{"line_number":1959,"context_line":"            self._wait_for_state_change(server, expected_status\u003d\u0027ERROR\u0027)"},{"line_number":1960,"context_line":""},{"line_number":1961,"context_line":"            self.assertTrue("},{"line_number":1962,"context_line":"                any("},{"line_number":1963,"context_line":"                    ["},{"line_number":1964,"context_line":"                        item"},{"line_number":1965,"context_line":"                        for item in self.notifier.versioned_notifications"},{"line_number":1966,"context_line":"                        if item[\"event_type\"] \u003d\u003d \"compute.exception\""},{"line_number":1967,"context_line":"                    ]"},{"line_number":1968,"context_line":"                )"},{"line_number":1969,"context_line":"            )"},{"line_number":1970,"context_line":""},{"line_number":1971,"context_line":"            # Detach share despite the share error"},{"line_number":1972,"context_line":"            self.notifier.reset()"},{"line_number":1973,"context_line":"            self._detach_share("}],"source_content_type":"text/x-python","patch_set":48,"id":"20e071c7_c95ce0e0","line":1970,"range":{"start_line":1961,"start_character":0,"end_line":1970,"end_character":0},"updated":"2024-11-05 13:48:30.000000000","message":"I still think the order should be deterministic in the functional env so this could work with hardcoding the index of the compute.exception notification.","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":true,"context_lines":[{"line_number":1985,"context_line":"                    \u0027shares\u0027: expected_shares,"},{"line_number":1986,"context_line":"                    \u0027power_state\u0027: \u0027shutdown\u0027},"},{"line_number":1987,"context_line":"                actual\u003dself.notifier.versioned_notifications[0])"},{"line_number":1988,"context_line":"            expected_shares[0][\u0027nova_object.data\u0027][\u0027status\u0027] \u003d \u0027detaching\u0027"},{"line_number":1989,"context_line":"            self._verify_notification("},{"line_number":1990,"context_line":"                \u0027instance-share_detach-end\u0027,"},{"line_number":1991,"context_line":"                replacements\u003d{"}],"source_content_type":"text/x-python","patch_set":48,"id":"44ed5474_e58afa88","line":1988,"updated":"2024-11-05 13:48:30.000000000","message":"I don\u0027t see why we need this. This value is not used later in this test.","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":true,"context_lines":[{"line_number":2003,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":2004,"context_line":"            self._wait_for_notification(\u0027instance.reboot.start\u0027)"},{"line_number":2005,"context_line":"            self._wait_for_notification(\u0027instance.reboot.end\u0027)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"    def _test_rescue_unrescue_server(self, server):"},{"line_number":2008,"context_line":"        # Both \"rescue\" and \"unrescue\" notification asserts are made here"},{"line_number":2009,"context_line":"        # rescue notification asserts"}],"source_content_type":"text/x-python","patch_set":48,"id":"153aca1a_d944d52f","line":2006,"updated":"2024-11-05 13:48:30.000000000","message":"we missing the coverage for detach.error","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7f4a64351d9f3582c3976e80db948ff1f3f18c17","unresolved":false,"context_lines":[{"line_number":2003,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":2004,"context_line":"            self._wait_for_notification(\u0027instance.reboot.start\u0027)"},{"line_number":2005,"context_line":"            self._wait_for_notification(\u0027instance.reboot.end\u0027)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"    def _test_rescue_unrescue_server(self, server):"},{"line_number":2008,"context_line":"        # Both \"rescue\" and \"unrescue\" notification asserts are made here"},{"line_number":2009,"context_line":"        # rescue notification asserts"}],"source_content_type":"text/x-python","patch_set":48,"id":"e07c9288_5f23eb5b","line":2006,"in_reply_to":"153aca1a_d944d52f","updated":"2024-11-05 13:50:55.000000000","message":"probably in the next patch in the series.","commit_id":"a52fcb174d309260668fba0eb9ffed4dbeed0332"}],"nova/tests/unit/notifications/objects/test_notification.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"98ecd665acccf4b8ba81ab124c51b5171be01c1a","unresolved":true,"context_lines":[{"line_number":397,"context_line":"        \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":398,"context_line":"    \u0027InstanceActionResizePrepPayload\u0027: \u00271.4-214cb6123beb0ffe5eb1e08ce424086b\u0027,"},{"line_number":399,"context_line":"    \u0027InstanceActionShareNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":400,"context_line":"    \u0027InstanceActionSharePayload\u0027: \u00271.0-ccadcef11a8657ca8124fa15aad99b2d\u0027,"},{"line_number":401,"context_line":"    \u0027InstanceActionVolumeNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":402,"context_line":"    \u0027InstanceActionVolumePayload\u0027: \u00271.7-542d9e1485c6b925958df9912dc744ec\u0027,"},{"line_number":403,"context_line":"    \u0027InstanceActionVolumeSwapNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":42,"id":"6e697e8e_325595dd","line":400,"updated":"2024-08-28 14:24:47.000000000","message":"this is wrong, if the hash changes the the version needs to be bumped","commit_id":"1b2bd9ac5f5d50ff47fcb6eb138ff5ded0536752"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8d4e6ceea9d52323985c991d440e5a70a3b38357","unresolved":true,"context_lines":[{"line_number":397,"context_line":"        \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":398,"context_line":"    \u0027InstanceActionResizePrepPayload\u0027: \u00271.4-214cb6123beb0ffe5eb1e08ce424086b\u0027,"},{"line_number":399,"context_line":"    \u0027InstanceActionShareNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":400,"context_line":"    \u0027InstanceActionSharePayload\u0027: \u00271.0-ccadcef11a8657ca8124fa15aad99b2d\u0027,"},{"line_number":401,"context_line":"    \u0027InstanceActionVolumeNotification\u0027: \u00271.0-a73147b93b520ff0061865849d3dfa56\u0027,"},{"line_number":402,"context_line":"    \u0027InstanceActionVolumePayload\u0027: \u00271.7-542d9e1485c6b925958df9912dc744ec\u0027,"},{"line_number":403,"context_line":"    \u0027InstanceActionVolumeSwapNotification\u0027:"}],"source_content_type":"text/x-python","patch_set":42,"id":"3b809e4e_e5850a4d","line":400,"in_reply_to":"6e697e8e_325595dd","updated":"2024-11-05 13:48:30.000000000","message":"Did we agreed at some point that we will only bump the version of these new ovos once in the series? (I have vague memories about such a discussion).","commit_id":"1b2bd9ac5f5d50ff47fcb6eb138ff5ded0536752"}]}