)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c0f4b2b425b2d5c6c1c9d9507c074942d8571800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"3a04c6ca_acfd9204","updated":"2024-11-05 13:57:59.000000000","message":"logic looks good but the detach.error case is not covered in the func test.","commit_id":"a2d96613ed6869591f71bdcea1f45f0cdee90476"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4e73b2f1dbc1efcaf925531d03e59414e76a4de0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"497d7e0a_6f9f07fb","updated":"2024-11-15 10:52:11.000000000","message":"The missing test coverage here warrants a -1 from me at this point. There was couple of nits require followup in previous patches too. So I can be convinced to add the missing coverage in that follow up to. But I would like to see the FUP patch proposed before I will switch to a positive review.","commit_id":"a29636337e8afc2179b4e3a24df8ab1eeae40ca9"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3aee070d21cb9cf3c66f0df1bed331359ee918ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"cf988ba7_ea180cb5","updated":"2024-11-20 15:13:01.000000000","message":"Thanks for the test. Looks good to me.","commit_id":"ed785e4d9fd59c25ffde8a751ce48ed4820ef841"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4a5854ccaedf293e9be02f73d1e3d1560ac189fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"9415dea9_c3240172","updated":"2024-12-10 12:40:50.000000000","message":"recheck functional post failure","commit_id":"7dfb15235e702468ce0314597b3ef7b67d8b5748"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"60262b66bac49309a41d52896bdfbbade5549741","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"90c5c665_0e2070da","updated":"2024-12-12 16:36:52.000000000","message":"recheck grenade failed to fetch several url https://mirror-int.ord.rax.opendev.org/ubuntu/pool/main/p/postgresql-14/libpq5_14.13-0ubuntu0.22.04.1_amd64.deb  404  Not Found [IP: 10.209.96.36 443]","commit_id":"7dfb15235e702468ce0314597b3ef7b67d8b5748"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d86be1648f4d07b6118575d951d6e2d467ea9119","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"4623a3ef_0de99f5f","updated":"2024-12-12 13:44:49.000000000","message":"recheck multicell yet again a problem when ssh\u0027ing the instance\n\n\n```\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/utils/__init__.py\", line 65, in wrapper\n    return f(*func_args, **func_kwargs)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/opt/stack/tempest/tempest/scenario/test_volume_boot_pattern.py\", line 211, in test_image_defined_boot_from_volume\n    instance2 \u003d self.create_server(image_id\u003dimage[\u0027id\u0027], name\u003dname,\n                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/opt/stack/tempest/tempest/scenario/manager.py\", line 349, in create_server\n    body, _ \u003d compute.create_test_server(\n              ^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/opt/stack/tempest/tempest/common/compute.py\", line 340, in create_test_server\n    with excutils.save_and_reraise_exception():\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.12/site-packages/oslo_utils/excutils.py\", line 227, in __exit__\n    self.force_reraise()\n  File \"/opt/stack/tempest/.tox/tempest/lib/python3.12/site-packages/oslo_utils/excutils.py\", line 200, in force_reraise\n    raise self.value\n  File \"/opt/stack/tempest/tempest/common/compute.py\", line 335, in create_test_server\n    wait_for_ssh_or_ping(\n  File \"/opt/stack/tempest/tempest/common/compute.py\", line 148, in wait_for_ssh_or_ping\n    waiters.wait_for_ssh(\n  File \"/opt/stack/tempest/tempest/common/waiters.py\", line 713, in wait_for_ssh\n    raise lib_exc.TimeoutException()\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: None\n\n```","commit_id":"7dfb15235e702468ce0314597b3ef7b67d8b5748"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"611ac34c52dcd4822995e929498046651bd5f27e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"c96c41d3_b7f3ca5f","updated":"2024-12-09 10:30:01.000000000","message":"recheck parent merged","commit_id":"7dfb15235e702468ce0314597b3ef7b67d8b5748"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4bac67e71dfded732810f0e38e756dc51fa49d4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"3fe17ace_2a9ef1cc","updated":"2024-12-11 10:56:54.000000000","message":"recheck yet again volume attachment timeout failure \n\n```\ntraceback-1: {{{\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/waiters.py\", line 464, in wait_for_volume_attachment_remove_from_server\n    raise lib_exc.TimeoutException(message)\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: Volume 0df1c3e7-73bd-44f9-ac55-d95b54a201d6 failed to detach from server 0c3fba0d-4d82-48b3-8a7f-3af31256c943 within the required time (196 s) from the compute API perspective\n}}}\n\ntraceback-2: {{{\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/waiters.py\", line 396, in wait_for_volume_resource_status\n    raise lib_exc.TimeoutException(message)\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: volume 0df1c3e7-73bd-44f9-ac55-d95b54a201d6 failed to reach available status (current in-use) within the required time (196 s).\n}}}\n\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/utils/__init__.py\", line 65, in wrapper\n    return f(*func_args, **func_kwargs)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File \"/opt/stack/tempest/tempest/api/compute/servers/test_server_rescue.py\", line 254, in test_stable_device_rescue_disk_virtio_with_volume_attached\n    self._test_stable_device_rescue(\n  File \"/opt/stack/tempest/tempest/api/compute/servers/test_server_rescue.py\", line 177, in _test_stable_device_rescue\n    compute.wait_for_ssh_or_ping(\n  File \"/opt/stack/tempest/tempest/common/compute.py\", line 148, in wait_for_ssh_or_ping\n    waiters.wait_for_ssh(\n  File \"/opt/stack/tempest/tempest/common/waiters.py\", line 713, in wait_for_ssh\n    raise lib_exc.TimeoutException()\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: None\n\n```","commit_id":"7dfb15235e702468ce0314597b3ef7b67d8b5748"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d30e1f7ce142c5af65488f120fe1287c26b20f42","unresolved":true,"context_lines":[{"line_number":4750,"context_line":""},{"line_number":4751,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4752,"context_line":"        def _deny_share(context, instance, share_mapping):"},{"line_number":4753,"context_line":"            def notify(phase, exception\u003dNone):"},{"line_number":4754,"context_line":"                try:"},{"line_number":4755,"context_line":"                    share_mapping"},{"line_number":4756,"context_line":"                    share_id \u003d share_mapping.share_id"}],"source_content_type":"text/x-python","patch_set":40,"id":"87d557c0_b6cba4f3","line":4753,"updated":"2024-07-31 15:11:17.000000000","message":"please don\u0027t do this amount of nesting. It is really hard to follow what is visible to this nested function.","commit_id":"9340ff4b4ee8146af24f58747232231b95362264"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"c008bab6826f9dca198c6e5cd2381de9e5290193","unresolved":false,"context_lines":[{"line_number":4750,"context_line":""},{"line_number":4751,"context_line":"        @utils.synchronized(share_mapping.share_id)"},{"line_number":4752,"context_line":"        def _deny_share(context, instance, share_mapping):"},{"line_number":4753,"context_line":"            def notify(phase, exception\u003dNone):"},{"line_number":4754,"context_line":"                try:"},{"line_number":4755,"context_line":"                    share_mapping"},{"line_number":4756,"context_line":"                    share_id \u003d share_mapping.share_id"}],"source_content_type":"text/x-python","patch_set":40,"id":"e4a78dae_8c7e30e1","line":4753,"in_reply_to":"87d557c0_b6cba4f3","updated":"2024-09-17 06:43:26.000000000","message":"Done","commit_id":"9340ff4b4ee8146af24f58747232231b95362264"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"d30e1f7ce142c5af65488f120fe1287c26b20f42","unresolved":true,"context_lines":[{"line_number":4752,"context_line":"        def _deny_share(context, instance, share_mapping):"},{"line_number":4753,"context_line":"            def notify(phase, exception\u003dNone):"},{"line_number":4754,"context_line":"                try:"},{"line_number":4755,"context_line":"                    share_mapping"},{"line_number":4756,"context_line":"                    share_id \u003d share_mapping.share_id"},{"line_number":4757,"context_line":"                except NameError:"},{"line_number":4758,"context_line":"                    share_id \u003d None"}],"source_content_type":"text/x-python","patch_set":40,"id":"117c0a78_1c49ff06","line":4755,"updated":"2024-07-31 15:11:17.000000000","message":"why we have this seemingly noop step here?","commit_id":"9340ff4b4ee8146af24f58747232231b95362264"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"c008bab6826f9dca198c6e5cd2381de9e5290193","unresolved":false,"context_lines":[{"line_number":4752,"context_line":"        def _deny_share(context, instance, share_mapping):"},{"line_number":4753,"context_line":"            def notify(phase, exception\u003dNone):"},{"line_number":4754,"context_line":"                try:"},{"line_number":4755,"context_line":"                    share_mapping"},{"line_number":4756,"context_line":"                    share_id \u003d share_mapping.share_id"},{"line_number":4757,"context_line":"                except NameError:"},{"line_number":4758,"context_line":"                    share_id \u003d None"}],"source_content_type":"text/x-python","patch_set":40,"id":"cfa3ea58_0b934392","line":4755,"in_reply_to":"117c0a78_1c49ff06","updated":"2024-09-17 06:43:26.000000000","message":"Done","commit_id":"9340ff4b4ee8146af24f58747232231b95362264"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"971795e4ddaa6e25a5e66d7b6fd2a9675dd49cd5","unresolved":true,"context_lines":[{"line_number":4834,"context_line":"                LOG.error(e.format_message())"},{"line_number":4835,"context_line":"                raise"},{"line_number":4836,"context_line":"            finally:"},{"line_number":4837,"context_line":"                notify(fields.NotificationPhase.END)"},{"line_number":4838,"context_line":""},{"line_number":4839,"context_line":"        _deny_share(context, instance, share_mapping)"},{"line_number":4840,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"8d26474b_c13acc1f","line":4837,"updated":"2024-08-28 14:28:48.000000000","message":"same semantic issue than I commented on in the previous patch. We should not have end notification if we sent an error notifiction.","commit_id":"139622a09f1c22b86ccd58657804e11930ad4338"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"c008bab6826f9dca198c6e5cd2381de9e5290193","unresolved":false,"context_lines":[{"line_number":4834,"context_line":"                LOG.error(e.format_message())"},{"line_number":4835,"context_line":"                raise"},{"line_number":4836,"context_line":"            finally:"},{"line_number":4837,"context_line":"                notify(fields.NotificationPhase.END)"},{"line_number":4838,"context_line":""},{"line_number":4839,"context_line":"        _deny_share(context, instance, share_mapping)"},{"line_number":4840,"context_line":""}],"source_content_type":"text/x-python","patch_set":42,"id":"0a8ee4f8_19a0f8e8","line":4837,"in_reply_to":"8d26474b_c13acc1f","updated":"2024-09-17 06:43:26.000000000","message":"Done","commit_id":"139622a09f1c22b86ccd58657804e11930ad4338"}],"nova/tests/functional/notification_sample_tests/test_instance.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"c0f4b2b425b2d5c6c1c9d9507c074942d8571800","unresolved":true,"context_lines":[{"line_number":2002,"context_line":"            post \u003d {\u0027reboot\u0027: {\u0027type\u0027: \u0027HARD\u0027}}"},{"line_number":2003,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":2004,"context_line":"            self._wait_for_notification(\u0027instance.reboot.start\u0027)"},{"line_number":2005,"context_line":"            self._wait_for_notification(\u0027instance.reboot.end\u0027)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"    def _test_rescue_unrescue_server(self, server):"},{"line_number":2008,"context_line":"        # Both \"rescue\" and \"unrescue\" notification asserts are made here"}],"source_content_type":"text/x-python","patch_set":48,"id":"b2765023_cf920001","line":2005,"updated":"2024-11-05 13:57:59.000000000","message":"we missing the coverage for the detach.error case.","commit_id":"a2d96613ed6869591f71bdcea1f45f0cdee90476"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"34774c3150021032ac0edb7c847dc5d2292dd691","unresolved":false,"context_lines":[{"line_number":2002,"context_line":"            post \u003d {\u0027reboot\u0027: {\u0027type\u0027: \u0027HARD\u0027}}"},{"line_number":2003,"context_line":"            self.api.post_server_action(server[\u0027id\u0027], post)"},{"line_number":2004,"context_line":"            self._wait_for_notification(\u0027instance.reboot.start\u0027)"},{"line_number":2005,"context_line":"            self._wait_for_notification(\u0027instance.reboot.end\u0027)"},{"line_number":2006,"context_line":""},{"line_number":2007,"context_line":"    def _test_rescue_unrescue_server(self, server):"},{"line_number":2008,"context_line":"        # Both \"rescue\" and \"unrescue\" notification asserts are made here"}],"source_content_type":"text/x-python","patch_set":48,"id":"1d09bb7c_ed4821de","line":2005,"in_reply_to":"b2765023_cf920001","updated":"2024-11-19 11:07:17.000000000","message":"Test added","commit_id":"a2d96613ed6869591f71bdcea1f45f0cdee90476"}]}