)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"16ba71fcb087dc85287c920ab897ed879aadfca6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":37,"id":"e1b90045_d070ab16","updated":"2024-07-02 11:33:15.000000000","message":"still missing some test coverage.","commit_id":"4e15c13df45fc3bc78970b623dfdb51481005f0e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f8c8e245393263afb1f26c44451d2957a346fd57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"0e4939e0_16036bb5","updated":"2024-08-29 13:43:43.000000000","message":"btw I just tested locally rescue with attached share works and the rescue instance has access to the share.","commit_id":"dfafb1d6208e8afb6fb60e1ecdf39c7057a863bc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b63f3b5adc612ca19ea707e6cbc55f30fdeec895","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"ad278ae3_be827b59","updated":"2024-10-11 11:51:46.000000000","message":"Looks good.","commit_id":"176b1d8c569217d38157d14d50a2ab100e3f92d3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1e5a9f2ac9fb8b6681398a26290b72c2698db98a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"91e3d95e_0d5b05dc","updated":"2024-11-13 15:53:04.000000000","message":"I\u0027m cool with this patch even if this one is useless given we don\u0027t accept to suspend a instance with shares  \n```\nstack@sbauza-manila:~/devstack$ openstack server suspend vm1\nConflictException: 409: Client Error for url: http://10.0.79.108/compute/v2.1/servers/8031ca33-505b-41dd-8832-7d7ff1998266/action, Feature not supported with instances that have shares.\n```","commit_id":"0b4ab058872b26d4221df54eb5f41e035ce06759"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"fce2b556bc7980a4e6af58c7ea4dc844c54bee08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"ee062b66_fac3000a","in_reply_to":"91e3d95e_0d5b05dc","updated":"2024-11-18 18:01:36.000000000","message":"I discussed that with gibi and rené and we agreed on the fact we can still accept this patch even if suspend doesn\u0027t support it.","commit_id":"0b4ab058872b26d4221df54eb5f41e035ce06759"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"f4b4281a17c163c926e11e3d8ba8abfb0474f9e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"504c70fa_0ea65c80","updated":"2024-11-15 10:34:53.000000000","message":"Looks good.","commit_id":"f42cd826327ebf53e827c2d57f547f7dcae83063"},{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"900543f8433666b3d847e3d02d089fcc5e80c5db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"d5f40691_2ecd5aad","updated":"2024-11-14 04:53:07.000000000","message":"zuul -1 is bcz of one pep8 issue, otherwise LGTM.","commit_id":"f42cd826327ebf53e827c2d57f547f7dcae83063"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"eacdf4544bd02d15e78fb3d4c0842023a49d062a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"3936b4ba_e5332993","updated":"2024-11-28 08:53:33.000000000","message":"recheck\nvolume upload test failed with\n```\nDetails: {\u0027message\u0027: \u0027No image found with ID cb17050b-a5a9-4f12-87c2-351989168b23\u003cbr /\u003e\u003cbr /\u003e\\n\\n\\n\u0027, \u0027code\u0027: \u0027404 Not Found\u0027, \u0027title\u0027: \u0027Not Found\u0027}\n```","commit_id":"19bf42a582402ee072645a335f35c205eb5a021b"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"728d4b434c4e0282340273d2f2254f9cd9113444","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"1e3347b3_911453d7","updated":"2024-11-29 17:18:20.000000000","message":"recheck https://review.opendev.org/860286 is merged now.","commit_id":"19bf42a582402ee072645a335f35c205eb5a021b"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96cb6dcbef6900e642e18e066cdb45e40dee6b00","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":36,"id":"f91a1d4a_f3bf0e7a","updated":"2024-06-18 11:53:16.000000000","message":"I think to forgot to assert that mount_all is called.","commit_id":"6dcd456a6ffec6867189d10794e2e7eae387ed8e"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"599525a73a3e27867661cf2db0f6583556389e0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"46e1e4e8_d8c8bae3","in_reply_to":"c42b9e2c_89bf46ee","updated":"2024-09-23 16:13:15.000000000","message":"Done","commit_id":"6dcd456a6ffec6867189d10794e2e7eae387ed8e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"92b845e4d7c6a6564f4ee0d58964ba8f772ed836","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":36,"id":"c42b9e2c_89bf46ee","in_reply_to":"f91a1d4a_f3bf0e7a","updated":"2024-06-18 11:54:57.000000000","message":"or more like asserting that drive.mount_share called for all shares before driver.rescue","commit_id":"6dcd456a6ffec6867189d10794e2e7eae387ed8e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a1c69df3a44589f71719a3da7bc2ccf6d0f16fa2","unresolved":true,"context_lines":[{"line_number":2661,"context_line":"                                       mock.sentinel.block_device_info,"},{"line_number":2662,"context_line":"                                       share_info)"},{"line_number":2663,"context_line":"        self.compute.terminate_instance(self.context, instance, [])"},{"line_number":2664,"context_line":""},{"line_number":2665,"context_line":"    def test_power_on(self):"},{"line_number":2666,"context_line":"        # Ensure instance can be powered on."},{"line_number":2667,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"dbe9b400_92337123","line":2664,"updated":"2024-07-31 13:14:08.000000000","message":"here I\u0027d appreciate some negative testing, particularly if we can\u0027t mount the share","commit_id":"cb04085e094baaa670db73c3d7a0f73e9da8331c"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"599525a73a3e27867661cf2db0f6583556389e0d","unresolved":false,"context_lines":[{"line_number":2661,"context_line":"                                       mock.sentinel.block_device_info,"},{"line_number":2662,"context_line":"                                       share_info)"},{"line_number":2663,"context_line":"        self.compute.terminate_instance(self.context, instance, [])"},{"line_number":2664,"context_line":""},{"line_number":2665,"context_line":"    def test_power_on(self):"},{"line_number":2666,"context_line":"        # Ensure instance can be powered on."},{"line_number":2667,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"7e415987_cdb82b6d","line":2664,"in_reply_to":"dbe9b400_92337123","updated":"2024-09-23 16:13:15.000000000","message":"Done","commit_id":"cb04085e094baaa670db73c3d7a0f73e9da8331c"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"96cb6dcbef6900e642e18e066cdb45e40dee6b00","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":36,"id":"1755e4d2_43351284","updated":"2024-06-18 11:53:16.000000000","message":"I think you forgot to assert that mount_all is called.","commit_id":"6dcd456a6ffec6867189d10794e2e7eae387ed8e"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"599525a73a3e27867661cf2db0f6583556389e0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"ff11f5a1_73b3c815","in_reply_to":"065aa232_9c0afafb","updated":"2024-09-23 16:13:15.000000000","message":"Done","commit_id":"6dcd456a6ffec6867189d10794e2e7eae387ed8e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"92b845e4d7c6a6564f4ee0d58964ba8f772ed836","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":36,"id":"065aa232_9c0afafb","in_reply_to":"1755e4d2_43351284","updated":"2024-06-18 11:54:57.000000000","message":"or more like asserting that drive.mount_share called for all shares before driver.rescue","commit_id":"6dcd456a6ffec6867189d10794e2e7eae387ed8e"}],"nova/virt/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6973adc7e32149ea79915a8141b938a9f9f1763a","unresolved":true,"context_lines":[{"line_number":902,"context_line":"        raise NotImplementedError()"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"    def rescue(self, context, instance, network_info, image_meta,"},{"line_number":905,"context_line":"               rescue_password, block_device_info, share_info\u003dNone):"},{"line_number":906,"context_line":"        \"\"\"Rescue the specified instance."},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"        :param nova.context.RequestContext context:"}],"source_content_type":"text/x-python","patch_set":28,"id":"6918bf98_cce91d5e","line":905,"updated":"2024-02-28 13:28:23.000000000","message":"can we make the new param mandatory to catch case where we forgot to a pass this info in and therefore loosing shares?","commit_id":"f3721b7a4d6b4872b61efd045ef6e628500a9e2a"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"79102448dbf37a3804da86b1c3c931e75bac90a1","unresolved":false,"context_lines":[{"line_number":902,"context_line":"        raise NotImplementedError()"},{"line_number":903,"context_line":""},{"line_number":904,"context_line":"    def rescue(self, context, instance, network_info, image_meta,"},{"line_number":905,"context_line":"               rescue_password, block_device_info, share_info\u003dNone):"},{"line_number":906,"context_line":"        \"\"\"Rescue the specified instance."},{"line_number":907,"context_line":""},{"line_number":908,"context_line":"        :param nova.context.RequestContext context:"}],"source_content_type":"text/x-python","patch_set":28,"id":"f778a23c_e6cb75ab","line":905,"in_reply_to":"6918bf98_cce91d5e","updated":"2024-06-18 08:17:56.000000000","message":"Done","commit_id":"f3721b7a4d6b4872b61efd045ef6e628500a9e2a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"a1c69df3a44589f71719a3da7bc2ccf6d0f16fa2","unresolved":true,"context_lines":[{"line_number":913,"context_line":"        raise NotImplementedError()"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"    def rescue(self, context, instance, network_info, image_meta,"},{"line_number":916,"context_line":"               rescue_password, block_device_info, share_info):"},{"line_number":917,"context_line":"        \"\"\"Rescue the specified instance."},{"line_number":918,"context_line":""},{"line_number":919,"context_line":"        :param nova.context.RequestContext context:"}],"source_content_type":"text/x-python","patch_set":38,"id":"ab6949a2_0acd1ad6","line":916,"updated":"2024-07-31 13:14:08.000000000","message":"same point, we need to notify the 3rd party vendors by an email","commit_id":"cb04085e094baaa670db73c3d7a0f73e9da8331c"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"6973adc7e32149ea79915a8141b938a9f9f1763a","unresolved":true,"context_lines":[{"line_number":4346,"context_line":"        :param nova.objects.ShareMappingList share_info:"},{"line_number":4347,"context_line":"            optional list of share_mapping"},{"line_number":4348,"context_line":"        \"\"\""},{"line_number":4349,"context_line":"        if share_info is None:"},{"line_number":4350,"context_line":"            share_info \u003d objects.ShareMappingList()"},{"line_number":4351,"context_line":""},{"line_number":4352,"context_line":"        instance_dir \u003d libvirt_utils.get_instance_path(instance)"},{"line_number":4353,"context_line":"        unrescue_xml \u003d self._get_existing_domain_xml("}],"source_content_type":"text/x-python","patch_set":28,"id":"489e6027_71e6b1f0","line":4350,"range":{"start_line":4349,"start_character":0,"end_line":4350,"end_character":51},"updated":"2024-02-28 13:28:23.000000000","message":"this could be a potential bug if the instance has shares and we just forgot to pass in the param. I would make the param mandatory","commit_id":"f3721b7a4d6b4872b61efd045ef6e628500a9e2a"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"79102448dbf37a3804da86b1c3c931e75bac90a1","unresolved":false,"context_lines":[{"line_number":4346,"context_line":"        :param nova.objects.ShareMappingList share_info:"},{"line_number":4347,"context_line":"            optional list of share_mapping"},{"line_number":4348,"context_line":"        \"\"\""},{"line_number":4349,"context_line":"        if share_info is None:"},{"line_number":4350,"context_line":"            share_info \u003d objects.ShareMappingList()"},{"line_number":4351,"context_line":""},{"line_number":4352,"context_line":"        instance_dir \u003d libvirt_utils.get_instance_path(instance)"},{"line_number":4353,"context_line":"        unrescue_xml \u003d self._get_existing_domain_xml("}],"source_content_type":"text/x-python","patch_set":28,"id":"500199ba_acb6974f","line":4350,"range":{"start_line":4349,"start_character":0,"end_line":4350,"end_character":51},"in_reply_to":"489e6027_71e6b1f0","updated":"2024-06-18 08:17:56.000000000","message":"Done","commit_id":"f3721b7a4d6b4872b61efd045ef6e628500a9e2a"}]}