)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ac5d3361478d48e3233774ee14be7eab0bd2b659","unresolved":true,"context_lines":[{"line_number":4989,"context_line":"        block_device_info \u003d self._get_instance_block_device_info("},{"line_number":4990,"context_line":"                                context, instance, bdms\u003dbdms)"},{"line_number":4991,"context_line":""},{"line_number":4992,"context_line":"        share_info \u003d self._get_share_info(context, instance)"},{"line_number":4993,"context_line":""},{"line_number":4994,"context_line":"        extra_usage_info \u003d {\u0027rescue_image_name\u0027:"},{"line_number":4995,"context_line":"                            self._get_image_name(rescue_image_meta)}"}],"source_content_type":"text/x-python","patch_set":33,"id":"6e75ccd0_bfa1911a","line":4992,"updated":"2024-05-28 09:21:45.000000000","message":"this will only log share_mappings in ERROR state. And below we don\u0027t try to mount those again. So the question is can rescue be called on an instance with a share mapping in ERROR. Unfortunately the API ref does not state what instance state supports the rescue action. https://docs.openstack.org/api-ref/compute/#rescue-server-rescue-action\nBased on the code we might even allow rescuing an instance in ERROR state.","commit_id":"12ea82967cf04cd4054a128310880f621246e837"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"aac2aca64099c4e0c6281a58d87594e99d438016","unresolved":true,"context_lines":[{"line_number":4989,"context_line":"        block_device_info \u003d self._get_instance_block_device_info("},{"line_number":4990,"context_line":"                                context, instance, bdms\u003dbdms)"},{"line_number":4991,"context_line":""},{"line_number":4992,"context_line":"        share_info \u003d self._get_share_info(context, instance)"},{"line_number":4993,"context_line":""},{"line_number":4994,"context_line":"        extra_usage_info \u003d {\u0027rescue_image_name\u0027:"},{"line_number":4995,"context_line":"                            self._get_image_name(rescue_image_meta)}"}],"source_content_type":"text/x-python","patch_set":33,"id":"00049175_39c76cda","line":4992,"in_reply_to":"6e75ccd0_bfa1911a","updated":"2024-05-28 13:09:11.000000000","message":"We should try the remount and fail if we cannot mount the share. Also check if the driver has the mount call already.","commit_id":"12ea82967cf04cd4054a128310880f621246e837"}]}