)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"4e6b2677cfc9ae47402877263c2e5fedf0e7fe9c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alessio Ababilov \u003caababilov@griddynamics.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2012-06-15 18:34:20 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"repeat fusermount to avoid business"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix bug #1013689"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAIn%2F%2F%2B7A%3D","line":7,"updated":"2012-06-15 16:13:15.000000000","message":"You don\u0027t want to avoid business but busyness :)","commit_id":"37445b5b262ad134e79a4b4e2a6543e112fb1acb"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"cb5f1807707c503f8efc3af108dbf4c775be79b5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alessio Ababilov \u003caababilov@griddynamics.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2012-06-19 19:22:25 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"repeat fusermount to avoid business"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fix bug #1013689"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAI3%2F%2F%2F4g%3D","line":7,"updated":"2012-06-20 07:46:43.000000000","message":"How does this description map to the fact that this patch adds a sync call? (Which doesn\u0027t seem much like a mount to me).","commit_id":"1e6ea8481178ff5a8c73f57d1b6263e845d99a97"}],"nova/virt/disk/guestfs.py":[{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"4e6b2677cfc9ae47402877263c2e5fedf0e7fe9c","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            return"},{"line_number":91,"context_line":"        # root users don\u0027t need a specific unmnt_dev()"},{"line_number":92,"context_line":"        # but ordinary users do"},{"line_number":93,"context_line":"        utils.execute(\u0027fusermount\u0027, \u0027-u\u0027, self.mount_dir, run_as_root\u003dTrue, attempts\u003d4)"},{"line_number":94,"context_line":"        self.mounted \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAIn%2F%2F%2B68%3D","line":93,"updated":"2012-06-15 16:13:15.000000000","message":"How do we know 4 is always enough?","commit_id":"37445b5b262ad134e79a4b4e2a6543e112fb1acb"},{"author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"change_message_id":"9f8c321c35cd9175ef19f8f705da168a6d973dd9","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def unmnt_dev(self):"},{"line_number":89,"context_line":"        if not self.mounted:"},{"line_number":90,"context_line":"            return"},{"line_number":91,"context_line":"        utils.execute(\u0027sync\u0027)"},{"line_number":92,"context_line":"        # root users don\u0027t need a specific unmnt_dev()"},{"line_number":93,"context_line":"        # but ordinary users do"},{"line_number":94,"context_line":"        utils.execute(\u0027fusermount\u0027, \u0027-u\u0027, self.mount_dir, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAI3%2F%2F%2F3k%3D","line":91,"updated":"2012-06-20 08:48:40.000000000","message":"Previous comment from pbrady was \"...this is probably only changing the timing.\"\n https://review.openstack.org/#/c/8604/1/nova/virt/disk/guestfs.py,unified\nIt might appear to work, but it\u0027s not the right solution.","commit_id":"1e6ea8481178ff5a8c73f57d1b6263e845d99a97"},{"author":{"_account_id":1267,"name":"Alexei Ababilov","display_name":"Alexei Ababilov","email":"ilovegnulinux@gmail.com","username":"aababilov"},"change_message_id":"950ab276d942baec2fc70da91c987304b1b6952f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def unmnt_dev(self):"},{"line_number":89,"context_line":"        if not self.mounted:"},{"line_number":90,"context_line":"            return"},{"line_number":91,"context_line":"        utils.execute(\u0027sync\u0027)"},{"line_number":92,"context_line":"        # root users don\u0027t need a specific unmnt_dev()"},{"line_number":93,"context_line":"        # but ordinary users do"},{"line_number":94,"context_line":"        utils.execute(\u0027fusermount\u0027, \u0027-u\u0027, self.mount_dir, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAI3%2F%2F%2FF4%3D","line":91,"in_reply_to":"AAAAI3%2F%2F%2F3M%3D","updated":"2012-06-21 07:32:19.000000000","message":"Could you share your experience in reproducing and fixing this bug, please?\n\nFor us, attempts\u003d4 is not acceptable. On our machines (HP ProBooks and miscellaneous servers), very often, unmount is reported to be _successful_  during the _first_ attempt, but the filesystem remains _unsynchronized_ and authorized_keys are not updated, so, the VM is not accessible by ssh.\n\nThe same problem will be with sleeping for 4 seconds - the filesystem remains not synchronized.\n\nWhy are you against sync? It\u0027s innocent and it constantly fixes the bug.","commit_id":"1e6ea8481178ff5a8c73f57d1b6263e845d99a97"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"0aa1e705a20030e2f5cd54cb388aab6406876559","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def unmnt_dev(self):"},{"line_number":89,"context_line":"        if not self.mounted:"},{"line_number":90,"context_line":"            return"},{"line_number":91,"context_line":"        utils.execute(\u0027sync\u0027)"},{"line_number":92,"context_line":"        # root users don\u0027t need a specific unmnt_dev()"},{"line_number":93,"context_line":"        # but ordinary users do"},{"line_number":94,"context_line":"        utils.execute(\u0027fusermount\u0027, \u0027-u\u0027, self.mount_dir, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAI3%2F%2F%2F3M%3D","line":91,"in_reply_to":"AAAAI3%2F%2F%2F3k%3D","updated":"2012-06-20 08:53:34.000000000","message":"yes the attempts\u003d4 is probably better.\nI would probably bump up a bit to 6,7 ?\nHave we tested how successful these numbers are, and on what platform?\nAlso if we have a failure even after X attempts, we should still call another fusermount with the -z param added so that stale mounts are cleaned up at some stage.","commit_id":"1e6ea8481178ff5a8c73f57d1b6263e845d99a97"},{"author":{"_account_id":1914,"name":"rich-annexia","email":"rich@annexia.org","username":"rich-annexia"},"change_message_id":"b89eb42d4f77f39f1342e885408f91b3768cc085","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    def unmnt_dev(self):"},{"line_number":89,"context_line":"        if not self.mounted:"},{"line_number":90,"context_line":"            return"},{"line_number":91,"context_line":"        utils.execute(\u0027sync\u0027)"},{"line_number":92,"context_line":"        # root users don\u0027t need a specific unmnt_dev()"},{"line_number":93,"context_line":"        # but ordinary users do"},{"line_number":94,"context_line":"        utils.execute(\u0027fusermount\u0027, \u0027-u\u0027, self.mount_dir, run_as_root\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAJX%2F%2F%2FgM%3D","line":91,"updated":"2012-06-29 08:59:36.000000000","message":"There\u0027s no analysis at all of what the bug is that this is supposed to fix.  \"sync\" *cannot* fix the bug as reported, while it will have a large negative performance impact on nodes.  It\u0027s a very poor decision to include this change, without even the basics of proper bug analysis having been attempted.","commit_id":"d28104350e0f3db191d0b6b1222f795a6026a842"}]}