)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1754a10be779b091058a491a601a4d48c7802440","unresolved":true,"context_lines":[{"line_number":10,"context_line":"lead to a \u0027False\u0027 result. These branches are:"},{"line_number":11,"context_line":"\t- Physnet found affinity on a NUMA cell outside the chosen ones."},{"line_number":12,"context_line":"\t- Tunneled networks found affinity on a NUMA cell outside the"},{"line_number":13,"context_line":"\t  chosen ones."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: #1751784"},{"line_number":16,"context_line":"Resolves: rhbz#2107306"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"975b2410_01d81fca","line":13,"updated":"2023-05-11 15:03:57.000000000","message":"nit: tabs shoudl be avoided but it does not really hurt here\ntabs shoudl be converted to 4 spaces to follow pythons style\nguidlines.","commit_id":"07d6a4c185e73ef2b7a0e79d61888926b1daafa2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1754a10be779b091058a491a601a4d48c7802440","unresolved":true,"context_lines":[{"line_number":13,"context_line":"\t  chosen ones."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Partial-Bug: #1751784"},{"line_number":16,"context_line":"Resolves: rhbz#2107306"},{"line_number":17,"context_line":"Change-Id: I4d45f383b3c4794f8a114047455efb764f60f2a2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"593bd1f3_c9cf4d3f","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":22},"updated":"2023-05-11 15:03:57.000000000","message":"downstream bug tracker should not be in the commit message","commit_id":"07d6a4c185e73ef2b7a0e79d61888926b1daafa2"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"f0901c3a880fd85c43c79ccfecce9f9b6112a63f","unresolved":true,"context_lines":[{"line_number":12,"context_line":"\t- Tunneled networks found affinity on a NUMA cell outside the"},{"line_number":13,"context_line":"          chosen ones."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"note(camorris): Fixed commit message and made log.DEBUG not repeat"},{"line_number":16,"context_line":"                itself. Fixed tox error and network_metadata.tunneled"},{"line_number":17,"context_line":"                debug logs and tox again"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"83ba467f_dad8bb29","line":15,"updated":"2023-05-19 15:15:20.000000000","message":"You don\u0027t need to \"log\" your changes in the commit message, the commit message should be about the change itself, not the review process. Review comments in Gerrit are best used for the latter.","commit_id":"8556e1548f68869ed722f3fe1ce76a422a03c9cd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e27f133dbe0d3db7eed7ce377633652b1763f5a7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"85f6c264_011a5fd0","line":21,"updated":"2023-05-18 23:09:25.000000000","message":"you could add \n\"Co-Authored-By: Carl \u003ccamorris@redhat.com\u003e\"\n\nif you like.","commit_id":"8556e1548f68869ed722f3fe1ce76a422a03c9cd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"c2fa47a50d96114684ea55a7278c586a01eb2f19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"623a9d46_b25c4079","updated":"2022-10-11 14:33:14.000000000","message":"recheck","commit_id":"07d6a4c185e73ef2b7a0e79d61888926b1daafa2"},{"author":{"_account_id":34443,"name":"Jorge San Emeterio","display_name":"jsanemet","email":"jsanemet@redhat.com","username":"jsanemet"},"change_message_id":"6212fb093637f487e38d85c3702e8de815f42f0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"72c0abb8_3862354f","updated":"2022-10-13 07:59:34.000000000","message":"recheck","commit_id":"07d6a4c185e73ef2b7a0e79d61888926b1daafa2"},{"author":{"_account_id":35186,"name":"Carl Morris","display_name":"Carloutte","email":"carlmorris84@gmail.com","username":"carloutte"},"change_message_id":"32442e2ef15752b8537f9ccf88a7035338e4247b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"539cd1ca_69549bb5","updated":"2023-05-17 14:09:50.000000000","message":"recheck fixed tox error","commit_id":"40b879888ebf7c6685c6e0d94b7d5665f0dc9316"},{"author":{"_account_id":35186,"name":"Carl Morris","display_name":"Carloutte","email":"carlmorris84@gmail.com","username":"carloutte"},"change_message_id":"78f23fa5fcbe2e79bbb29f68986ec492b12949c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"755d3227_36fbff6e","updated":"2023-05-17 14:17:19.000000000","message":"recheck","commit_id":"685dbf60741ed80458f94738f57082c08f7ce293"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8a78cba19a95bcfd0f74e78b18f877cd4502e530","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5e727575_a9d53012","updated":"2023-10-18 15:27:55.000000000","message":"It\u0027s a bummer to not see any tests along with this to *ensure* that we\u0027re hitting these new lines of code and that they work. That said, coverage says we are hitting them, so I guess this is okay at least in current form.","commit_id":"1915a3122a1df1f0dbe5edbaf25919f8875733af"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"439297c279c0a5e360ea745b6b6ad320f6387747","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a8ab1812_5993fb79","updated":"2023-09-12 09:24:18.000000000","message":"comments are addressed, \nwas not sure how to test, so logs can be seen in compute logs, so tested for tests: NetworkRequestSupportTestCase\nbelow worked and confirm added logs.\n```\ntest_missing_networks\ntest_physnet_networks\ntest_tunnel_network\ntest_multiple_networks -\u003e confirms all added logs\n```\nlgtm","commit_id":"1915a3122a1df1f0dbe5edbaf25919f8875733af"},{"author":{"_account_id":35186,"name":"Carl Morris","display_name":"Carloutte","email":"carlmorris84@gmail.com","username":"carloutte"},"change_message_id":"d9b4f3eccb749746a538dbdbebef07f4922da16d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3378f79b_3bf7bd7b","updated":"2023-07-19 15:05:04.000000000","message":"recheck","commit_id":"1915a3122a1df1f0dbe5edbaf25919f8875733af"},{"author":{"_account_id":35186,"name":"Carl Morris","display_name":"Carloutte","email":"carlmorris84@gmail.com","username":"carloutte"},"change_message_id":"c1be9bfc55c9896f64e759f17dec681c63df71b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a5a90861_8d8eea3d","updated":"2023-08-14 18:03:10.000000000","message":"recheck","commit_id":"1915a3122a1df1f0dbe5edbaf25919f8875733af"},{"author":{"_account_id":35186,"name":"Carl Morris","display_name":"Carloutte","email":"carlmorris84@gmail.com","username":"carloutte"},"change_message_id":"dd135eac08eec4de69929d9506db617d75397a78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ce015343_a82b3bb4","updated":"2023-08-28 16:10:07.000000000","message":"recheck\n\nFailed on the zuul being unable to connect to test machine:  paramiko.ssh_exception.NoValidConnectionsError: [Errno None] Unable to connect to port 22 on 172.24.5.251","commit_id":"1915a3122a1df1f0dbe5edbaf25919f8875733af"},{"author":{"_account_id":35186,"name":"Carl Morris","display_name":"Carloutte","email":"carlmorris84@gmail.com","username":"carloutte"},"change_message_id":"0fedc38aae7673345cf2f256f0bc5b4475d77629","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f16bfe7b_afb10962","updated":"2023-07-19 19:57:42.000000000","message":"recheck\nnot sure why \"curl -O https://raw.githubusercontent.com/ceph/ceph/quincy/src/cephadm/cephadm\" failed, it works on my laptop","commit_id":"1915a3122a1df1f0dbe5edbaf25919f8875733af"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4e7835c20bdb07721b4a799074aaf5056059c9fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d6203882_89d97e45","updated":"2023-10-18 19:02:07.000000000","message":"this has been here for a while and im currently trying to debug somethign that this will be very useful for so +2w","commit_id":"1915a3122a1df1f0dbe5edbaf25919f8875733af"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"2508f58f39c19321a6c568eceff4e59d3ad0d757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0e63d43a_8f10ced1","in_reply_to":"f16bfe7b_afb10962","updated":"2023-07-19 20:27:33.000000000","message":"Looks like this is being worked on here:\n\nhttps://review.opendev.org/c/openstack/devstack-plugin-ceph/+/888952","commit_id":"1915a3122a1df1f0dbe5edbaf25919f8875733af"}],"nova/virt/hardware.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1754a10be779b091058a491a601a4d48c7802440","unresolved":true,"context_lines":[{"line_number":2254,"context_line":"            required_physnets -\u003d required_physnets.intersection("},{"line_number":2255,"context_line":"                host_cell.network_metadata.physnets)"},{"line_number":2256,"context_line":""},{"line_number":2257,"context_line":"            if required_physnets:"},{"line_number":2258,"context_line":"                LOG.debug(\u0027Not all requested physnets have affinity to one \u0027"},{"line_number":2259,"context_line":"                          \u0027of the chosen host NUMA cells. Remaining physnets \u0027"},{"line_number":2260,"context_line":"                          \u0027are: %(physnets)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a5c9eb0_f7f9c623","line":2257,"updated":"2023-05-11 15:03:57.000000000","message":"i dont think we want to print this on every iteration of the for\n\nthat will be a bit noicy so can we dedent this and only print it once\n\nthe log message will need to be updated slightly as we wont know if we remove thing but i guess you coudl do soemthign liek this\n\n\n        removed_phsynets \u003d False\n        # chosen host NUMA cells\n        for host_cell in chosen_host_cells:\n            if \u0027network_metadata\u0027 not in host_cell:\n                continue\n            # if one of these cells provides affinity for one or more physnets,\n            # drop said physnet(s) from the list we\u0027re searching for\n            required_physnets -\u003d required_physnets.intersection(\n                host_cell.network_metadata.physnets)\n            removed_phsynets \u003d True\n         if required_physnets and removed_phsynets:\n             LOG.debug(\n                 \u0027Not all requested physnets have affinity to one \u0027\n                 \u0027of the chosen host NUMA cells. Remaining physnets \u0027\n                 \u0027are: %(physnets)s.\u0027,\n                 {\u0027physnets\u0027: required_physnets}\n             )","commit_id":"07d6a4c185e73ef2b7a0e79d61888926b1daafa2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1754a10be779b091058a491a601a4d48c7802440","unresolved":true,"context_lines":[{"line_number":2272,"context_line":"            # we need to fail because we should be using that node and are not"},{"line_number":2273,"context_line":"            if required_physnets.intersection("},{"line_number":2274,"context_line":"                    host_cell.network_metadata.physnets):"},{"line_number":2275,"context_line":"                LOG.debug(\u0027A physnet is having affinity to a NUMA cell \u0027"},{"line_number":2276,"context_line":"                          \u0027outside the chosen host cells. These are \u0027"},{"line_number":2277,"context_line":"                          \u0027considered to not support the network then.\u0027)"},{"line_number":2278,"context_line":"                return False"},{"line_number":2279,"context_line":""},{"line_number":2280,"context_line":"    if required_tunnel:"}],"source_content_type":"text/x-python","patch_set":2,"id":"8183c1a0_83a30740","line":2277,"range":{"start_line":2275,"start_character":26,"end_line":2277,"end_character":71},"updated":"2023-05-11 15:03:57.000000000","message":"\u0027A physnet is requires affinity to a NUMA cell \u0027\n\u0027outside the  host cells.\u0027\nThe cell i These are \u0027\n\u0027considered to not support the network then.\u0027","commit_id":"07d6a4c185e73ef2b7a0e79d61888926b1daafa2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"943932c86e5ea971c07326a1d85878b9740add4a","unresolved":true,"context_lines":[{"line_number":2272,"context_line":"            # we need to fail because we should be using that node and are not"},{"line_number":2273,"context_line":"            if required_physnets.intersection("},{"line_number":2274,"context_line":"                    host_cell.network_metadata.physnets):"},{"line_number":2275,"context_line":"                LOG.debug(\u0027A physnet is having affinity to a NUMA cell \u0027"},{"line_number":2276,"context_line":"                          \u0027outside the chosen host cells. These are \u0027"},{"line_number":2277,"context_line":"                          \u0027considered to not support the network then.\u0027)"},{"line_number":2278,"context_line":"                return False"},{"line_number":2279,"context_line":""},{"line_number":2280,"context_line":"    if required_tunnel:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3cb3d2a5_0ceb3a1a","line":2277,"range":{"start_line":2275,"start_character":26,"end_line":2277,"end_character":71},"in_reply_to":"8183c1a0_83a30740","updated":"2023-05-16 21:34:41.000000000","message":"i did not update the seccond sentance properly\n\n\u0027A physnet requires affinity to a NUMA cell \u0027\n\u0027outside this host cells.\u0027\n\u0027This host cell cannot satify network requests for that phsynet.\u0027","commit_id":"07d6a4c185e73ef2b7a0e79d61888926b1daafa2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"1754a10be779b091058a491a601a4d48c7802440","unresolved":true,"context_lines":[{"line_number":2299,"context_line":"                continue"},{"line_number":2300,"context_line":""},{"line_number":2301,"context_line":"            if host_cell.network_metadata.tunneled:"},{"line_number":2302,"context_line":"                LOG.debug(\u0027Tunneled networks are having affinity to a NUMA \u0027"},{"line_number":2303,"context_line":"                          \u0027cell outside the chosen host cells. These are \u0027"},{"line_number":2304,"context_line":"                          \u0027considered to not support the network then.\u0027)"},{"line_number":2305,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"46d5b6c2_1d5ea4fa","line":2302,"updated":"2023-05-11 15:03:57.000000000","message":"same with this we probably want to just print this once out side the loop.","commit_id":"07d6a4c185e73ef2b7a0e79d61888926b1daafa2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"943932c86e5ea971c07326a1d85878b9740add4a","unresolved":true,"context_lines":[{"line_number":2299,"context_line":"                continue"},{"line_number":2300,"context_line":""},{"line_number":2301,"context_line":"            if host_cell.network_metadata.tunneled:"},{"line_number":2302,"context_line":"                LOG.debug(\u0027Tunneled networks are having affinity to a NUMA \u0027"},{"line_number":2303,"context_line":"                          \u0027cell outside the chosen host cells. These are \u0027"},{"line_number":2304,"context_line":"                          \u0027considered to not support the network then.\u0027)"},{"line_number":2305,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"a584a322_ac8bbedb","line":2302,"in_reply_to":"46d5b6c2_1d5ea4fa","updated":"2023-05-16 21:34:41.000000000","message":"ignore this \n\nas mentioned on Slack while this is in a loop if this prints we then return False so this will only print once for a given host\n\nthe wording is still not good however\n\n\"The host declares numa affinity for tunnled networks. the current instance\nrequest a tunnelled network but this host cell is out of the set declared to be local\nto the tunnel network endpoint. As such this host cell cannot support the requested tunneled network.\"","commit_id":"07d6a4c185e73ef2b7a0e79d61888926b1daafa2"}]}