)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"f3a080fc8a0738bf9fd6b30090ed6d542a4f7d8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9c3823ce_86ce3b7e","updated":"2022-10-18 14:18:14.000000000","message":"recheck sqlite3.OperationalError: no such savepoint: sa_savepoint_1","commit_id":"11aedb93cd2f036399f1dca89bdf744c59e120f0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"01e9e4c04720fbbe44f61512c807b4952cee839f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e41461b1_b82115cf","updated":"2023-01-19 12:57:06.000000000","message":"i think this is fine the -1 is because we might want an api sample test for this?\n","commit_id":"7eb0b946b834abeb6753fca43c5a78ca5b40e83b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ccc6a8837588513952781d3711ab58625879af95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"56e19969_8b33bcae","in_reply_to":"e41461b1_b82115cf","updated":"2023-01-24 11:34:54.000000000","message":"if others are fine with the test coverage then we can proceed as is.\n409 conflict is the correct error code and its already somethign this api can return so there is no issues where with api compatiblity","commit_id":"7eb0b946b834abeb6753fca43c5a78ca5b40e83b"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e9aed9f0cdb4b8889ab19c996d7819e4e1fcaef3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75e9237d_520b4546","updated":"2023-01-26 09:50:01.000000000","message":"Looks good.Thank you!","commit_id":"ec40d5aee34e9428e2a19231fc3df4d23d75b779"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ccc6a8837588513952781d3711ab58625879af95","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5cc0baa9_5072a7f8","updated":"2023-01-24 11:34:54.000000000","message":"this is really a +1.5 but im rounding up.\n\nwe try to avoid mock in functional tests they way you have mock the state but its one of the cleaner ways to do that.\n\nso if others are ok with it then they can proceed with this.","commit_id":"ec40d5aee34e9428e2a19231fc3df4d23d75b779"}],"nova/tests/functional/api_sample_tests/test_remote_consoles.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ccc6a8837588513952781d3711ab58625879af95","unresolved":true,"context_lines":[{"line_number":43,"context_line":"                              response, 200)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @mock.patch.object(compute.API, \u0027get_vnc_console\u0027)"},{"line_number":46,"context_line":"    def test_get_vnc_console_instance_invalid_state(self,"},{"line_number":47,"context_line":"                                                    mock_get_vnc_console):"},{"line_number":48,"context_line":"        uuid \u003d self._post_server()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def fake_get_vnc_console(*args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fe2b95a7_d09fc90a","line":47,"range":{"start_line":46,"start_character":0,"end_line":47,"end_character":74},"updated":"2023-01-24 11:34:54.000000000","message":"nit: this should be\n\n    def test_get_vnc_console_instance_invalid_state(\n        self, mock_get_vnc_console\n    ):\n        \nwe are trying to convert all code to that style over time.","commit_id":"ec40d5aee34e9428e2a19231fc3df4d23d75b779"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ccc6a8837588513952781d3711ab58625879af95","unresolved":true,"context_lines":[{"line_number":47,"context_line":"                                                    mock_get_vnc_console):"},{"line_number":48,"context_line":"        uuid \u003d self._post_server()"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        def fake_get_vnc_console(*args, **kwargs):"},{"line_number":51,"context_line":"            raise exception.InstanceInvalidState("},{"line_number":52,"context_line":"                attr\u003d\u0027fake_attr\u0027, state\u003d\u0027fake_state\u0027, method\u003d\u0027fake_method\u0027,"},{"line_number":53,"context_line":"                instance_uuid\u003duuid)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        mock_get_vnc_console.side_effect \u003d fake_get_vnc_console"},{"line_number":56,"context_line":"        response \u003d self._do_post(\u0027servers/%s/action\u0027 % uuid,"}],"source_content_type":"text/x-python","patch_set":6,"id":"a3baa465_2a8ee185","line":53,"range":{"start_line":50,"start_character":7,"end_line":53,"end_character":35},"updated":"2023-01-24 11:34:54.000000000","message":"functional test shoudl not use mocks like this\n\ni guess we dont have a good way to put it in the migrating or deleting state without having a race condition so i guess this will do.\n\nthe way to do that in a functional test is via creatign locks but i htink we can leave this as is.\nlets see whtat others think","commit_id":"ec40d5aee34e9428e2a19231fc3df4d23d75b779"}]}