)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4d454a9e5f064896ddf1a120bfd91b195d039785","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e2d0ca1_b635722c","line":10,"updated":"2022-10-29 15:29:43.000000000","message":"Closes-Bug: 1993736","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"709dedb838ad76d280caa9a651941d8b46be99c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"96430a38_92fdcfcd","line":10,"in_reply_to":"5da8c8d9_d2921cb3","updated":"2022-11-03 13:05:52.000000000","message":"they are suggesting you add that line\n\nby convention we add Closes-Bug to the commit message so that our automation will update launchpad when the commit merges\n\ngerrit will also trun it into a hyperlink in the ui so you can click on it and go directly to the bug","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"},{"author":{"_account_id":35421,"name":"Alex Chan","email":"alexchanwork20@gmail.com","username":"alexc20"},"change_message_id":"1b49febeba7e6f73f006ecf6cc2f78e50d5c9eb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5da8c8d9_d2921cb3","line":10,"in_reply_to":"8e2d0ca1_b635722c","updated":"2022-10-31 12:35:07.000000000","message":"Yes, this patchset is exactly meant to fix that bug.","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d2f0de89aebc4482896ec7163c2a3fbab51eb718","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"record action log when deleting shelved instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug link: https://bugs.launchpad.net/nova/+bug/1993736"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9ce18cbba5083c55d15d9b7c2a89133d227754ea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2665c005_d3b3a984","line":9,"updated":"2022-11-03 15:17:45.000000000","message":"This isn\u0027t right, it should be as provided:\n\n Closes-Bug: 1993736","commit_id":"6e0fb6194c6c4024c76656f09816402850b71548"},{"author":{"_account_id":35421,"name":"Alex Chan","email":"alexchanwork20@gmail.com","username":"alexc20"},"change_message_id":"f1777e105944835438f78d46f2ad69e9e5b0f3b7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"record action log when deleting shelved instance"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Bug link: https://bugs.launchpad.net/nova/+bug/1993736"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I9ce18cbba5083c55d15d9b7c2a89133d227754ea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"86a0ea59_0093a3eb","line":9,"in_reply_to":"2665c005_d3b3a984","updated":"2022-11-03 18:20:27.000000000","message":"Done","commit_id":"6e0fb6194c6c4024c76656f09816402850b71548"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31746,"name":"Oleksandr Kozachenko","email":"okozachenko1203@gmail.com","username":"okozachenko"},"change_message_id":"74045c300c82b4eb5138a90e297b434d6e24b5a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"974fbc90_cf86bf42","updated":"2022-10-22 15:50:42.000000000","message":"recheck","commit_id":"aaf82370a79dde4f0ca662f8a02987cff45eef42"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"9f1f85b81f2aed4b65b99725dd53d3cac51c92c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"25280b03_662d7858","updated":"2022-10-27 12:43:32.000000000","message":"this looks like it shoudl work but its missing test coverage to assert that the log is not recorded. can you extend or copy one of the server delete functional tests and just assert the instance action log now has the deleted event","commit_id":"aaf82370a79dde4f0ca662f8a02987cff45eef42"},{"author":{"_account_id":35421,"name":"Alex Chan","email":"alexchanwork20@gmail.com","username":"alexc20"},"change_message_id":"543db97c41f2c7b14e1b97430eee7f48b3441584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f53513a8_5ef5a536","in_reply_to":"25280b03_662d7858","updated":"2022-10-28 17:53:39.000000000","message":"I have added functional tests for deleting shelved instance.","commit_id":"aaf82370a79dde4f0ca662f8a02987cff45eef42"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"46b76835e30a2696f104ff2e7af24e988e6d4aab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e3ca6049_b778dedd","updated":"2022-10-28 17:32:43.000000000","message":"by the way this technically should have a but referenced in the commit and it would be nice to have a release note but if you add them im happy to review.","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"},{"author":{"_account_id":35421,"name":"Alex Chan","email":"alexchanwork20@gmail.com","username":"alexc20"},"change_message_id":"543db97c41f2c7b14e1b97430eee7f48b3441584","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe9e0f45_d20450fa","updated":"2022-10-28 17:53:39.000000000","message":"thank you!","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"},{"author":{"_account_id":35421,"name":"Alex Chan","email":"alexchanwork20@gmail.com","username":"alexc20"},"change_message_id":"3b7fa648012987b8ef6d2ca28f1b7df4a3e95d15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"515bbae7_308d1597","in_reply_to":"e3ca6049_b778dedd","updated":"2022-10-28 18:45:31.000000000","message":"This patchset fixes the shelved instance delete action log issue that is reported at https://bugs.launchpad.net/nova/+bug/1993736.","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3f27dfc643638015fb5a85ae9ec1b3c6fc5b5bdc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c753b5ee_d358ff42","updated":"2022-11-03 20:56:29.000000000","message":"Sean was +2 on this before I asked for a couple more assertions, so I\u0027m proxying an extra +2 on here. I\u0027ll let zuul keep Alex honest that the new assertion works.\n\nThanks for your patience!","commit_id":"c97507dfcd57cce9d76670d3b0d48538900c00e9"}],"nova/compute/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ad6f6c5529964eebd93f2a485153d44415cb0f4a","unresolved":true,"context_lines":[{"line_number":2547,"context_line":"                          instance\u003dinstance)"},{"line_number":2548,"context_line":"                with nova_context.target_cell(context, cell) as cctxt:"},{"line_number":2549,"context_line":"                    self._local_delete(cctxt, instance, bdms, delete_type, cb)"},{"line_number":2550,"context_line":"                    self._record_action_start(context, instance,"},{"line_number":2551,"context_line":"                                              instance_actions.DELETE)"},{"line_number":2552,"context_line":""},{"line_number":2553,"context_line":"        except exception.InstanceNotFound:"},{"line_number":2554,"context_line":"            # NOTE(comstud): Race condition. Instance already gone."}],"source_content_type":"text/x-python","patch_set":1,"id":"7980dd0c_50c4261a","line":2551,"range":{"start_line":2550,"start_character":20,"end_line":2551,"end_character":70},"updated":"2022-10-27 12:40:51.000000000","message":"nit: this shoudl be\n\n                    self._record_action_start(\n                        context, instance, instance_actions.DELETE\n                    )\n                    \nor \n                   \n                   self._record_action_start(\n                        context, instance, instance_actions.DELETE)","commit_id":"aaf82370a79dde4f0ca662f8a02987cff45eef42"},{"author":{"_account_id":35421,"name":"Alex Chan","email":"alexchanwork20@gmail.com","username":"alexc20"},"change_message_id":"543db97c41f2c7b14e1b97430eee7f48b3441584","unresolved":false,"context_lines":[{"line_number":2547,"context_line":"                          instance\u003dinstance)"},{"line_number":2548,"context_line":"                with nova_context.target_cell(context, cell) as cctxt:"},{"line_number":2549,"context_line":"                    self._local_delete(cctxt, instance, bdms, delete_type, cb)"},{"line_number":2550,"context_line":"                    self._record_action_start(context, instance,"},{"line_number":2551,"context_line":"                                              instance_actions.DELETE)"},{"line_number":2552,"context_line":""},{"line_number":2553,"context_line":"        except exception.InstanceNotFound:"},{"line_number":2554,"context_line":"            # NOTE(comstud): Race condition. Instance already gone."}],"source_content_type":"text/x-python","patch_set":1,"id":"13712dee_9ec7cfac","line":2551,"range":{"start_line":2550,"start_character":20,"end_line":2551,"end_character":70},"in_reply_to":"7980dd0c_50c4261a","updated":"2022-10-28 17:53:39.000000000","message":"Ack","commit_id":"aaf82370a79dde4f0ca662f8a02987cff45eef42"}],"nova/tests/functional/test_instance_actions.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8eedabca6c576a11fb74e1ce64b542bc137b9c97","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        self.assertEqual(\u0027delete\u0027, actions[0][\u0027action\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(\u0027shelve\u0027, actions[1][\u0027action\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027create\u0027, actions[2][\u0027action\u0027])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class HypervisorError(Exception):"},{"line_number":73,"context_line":"    \"\"\"This is just used to make sure the exception type is in the events.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"966d9911_e5158f4d","line":70,"updated":"2022-10-28 17:29:57.000000000","message":"thanks for adding this","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"},{"author":{"_account_id":35421,"name":"Alex Chan","email":"alexchanwork20@gmail.com","username":"alexc20"},"change_message_id":"543db97c41f2c7b14e1b97430eee7f48b3441584","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertEqual(\u0027delete\u0027, actions[0][\u0027action\u0027])"},{"line_number":68,"context_line":"        self.assertEqual(\u0027shelve\u0027, actions[1][\u0027action\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027create\u0027, actions[2][\u0027action\u0027])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"class HypervisorError(Exception):"},{"line_number":73,"context_line":"    \"\"\"This is just used to make sure the exception type is in the events.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"87644ba3_7ad622aa","line":70,"in_reply_to":"966d9911_e5158f4d","updated":"2022-10-28 17:53:39.000000000","message":"Ack","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"}],"nova/tests/unit/compute/test_api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"74cf37a1ea13f27dfa89b92db3797f04fea9f72f","unresolved":true,"context_lines":[{"line_number":1257,"context_line":"    @mock.patch(\u0027nova.compute.api.API._record_action_start\u0027)"},{"line_number":1258,"context_line":"    @mock.patch(\u0027nova.compute.api.API._local_delete\u0027)"},{"line_number":1259,"context_line":"    def test_delete_error_state_with_no_host("},{"line_number":1260,"context_line":"            self, mock_local_delete, mock_record, mock_service_get,"},{"line_number":1261,"context_line":"            _mock_notify, _mock_save, mock_bdm_get, mock_lookup,"},{"line_number":1262,"context_line":"            _mock_del_booting):"},{"line_number":1263,"context_line":"        # Instance in error state with no host should be a local delete"}],"source_content_type":"text/x-python","patch_set":2,"id":"35499b05_07bc66ee","line":1260,"range":{"start_line":1260,"start_character":37,"end_line":1260,"end_character":48},"updated":"2022-11-03 13:48:09.000000000","message":"Can you assert that this gets called? If it\u0027s mocked, you might as well. Same below.","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"},{"author":{"_account_id":35421,"name":"Alex Chan","email":"alexchanwork20@gmail.com","username":"alexc20"},"change_message_id":"f1777e105944835438f78d46f2ad69e9e5b0f3b7","unresolved":false,"context_lines":[{"line_number":1257,"context_line":"    @mock.patch(\u0027nova.compute.api.API._record_action_start\u0027)"},{"line_number":1258,"context_line":"    @mock.patch(\u0027nova.compute.api.API._local_delete\u0027)"},{"line_number":1259,"context_line":"    def test_delete_error_state_with_no_host("},{"line_number":1260,"context_line":"            self, mock_local_delete, mock_record, mock_service_get,"},{"line_number":1261,"context_line":"            _mock_notify, _mock_save, mock_bdm_get, mock_lookup,"},{"line_number":1262,"context_line":"            _mock_del_booting):"},{"line_number":1263,"context_line":"        # Instance in error state with no host should be a local delete"}],"source_content_type":"text/x-python","patch_set":2,"id":"a3c4344a_8f737707","line":1260,"range":{"start_line":1260,"start_character":37,"end_line":1260,"end_character":48},"in_reply_to":"35499b05_07bc66ee","updated":"2022-11-03 18:20:27.000000000","message":"Done","commit_id":"5ac4a90fed3a6e39dc67467e284d3c8f33ce4f6e"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0edfd9e73fe77c50cf56a4b0bd709cb68c316d12","unresolved":true,"context_lines":[{"line_number":1270,"context_line":"            self.compute_api.delete(self.context, inst)"},{"line_number":1271,"context_line":"            mock_local_delete.assert_called_once_with("},{"line_number":1272,"context_line":"                    self.context, inst, mock_bdm_get.return_value,"},{"line_number":1273,"context_line":"                    \u0027delete\u0027, self.compute_api._do_delete)"},{"line_number":1274,"context_line":"            mock_terminate.assert_not_called()"},{"line_number":1275,"context_line":"        mock_service_get.assert_not_called()"},{"line_number":1276,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b53925f4_a1e115af","line":1273,"updated":"2022-11-03 16:09:43.000000000","message":"dan ment add something like \n\nmock_record.assert_called_once_with(self.context, inst.uuid)\n\nor \n\nmock_record.assert_called_once()","commit_id":"6e0fb6194c6c4024c76656f09816402850b71548"},{"author":{"_account_id":35421,"name":"Alex Chan","email":"alexchanwork20@gmail.com","username":"alexc20"},"change_message_id":"f1777e105944835438f78d46f2ad69e9e5b0f3b7","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"            self.compute_api.delete(self.context, inst)"},{"line_number":1271,"context_line":"            mock_local_delete.assert_called_once_with("},{"line_number":1272,"context_line":"                    self.context, inst, mock_bdm_get.return_value,"},{"line_number":1273,"context_line":"                    \u0027delete\u0027, self.compute_api._do_delete)"},{"line_number":1274,"context_line":"            mock_terminate.assert_not_called()"},{"line_number":1275,"context_line":"        mock_service_get.assert_not_called()"},{"line_number":1276,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"09bd3b2b_1afc54d0","line":1273,"in_reply_to":"b53925f4_a1e115af","updated":"2022-11-03 18:20:27.000000000","message":"Done","commit_id":"6e0fb6194c6c4024c76656f09816402850b71548"}]}