)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5c689e7c578270276c7e0a706c99a66d5581e243","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3bfee391_1de527dd","updated":"2022-12-13 10:37:00.000000000","message":"Hey Artom, a couple of small comments","commit_id":"223e94902f9e9822009390bc21d555997209c985"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"87ccdfb28356949214f65e123c2ddf8e25f9b891","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"44d8338c_3d68a031","updated":"2023-04-06 17:01:23.000000000","message":"+1 for the two-phase-commit of repro...fix. ","commit_id":"0cc0162f864b12eccd1d40641bb79ab90ef54ebc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"087afcd1393fb364fef355c29bc9b9de55ef46cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2d83427f_88f8a65d","updated":"2023-03-06 13:27:24.000000000","message":"looks good. I\u0027m not approving it as we are in a delicate time between RC1 and the Antelope release. Ping me after Antelope is out of the door and I will approve this.","commit_id":"0cc0162f864b12eccd1d40641bb79ab90ef54ebc"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"31421bfbc807333d5fed7bd756001aa6bac9c5d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4878244e_278b1d40","updated":"2023-01-10 18:59:17.000000000","message":"recheck","commit_id":"0cc0162f864b12eccd1d40641bb79ab90ef54ebc"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"01d2eef7781eb238cc1ba69dbdde795cb0ff57d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7208f5fd_6cd3a4e7","updated":"2023-05-04 08:10:13.000000000","message":"still looks good","commit_id":"04ebae9dc01ebd24552b5aacd1a0f8b129013a9e"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5c689e7c578270276c7e0a706c99a66d5581e243","unresolved":true,"context_lines":[{"line_number":2307,"context_line":"            flavor_id\u003dself._create_flavor("},{"line_number":2308,"context_line":"                extra_spec\u003d{\u0027hw:cpu_policy\u0027: \u0027dedicated\u0027}))"},{"line_number":2309,"context_line":"        flavor_id \u003d self._create_flavor(extra_spec\u003dextra_spec)"},{"line_number":2310,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":2311,"context_line":"        self.assertTrue(self.mock_filter.called)"},{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"    def test_socket_policy_fail(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"24c29ddb_d96e74b4","line":2310,"updated":"2022-12-13 10:37:00.000000000","message":"I don\u0027t get the change here, could you update the commit message explaining why your change fixed this test?","commit_id":"223e94902f9e9822009390bc21d555997209c985"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"87ccdfb28356949214f65e123c2ddf8e25f9b891","unresolved":true,"context_lines":[{"line_number":2307,"context_line":"            flavor_id\u003dself._create_flavor("},{"line_number":2308,"context_line":"                extra_spec\u003d{\u0027hw:cpu_policy\u0027: \u0027dedicated\u0027}))"},{"line_number":2309,"context_line":"        flavor_id \u003d self._create_flavor(extra_spec\u003dextra_spec)"},{"line_number":2310,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":2311,"context_line":"        self.assertTrue(self.mock_filter.called)"},{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"    def test_socket_policy_fail(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"789da9f1_ecd0704c","line":2310,"in_reply_to":"03c283e2_11e6b374","updated":"2023-04-06 17:01:23.000000000","message":"The fact that this is a two-step commit for repro..fix should make this plenty clear I think. Perhaps Sahid didn\u0027t realize there\u0027s a patch under this one?","commit_id":"223e94902f9e9822009390bc21d555997209c985"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef25763ef03845deeb0d10cb3037c0774bb5a6e3","unresolved":true,"context_lines":[{"line_number":2307,"context_line":"            flavor_id\u003dself._create_flavor("},{"line_number":2308,"context_line":"                extra_spec\u003d{\u0027hw:cpu_policy\u0027: \u0027dedicated\u0027}))"},{"line_number":2309,"context_line":"        flavor_id \u003d self._create_flavor(extra_spec\u003dextra_spec)"},{"line_number":2310,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":2311,"context_line":"        self.assertTrue(self.mock_filter.called)"},{"line_number":2312,"context_line":""},{"line_number":2313,"context_line":"    def test_socket_policy_fail(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"03c283e2_11e6b374","line":2310,"in_reply_to":"24c29ddb_d96e74b4","updated":"2022-12-21 18:16:11.000000000","message":"I\u0027ve added a docstring to the patch below this one, hopefully it makes things clearer.","commit_id":"223e94902f9e9822009390bc21d555997209c985"}],"nova/tests/unit/compute/test_resource_tracker.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e1d424527bddf59bf4da1fa41fe6ea87ceb19aeb","unresolved":true,"context_lines":[{"line_number":190,"context_line":"            memory\u003d_2MB,"},{"line_number":191,"context_line":"            cpu_usage\u003d0,"},{"line_number":192,"context_line":"            memory_usage\u003d0,"},{"line_number":193,"context_line":"            socket\u003d0,"},{"line_number":194,"context_line":"            mempages\u003d[_NUMA_PAGE_TOPOLOGIES[\u00272mb*1024\u0027]],"},{"line_number":195,"context_line":"            siblings\u003d[set([3]), set([4])],"},{"line_number":196,"context_line":"            pinned_cpus\u003dset())]),"}],"source_content_type":"text/x-python","patch_set":5,"id":"cea42fee_df7dc88f","line":193,"updated":"2023-01-18 06:07:58.000000000","message":"i probably would have used socket\u003d1 but this is fine\n\ncurrenlyt its modeling a spu with multiple numa nodes which is not uncommon so this works","commit_id":"0cc0162f864b12eccd1d40641bb79ab90ef54ebc"}],"nova/tests/unit/virt/test_hardware.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5c689e7c578270276c7e0a706c99a66d5581e243","unresolved":true,"context_lines":[{"line_number":2013,"context_line":"                                     topology.cells[i].pagesize)"},{"line_number":2014,"context_line":"                    self.assertEqual(testitem[\"expect\"].cells[i].cpu_pinning,"},{"line_number":2015,"context_line":"                                     topology.cells[i].cpu_pinning)"},{"line_number":2016,"context_line":""},{"line_number":2017,"context_line":"    def test_host_usage_contiguous(self):"},{"line_number":2018,"context_line":"        hosttopo \u003d objects.NUMATopology(cells\u003d["},{"line_number":2019,"context_line":"            objects.NUMACell("}],"source_content_type":"text/x-python","patch_set":4,"id":"ee898989_f9f11c5c","line":2016,"updated":"2022-12-13 10:37:00.000000000","message":"Can we have a test that is showing now that setting socket to something else than zero will be well reported?","commit_id":"223e94902f9e9822009390bc21d555997209c985"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"e1d424527bddf59bf4da1fa41fe6ea87ceb19aeb","unresolved":false,"context_lines":[{"line_number":2013,"context_line":"                                     topology.cells[i].pagesize)"},{"line_number":2014,"context_line":"                    self.assertEqual(testitem[\"expect\"].cells[i].cpu_pinning,"},{"line_number":2015,"context_line":"                                     topology.cells[i].cpu_pinning)"},{"line_number":2016,"context_line":""},{"line_number":2017,"context_line":"    def test_host_usage_contiguous(self):"},{"line_number":2018,"context_line":"        hosttopo \u003d objects.NUMATopology(cells\u003d["},{"line_number":2019,"context_line":"            objects.NUMACell("}],"source_content_type":"text/x-python","patch_set":4,"id":"7d2aa335_90ee50a5","line":2016,"in_reply_to":"68fd10a5_d13b294c","updated":"2023-01-18 06:07:58.000000000","message":"Done","commit_id":"223e94902f9e9822009390bc21d555997209c985"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"ef25763ef03845deeb0d10cb3037c0774bb5a6e3","unresolved":true,"context_lines":[{"line_number":2013,"context_line":"                                     topology.cells[i].pagesize)"},{"line_number":2014,"context_line":"                    self.assertEqual(testitem[\"expect\"].cells[i].cpu_pinning,"},{"line_number":2015,"context_line":"                                     topology.cells[i].cpu_pinning)"},{"line_number":2016,"context_line":""},{"line_number":2017,"context_line":"    def test_host_usage_contiguous(self):"},{"line_number":2018,"context_line":"        hosttopo \u003d objects.NUMATopology(cells\u003d["},{"line_number":2019,"context_line":"            objects.NUMACell("}],"source_content_type":"text/x-python","patch_set":4,"id":"68fd10a5_d13b294c","line":2016,"in_reply_to":"ee898989_f9f11c5c","updated":"2022-12-21 18:16:11.000000000","message":"Sure","commit_id":"223e94902f9e9822009390bc21d555997209c985"}],"nova/virt/hardware.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5c689e7c578270276c7e0a706c99a66d5581e243","unresolved":true,"context_lines":[{"line_number":2566,"context_line":"            cpuset\u003dhost_cell.cpuset,"},{"line_number":2567,"context_line":"            pcpuset\u003dhost_cell.pcpuset,"},{"line_number":2568,"context_line":"            memory\u003dhost_cell.memory,"},{"line_number":2569,"context_line":"            socket\u003dhost_cell.socket,"},{"line_number":2570,"context_line":"            cpu_usage\u003d0,"},{"line_number":2571,"context_line":"            memory_usage\u003d0,"},{"line_number":2572,"context_line":"            mempages\u003dhost_cell.mempages,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e0d8e3ac_523da0f1","line":2569,"updated":"2022-12-13 10:37:00.000000000","message":"Yes this makes sense ++","commit_id":"223e94902f9e9822009390bc21d555997209c985"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"087afcd1393fb364fef355c29bc9b9de55ef46cf","unresolved":false,"context_lines":[{"line_number":2566,"context_line":"            cpuset\u003dhost_cell.cpuset,"},{"line_number":2567,"context_line":"            pcpuset\u003dhost_cell.pcpuset,"},{"line_number":2568,"context_line":"            memory\u003dhost_cell.memory,"},{"line_number":2569,"context_line":"            socket\u003dhost_cell.socket,"},{"line_number":2570,"context_line":"            cpu_usage\u003d0,"},{"line_number":2571,"context_line":"            memory_usage\u003d0,"},{"line_number":2572,"context_line":"            mempages\u003dhost_cell.mempages,"}],"source_content_type":"text/x-python","patch_set":4,"id":"6ef08b93_1e33148a","line":2569,"in_reply_to":"e0d8e3ac_523da0f1","updated":"2023-03-06 13:27:24.000000000","message":"Also all the other non test code call of NUMACell() has the socket param filled properly.","commit_id":"223e94902f9e9822009390bc21d555997209c985"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"87ccdfb28356949214f65e123c2ddf8e25f9b891","unresolved":true,"context_lines":[{"line_number":2566,"context_line":"            cpuset\u003dhost_cell.cpuset,"},{"line_number":2567,"context_line":"            pcpuset\u003dhost_cell.pcpuset,"},{"line_number":2568,"context_line":"            memory\u003dhost_cell.memory,"},{"line_number":2569,"context_line":"            socket\u003dhost_cell.socket,"},{"line_number":2570,"context_line":"            cpu_usage\u003d0,"},{"line_number":2571,"context_line":"            memory_usage\u003d0,"},{"line_number":2572,"context_line":"            mempages\u003dhost_cell.mempages,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d508946f_283fe3b2","line":2569,"updated":"2023-04-06 17:01:23.000000000","message":"Isn\u0027t this bug basically due to this (lossy) re-creating of these objects? Why are we doing that exactly?","commit_id":"0cc0162f864b12eccd1d40641bb79ab90ef54ebc"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"36893896ecdd624b7f430c7c78a435679b661add","unresolved":true,"context_lines":[{"line_number":2566,"context_line":"            cpuset\u003dhost_cell.cpuset,"},{"line_number":2567,"context_line":"            pcpuset\u003dhost_cell.pcpuset,"},{"line_number":2568,"context_line":"            memory\u003dhost_cell.memory,"},{"line_number":2569,"context_line":"            socket\u003dhost_cell.socket,"},{"line_number":2570,"context_line":"            cpu_usage\u003d0,"},{"line_number":2571,"context_line":"            memory_usage\u003d0,"},{"line_number":2572,"context_line":"            mempages\u003dhost_cell.mempages,"}],"source_content_type":"text/x-python","patch_set":5,"id":"2a9db933_7b2646d0","line":2569,"in_reply_to":"3f9f1cc3_49eb0245","updated":"2023-04-06 17:40:50.000000000","message":"That\u0027s not what I\u0027m saying, I\u0027m just wondering why we\u0027re doing it this way. If there\u0027s not some good reason I\u0027m missing then, yes, I think we should refactor it, but not as a part of fixing this bug of course.","commit_id":"0cc0162f864b12eccd1d40641bb79ab90ef54ebc"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"772a0107c0d2b150142b916142b3bdc78a283366","unresolved":true,"context_lines":[{"line_number":2566,"context_line":"            cpuset\u003dhost_cell.cpuset,"},{"line_number":2567,"context_line":"            pcpuset\u003dhost_cell.pcpuset,"},{"line_number":2568,"context_line":"            memory\u003dhost_cell.memory,"},{"line_number":2569,"context_line":"            socket\u003dhost_cell.socket,"},{"line_number":2570,"context_line":"            cpu_usage\u003d0,"},{"line_number":2571,"context_line":"            memory_usage\u003d0,"},{"line_number":2572,"context_line":"            mempages\u003dhost_cell.mempages,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f9f1cc3_49eb0245","line":2569,"in_reply_to":"d508946f_283fe3b2","updated":"2023-04-06 17:07:50.000000000","message":"It is. Are you saying we should refactor this lossy recreation? I\u0027m not against that, but could we do that in a follow up patch, since we\u0027ll want to backport this fix to at least wallaby?","commit_id":"0cc0162f864b12eccd1d40641bb79ab90ef54ebc"}]}