)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7e814a2ff9769209978789b8cc997e22526157f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a86a541e_33e81a50","updated":"2023-04-06 16:55:08.000000000","message":"I think we\u0027ve got critical mass for asking this to be moved ;)","commit_id":"2786cc38d7588f224e96be4c06e7d6cf211ae536"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"282103e26ab77c67edfeac50f1dfc090497631f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d1422955_f092a53a","updated":"2023-03-06 13:27:07.000000000","message":"looks good. The move of the TC can be done in a separate patch. I\u0027m not approving it as we are in a delicate time between RC1 and the Antelope release. Ping me after Antelope is out of the door and I will approve this.","commit_id":"2786cc38d7588f224e96be4c06e7d6cf211ae536"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"5e668edb61e6860ef2e3983e90b18feb56af145e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5c2ce3f9_73b3c119","updated":"2023-01-10 18:59:10.000000000","message":"recheck","commit_id":"2786cc38d7588f224e96be4c06e7d6cf211ae536"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"6326aa706978b79f80271c4c389cea04fc2bef86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c085630f_ab2d8e3c","updated":"2023-04-25 23:17:13.000000000","message":"Looks good, thanks!","commit_id":"63d6ecd99b7dec06cf0cf8358b43b0d8fa607504"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"98e7b1d7753276aeb40b01c6a70a770420a4fc37","unresolved":true,"context_lines":[{"line_number":992,"context_line":""},{"line_number":993,"context_line":"        # update the compute_node"},{"line_number":994,"context_line":"        self._update(context, cn, startup\u003dstartup)"},{"line_number":995,"context_line":"        LOG.info(\u0027Compute_service record updated for %(host)s:%(node)s\u0027,"},{"line_number":996,"context_line":"                  {\u0027host\u0027: self.host, \u0027node\u0027: nodename})"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"        # Check if there is any resource assigned but not found"}],"source_content_type":"text/x-python","patch_set":4,"id":"53aa7ef5_15627878","line":995,"updated":"2023-04-25 20:54:33.000000000","message":"This looks like an unrelated change?","commit_id":"bb985106f769501002ee6b586d3c220e114ed520"},{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"9560525ec1ea45b3e21933711592d4eeeef19c26","unresolved":true,"context_lines":[{"line_number":992,"context_line":""},{"line_number":993,"context_line":"        # update the compute_node"},{"line_number":994,"context_line":"        self._update(context, cn, startup\u003dstartup)"},{"line_number":995,"context_line":"        LOG.info(\u0027Compute_service record updated for %(host)s:%(node)s\u0027,"},{"line_number":996,"context_line":"                  {\u0027host\u0027: self.host, \u0027node\u0027: nodename})"},{"line_number":997,"context_line":""},{"line_number":998,"context_line":"        # Check if there is any resource assigned but not found"}],"source_content_type":"text/x-python","patch_set":4,"id":"27f6595a_774a6dd3","line":995,"in_reply_to":"53aa7ef5_15627878","updated":"2023-04-25 22:46:10.000000000","message":"Err, yeah, fixed.","commit_id":"bb985106f769501002ee6b586d3c220e114ed520"}],"nova/tests/functional/libvirt/test_pci_sriov_servers.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"384e198e6de4564937dd3c51f279a45448df001d","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":2286,"context_line":"        self.assertTrue(self.mock_filter.called)"},{"line_number":2287,"context_line":""},{"line_number":2288,"context_line":"    def test_socket_policy_bug_1995153(self):"},{"line_number":2289,"context_line":"        \"\"\"The numa_usage_from_instance_numa() method in hardware.py saves the"},{"line_number":2290,"context_line":"        host NUMAToplogy object with NUMACells that have no `socket` set. This"},{"line_number":2291,"context_line":"        was an omission in the original implementation of the `socket` PCI NUMA"}],"source_content_type":"text/x-python","patch_set":3,"id":"5769d5e8_bc168731","line":2288,"updated":"2023-01-18 06:03:21.000000000","message":"i generally dislike adding regression bug repoduced in line in the main test cases.\n\nit makes them harder to find but the doc string is good at explaing why this is here.\n\nim not going to insist on movign this to the correct place but it would be my prefernce","commit_id":"2786cc38d7588f224e96be4c06e7d6cf211ae536"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9e961577a0198a36a719a6b3c1bc93691deffc81","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":2286,"context_line":"        self.assertTrue(self.mock_filter.called)"},{"line_number":2287,"context_line":""},{"line_number":2288,"context_line":"    def test_socket_policy_bug_1995153(self):"},{"line_number":2289,"context_line":"        \"\"\"The numa_usage_from_instance_numa() method in hardware.py saves the"},{"line_number":2290,"context_line":"        host NUMAToplogy object with NUMACells that have no `socket` set. This"},{"line_number":2291,"context_line":"        was an omission in the original implementation of the `socket` PCI NUMA"}],"source_content_type":"text/x-python","patch_set":3,"id":"aceae962_2fce61f3","line":2288,"in_reply_to":"5769d5e8_bc168731","updated":"2023-02-02 00:20:53.000000000","message":"I agree with Sean here ... I don\u0027t think this a good habit to start.\n\nI\u0027m happy to move this under nova/tests/functional/regressions/ myself if Artom doesn\u0027t mind, so as not to make more work for him.","commit_id":"2786cc38d7588f224e96be4c06e7d6cf211ae536"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"6936a2aceae3bde339d34c73bb0f96decd89b5b1","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":2286,"context_line":"        self.assertTrue(self.mock_filter.called)"},{"line_number":2287,"context_line":""},{"line_number":2288,"context_line":"    def test_socket_policy_bug_1995153(self):"},{"line_number":2289,"context_line":"        \"\"\"The numa_usage_from_instance_numa() method in hardware.py saves the"},{"line_number":2290,"context_line":"        host NUMAToplogy object with NUMACells that have no `socket` set. This"},{"line_number":2291,"context_line":"        was an omission in the original implementation of the `socket` PCI NUMA"}],"source_content_type":"text/x-python","patch_set":3,"id":"daa3b75f_513d1e5f","line":2288,"in_reply_to":"aceae962_2fce61f3","updated":"2023-03-07 05:25:13.000000000","message":"+1, as this is a reproducer of a specific reported bug.","commit_id":"2786cc38d7588f224e96be4c06e7d6cf211ae536"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7e814a2ff9769209978789b8cc997e22526157f3","unresolved":true,"context_lines":[{"line_number":2285,"context_line":"        self._create_server(flavor_id\u003dflavor_id)"},{"line_number":2286,"context_line":"        self.assertTrue(self.mock_filter.called)"},{"line_number":2287,"context_line":""},{"line_number":2288,"context_line":"    def test_socket_policy_bug_1995153(self):"},{"line_number":2289,"context_line":"        \"\"\"The numa_usage_from_instance_numa() method in hardware.py saves the"},{"line_number":2290,"context_line":"        host NUMAToplogy object with NUMACells that have no `socket` set. This"},{"line_number":2291,"context_line":"        was an omission in the original implementation of the `socket` PCI NUMA"}],"source_content_type":"text/x-python","patch_set":3,"id":"a8a46fff_4c241e71","line":2288,"in_reply_to":"daa3b75f_513d1e5f","updated":"2023-04-06 16:55:08.000000000","message":"Also agree.","commit_id":"2786cc38d7588f224e96be4c06e7d6cf211ae536"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"384e198e6de4564937dd3c51f279a45448df001d","unresolved":true,"context_lines":[{"line_number":2324,"context_line":"                                     expected_state\u003d\u0027ERROR\u0027)"},{"line_number":2325,"context_line":"        self.assertIn(\u0027fault\u0027, server)"},{"line_number":2326,"context_line":"        self.assertIn(\u0027NotImplementedError\u0027, server[\u0027fault\u0027][\u0027message\u0027])"},{"line_number":2327,"context_line":"        self.assertTrue(self.mock_filter.called)"},{"line_number":2328,"context_line":""},{"line_number":2329,"context_line":"    def test_socket_policy_fail(self):"},{"line_number":2330,"context_line":"        # With 2 sockets containing 1 NUMA node each, make the first socket\u0027s"}],"source_content_type":"text/x-python","patch_set":3,"id":"e16e535b_19e330e4","line":2327,"updated":"2023-01-18 06:03:21.000000000","message":"you could also assert the topology in the db but this also works","commit_id":"2786cc38d7588f224e96be4c06e7d6cf211ae536"}]}