)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"45f021d28d7ed9611542084f82c92e01207d22ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"194be59e_8c7fd766","updated":"2022-11-01 20:32:44.000000000","message":"Hi, for changes that are features or otherwise need to involve some design discussion, will need to create a spec and blueprint:\n\nhttps://docs.openstack.org/nova/latest/contributor/blueprints.html\n\nDiscussion will occur on the spec review. For detailed info about specs, see:\n\nhttps://specs.openstack.org/openstack/nova-specs/readme.html\n\nI\u0027m adding a procedural -2 to this pending spec proposal and approval. You may continue to upload new patchsets without worry about accidental merge.","commit_id":"9d548e4ee9c23224d5fc2c215ab6473fbcad70ac"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"914a60f9fc1aa0e264247623846699c3e7c1e138","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2f822944_32f2a0ba","in_reply_to":"194be59e_8c7fd766","updated":"2022-11-01 21:02:15.000000000","message":"Hi\ni\u0027m wokring on this spec:\nhttps://specs.openstack.org/openstack/ironic-specs/specs/not-implemented/vnc-graphical-console.html\nand i\u0027ve got 2 commits:\nfirst one is adding vnc concole support for ironic\nsecond - realization of new graphical console interface\neverything is checked on my local\n\nso this is a first part","commit_id":"9d548e4ee9c23224d5fc2c215ab6473fbcad70ac"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"4223a1886fa98110b8d73cb066bc5eba068dd9b8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eab366ba_d6e49b52","in_reply_to":"2f822944_32f2a0ba","updated":"2022-11-01 21:51:10.000000000","message":"Cool, so that spec will cover the ironic implementation. We\u0027ll just need a nova spec to cover the nova implementation.","commit_id":"9d548e4ee9c23224d5fc2c215ab6473fbcad70ac"},{"author":{"_account_id":35370,"name":"Kirill","email":"kirill.germanov@gcore.com","username":"kirillgermanov"},"change_message_id":"efd12e16e931b2fcb2e1b90b766522e84e64a379","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"71f22114_62f4abc9","in_reply_to":"eab366ba_d6e49b52","updated":"2022-11-02 14:30:32.000000000","message":"thanks, got it\nwe also have this blueprint for nova:\nhttps://blueprints.launchpad.net/nova/+spec/ironic-vnc-console\nbut my changes are global so i\u0027ll return with spec.","commit_id":"9d548e4ee9c23224d5fc2c215ab6473fbcad70ac"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"687db69d5a196fc7525ae8b4806e78126c32cb79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7b344a27_5a22d28b","updated":"2023-02-10 16:02:18.000000000","message":"Hey, so https://blueprints.launchpad.net/nova/+spec/ironic-vnc-console was approved.\n@Kirill, is this patch the implementation of that above blueprint ? If so, we can remove the -2.","commit_id":"e327b4f45868d96fe0689460b0ed8b28ccfbda6c"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b817f801e9dcc8461f3fddf1762183d919797f4b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45a3549d_bbeeaa3c","updated":"2023-02-15 11:34:12.000000000","message":"I have mostly concerns about the persistence of some password field that\u0027s given by the virt driver while we already have a token mechanism in place.\n","commit_id":"e327b4f45868d96fe0689460b0ed8b28ccfbda6c"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"ca82fbc4fa641fb2758f66fcbb6d39aa94e123eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"47298dcf_044c296b","updated":"2025-02-23 22:02:35.000000000","message":"I\u0027ve been working on a recent effort to add graphical console support to Ironic, so this change is superseded by https://review.opendev.org/c/openstack/nova/+/942528","commit_id":"e327b4f45868d96fe0689460b0ed8b28ccfbda6c"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"10ada35a1cb02e43ff17cabc15781df5fa6e0a0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"52b0f49b_dee83679","updated":"2023-02-10 19:13:34.000000000","message":"Spec got approved","commit_id":"e327b4f45868d96fe0689460b0ed8b28ccfbda6c"}],"nova/console/type.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b817f801e9dcc8461f3fddf1762183d919797f4b","unresolved":true,"context_lines":[{"line_number":18,"context_line":"        self.host \u003d host"},{"line_number":19,"context_line":"        self.port \u003d port"},{"line_number":20,"context_line":"        self.internal_access_path \u003d internal_access_path"},{"line_number":21,"context_line":"        self.password \u003d password"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    def get_connection_info(self, token, access_url):"},{"line_number":24,"context_line":"        \"\"\"Returns an unreferenced dict with connection information.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fda846c2_e714ffbf","line":21,"updated":"2023-02-15 11:34:12.000000000","message":"this wasn\u0027t discussed in the spec https://specs.openstack.org/openstack/nova-specs/specs/2023.1/approved/nova-vnc-support-for-ironic.html#proposed-change","commit_id":"e327b4f45868d96fe0689460b0ed8b28ccfbda6c"}],"nova/db/main/models.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b817f801e9dcc8461f3fddf1762183d919797f4b","unresolved":true,"context_lines":[{"line_number":1063,"context_line":"    instance_uuid \u003d sa.Column(sa.String(36), nullable\u003dFalse)"},{"line_number":1064,"context_line":"    expires \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":1065,"context_line":"    access_url_base \u003d sa.Column(sa.String(255))"},{"line_number":1066,"context_line":"    password \u003d sa.Column(sa.String(8))"},{"line_number":1067,"context_line":"    "},{"line_number":1068,"context_line":"    instance \u003d orm.relationship("},{"line_number":1069,"context_line":"        \"Instance\","}],"source_content_type":"text/x-python","patch_set":4,"id":"9ffba885_a440257f","line":1066,"updated":"2023-02-15 11:34:12.000000000","message":"I\u0027m confused. In the approved spec, no data impact was defined and I wonder here why we should persist the VNC bearer token in the object model on the client side (this can be errorprone)\n\nhttps://specs.openstack.org/openstack/nova-specs/specs/2023.1/approved/nova-vnc-support-for-ironic.html#data-model-impact","commit_id":"e327b4f45868d96fe0689460b0ed8b28ccfbda6c"}],"nova/objects/console_auth_token.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"b817f801e9dcc8461f3fddf1762183d919797f4b","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        # database. A hash of the token is stored instead and is not a"},{"line_number":53,"context_line":"        # field on the object."},{"line_number":54,"context_line":"        \u0027token\u0027: fields.StringField(nullable\u003dFalse),"},{"line_number":55,"context_line":"        \u0027password\u0027: fields.StringField(nullable\u003dTrue),"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":4,"id":"399d6e62_925a4625","line":55,"updated":"2023-02-15 11:34:12.000000000","message":"I don\u0027t see why we need to return a password here if we already have a VNC token.","commit_id":"e327b4f45868d96fe0689460b0ed8b28ccfbda6c"}]}