)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"79469ae74f2a69746e75ff9dd2a66f302a65a3cf","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This just adds the service ref to init_host() so that we can pass it"},{"line_number":10,"context_line":"(if it exists) at startup. On the first run, this will be None, so"},{"line_number":11,"context_line":"we know that we don\u0027t have an existing service record and thus do not"},{"line_number":12,"context_line":"need to do any migration."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related to blueprint stable-compute-uuid"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"22b0ce5b_b4b3e1c4","line":12,"updated":"2023-01-10 09:15:17.000000000","message":"thanks for the explanation!","commit_id":"ec9426ae2bcd9ae4a6b9ca193b65872ebea504b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eeaf6da9691a6b4ae030376665361b456e9fd2d6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This just adds the service ref to init_host() so that we can pass it"},{"line_number":10,"context_line":"(if it exists) at startup. On the first run, this will be None, so"},{"line_number":11,"context_line":"we know that we don\u0027t have an existing service record and thus do not"},{"line_number":12,"context_line":"need to do any migration."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Related to blueprint stable-compute-uuid"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"58dfde0c_af17202d","line":12,"in_reply_to":"22b0ce5b_b4b3e1c4","updated":"2023-01-26 20:54:28.000000000","message":"Ack","commit_id":"ec9426ae2bcd9ae4a6b9ca193b65872ebea504b3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aaaf587c9f15b74fd709887a7af35a6059eea1b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f984da9c_7d2c5490","updated":"2023-01-09 20:36:54.000000000","message":"the functional job failure seem to be related to the tox 4 issues so i dont think there is any point rechecking until that is resloved.","commit_id":"ec9426ae2bcd9ae4a6b9ca193b65872ebea504b3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b52d9de0f484cd2583b55beb3d49eaa67d7969fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2ac1ffc3_618addb6","updated":"2023-01-13 00:24:11.000000000","message":"Looks OK to me","commit_id":"4b04ad937c2ffd3f932289daa6ed4258ed95f5e9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4348971ef8f640db079a57569193cfd3b1b5b428","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7b88238b_876a938c","updated":"2023-01-17 18:41:08.000000000","message":"recheck ceph-multistore oom","commit_id":"4b04ad937c2ffd3f932289daa6ed4258ed95f5e9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4303c0b4da432d7a431b732464aa9866698be8e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e53cc1a4_bf56aad6","updated":"2023-01-11 22:03:42.000000000","message":"recheck cinder-volume OOM and two other unrelated (snapshot and volume) test fails","commit_id":"4b04ad937c2ffd3f932289daa6ed4258ed95f5e9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"aabd4892fbade74078a70b16d8c08eca8e03f5d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3bfbf7d5_b00fefe6","updated":"2023-01-17 16:17:24.000000000","message":"recheck infra post fails","commit_id":"4b04ad937c2ffd3f932289daa6ed4258ed95f5e9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c03e3c091513c688f7f15d19dd551a0ebe56ef80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"50b559a6_2873d996","updated":"2023-01-13 14:35:55.000000000","message":"recheck post failure","commit_id":"4b04ad937c2ffd3f932289daa6ed4258ed95f5e9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"86a3978ab5243bfabb88a2265446f9cd62945fbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2ab56579_8dcca8d5","updated":"2023-01-20 18:44:38.000000000","message":"recheck grenade failed to create cinder resources before upgrade","commit_id":"cf111d10013eedca0f377d84307e7e41181b7200"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"adc630749da2082bf8545f9d031e2f86e6b4f784","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9eae7ecb_c0749214","updated":"2023-01-20 22:26:53.000000000","message":"recheck volume attach test fail","commit_id":"cf111d10013eedca0f377d84307e7e41181b7200"}],"nova/compute/manager.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c5c390aab974efd884f77bb3b1d3f9abca0a5dc7","unresolved":true,"context_lines":[{"line_number":1493,"context_line":"        return nodes_by_uuid"},{"line_number":1494,"context_line":""},{"line_number":1495,"context_line":"    def init_host(self, service_ref):"},{"line_number":1496,"context_line":"        \"\"\"Initialization for a standalone compute service.\"\"\""},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"        if CONF.pci.device_spec:"},{"line_number":1499,"context_line":"            # Simply loading the PCI passthrough spec will do a bunch of"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f167dfc_e126b685","line":1496,"updated":"2023-01-24 08:59:52.000000000","message":"nit: Updating the docstring to refer that new arg. Mentioning the fact that this can be None in some circumstance can help future debugging and development.","commit_id":"cf111d10013eedca0f377d84307e7e41181b7200"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ce00cc8c1ef51d389764ea95e865a0f2373163e7","unresolved":false,"context_lines":[{"line_number":1493,"context_line":"        return nodes_by_uuid"},{"line_number":1494,"context_line":""},{"line_number":1495,"context_line":"    def init_host(self, service_ref):"},{"line_number":1496,"context_line":"        \"\"\"Initialization for a standalone compute service.\"\"\""},{"line_number":1497,"context_line":""},{"line_number":1498,"context_line":"        if CONF.pci.device_spec:"},{"line_number":1499,"context_line":"            # Simply loading the PCI passthrough spec will do a bunch of"}],"source_content_type":"text/x-python","patch_set":7,"id":"10366187_7e7c1057","line":1496,"in_reply_to":"7f167dfc_e126b685","updated":"2023-01-26 15:44:46.000000000","message":"Ack, I\u0027ll do this if I respin, or in a FUP.","commit_id":"cf111d10013eedca0f377d84307e7e41181b7200"}],"nova/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"91357661491febe6cefe410b44556cd97502f634","unresolved":true,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        Child classes should override this method."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param service_ref: An objects.Service if one exists, else None."},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        pass"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"23f12d56_71714ae3","line":114,"updated":"2022-12-06 19:22:12.000000000","message":"Here, it says to pass None of the service does not exist yet. That\u0027s my desired behavior.","commit_id":"d2a2f9722ac05b73cdfff871000fd55e409ae23c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aaaf587c9f15b74fd709887a7af35a6059eea1b9","unresolved":true,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        Child classes should override this method."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param service_ref: An objects.Service if one exists, else None."},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        pass"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5b92fea6_827a9942","line":114,"in_reply_to":"23f12d56_71714ae3","updated":"2023-01-09 20:36:54.000000000","message":"ok so that is why you are not default this to None and taking it a as a keyword arg.\nyou are reserving none as a sentinal value and useing it to indifcat that you do not belive a service currently shoudl exist if None is passed.","commit_id":"d2a2f9722ac05b73cdfff871000fd55e409ae23c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"eeaf6da9691a6b4ae030376665361b456e9fd2d6","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        Child classes should override this method."},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        :param service_ref: An objects.Service if one exists, else None."},{"line_number":115,"context_line":"        \"\"\""},{"line_number":116,"context_line":"        pass"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8113970d_843e1346","line":114,"in_reply_to":"5b92fea6_827a9942","updated":"2023-01-26 20:54:28.000000000","message":"Ack","commit_id":"d2a2f9722ac05b73cdfff871000fd55e409ae23c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aaaf587c9f15b74fd709887a7af35a6059eea1b9","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def init_host(self, service_ref):"},{"line_number":107,"context_line":"        \"\"\"Hook to do additional manager initialization when one requests"},{"line_number":108,"context_line":"        the service be started.  This is called before any service record"},{"line_number":109,"context_line":"        is created, but if one already exists for this service, it is"},{"line_number":110,"context_line":"        provided."},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"55e02ce4_3478b9ea","line":108,"range":{"start_line":108,"start_character":38,"end_line":108,"end_character":41},"updated":"2023-01-09 20:36:54.000000000","message":"nit: is -\u003e can be?\n\ni think even before \"can be\" is more correct\n\n\"is\" is correct in the context of a singel compute agent start and the first invocation of init_host. for all other invocations when the compute agent is recreated we expect the compute service to still exist so we would now pass it in that case.","commit_id":"ec9426ae2bcd9ae4a6b9ca193b65872ebea504b3"}],"nova/service.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"daac5d1b1a6df892e52b59ec51a2e7f699d27dee","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":160,"context_line":"        self.service_ref \u003d objects.Service.get_by_host_and_binary("},{"line_number":161,"context_line":"            ctxt, self.host, self.binary)"},{"line_number":162,"context_line":"        self.manager.init_host(self.service_ref)"},{"line_number":163,"context_line":"        self.model_disconnected \u003d False"},{"line_number":164,"context_line":"        if self.service_ref:"},{"line_number":165,"context_line":"            _update_service_ref(self.service_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"94b074e8_aabfdd51","line":162,"updated":"2022-12-05 15:43:18.000000000","message":"Based on the if below we might calling this with self.service_ref \u003d None\nDo we want to move the init_host all the way down L176 so that we can always pass a valid service_ref to it? At this point I don\u0027t see if passing None is OK or not.","commit_id":"d2a2f9722ac05b73cdfff871000fd55e409ae23c"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"aaaf587c9f15b74fd709887a7af35a6059eea1b9","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":160,"context_line":"        self.service_ref \u003d objects.Service.get_by_host_and_binary("},{"line_number":161,"context_line":"            ctxt, self.host, self.binary)"},{"line_number":162,"context_line":"        self.manager.init_host(self.service_ref)"},{"line_number":163,"context_line":"        self.model_disconnected \u003d False"},{"line_number":164,"context_line":"        if self.service_ref:"},{"line_number":165,"context_line":"            _update_service_ref(self.service_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"908dceeb_fb43d2fe","line":162,"in_reply_to":"59a46024_afbe8097","updated":"2023-01-09 20:36:54.000000000","message":"ah so this is the context of your other comment.\nmarking as resolved since you have naswered gibis quetion this is intentionsl.","commit_id":"d2a2f9722ac05b73cdfff871000fd55e409ae23c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"91357661491febe6cefe410b44556cd97502f634","unresolved":true,"context_lines":[{"line_number":159,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":160,"context_line":"        self.service_ref \u003d objects.Service.get_by_host_and_binary("},{"line_number":161,"context_line":"            ctxt, self.host, self.binary)"},{"line_number":162,"context_line":"        self.manager.init_host(self.service_ref)"},{"line_number":163,"context_line":"        self.model_disconnected \u003d False"},{"line_number":164,"context_line":"        if self.service_ref:"},{"line_number":165,"context_line":"            _update_service_ref(self.service_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"59a46024_afbe8097","line":162,"in_reply_to":"94b074e8_aabfdd51","updated":"2022-12-06 19:22:12.000000000","message":"This is intentional, and documented in the docstring for manager.","commit_id":"d2a2f9722ac05b73cdfff871000fd55e409ae23c"}]}