)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e6efeb2d6d68cd012703768c382ea2ed0ce61fb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0b98bd8_53231619","updated":"2023-01-10 09:34:48.000000000","message":"just a nit but the direction looks good. I guess it is WIP as it has no test coverage","commit_id":"a0927dec277b5a62e365359058433d0b87a63a52"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5619a7cd1f2b2bd2ce842f5d745ee349a447914a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5363b944_1bcb4287","updated":"2023-01-20 18:46:12.000000000","message":"check experimental","commit_id":"d6e8f55028f577a80c88304b7597d71600f1400b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"01d1989bb29569a08b4b92d231ecd08738e0af9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"fd9ef1bc_b3809bf2","updated":"2023-01-25 14:56:13.000000000","message":"check experimental","commit_id":"d6e8f55028f577a80c88304b7597d71600f1400b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d6689c58b463d1df06b9ae34301c4f75f238d0c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a4e7ebc1_71e82342","updated":"2023-01-20 22:29:54.000000000","message":"experimental ironic job failed on the hostname rename detection, and two (both?) nodes are found. This probably needs another exclusion for ironic since the hostname rename thing is really only for the single-node (i.e. libvirt style) host. I\u0027ll dig into that next week.","commit_id":"d6e8f55028f577a80c88304b7597d71600f1400b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b264806e5efe4e945c9a80b2d090c5dd598d797b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ce0e5929_cb98cce3","updated":"2023-01-20 22:27:35.000000000","message":"recheck sshable server timeout","commit_id":"d6e8f55028f577a80c88304b7597d71600f1400b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3f007a9368d6351bafaa76ec146664ce20574178","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0891424c_76759723","updated":"2023-01-20 18:46:04.000000000","message":"recheck unrelated volume failure","commit_id":"d6e8f55028f577a80c88304b7597d71600f1400b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"249c72e43c90b7284f37fd311fdce1a32ce3a84b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b717bade_d4d0c71c","updated":"2023-01-26 19:14:09.000000000","message":"This: https://review.opendev.org/c/openstack/ironic/+/871838\n\npassed everything with nova in the mix, so I think we can say that ironic should be good with this change.","commit_id":"3dcf19e9455bc4c7bf6dd7704a6c7c77452a02f8"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7e3e3560a1066181936fd6b24dd626e4e4f95c9e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"367be77d_fe5a4c41","updated":"2023-01-25 18:41:45.000000000","message":"check experimental","commit_id":"3dcf19e9455bc4c7bf6dd7704a6c7c77452a02f8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"feb3954731a55aa2c5dfd545009c89cb85f8e2d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"1c610c48_58bb989d","updated":"2023-01-31 07:39:46.000000000","message":"I only have nits","commit_id":"e258164f5a6c9ce378fc9828b137d68e9adf5bfd"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"27537a70373bdf76429f95d349af5b078018070c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"86527322_3ebfba9c","updated":"2023-01-31 15:28:04.000000000","message":"Nothing controversial I see here. Again, will leave it open for others to chime in before +W\u0027d it (I also need to look at the whole series)","commit_id":"e258164f5a6c9ce378fc9828b137d68e9adf5bfd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0b810f119049e7c5e5a957628dddad06e3914964","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6679ef40_df4e57b1","updated":"2023-01-31 16:19:14.000000000","message":"holding +w to allow gibi to resopnd","commit_id":"e258164f5a6c9ce378fc9828b137d68e9adf5bfd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"014a37ad86779aa788c20a9d8be73ff953af2297","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"2867bcc4_1938416b","updated":"2023-01-31 00:16:15.000000000","message":"recheck job timeout","commit_id":"e258164f5a6c9ce378fc9828b137d68e9adf5bfd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ec2b26f4694bd14fe5fbe413643839edd10a7227","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"bc333aa3_3d3be965","updated":"2023-01-31 07:35:23.000000000","message":"recheck sdk job failed to build the python venv with\n\nhttp.client.RemoteDisconnected: Remote end closed connection without response","commit_id":"e258164f5a6c9ce378fc9828b137d68e9adf5bfd"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"bbfbf2d3936d80f6d61b0c13f924ab561caf92ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"ddd57a33_23f8d4cc","in_reply_to":"6679ef40_df4e57b1","updated":"2023-01-31 19:32:38.000000000","message":"Since we\u0027re not sure, I just tacked it on after this:\n\nhttps://review.opendev.org/c/openstack/nova/+/872348\n\nHopefully that will allow this to progress and if that\u0027s not what gibi meant, we can discuss there.","commit_id":"e258164f5a6c9ce378fc9828b137d68e9adf5bfd"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"bb83986ad5608d50a1ab0c367ba251c93a5933c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"7c332177_cb86eb32","in_reply_to":"ddd57a33_23f8d4cc","updated":"2023-02-01 05:24:52.000000000","message":"ack","commit_id":"e258164f5a6c9ce378fc9828b137d68e9adf5bfd"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"e6efeb2d6d68cd012703768c382ea2ed0ce61fb1","unresolved":true,"context_lines":[{"line_number":1590,"context_line":"        # NOTE(gibi): At this point the compute_nodes of the resource tracker"},{"line_number":1591,"context_line":"        # has not been populated yet so we cannot rely on the resource tracker"},{"line_number":1592,"context_line":"        # here."},{"line_number":1593,"context_line":"        # NOTE(gibi): If ironic and vcenter virt driver slow start time"},{"line_number":1594,"context_line":"        # becomes problematic here then we should consider adding a config"},{"line_number":1595,"context_line":"        # option or a driver flag to tell us if we should thread"},{"line_number":1596,"context_line":"        # _destroy_evacuated_instances and"},{"line_number":1597,"context_line":"        # _error_out_instances_whose_build_was_interrupted out in the"},{"line_number":1598,"context_line":"        # background on startup"},{"line_number":1599,"context_line":"        context \u003d nova.context.get_admin_context()"},{"line_number":1600,"context_line":"        nodes_by_uuid \u003d self._get_nodes(context)"},{"line_number":1601,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"acb5155d_8789cc83","line":1598,"range":{"start_line":1593,"start_character":0,"end_line":1598,"end_character":31},"updated":"2023-01-10 09:34:48.000000000","message":"nit: this might be better moved to the top of the try block below doing the `_destroy_evacuated_instances` and `_destroy_evacuated_instances` class.","commit_id":"a0927dec277b5a62e365359058433d0b87a63a52"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"27537a70373bdf76429f95d349af5b078018070c","unresolved":true,"context_lines":[{"line_number":1590,"context_line":"        # NOTE(gibi): At this point the compute_nodes of the resource tracker"},{"line_number":1591,"context_line":"        # has not been populated yet so we cannot rely on the resource tracker"},{"line_number":1592,"context_line":"        # here."},{"line_number":1593,"context_line":"        # NOTE(gibi): If ironic and vcenter virt driver slow start time"},{"line_number":1594,"context_line":"        # becomes problematic here then we should consider adding a config"},{"line_number":1595,"context_line":"        # option or a driver flag to tell us if we should thread"},{"line_number":1596,"context_line":"        # _destroy_evacuated_instances and"},{"line_number":1597,"context_line":"        # _error_out_instances_whose_build_was_interrupted out in the"},{"line_number":1598,"context_line":"        # background on startup"},{"line_number":1599,"context_line":"        context \u003d nova.context.get_admin_context()"},{"line_number":1600,"context_line":"        nodes_by_uuid \u003d self._get_nodes(context)"},{"line_number":1601,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9d2bf7ca_08250e64","line":1598,"range":{"start_line":1593,"start_character":0,"end_line":1598,"end_character":31},"in_reply_to":"47ea38f2_002e54f2","updated":"2023-01-31 15:28:04.000000000","message":"this can be done in a FUP unless a rebase is needed.","commit_id":"a0927dec277b5a62e365359058433d0b87a63a52"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c2dfb47bc3f7ca4a3632e6452cf6d0f8343e79a9","unresolved":true,"context_lines":[{"line_number":1590,"context_line":"        # NOTE(gibi): At this point the compute_nodes of the resource tracker"},{"line_number":1591,"context_line":"        # has not been populated yet so we cannot rely on the resource tracker"},{"line_number":1592,"context_line":"        # here."},{"line_number":1593,"context_line":"        # NOTE(gibi): If ironic and vcenter virt driver slow start time"},{"line_number":1594,"context_line":"        # becomes problematic here then we should consider adding a config"},{"line_number":1595,"context_line":"        # option or a driver flag to tell us if we should thread"},{"line_number":1596,"context_line":"        # _destroy_evacuated_instances and"},{"line_number":1597,"context_line":"        # _error_out_instances_whose_build_was_interrupted out in the"},{"line_number":1598,"context_line":"        # background on startup"},{"line_number":1599,"context_line":"        context \u003d nova.context.get_admin_context()"},{"line_number":1600,"context_line":"        nodes_by_uuid \u003d self._get_nodes(context)"},{"line_number":1601,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8896080f_a328b090","line":1598,"range":{"start_line":1593,"start_character":0,"end_line":1598,"end_character":31},"in_reply_to":"9d2bf7ca_08250e64","updated":"2023-01-31 15:33:35.000000000","message":"Sorry gibi, I thought you were referencing your note there and weren\u0027t asking me to do something. You\u0027re quoting a comment here, are you saying the comment should be moved to the try block below?","commit_id":"a0927dec277b5a62e365359058433d0b87a63a52"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"feb3954731a55aa2c5dfd545009c89cb85f8e2d6","unresolved":true,"context_lines":[{"line_number":1590,"context_line":"        # NOTE(gibi): At this point the compute_nodes of the resource tracker"},{"line_number":1591,"context_line":"        # has not been populated yet so we cannot rely on the resource tracker"},{"line_number":1592,"context_line":"        # here."},{"line_number":1593,"context_line":"        # NOTE(gibi): If ironic and vcenter virt driver slow start time"},{"line_number":1594,"context_line":"        # becomes problematic here then we should consider adding a config"},{"line_number":1595,"context_line":"        # option or a driver flag to tell us if we should thread"},{"line_number":1596,"context_line":"        # _destroy_evacuated_instances and"},{"line_number":1597,"context_line":"        # _error_out_instances_whose_build_was_interrupted out in the"},{"line_number":1598,"context_line":"        # background on startup"},{"line_number":1599,"context_line":"        context \u003d nova.context.get_admin_context()"},{"line_number":1600,"context_line":"        nodes_by_uuid \u003d self._get_nodes(context)"},{"line_number":1601,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"47ea38f2_002e54f2","line":1598,"range":{"start_line":1593,"start_character":0,"end_line":1598,"end_character":31},"in_reply_to":"acb5155d_8789cc83","updated":"2023-01-31 07:39:46.000000000","message":"This nit is still valid","commit_id":"a0927dec277b5a62e365359058433d0b87a63a52"}],"releasenotes/notes/stable-compute-uuid-08663a0955616728.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"feb3954731a55aa2c5dfd545009c89cb85f8e2d6","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The compute manager now uses a local file to provide node uuid persistence"},{"line_number":5,"context_line":"    to guard against problems with renamed services, among other things."},{"line_number":6,"context_line":"    Deployers wishing to ensure that *new* compute services get a predicatble"},{"line_number":7,"context_line":"    uuid before initial startup may provision that file and nova will use it,"},{"line_number":8,"context_line":"    otherwise nova will generate and write one to a `compute_id` file in"},{"line_number":9,"context_line":"    `CONF.state_path` the first time it starts up. Accidental renames of a"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"51bfbab1_8ec2e5c9","line":6,"range":{"start_line":6,"start_character":66,"end_line":6,"end_character":77},"updated":"2023-01-31 07:39:46.000000000","message":"nit:predictable","commit_id":"e258164f5a6c9ce378fc9828b137d68e9adf5bfd"}]}