)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d1e74602fe5cb046ecc28317d05fa8a581e0c2f3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove the redundance code in HostState.update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The HostState is local variable in HostManager, So the updated is"},{"line_number":10,"context_line":"None for HostState."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I14c2684edf5e9a04c673d039d340afe23e448ff9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"63338ef2_522c92db","line":10,"updated":"2022-12-20 12:47:33.000000000","message":"This doesn\u0027t make sense to me. \u0027updated\u0027 is being set from the value of a ComputeNode object. We seem to be using it to detect whether updates are required or not. Can you clarify this?","commit_id":"12f04a3017aaa5d86729cf640f637f7b0b8d59b5"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"1af32c0672436258c3ba7ab372513421e56862d1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Remove the redundance code in HostState.update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The HostState is local variable in HostManager, So the updated is"},{"line_number":10,"context_line":"None for HostState."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I14c2684edf5e9a04c673d039d340afe23e448ff9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6ec45bd0_a9e8d843","line":10,"in_reply_to":"63338ef2_522c92db","updated":"2022-12-22 08:38:26.000000000","message":"Hi stephenfin, In HostManager._get_host_states method, the host_state_map is None, so we get the HostState object by HostManager.host_state_cls and the initial value of HostState.updated is None.\nthe judge whether updates or not is in HostState._update_from_compute_node, and the method called chain is  \"HostManager._get_host_states--\u003eHostState.update --\u003e HostState._update_from_compute_node\". That is the HostState is local variable in HostManager, and update the HostState by compute_nodes in DB with the \"HostState.updated\u003dNone\".","commit_id":"12f04a3017aaa5d86729cf640f637f7b0b8d59b5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"87284d7911142926d0b14c67bf11bc5c06889729","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c42fc8e0_04bf36e0","updated":"2022-11-14 07:08:19.000000000","message":"recheck","commit_id":"a061c0c63b4adbb6b9b9ca3156c5c2a49d54a1b2"},{"author":{"_account_id":31827,"name":"Jorhson Deng","email":"jorhson_deng@163.com","username":"dengzhaosen"},"change_message_id":"21f767c4abd2ce4ae493ec7b1a1c52d527fe5342","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7ff4000b_8006db17","updated":"2022-11-15 02:18:45.000000000","message":"recheck","commit_id":"12f04a3017aaa5d86729cf640f637f7b0b8d59b5"}]}