)]}'
{"id":"openstack%2Fnova~864671","triplet_id":"openstack%2Fnova~stable%2Ftrain~I2b07fd03fd3ba7662695384940ceda479fcf9f0a","project":"openstack/nova","branch":"stable/train","topic":"bug/1628606","attention_set":{},"removed_from_attention_set":{"34860":{"account":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"last_update":"2022-11-24 04:29:42.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I2b07fd03fd3ba7662695384940ceda479fcf9f0a","subject":"Move pre-3.44 Cinder post live migration test to test_compute_mgr","status":"ABANDONED","created":"2022-11-16 05:44:33.000000000","updated":"2022-11-24 04:29:42.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"404e0404332a6ee05c89fcab37ba98c176d07524","_number":864671,"virtual_id_number":864671,"owner":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2022-11-23 12:07:33.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"all":[{"value":1,"date":"2022-11-23 11:00:41.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"}],"REVIEWER":[{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-16 05:44:33.000000000","updated_by":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"reviewer":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"state":"CC"},{"updated":"2022-11-16 06:34:36.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-23 10:42:02.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"}],"messages":[{"id":"9d83185416b48835d1707ad0b35d91d020e9e161","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-16 05:44:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"250d6aabc82ddfcc355735cb56cc078b61200e18","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-16 05:45:38.000000000","message":"Topic set to bug/1628606/train","accounts_in_message":[],"_revision_number":1},{"id":"35603eb5de15f1bae3fa7fee54fe7569aa37f6b6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-16 06:34:36.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/89796e9796254ac8b3cb8e5868678047\n\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/d5d348acbde843638db34bc13f30661d : SUCCESS in 49m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/30ce5208d44c42deaf1567c2ac2793ba : SUCCESS in 19m 15s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f4cdc8f875e34493a150dbb6f81f82d5 : SUCCESS in 9m 43s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b56952603dc544dab080f9b5097267fc : SUCCESS in 15m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d1968c0c435c46cfa4340b57822c9f60 : SUCCESS in 18m 07s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/72f3530c8cfc4b059a80b0f15411528c : SUCCESS in 18m 17s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c87f0a80bf91435790861b259cf3a528 : SUCCESS in 9m 07s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/0cc4580c96aa4977ad7d6ba567878cfc : SUCCESS in 23m 33s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/f2bce87b559b4411a24730e515746fa4 : SUCCESS in 21m 55s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/1ec93bb52994457e9e22d651f0d9f4a2 : SUCCESS in 5m 06s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"3adab76dc3969324fc2d9a9dd746ff0275e7c9c2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-23 09:57:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"81a92918130ef5dddf51ef2c855cd1c2ac598811","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-11-23 10:42:02.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"2908793b0bc81777aaf1b7a8b34a0eb5531b1609","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-23 10:46:12.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"ae4f3a02bbdab65a02a267e3fd63227e5b407dd3","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-23 11:00:41.000000000","message":"Uploaded patch set 4: New patch set was added with same tree, parent, and commit message as Patch Set 3.","accounts_in_message":[],"_revision_number":4},{"id":"95ca1124c587de244865e7b22b64cefcb9f9ead6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-23 12:07:33.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/204efc34ed23448ebd721508444ea901\n\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/a4c636e92b3b4386bb6d92c79918ea19 : SUCCESS in 58m 02s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9439ba6da1444be8b6b81782e13b96ac : SUCCESS in 17m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e535c017e03a4b7abef22e62ffd59345 : SUCCESS in 9m 34s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/35135e3fd8cb421c856adcb940697371 : SUCCESS in 12m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d69b85c710b4497bac8429c31b4bdff3 : SUCCESS in 14m 28s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f29bf831d93b400facdc5c9a90af1386 : SUCCESS in 13m 01s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/9507e946ebd941aaac5f8823ac724ce5 : SUCCESS in 10m 35s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/6f421afbaefb49199a3ce91fe919c92d : FAILURE in 19m 22s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/db50c10174b0481488c5c17ecf99013a : SUCCESS in 17m 05s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/0fcba68a33644cbfaaa57824b4641458 : SUCCESS in 4m 18s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"404e0404332a6ee05c89fcab37ba98c176d07524","tag":"autogenerated:gerrit:abandon","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-24 04:29:42.000000000","message":"Abandoned\n\nAdded because I thought its a good idea to have more test cases, abandoning, because its not really required from backport perspective","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"afb063c33cedeaab3271cec7d7509d0bb06e0efc","revisions":{"f68899fc24248adf67c26d56e9b720c2a150eb6d":{"kind":"REWORK","_number":1,"created":"2022-11-16 05:44:33.000000000","uploader":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"ref":"refs/changes/71/864671/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/71/864671/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/71/864671/1"}}},"commit":{"parents":[{"commit":"be21e9faaff86a48b006a93e1c8561415b78e49a","subject":"Refactor volume connection cleanup out of _post_live_migration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/be21e9faaff86a48b006a93e1c8561415b78e49a"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-09-20 17:06:56.000000000","tz":-240},"committer":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2022-11-16 05:41:20.000000000","tz":0},"subject":"Move pre-3.44 Cinder post live migration test to test_compute_mgr","message":"Move pre-3.44 Cinder post live migration test to test_compute_mgr\n\nThe previous patch (Id0e8b1c32600d53382e5ac938e403258c80221a0) created\n_post_live_migration_remove_source_vol_connections() in an attempt to\nsplit out _post_live_migration() into smaller more self-contained\nmethods. The test for the pre-3.44 Cinder API behavior was kept in\ntest_compute. test_compute runs API and compute services and\nuses the database, and therefore should not receive new tests. Compute\nAPI tests should go in test_compute_api, compute manager tests in\ntest_compute_mgr and anything that needs a running service and/or\ndatabase should go under functional/. While there will be no concerted\neffort to \"convert\" test_compute (like for mox -\u003e mock), it\u0027s still\ngood to do it when the opportunity arises. In addition, having unit\ntests for two branches of the same method in different files is just\nconfusing. This patch removes the pre-3.44 Cinder API unit test from\ntest_compute and adds a new one right above the existing test for\npost-3.44 Cinder API behavior in test_compute_mgr.\n\nChange-Id: I2b07fd03fd3ba7662695384940ceda479fcf9f0a\n(cherry picked from commit cfb283cdd0fd016bc8151a5122b7b1f581203c34)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f68899fc24248adf67c26d56e9b720c2a150eb6d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f68899fc24248adf67c26d56e9b720c2a150eb6d"}]},"branch":"refs/heads/stable/train"},"645af0a6715457970a8e9b1670f174d54e9ff651":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2022-11-23 09:57:31.000000000","uploader":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"ref":"refs/changes/71/864671/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/71/864671/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/71/864671/2"}}},"commit":{"parents":[{"commit":"2b4b457d41bdf4417a88d3210c681aa4d99ed667","subject":"Refactor volume connection cleanup out of _post_live_migration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b4b457d41bdf4417a88d3210c681aa4d99ed667"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-09-20 17:06:56.000000000","tz":-240},"committer":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2022-11-23 09:54:43.000000000","tz":0},"subject":"Move pre-3.44 Cinder post live migration test to test_compute_mgr","message":"Move pre-3.44 Cinder post live migration test to test_compute_mgr\n\nThe previous patch (Id0e8b1c32600d53382e5ac938e403258c80221a0) created\n_post_live_migration_remove_source_vol_connections() in an attempt to\nsplit out _post_live_migration() into smaller more self-contained\nmethods. The test for the pre-3.44 Cinder API behavior was kept in\ntest_compute. test_compute runs API and compute services and\nuses the database, and therefore should not receive new tests. Compute\nAPI tests should go in test_compute_api, compute manager tests in\ntest_compute_mgr and anything that needs a running service and/or\ndatabase should go under functional/. While there will be no concerted\neffort to \"convert\" test_compute (like for mox -\u003e mock), it\u0027s still\ngood to do it when the opportunity arises. In addition, having unit\ntests for two branches of the same method in different files is just\nconfusing. This patch removes the pre-3.44 Cinder API unit test from\ntest_compute and adds a new one right above the existing test for\npost-3.44 Cinder API behavior in test_compute_mgr.\n\nPartial-Bug: #1628606\n\nChange-Id: I2b07fd03fd3ba7662695384940ceda479fcf9f0a\n(cherry picked from commit cfb283cdd0fd016bc8151a5122b7b1f581203c34)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/645af0a6715457970a8e9b1670f174d54e9ff651"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/645af0a6715457970a8e9b1670f174d54e9ff651"}]},"branch":"refs/heads/stable/train"},"59dd7506f7e5950b35dfd842b13ff8cbfe5233fb":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2022-11-23 10:46:12.000000000","uploader":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"ref":"refs/changes/71/864671/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/71/864671/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/71/864671/3"}}},"commit":{"parents":[{"commit":"ae394349f7f929238a4c3e2e063632e553b4612d","subject":"Refactor volume connection cleanup out of _post_live_migration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ae394349f7f929238a4c3e2e063632e553b4612d"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-09-20 17:06:56.000000000","tz":-240},"committer":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2022-11-23 10:41:03.000000000","tz":0},"subject":"Move pre-3.44 Cinder post live migration test to test_compute_mgr","message":"Move pre-3.44 Cinder post live migration test to test_compute_mgr\n\nThe previous patch (Id0e8b1c32600d53382e5ac938e403258c80221a0) created\n_post_live_migration_remove_source_vol_connections() in an attempt to\nsplit out _post_live_migration() into smaller more self-contained\nmethods. The test for the pre-3.44 Cinder API behavior was kept in\ntest_compute. test_compute runs API and compute services and\nuses the database, and therefore should not receive new tests. Compute\nAPI tests should go in test_compute_api, compute manager tests in\ntest_compute_mgr and anything that needs a running service and/or\ndatabase should go under functional/. While there will be no concerted\neffort to \"convert\" test_compute (like for mox -\u003e mock), it\u0027s still\ngood to do it when the opportunity arises. In addition, having unit\ntests for two branches of the same method in different files is just\nconfusing. This patch removes the pre-3.44 Cinder API unit test from\ntest_compute and adds a new one right above the existing test for\npost-3.44 Cinder API behavior in test_compute_mgr.\n\nPartial-Bug: #1628606\n\nChange-Id: I2b07fd03fd3ba7662695384940ceda479fcf9f0a\n(cherry picked from commit cfb283cdd0fd016bc8151a5122b7b1f581203c34)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/59dd7506f7e5950b35dfd842b13ff8cbfe5233fb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/59dd7506f7e5950b35dfd842b13ff8cbfe5233fb"}]},"branch":"refs/heads/stable/train"},"afb063c33cedeaab3271cec7d7509d0bb06e0efc":{"kind":"NO_CHANGE","_number":4,"created":"2022-11-23 11:00:41.000000000","uploader":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"ref":"refs/changes/71/864671/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/71/864671/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/71/864671/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/71/864671/4"}}},"commit":{"parents":[{"commit":"3025f6521f5ddbe4c4e5741a99a77448baf3b2b6","subject":"Refactor volume connection cleanup out of _post_live_migration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3025f6521f5ddbe4c4e5741a99a77448baf3b2b6"}]}],"author":{"name":"Artom Lifshitz","email":"alifshit@redhat.com","date":"2019-09-20 17:06:56.000000000","tz":-240},"committer":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2022-11-23 10:59:41.000000000","tz":0},"subject":"Move pre-3.44 Cinder post live migration test to test_compute_mgr","message":"Move pre-3.44 Cinder post live migration test to test_compute_mgr\n\nThe previous patch (Id0e8b1c32600d53382e5ac938e403258c80221a0) created\n_post_live_migration_remove_source_vol_connections() in an attempt to\nsplit out _post_live_migration() into smaller more self-contained\nmethods. The test for the pre-3.44 Cinder API behavior was kept in\ntest_compute. test_compute runs API and compute services and\nuses the database, and therefore should not receive new tests. Compute\nAPI tests should go in test_compute_api, compute manager tests in\ntest_compute_mgr and anything that needs a running service and/or\ndatabase should go under functional/. While there will be no concerted\neffort to \"convert\" test_compute (like for mox -\u003e mock), it\u0027s still\ngood to do it when the opportunity arises. In addition, having unit\ntests for two branches of the same method in different files is just\nconfusing. This patch removes the pre-3.44 Cinder API unit test from\ntest_compute and adds a new one right above the existing test for\npost-3.44 Cinder API behavior in test_compute_mgr.\n\nPartial-Bug: #1628606\n\nChange-Id: I2b07fd03fd3ba7662695384940ceda479fcf9f0a\n(cherry picked from commit cfb283cdd0fd016bc8151a5122b7b1f581203c34)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/afb063c33cedeaab3271cec7d7509d0bb06e0efc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/afb063c33cedeaab3271cec7d7509d0bb06e0efc"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}