)]}'
{"id":"openstack%2Fnova~864721","triplet_id":"openstack%2Fnova~stable%2Ftrain~Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f","project":"openstack/nova","branch":"stable/train","topic":"bug/1978983","attention_set":{},"removed_from_attention_set":{"15334":{"account":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"last_update":"2022-11-17 13:36:14.000000000","reason":"Reviewer/Cc was removed"},"34860":{"account":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"last_update":"2022-11-17 13:38:38.000000000","reason":"\u003cGERRIT_ACCOUNT_34860\u003e replied on the change","reason_account":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"}}},"hashtags":[],"change_id":"Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f","subject":"functional: Rework \u0027_delete_server\u0027","status":"ABANDONED","created":"2022-11-16 10:17:02.000000000","updated":"2022-11-25 09:40:57.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5bb68a1ae567d78187f51364ea799d1c1d12ef25","_number":864721,"virtual_id_number":864721,"owner":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2022-11-17 14:26:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2022-11-17 13:38:38.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-16 10:17:02.000000000","updated_by":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2022-11-16 11:05:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-17 13:36:14.000000000","updated_by":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"CC"}],"messages":[{"id":"c84fe9f00b67be03da82f59fa9252071e75e082f","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-16 10:17:02.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"acf04a905ed37a8fc8a445c87f9fea0460a7cedb","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-16 11:05:35.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/01f204d321d74154abaa806fdb651f62\n\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f5c3dc49b62f4849b10eeee5d20079ab : SUCCESS in 47m 43s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ba48c7530b1b4aafa73eedfe5277eb63 : SUCCESS in 15m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/17e2a81dd6424c17a86ccc344431be6c : SUCCESS in 9m 54s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/5c1007b56b084476b4c5b3149795442b : SUCCESS in 13m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fad205f3b0c142d085725b5622730fd8 : SUCCESS in 11m 29s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/aadfb6d838df4c75911ae09e6c49d877 : SUCCESS in 12m 22s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b7b58b29afc74419ba93a8dd5f0fed7d : SUCCESS in 10m 24s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/fabd2e226232490fa113a9ecb2373cf3 : FAILURE in 19m 08s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/0c29e6715ae44aa69ddd1e9624a570b7 : FAILURE in 15m 05s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/4a2c28add96f47a7b0b2a66702bbe2c5 : SUCCESS in 4m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"0e5df327917e79f2d826816d2d889e07aeca140d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-17 13:36:14.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d76bee269a0484c33a21ffe3761037cabebbdcb0","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-17 13:38:38.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"c85f49e12e843c1c0381edca72b6332b1c67ed33","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-17 14:26:32.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/07c0774390244505860c16010206df8e\n\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/da1740714a5c47e0bde508ac710fe0e8 : SUCCESS in 48m 32s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/74c77c52ac4243f1a3ef96dc7469693a : SUCCESS in 15m 04s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/fb8321dd52fe48429a3af61a71cf1b4a : SUCCESS in 9m 55s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/61a1b93558534242b7f10f683a1305bd : SUCCESS in 12m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ecffaf12a1ba4a7ea050461b551aefc6 : SUCCESS in 12m 20s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/db26e3bfb56743ce89006402d007b4ce : SUCCESS in 11m 30s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/062a83f30b894220b503b3f274d88d79 : SUCCESS in 11m 17s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/99c29eeb0168406a9c0ca4eeccab1521 : SUCCESS in 16m 51s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/718de8bfc4cd407194e660d4b8a90cf6 : SUCCESS in 15m 46s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/e4a3011237754b65bc69e411b1f130c1 : SUCCESS in 4m 17s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"5bb68a1ae567d78187f51364ea799d1c1d12ef25","tag":"autogenerated:gerrit:abandon","author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"date":"2022-11-25 09:40:57.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1cd02cba257edf6452604ffab27efda9230298f6","revisions":{"d04ab080af1a725872519a5daaac6d8ea243424d":{"kind":"REWORK","_number":1,"created":"2022-11-16 10:17:02.000000000","uploader":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"ref":"refs/changes/21/864721/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/864721/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/864721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/864721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/864721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/864721/1"}}},"commit":{"parents":[{"commit":"097a21821874b3934412676ae5c7009b061e563d","subject":"functional: Change order of two classes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/097a21821874b3934412676ae5c7009b061e563d"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-11 09:25:45.000000000","tz":60},"committer":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2022-11-16 10:16:05.000000000","tz":0},"subject":"functional: Rework \u0027_delete_server\u0027","message":"functional: Rework \u0027_delete_server\u0027\n\nWe want \u0027ServerBase\u0027 to inherit from \u0027InstanceHelperMixin\u0027. They both\nhave implementations of a \"wait until server is deleted\" function.  The\n\u0027ServerBase\u0027 implementation is called \u0027_wait_for_deletion\u0027 and takes a\n\u0027server_id\u0027, while the \u0027InstanceHelperMixin\u0027 implementation is called\n\u0027_wait_until_deleted\u0027 and takes a full server JSON-y dict. A later\nchange, I0c56841d098d3e9d72db65be3143f3c893f0b6ba, will rework the\n\u0027ServersTestBase\u0027 version to bring it inline with \u0027InstanceHelperMixin\u0027\nversion. However, \u0027ServerBase._delete_server\u0027 currently calls a\n\u0027_wait_for_deletion\u0027 function and passes it a \u0027server_id\u0027. As such,\n\u0027_delete_server\u0027 itself is only passed a server_id. After the future\nchange, this \u0027server_id\u0027 will no longer be enough as \u0027_delete_server\u0027\nwill need to call the newly merged \u0027_wait_until_deleted\u0027 that takes a\nfull server JSON-y dict, so \u0027_delete_server\u0027 itself needs to receive a\nfull server JSON-y dict.\n\nDo this work now to simplify the future patch.\n\nChange-Id: Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n(cherry picked from commit 57f335090b9e56d764c02705a42ce2d3690d8955)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d04ab080af1a725872519a5daaac6d8ea243424d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d04ab080af1a725872519a5daaac6d8ea243424d"}]},"branch":"refs/heads/stable/train"},"1cd02cba257edf6452604ffab27efda9230298f6":{"kind":"REWORK","_number":2,"created":"2022-11-17 13:36:14.000000000","uploader":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"ref":"refs/changes/21/864721/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/864721/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/864721/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/864721/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/864721/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/864721/2"}}},"commit":{"parents":[{"commit":"c70b3810da3e1d5a428c380ec71be64c419eb25f","subject":"functional: Change order of two classes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c70b3810da3e1d5a428c380ec71be64c419eb25f"}]}],"author":{"name":"Stephen Finucane","email":"sfinucan@redhat.com","date":"2019-10-11 09:25:45.000000000","tz":60},"committer":{"name":"Amit Uniyal","email":"auniyal@redhat.com","date":"2022-11-17 13:29:10.000000000","tz":0},"subject":"functional: Rework \u0027_delete_server\u0027","message":"functional: Rework \u0027_delete_server\u0027\n\nWe want \u0027ServerBase\u0027 to inherit from \u0027InstanceHelperMixin\u0027. They both\nhave implementations of a \"wait until server is deleted\" function.  The\n\u0027ServerBase\u0027 implementation is called \u0027_wait_for_deletion\u0027 and takes a\n\u0027server_id\u0027, while the \u0027InstanceHelperMixin\u0027 implementation is called\n\u0027_wait_until_deleted\u0027 and takes a full server JSON-y dict. A later\nchange, I0c56841d098d3e9d72db65be3143f3c893f0b6ba, will rework the\n\u0027ServersTestBase\u0027 version to bring it inline with \u0027InstanceHelperMixin\u0027\nversion. However, \u0027ServerBase._delete_server\u0027 currently calls a\n\u0027_wait_for_deletion\u0027 function and passes it a \u0027server_id\u0027. As such,\n\u0027_delete_server\u0027 itself is only passed a server_id. After the future\nchange, this \u0027server_id\u0027 will no longer be enough as \u0027_delete_server\u0027\nwill need to call the newly merged \u0027_wait_until_deleted\u0027 that takes a\nfull server JSON-y dict, so \u0027_delete_server\u0027 itself needs to receive a\nfull server JSON-y dict.\n\nDo this work now to simplify the future patch.\n\nRelated-Bug: #1978983\n\nChange-Id: Iceafa5ff2b7abff7c6d974ba49036ef03fb1c85f\nSigned-off-by: Stephen Finucane \u003csfinucan@redhat.com\u003e\n(cherry picked from commit 57f335090b9e56d764c02705a42ce2d3690d8955)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1cd02cba257edf6452604ffab27efda9230298f6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1cd02cba257edf6452604ffab27efda9230298f6"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[]}