)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b3abbb82770fc84192ded2f168133642359758d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"763d09ab_8be96176","updated":"2022-11-24 17:41:50.000000000","message":"overall looks OK I just have a request for explanation inline.","commit_id":"7c53f241db38d76713b1c9d12f524ff0cee0f4b3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"2f21ed448d634839b4ebb86962ea590c5b3485b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0dd7db7d_c8017d53","updated":"2022-12-02 08:26:48.000000000","message":"recheck ceph timeout","commit_id":"a340630c5c78e5f5856004d0a551dfa93df7f28d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"7fb03881ad9307c83da3dce38d32c596ac0939da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7e78811f_f6bec9b3","updated":"2022-12-02 10:24:19.000000000","message":"recheck post failure on functests","commit_id":"a340630c5c78e5f5856004d0a551dfa93df7f28d"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b3abbb82770fc84192ded2f168133642359758d7","unresolved":false,"context_lines":[{"line_number":10983,"context_line":"                        \u0027pci_slot\u0027: \u00270000:01:00\u0027,"},{"line_number":10984,"context_line":"                        \u0027pci_vendor_info\u0027: \u00278086:154d\u0027,"},{"line_number":10985,"context_line":"                        \u0027physical_network\u0027: \u0027physnet2\u0027,"},{"line_number":10986,"context_line":"                        \u0027device_mac_address\u0027: \u0027b4:96:91:34:f4:36\u0027"},{"line_number":10987,"context_line":"                    },"},{"line_number":10988,"context_line":"                ),"},{"line_number":10989,"context_line":"            ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"c3fba6d5_4eb4ec3d","line":10986,"updated":"2022-11-24 17:41:50.000000000","message":"This is interesting. This was not in the yoga version https://review.opendev.org/c/openstack/nova/+/855023/4/nova/tests/unit/compute/test_compute_mgr.py#11012 But probably not wrong to have it.","commit_id":"7c53f241db38d76713b1c9d12f524ff0cee0f4b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"59b6916606ca10c44bf1e3fedbea52bee215b468","unresolved":true,"context_lines":[{"line_number":10983,"context_line":"                        \u0027pci_slot\u0027: \u00270000:01:00\u0027,"},{"line_number":10984,"context_line":"                        \u0027pci_vendor_info\u0027: \u00278086:154d\u0027,"},{"line_number":10985,"context_line":"                        \u0027physical_network\u0027: \u0027physnet2\u0027,"},{"line_number":10986,"context_line":"                        \u0027device_mac_address\u0027: \u0027b4:96:91:34:f4:36\u0027"},{"line_number":10987,"context_line":"                    },"},{"line_number":10988,"context_line":"                ),"},{"line_number":10989,"context_line":"            ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"785ed442_77bb13be","line":10986,"in_reply_to":"c3fba6d5_4eb4ec3d","updated":"2022-11-24 18:09:38.000000000","message":"same as my comment on the next page this is commeing form the vpd test updates for off path network backends.\n\ni proably dont need this but the unit and fucntional tests for that feature and this are stongly related and it got pulled in. wehn i was resoveing the merge conflicts.\n\nbasically i dropped the card cerial number bits but kept the device_mac_addrss bits that were related to this patch.\n\nthe vpd feature add the serial number and pf mac adress to the profiel as well.\n\nill see if i can find that commit and refernce it in the commit message","commit_id":"7c53f241db38d76713b1c9d12f524ff0cee0f4b3"}],"nova/tests/unit/network/test_neutron.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b3abbb82770fc84192ded2f168133642359758d7","unresolved":true,"context_lines":[{"line_number":7764,"context_line":"            side_effect\u003dexception.PciDeviceNotFoundById(id\u003d\u00270000:0a:00.1\u0027))"},{"line_number":7765,"context_line":"    )"},{"line_number":7766,"context_line":"    @mock.patch.object(pci_whitelist.Whitelist, \u0027get_devspec\u0027)"},{"line_number":7767,"context_line":"    def test__get_pci_device_profile_pf(self, mock_get_pci_device_devspec):"},{"line_number":7768,"context_line":"        devspec \u003d mock.Mock()"},{"line_number":7769,"context_line":"        devspec.get_tags.return_value \u003d {\u0027physical_network\u0027: \u0027physnet1\u0027}"},{"line_number":7770,"context_line":"        mock_get_pci_device_devspec.return_value \u003d devspec"}],"source_content_type":"text/x-python","patch_set":4,"id":"d9917140_ff39f8f2","line":7767,"updated":"2022-11-24 17:41:50.000000000","message":"this is pretty different from the yoga version. This probably needs to be explained in the commit message.","commit_id":"7c53f241db38d76713b1c9d12f524ff0cee0f4b3"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"59b6916606ca10c44bf1e3fedbea52bee215b468","unresolved":true,"context_lines":[{"line_number":7764,"context_line":"            side_effect\u003dexception.PciDeviceNotFoundById(id\u003d\u00270000:0a:00.1\u0027))"},{"line_number":7765,"context_line":"    )"},{"line_number":7766,"context_line":"    @mock.patch.object(pci_whitelist.Whitelist, \u0027get_devspec\u0027)"},{"line_number":7767,"context_line":"    def test__get_pci_device_profile_pf(self, mock_get_pci_device_devspec):"},{"line_number":7768,"context_line":"        devspec \u003d mock.Mock()"},{"line_number":7769,"context_line":"        devspec.get_tags.return_value \u003d {\u0027physical_network\u0027: \u0027physnet1\u0027}"},{"line_number":7770,"context_line":"        mock_get_pci_device_devspec.return_value \u003d devspec"}],"source_content_type":"text/x-python","patch_set":4,"id":"0cb8b2b5_8ea7a6a9","line":7767,"in_reply_to":"d9917140_ff39f8f2","updated":"2022-11-24 18:09:38.000000000","message":"ya this is becasue\nhttps://review.opendev.org/c/openstack/nova/+/864931 is not xena if i rememebr correctly\n\nnot nessisarly that patch specifically but this is related to the vpd feature.\nfor off path acclerators thats where the card_serial bit below are coming form \ni shoudl probablk remove this as that feature is not in xena.","commit_id":"7c53f241db38d76713b1c9d12f524ff0cee0f4b3"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b3abbb82770fc84192ded2f168133642359758d7","unresolved":false,"context_lines":[{"line_number":7845,"context_line":"        pci_dev \u003d {\u0027vendor_id\u0027: \u00271377\u0027,"},{"line_number":7846,"context_line":"                   \u0027product_id\u0027: \u00270047\u0027,"},{"line_number":7847,"context_line":"                   \u0027address\u0027: \u00270000:0a:00.1\u0027,"},{"line_number":7848,"context_line":"                   \u0027dev_type\u0027: \u0027type-VF\u0027"},{"line_number":7849,"context_line":"                  }"},{"line_number":7850,"context_line":""},{"line_number":7851,"context_line":"        whitelist \u003d pci_whitelist.Whitelist(CONF.pci.passthrough_whitelist)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fdf1c3f3_28587c8f","line":7848,"updated":"2022-11-24 17:41:50.000000000","message":"As far as I see this is from the VPD feature probably not needed here but not wrong either.","commit_id":"7c53f241db38d76713b1c9d12f524ff0cee0f4b3"}]}