)]}'
{"id":"openstack%2Fnova~864934","triplet_id":"openstack%2Fnova~stable%2Fxena~I3998d0d49583806ac1c3ae64f1b1fe343cefd20d","project":"openstack/nova","branch":"stable/xena","topic":"bug/1970467","attention_set":{},"removed_from_attention_set":{"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2022-12-05 17:04:05.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I3998d0d49583806ac1c3ae64f1b1fe343cefd20d","subject":"Remove double mocking","status":"MERGED","created":"2022-11-17 19:08:21.000000000","updated":"2022-12-05 17:04:05.000000000","submitted":"2022-12-05 17:04:05.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":1,"has_review_started":true,"submission_id":"864934-bug/1970467","meta_rev_id":"1bd1417552ee1c211fd6b225d7f716bd2597c181","_number":864934,"virtual_id_number":864934,"owner":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-12-05 17:04:05.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-12-01 18:14:33.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":2,"date":"2022-12-02 08:27:25.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":1,"date":"2022-12-02 08:27:25.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-17 19:08:21.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"CC"},{"updated":"2022-11-17 19:22:39.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2022-11-17 19:40:31.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-24 17:43:25.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2022-12-01 18:14:33.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"CC"},{"updated":"2022-12-02 08:27:25.000000000","updated_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"reviewer":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"state":"REVIEWER"}],"messages":[{"id":"ebd429f1474ce501c6828ae8aa5a556c46ea7bf0","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-11-17 19:08:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f88ac6a6dce1578a087471c971c966a52b9f4596","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-17 19:22:39.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/5b2a390fa2434dcf9d18fb44d686be18\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/d90ad87ba9804a9fb45cac6b873779d2 : FAILURE in 9m 19s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/6760d64c612a4a0db5ebceb97067b9f3 : FAILURE in 12m 18s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"ab74b00aeb981fa8f091b769ec6664df7a467bd7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-17 19:40:31.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/48599abee20d47b8bb82accd1e77452d\n\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/2c9bc8ce1ec840548b837515ac075cab : FAILURE in 26m 06s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/97ea72e6dc6c48cfb0d3e24f2c808692 : FAILURE in 6m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/acee182d7e944fe1b826cfcdf4b2a9ac : SUCCESS in 7m 45s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/595de97ff08c4e3fa20adb197373b0ed : FAILURE in 6m 57s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/219705aee8584cef85b6d7172e0f5fdd : FAILURE in 6m 19s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/50737bf384164ef39e7c3e22615a063a : FAILURE in 6m 27s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/91775d9c475745afabacb360823fc1a9 : SUCCESS in 9m 17s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/bb2846ecbbfc4f528c5f2fab085e9cf8 : FAILURE in 6m 26s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/d2af88fcda154066ab377100448d2687 : FAILURE in 20m 27s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/74dd25de9c704c4d89c060438f08c42f : FAILURE in 20m 26s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/3e85709b03cd4c5f8adca0f803293837 : FAILURE in 21m 57s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"252a38475e549622ef487a08c83ff92c5d103ff6","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-11-18 11:44:15.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"0636351eaedd9658ada09dd50a34c39ee1f9beb3","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-18 12:08:57.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/7c9b266a5bd44dba8972c80011b64b75\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/5097a576ec374d71a6c1f2998d4759cf : FAILURE in 11m 12s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/eb098af991da4d4d9a65af8374c75611 : FAILURE in 15m 44s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c59f926ccfed9cf57dcb13b5c0ecef03e7d09709","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-11-18 12:12:05.000000000","message":"Uploaded patch set 3: New patch set was added with same tree, parent, and commit message as Patch Set 2.","accounts_in_message":[],"_revision_number":3},{"id":"90f7c68d3df3f03a5a97bec0e4152823035784a8","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-18 12:28:58.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/15c06b7c72074812b4cd91c1d2cafe73\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/7e7c410e134c432eb966108f74d570e3 : FAILURE in 11m 11s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/94623dc90b634a11884cca564b782c99 : FAILURE in 14m 48s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"761bf790e36b2fe76065807eaa8d09d0cdfd1ede","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-18 12:39:35.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/cff290d030a5447b9fb1bf7f0b624801\n\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/055a430513d04df4b8f61d197b851cce : FAILURE in 26m 20s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b530e017aea245368392a48fef3ffa52 : FAILURE in 7m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c86ff5f6e6314b02aeb8e92ac61ab0c9 : FAILURE in 7m 09s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9b2e6a0c3d0b4189990b7eed2fdf21df : FAILURE in 5m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9c6c0d5588ea4af8a4598b2ff424693b : FAILURE in 5m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/4b1884e5ce0648c195f50141ca96c9c3 : FAILURE in 6m 55s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a84c29056aa648bb8e08caaace3eecb5 : SUCCESS in 9m 32s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/7b0517782cbd43a5b0f33bb3741058de : FAILURE in 5m 57s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/916f59376000499a984c7819581c32e8 : FAILURE in 17m 45s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/ffcf0fd5c7f2402180823a28fbaf619a : FAILURE in 17m 29s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/9ff7bfa5161c4235a92617edf8a90064 : FAILURE in 18m 20s (non-voting)\n\nWarning:\n  Comments left for invalid file nova/tests/functional/libvirt/test_pci_sriov_servers.py","accounts_in_message":[],"_revision_number":3},{"id":"62f2f5d9ca5c12ae2bb89564b14dc98ae6d733d2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-11-21 17:08:27.000000000","message":"Uploaded patch set 4: Patch Set 3 was rebased.","accounts_in_message":[],"_revision_number":4},{"id":"03d1ae94d50fbf3fadec7580a90e2751b897bc7e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-21 17:26:15.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/051840d6c85a47afacf0f50570685f9f\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/8f3c1f5ecff54c86a1fe7628c6fcce8a : FAILURE in 7m 39s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/8c749d83af874b8ebad42be9f38791e0 : FAILURE in 15m 36s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"11cacfdd2c46bdd89848435b90fe821fd900eae6","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-21 17:34:49.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/0d814f04ccaf4237b140cffa4a1aa6e7\n\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/e63a4c4d714a49588af8a6d7ab1ff31c : FAILURE in 25m 17s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ee83bb6e2d454f3c9b3f104ed97c6f9c : FAILURE in 6m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f92947b1d8e3489b98b618b128d7865e : SUCCESS in 8m 24s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/34e462947b0c41c389c7ab0a8b7b9def : FAILURE in 6m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3c76c5f2526e4fbab22898bc68770a7a : FAILURE in 6m 09s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/5521e89a5573425084ec84833b6c9716 : FAILURE in 6m 32s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c71a3ff0a1c54ede8740897a18af444c : SUCCESS in 9m 45s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/dea5d3113cc94d9d859127a7dce8e2cf : FAILURE in 5m 55s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/40aee6df8ae647728414301c0810b22b : SUCCESS in 18m 07s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/ee1debf9056549f2905ccadda470b3d1 : SUCCESS in 18m 47s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/01da70b8e73a493ab3153cb955094baf : SUCCESS in 18m 23s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"fce372576baa0d9581b7dd24f9d94f5a09a7a1e7","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-11-21 17:41:25.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"6f5924984b05f5596fc09930227ad7a23c80158a","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-11-21 17:41:52.000000000","message":"Patch Set 4: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"08ed8fa72e71d97f55b43e55242e843a396afeba","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-11-22 11:54:07.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"17787169e9fd93bbdfab6bf7dc50e0ae4f3819d2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-22 12:23:40.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1adf54a6fcea4553a1a2ca968a4d10f7\n\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/a1a631fce96b4acc899dcb50f27a5424 : FAILURE in 21m 20s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/357bd75d362f482ebcb76ec6fd1e65b5 : SUCCESS in 15m 07s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a7220a3e6c7e4099bb647515189d4b73 : SUCCESS in 7m 50s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c8d2c5559c6a4bd5949bf3b814948a75 : SUCCESS in 10m 22s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ebd933201bfe4e568238b861f841a000 : SUCCESS in 11m 12s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/9a1a6e89a614439db78d8501f17daa00 : SUCCESS in 11m 45s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a08a0c8a7083448788568c3d5ba3c263 : SUCCESS in 8m 22s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/b1bfdfbd21e944aeb2b8ce74796c6a81 : FAILURE in 6m 30s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/42091127149a49b8980dc65ace72c30f : SUCCESS in 22m 15s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/917eb08321ad4caa9e5245b243e26a6e : SUCCESS in 16m 51s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d0e5903000db47cc9d185a9e9eff5521 : SUCCESS in 17m 14s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"834afd8914886eb76dc04d60a56e0fa2253ed535","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-22 12:31:53.000000000","message":"Patch Set 5:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/60313a96ea4d4ca4a579347b8cd3236a\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/56b6f8ffb990417ab22d63dc0ca6c49c : SUCCESS in 25m 52s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/7e422db63230469ca96686b1319dcd6f : SUCCESS in 29m 51s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"0946b0df40362225ae0a668119649cff4866d5a2","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-11-24 17:43:25.000000000","message":"Patch Set 5: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"4e2f1a66cc11629e77d6b62d1b536a4a4913b55d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-12-01 18:14:33.000000000","message":"Uploaded patch set 6: New patch set was added with same tree, parent, and commit message as Patch Set 5.","accounts_in_message":[],"_revision_number":6},{"id":"75631a326f952080eab6ae3812bf8363328ee839","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-01 18:44:08.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/ff9132cf57a44ea289b8e5b7e0a5dc31\n\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/d5384b64480946d89c3a98ac87ccb49a : FAILURE in 27m 41s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4613869fbcc74b139a974a6f1b93b823 : SUCCESS in 16m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3d2b71fdf42a49299ba13dbc60022ec4 : SUCCESS in 8m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/a3e345d26a564bb4b5604c3d4977fc87 : SUCCESS in 14m 46s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/337918b0e4694061a2dc1b228a0f0c81 : SUCCESS in 14m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c8ab6a667ae149148996ce92a242cfcf : SUCCESS in 15m 22s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/cfe53308982c4ea1b7beac9da5849198 : SUCCESS in 10m 14s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/61effd9c7d1f42fe8ce15c5bc3cc47de : SUCCESS in 6m 35s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/20bdea2a2d214b999dc3404a665463a3 : SUCCESS in 18m 57s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/a4b1d164dc924eb9a60ccbe0d34d2d5e : SUCCESS in 20m 23s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/cdd88f2e0e584cdea75ef5b60f362d09 : SUCCESS in 18m 31s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"9dd94d051696465eaf6cee1d0ee6d1907d4e1ec9","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-01 19:22:05.000000000","message":"Patch Set 6:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/1b9130c7d1f54ab9ae60d5482868eebf\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/8cde993ec7b44c28b64d23e5392a1bdb : SUCCESS in 24m 56s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/ee4e947328ff4c8aaff00f24ce120937 : SUCCESS in 40m 07s (non-voting)","accounts_in_message":[],"_revision_number":6},{"id":"ee7039fc22233848844eb247d92ef10669c8101e","author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"date":"2022-12-02 08:27:25.000000000","message":"Patch Set 6: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":6},{"id":"a3d92ce3f27ac8e1eee24461bd9644e76707cc13","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-05 15:25:20.000000000","message":"Patch Set 6: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":6},{"id":"d51c5125da21c74615d1525253263ab336b116fb","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-05 17:04:05.000000000","message":"Patch Set 6: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/4e858b80328a4a1fa04f051601e80997\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/04ce897dd0b84ed782123be441d77f8f : SUCCESS in 8m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c614bbbf1d294ef485200baced815296 : SUCCESS in 11m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/258e7c98c6dc4f5ab8cbf7db391873af : SUCCESS in 12m 35s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7314c1a1f20f41ec85a880620d633b56 : SUCCESS in 9m 04s\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/52cb1e2a61dd46ffbdc14f2fede9b00a : SUCCESS in 22m 11s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/daf4bb50b5d944c9b9afe5915a1e7151 : SUCCESS in 19m 11s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/d1ad972224824c5b862ee03f169c7880 : SUCCESS in 5m 55s","accounts_in_message":[],"_revision_number":6},{"id":"1bd1417552ee1c211fd6b225d7f716bd2597c181","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-05 17:04:05.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"54c7c97cb83609cbcba44856d412dae11fe8643b","revisions":{"2a9baccf83a6877b85a108ea5fc373feb82d5da8":{"kind":"REWORK","_number":1,"created":"2022-11-17 19:08:21.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/34/864934/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/864934/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/864934/1"}}},"commit":{"parents":[{"commit":"e33c1c736358127976a7de3ffc9ded33602e4f25","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e33c1c736358127976a7de3ffc9ded33602e4f25"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-11-17 19:00:29.000000000","tz":0},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nConflicts:\n    nova/tests/unit/api/openstack/compute/test_limits.py\n    nova/tests/unit/virt/libvirt/volume/test_lightos.py\n    nova/tests/unit/virt/test_block_device.py\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n(cherry picked from commit f8cf050a1380ae844e0184ed45f4a04fde3b07a9)\n(cherry picked from commit b40bd1bf52c87c31e18caf85d79dd03da6c7cffc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a9baccf83a6877b85a108ea5fc373feb82d5da8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2a9baccf83a6877b85a108ea5fc373feb82d5da8"}]},"branch":"refs/heads/stable/xena"},"776d6fcd44d310a42c99e8bed195479d15f01806":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2022-11-18 11:44:15.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/34/864934/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/864934/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/864934/2"}}},"commit":{"parents":[{"commit":"e918ccdf8ba0aa2ebf43cfbe5c86ad8b306295f1","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e918ccdf8ba0aa2ebf43cfbe5c86ad8b306295f1"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-11-18 11:43:49.000000000","tz":0},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nConflicts:\n    nova/tests/unit/api/openstack/compute/test_limits.py\n    nova/tests/unit/virt/libvirt/volume/test_lightos.py\n    nova/tests/unit/virt/test_block_device.py\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n(cherry picked from commit f8cf050a1380ae844e0184ed45f4a04fde3b07a9)\n(cherry picked from commit b40bd1bf52c87c31e18caf85d79dd03da6c7cffc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/776d6fcd44d310a42c99e8bed195479d15f01806"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/776d6fcd44d310a42c99e8bed195479d15f01806"}]},"branch":"refs/heads/stable/xena"},"1aead6dae22d5e9aa3229bc91b53d15846465b99":{"kind":"NO_CHANGE","_number":3,"created":"2022-11-18 12:12:05.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/34/864934/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/864934/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/864934/3"}}},"commit":{"parents":[{"commit":"392cad0e65664a35ef7ba2955b213f7db2a4545c","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/392cad0e65664a35ef7ba2955b213f7db2a4545c"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-11-18 12:11:28.000000000","tz":0},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nConflicts:\n    nova/tests/unit/api/openstack/compute/test_limits.py\n    nova/tests/unit/virt/libvirt/volume/test_lightos.py\n    nova/tests/unit/virt/test_block_device.py\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n(cherry picked from commit f8cf050a1380ae844e0184ed45f4a04fde3b07a9)\n(cherry picked from commit b40bd1bf52c87c31e18caf85d79dd03da6c7cffc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1aead6dae22d5e9aa3229bc91b53d15846465b99"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1aead6dae22d5e9aa3229bc91b53d15846465b99"}]},"branch":"refs/heads/stable/xena"},"2f195284795e4bdea1f63c7184bd342d3920fbf1":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2022-11-21 17:08:27.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/34/864934/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/864934/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/864934/4"}}},"commit":{"parents":[{"commit":"7c53f241db38d76713b1c9d12f524ff0cee0f4b3","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7c53f241db38d76713b1c9d12f524ff0cee0f4b3"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-11-21 17:05:55.000000000","tz":0},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nConflicts:\n    nova/tests/unit/api/openstack/compute/test_limits.py\n    nova/tests/unit/virt/libvirt/volume/test_lightos.py\n    nova/tests/unit/virt/test_block_device.py\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n(cherry picked from commit f8cf050a1380ae844e0184ed45f4a04fde3b07a9)\n(cherry picked from commit b40bd1bf52c87c31e18caf85d79dd03da6c7cffc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2f195284795e4bdea1f63c7184bd342d3920fbf1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2f195284795e4bdea1f63c7184bd342d3920fbf1"}]},"branch":"refs/heads/stable/xena"},"b648352115d79924d59b59670213f066cc253396":{"kind":"REWORK","_number":5,"created":"2022-11-22 11:54:07.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/34/864934/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/864934/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/864934/5"}}},"commit":{"parents":[{"commit":"7c53f241db38d76713b1c9d12f524ff0cee0f4b3","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/7c53f241db38d76713b1c9d12f524ff0cee0f4b3"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-11-21 17:58:18.000000000","tz":0},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nConflicts:\n    nova/tests/unit/api/openstack/compute/test_limits.py\n    nova/tests/unit/virt/libvirt/volume/test_lightos.py\n    nova/tests/unit/virt/test_block_device.py\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n(cherry picked from commit f8cf050a1380ae844e0184ed45f4a04fde3b07a9)\n(cherry picked from commit b40bd1bf52c87c31e18caf85d79dd03da6c7cffc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b648352115d79924d59b59670213f066cc253396"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b648352115d79924d59b59670213f066cc253396"}]},"branch":"refs/heads/stable/xena"},"54c7c97cb83609cbcba44856d412dae11fe8643b":{"kind":"NO_CHANGE","_number":6,"created":"2022-12-01 18:14:33.000000000","uploader":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"ref":"refs/changes/34/864934/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/34/864934/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/34/864934/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/34/864934/6"}}},"commit":{"parents":[{"commit":"a340630c5c78e5f5856004d0a551dfa93df7f28d","subject":"Record SRIOV PF MAC in the binding profile","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a340630c5c78e5f5856004d0a551dfa93df7f28d"}]}],"author":{"name":"Balazs Gibizer","email":"gibi@redhat.com","date":"2022-07-28 17:50:29.000000000","tz":120},"committer":{"name":"Sean Mooney","email":"work@seanmooney.info","date":"2022-12-01 18:14:01.000000000","tz":0},"subject":"Remove double mocking","message":"Remove double mocking\n\nIn py310 unittest.mock does not allow to mock the same function twice as\nthe second mocking will fail to autospec the Mock object created by the\nfirst mocking.\n\nThis patch manually fixes the double mocking.\n\nFixed cases:\n1) one of the mock was totally unnecessary so it was removed\n2) the second mock specialized the behavior of the first generic mock.\n   In this case the second mock is replaced with the configuration of\n   the first mock\n3) a test case with two test steps mocked the same function for each\n   step with overlapping mocks. Here the overlap was removed to have\n   the two mock exists independently\n\nThe get_connection injection in the libvirt functional test needed a\nfurther tweak (yeah I know it has many already) to act like a single\nmock (basically case #2) instead of a temporary re-mocking. Still the\nglobalness of the get_connection mocking warrant the special set / reset\nlogic there.\n\nConflicts:\n    nova/tests/unit/api/openstack/compute/test_limits.py\n    nova/tests/unit/virt/libvirt/volume/test_lightos.py\n    nova/tests/unit/virt/test_block_device.py\n\nChange-Id: I3998d0d49583806ac1c3ae64f1b1fe343cefd20d\n(cherry picked from commit f8cf050a1380ae844e0184ed45f4a04fde3b07a9)\n(cherry picked from commit b40bd1bf52c87c31e18caf85d79dd03da6c7cffc)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/54c7c97cb83609cbcba44856d412dae11fe8643b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/54c7c97cb83609cbcba44856d412dae11fe8643b"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[]}
