)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"73968b503936d0083e2209e452bcdb3839e04640","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"be9dfc09_a0a1e2f2","updated":"2022-11-18 16:49:07.000000000","message":"this is partial fix  but over all the direction makes sense to skip comparions ot None\n\ncan you add more test coverage to also cover the case where only one of the two items beign compared is none and make the change i noted inline","commit_id":"ecf8a2be2a990982378a6aa62bb7670bfc5795f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4e3d6881b74a006b8772e96a221375f99835e65a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"24ec2edf_068104be","updated":"2022-11-23 09:53:17.000000000","message":"the code is funcitonal but hte pep8 issue needs to be fixed to pass ci.\n\nthere is an autopep8 tox target that can do it automatically or you can just delete the space :)","commit_id":"656a306aeab5b30335a621760c98461f888b350d"},{"author":{"_account_id":28722,"name":"Anton Kurbatov","email":"anton.kurbatov@acronis.com","username":"akurbatov"},"change_message_id":"0d23af2e78c53dc25129ad8b7d39d582f97afdff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fdccc3d6_e269d4aa","updated":"2022-11-22 21:12:35.000000000","message":"v2: resolved @sean mooney comments","commit_id":"656a306aeab5b30335a621760c98461f888b350d"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"50f33d3fee7008fbd820209395cdd8c2b32e54be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"93b1de90_a9ca7132","updated":"2022-11-25 13:36:01.000000000","message":"recheck","commit_id":"b23869dc36213a952aebd4e86ea97c82261020a0"},{"author":{"_account_id":19234,"name":"Alexey Stupnikov","email":"aleksey.stupnikov@gmail.com","username":"astupnikov"},"change_message_id":"b13f99da745c8c80e9846a2cc6fae728671233d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c954c88c_737a1504","updated":"2022-11-25 17:18:56.000000000","message":"recheck","commit_id":"b23869dc36213a952aebd4e86ea97c82261020a0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2fa6e763a3cd20223eb90bd4bd6ddd9d73e9f7e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fa752f8b_f91f429b","updated":"2022-11-23 10:56:28.000000000","message":"this should pass ci now so +2\n\nthanks for finding and adressing this.","commit_id":"b23869dc36213a952aebd4e86ea97c82261020a0"}],"nova/compute/multi_cell_list.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"73968b503936d0083e2209e452bcdb3839e04640","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        for skey, sdir in zip(self.sort_keys, self.sort_dirs):"},{"line_number":42,"context_line":"            resultflag \u003d 1 if sdir \u003d\u003d \u0027desc\u0027 else -1"},{"line_number":43,"context_line":"            if (rec1[skey], rec2[skey]) \u003d\u003d (None, None):"},{"line_number":44,"context_line":"                continue"},{"line_number":45,"context_line":"            if rec1[skey] \u003c rec2[skey]:"},{"line_number":46,"context_line":"                return resultflag"},{"line_number":47,"context_line":"            elif rec1[skey] \u003e rec2[skey]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"088098e8_37506cc5","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":24},"updated":"2022-11-18 16:49:07.000000000","message":"https://docs.python.org/release/3.0.1/whatsnew/3.0.html#ordering-comparisons\nbased on ^ the python 2 behavior woudl have been to return false for both \u003c and \u003e\n\nif it was the only sort key it woudl return 0 overall.\n\nconintue perferst that behavior however you only cater for the case wehere both are none.\n\nthis should instead be\n\nif rec1[skey] is None or rec2[skey] is None:\n    continue\n    \nas sort order is undefiend for comparions between None and any value.\nso if either value is non we shoudl not include it in the sort perdicate.","commit_id":"ecf8a2be2a990982378a6aa62bb7670bfc5795f2"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4e3d6881b74a006b8772e96a221375f99835e65a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        for skey, sdir in zip(self.sort_keys, self.sort_dirs):"},{"line_number":42,"context_line":"            resultflag \u003d 1 if sdir \u003d\u003d \u0027desc\u0027 else -1"},{"line_number":43,"context_line":"            if (rec1[skey], rec2[skey]) \u003d\u003d (None, None):"},{"line_number":44,"context_line":"                continue"},{"line_number":45,"context_line":"            if rec1[skey] \u003c rec2[skey]:"},{"line_number":46,"context_line":"                return resultflag"},{"line_number":47,"context_line":"            elif rec1[skey] \u003e rec2[skey]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b955ae68_eed672f8","line":44,"range":{"start_line":44,"start_character":16,"end_line":44,"end_character":24},"in_reply_to":"088098e8_37506cc5","updated":"2022-11-23 09:53:17.000000000","message":"Done","commit_id":"ecf8a2be2a990982378a6aa62bb7670bfc5795f2"}],"nova/tests/unit/compute/test_multi_cell_list.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4e3d6881b74a006b8772e96a221375f99835e65a","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # None should not affect ordering"},{"line_number":102,"context_line":"        inst3 \u003d {\u0027key0\u0027: \u0027foo\u0027, \u0027key1\u0027: \u0027d\u0027, \u0027key2\u0027: 456}"},{"line_number":103,"context_line":"        inst4 \u003d {\u0027key0\u0027: None,  \u0027key1\u0027: \u0027s\u0027, \u0027key2\u0027: 123}"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # Should be equivalent to ascending by key1"},{"line_number":106,"context_line":"        ctx \u003d multi_cell_list.RecordSortContext([\u0027key0\u0027, \u0027key1\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"4cd47c92_d66f2ba5","line":103,"updated":"2022-11-23 09:53:17.000000000","message":"the code is fine over all but you have a pep8 issue\nher with a double space between None, and \u0027key1\u0027\n\nhttps://zuul.opendev.org/t/openstack/build/11f86182d9cc4a94a85bfeebebb342f8/log/job-output.txt#1790","commit_id":"656a306aeab5b30335a621760c98461f888b350d"}]}