)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0224c2abe4aed4851d195444aede1235abf5229b","unresolved":true,"context_lines":[{"line_number":11,"context_line":"detect the existence of such extension. Later patches will adapt Nova"},{"line_number":12,"context_line":"for the new format."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-lib/+/803905"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4b400d499b9f594798f2da6d16f21204371a9f42"},{"line_number":17,"context_line":"blueprint: qos-minimum-guaranteed-packet-rate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0c3b0ebb_2e839c64","line":14,"updated":"2022-11-24 17:55:42.000000000","message":"this probably needs to be explained why it is not a problem to backport this even though the neutron-lib change is not backported.","commit_id":"eaf70f06a136c86a20d97191b7f801038c81f751"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7b5bf783ddbcc0abbcd43be1c3f3e1767edf20fa","unresolved":true,"context_lines":[{"line_number":11,"context_line":"detect the existence of such extension. Later patches will adapt Nova"},{"line_number":12,"context_line":"for the new format."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron-lib/+/803905"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4b400d499b9f594798f2da6d16f21204371a9f42"},{"line_number":17,"context_line":"blueprint: qos-minimum-guaranteed-packet-rate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2484f206_3bab8d6f","line":14,"in_reply_to":"0c3b0ebb_2e839c64","updated":"2022-11-24 18:21:58.000000000","message":"ya i can add a note about that.\n\nthe short version is nova does not actully depend on neutron-lib for the definition of the constants but we used the depens on to prevent this form merging orginally\nuntil the neutron bit had been accpeted.\n\nsince we are not backporting the qos feature this constnt will really only be used in test code. i might look at droping thos test instead on monday.\n\ni didnt check how much would be affected by that.\n\nneither the PF mac fix or vdpa actully depend on this extension but sinfce there was a format change the unit/funcitonl tests need to be updated to test that and that all this really is for.","commit_id":"eaf70f06a136c86a20d97191b7f801038c81f751"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0224c2abe4aed4851d195444aede1235abf5229b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I4b400d499b9f594798f2da6d16f21204371a9f42"},{"line_number":17,"context_line":"blueprint: qos-minimum-guaranteed-packet-rate"},{"line_number":18,"context_line":"(cherry picked from commit 017b0a3d2332b1d3d20c2aa51ae9605f6c7676ee)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7dc35eae_c2be3038","line":18,"updated":"2022-11-24 17:55:42.000000000","message":"OK this is laned on master during xena","commit_id":"eaf70f06a136c86a20d97191b7f801038c81f751"}],"nova/network/neutron.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0224c2abe4aed4851d195444aede1235abf5229b","unresolved":true,"context_lines":[{"line_number":1272,"context_line":"    # the this extension mandatory. In Xena this extension will be optional to"},{"line_number":1273,"context_line":"    # support the scenario where Neutron upgraded first. So Neutron can mark"},{"line_number":1274,"context_line":"    # this mandatory earliest in Yoga."},{"line_number":1275,"context_line":"    def _has_extended_resource_request_extension(self, context, neutron\u003dNone):"},{"line_number":1276,"context_line":"        self._refresh_neutron_extensions_cache(context, neutron\u003dneutron)"},{"line_number":1277,"context_line":"        return constants.RESOURCE_REQUEST_GROUPS_EXTENSION in self.extensions"},{"line_number":1278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6d1500c2_d40033e4","line":1275,"updated":"2022-11-24 17:55:42.000000000","message":"either this needs to be renamed to has_extended_resource_request_extension simulating parts of I8058902df167239fa455396d3595a56bcf472b2b or later patches in the series needs to be adapted to call this \"_\" prefixed one. \nThis is why the unit tests are failing later in the series.","commit_id":"eaf70f06a136c86a20d97191b7f801038c81f751"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7b5bf783ddbcc0abbcd43be1c3f3e1767edf20fa","unresolved":true,"context_lines":[{"line_number":1272,"context_line":"    # the this extension mandatory. In Xena this extension will be optional to"},{"line_number":1273,"context_line":"    # support the scenario where Neutron upgraded first. So Neutron can mark"},{"line_number":1274,"context_line":"    # this mandatory earliest in Yoga."},{"line_number":1275,"context_line":"    def _has_extended_resource_request_extension(self, context, neutron\u003dNone):"},{"line_number":1276,"context_line":"        self._refresh_neutron_extensions_cache(context, neutron\u003dneutron)"},{"line_number":1277,"context_line":"        return constants.RESOURCE_REQUEST_GROUPS_EXTENSION in self.extensions"},{"line_number":1278,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1b37671c_daa6f493","line":1275,"in_reply_to":"6d1500c2_d40033e4","updated":"2022-11-24 18:21:58.000000000","message":"thanks that makes sense i I8058902df167239fa455396d3595a56bcf472b2b looks pretty big. i vaguly rememebr this and it proably coudl be backpoted but i think just dropping the _ make sense.\n\n\ni actully tested the unit test with a copy paste of this function then reverted it and did na interactive rebase to pull this in.\n\ni guess i didnt run the unit test after. so ill just rename it and note it in the commit.","commit_id":"eaf70f06a136c86a20d97191b7f801038c81f751"}]}