)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"8acba420f630c878647ea509f62da6fedd789599","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add more password generation options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some password policies require more than one occurence of symbols of one"},{"line_number":10,"context_line":"kind, or make restrictions about their occurence effectively requiring"},{"line_number":11,"context_line":"them to occure more often."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"a30ef1e3_8f0492b4","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":54},"updated":"2024-05-28 08:40:12.000000000","message":"occurrence","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"b8923c54618e9f560bf12cedbbfe903d000c532c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add more password generation options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some password policies require more than one occurence of symbols of one"},{"line_number":10,"context_line":"kind, or make restrictions about their occurence effectively requiring"},{"line_number":11,"context_line":"them to occure more often."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"f49a17ed_daf6619f","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":54},"in_reply_to":"a30ef1e3_8f0492b4","updated":"2024-05-29 10:37:15.000000000","message":"Done","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"},{"author":{"_account_id":37041,"name":"Maxime Lubin","display_name":"Maxime Lubin","email":"maxime.lubin@shadow.tech","username":"Previsou"},"change_message_id":"50cfc54c3a5caf814f3ffa3ac8c48e9548bb16c3","unresolved":true,"context_lines":[{"line_number":18,"context_line":"(upper/lower-case) and numbers, but also other printable characters in"},{"line_number":19,"context_line":"the password as a fourth symbol group."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"By makeing the symbol-classes the multi-string list"},{"line_number":22,"context_line":"\u0027password_symbol_groups\u0027, the administrator can add those and"},{"line_number":23,"context_line":"also override the other classes, if desired."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"2b3393f9_36f8b0bf","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":10},"updated":"2024-05-29 10:00:18.000000000","message":"making","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"b8923c54618e9f560bf12cedbbfe903d000c532c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"(upper/lower-case) and numbers, but also other printable characters in"},{"line_number":19,"context_line":"the password as a fourth symbol group."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"By makeing the symbol-classes the multi-string list"},{"line_number":22,"context_line":"\u0027password_symbol_groups\u0027, the administrator can add those and"},{"line_number":23,"context_line":"also override the other classes, if desired."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"4092a7d0_361f6577","line":21,"range":{"start_line":21,"start_character":3,"end_line":21,"end_character":10},"in_reply_to":"2b3393f9_36f8b0bf","updated":"2024-05-29 10:37:15.000000000","message":"Done","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"4cdecf0aa051bcf2dd88c11530d762799e6a3a58","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"edebad99_0feffaf7","updated":"2023-03-15 10:33:18.000000000","message":"retest","commit_id":"40e97c56578118dd839c37b8aec55bd2e6764ad8"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"c920eb054c0e639da6095fee60ff5ab2183c5327","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b3d201b0_752591da","in_reply_to":"edebad99_0feffaf7","updated":"2024-02-06 09:55:53.000000000","message":"Done","commit_id":"40e97c56578118dd839c37b8aec55bd2e6764ad8"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"9c2cfc81dc2f5e0d88d74460c89cf4a9d1181633","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e3b4ad35_1ec4896b","updated":"2023-05-03 07:30:04.000000000","message":"recheck","commit_id":"cc6c3c9570e5c684592a82c585cb528e712c55e0"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"c920eb054c0e639da6095fee60ff5ab2183c5327","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aad7fc27_d56dcd67","updated":"2024-02-06 09:55:53.000000000","message":"Sorry for the noise, that comment should be closed.","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"b8923c54618e9f560bf12cedbbfe903d000c532c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"362cb3e4_11537b58","updated":"2024-05-29 10:37:15.000000000","message":"Thanks for the feedback, I\u0027ve hopefully covered it all in the new patch.","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"},{"author":{"_account_id":37041,"name":"Maxime Lubin","display_name":"Maxime Lubin","email":"maxime.lubin@shadow.tech","username":"Previsou"},"change_message_id":"50cfc54c3a5caf814f3ffa3ac8c48e9548bb16c3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c40abba7_df20f478","updated":"2024-05-29 10:00:18.000000000","message":"The implementation already handles the case of an empty symbol group, but adding a test for this case might be worth it.","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"bf25e589b81315c7c5e358fd5a3d75066a19ed7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8fb06f7b_fad20ae3","in_reply_to":"c40abba7_df20f478","updated":"2024-05-29 10:37:39.000000000","message":"Done","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"},{"author":{"_account_id":37041,"name":"Maxime Lubin","display_name":"Maxime Lubin","email":"maxime.lubin@shadow.tech","username":"Previsou"},"change_message_id":"adc55516e2ba0e292dcc32d932ced1ea3d0f99f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"6e86065f_5e8a44c5","updated":"2024-06-12 09:28:10.000000000","message":"LGTM","commit_id":"8d03970dd08a987e37f3ed13c1734d3e5d63b82d"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"29d06dc76b8e503bce4e621377bdd11bd8029e24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3917f2cd_9e2fb586","updated":"2024-06-12 13:21:38.000000000","message":"Looks like a good improvement ++.\n\nCan you add a release note that explain introduction of the new options.","commit_id":"8d03970dd08a987e37f3ed13c1734d3e5d63b82d"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"bf25e589b81315c7c5e358fd5a3d75066a19ed7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"22c6688a_f1c43c65","updated":"2024-05-29 10:37:39.000000000","message":"Sorry, that one as well.","commit_id":"8d03970dd08a987e37f3ed13c1734d3e5d63b82d"},{"author":{"_account_id":34860,"name":"Amit Uniyal","email":"auniyal@redhat.com","username":"auniyal"},"change_message_id":"e47f898dea00e3f7d5ae569148ce3c89606e4a2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"74818ad1_6a50e3f4","updated":"2024-06-12 09:17:23.000000000","message":"recheck got timeout for `tempest-integrated-compute` job\nso no real test seems to be failing, so may be job assumed/calculated time in which all test should have tested, and it took more then that, hence job failed.\ndid not find anything helpful in logs\n```\n2024-05-29 12:43:52.466423 | RUN END RESULT_TIMED_OUT: [untrusted : opendev.org/openstack/tempest/playbooks/devstack-tempest.yaml@master]\n```\nchange lgtm","commit_id":"8d03970dd08a987e37f3ed13c1734d3e5d63b82d"}],"nova/tests/unit/test_utils.py":[{"author":{"_account_id":37041,"name":"Maxime Lubin","display_name":"Maxime Lubin","email":"maxime.lubin@shadow.tech","username":"Previsou"},"change_message_id":"50cfc54c3a5caf814f3ffa3ac8c48e9548bb16c3","unresolved":true,"context_lines":[{"line_number":172,"context_line":"    def test_generate_password_custom_groups(self):"},{"line_number":173,"context_line":"        password \u003d utils.generate_password()"},{"line_number":174,"context_line":"        self.assertEqual(len(password), CONF.password_length)"},{"line_number":175,"context_line":"        self.assertGreaterEqual("},{"line_number":176,"context_line":"            len([c for c in password if c in string.punctuation]),"},{"line_number":177,"context_line":"            CONF.password_all_group_samples)"},{"line_number":178,"context_line":"        self.assertFalse([c for c in password if c in string.digits])"}],"source_content_type":"text/x-python","patch_set":11,"id":"26b2a5d6_dc2890ab","line":175,"updated":"2024-05-29 10:00:18.000000000","message":"Perhaps you can perform this check for all groups, and not only for punctuations?","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"},{"author":{"_account_id":24434,"name":"Fabian Wiesel","email":"fabian.wiesel@sap.com","username":"fwiesel"},"change_message_id":"b8923c54618e9f560bf12cedbbfe903d000c532c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    def test_generate_password_custom_groups(self):"},{"line_number":173,"context_line":"        password \u003d utils.generate_password()"},{"line_number":174,"context_line":"        self.assertEqual(len(password), CONF.password_length)"},{"line_number":175,"context_line":"        self.assertGreaterEqual("},{"line_number":176,"context_line":"            len([c for c in password if c in string.punctuation]),"},{"line_number":177,"context_line":"            CONF.password_all_group_samples)"},{"line_number":178,"context_line":"        self.assertFalse([c for c in password if c in string.digits])"}],"source_content_type":"text/x-python","patch_set":11,"id":"a05311a6_ffb2cd0d","line":175,"in_reply_to":"26b2a5d6_dc2890ab","updated":"2024-05-29 10:37:15.000000000","message":"Done","commit_id":"4950ec92b90c799f2b4c4e1312ca522735894d1b"}]}