)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3492e3dce390d7fd7ed4651bb76d50598fd78707","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5ad6a4f4_7310d303","updated":"2022-12-08 09:04:20.000000000","message":"I\u0027m torn honestly. While I don\u0027t think this is hard to do it, I\u0027m a bit concerned by the impact it will have once we merge :\n- as you see, 20+ other changes will have merge conflicts, and at least the PCI series which I\u0027m afraid they could be delayed. Ideally, if we go merging this patch, I\u0027d honestly prefer to hold it until the FeatureFreeze as we can accept it later in the release... or maybe at the beginning of the B release as it costs the least.\n- as Sean said, there is also a burden on backports. Once we merge it, we\u0027ll hardly depend on it for every single backport we may do before Antelope. We have to correctly balance the benefits over the costs here. Another reason to consider it for later, ideally in the beginning of the next release.\n\n-1\u0027ing not because I don\u0027t want to change the way it is, but rather because we have other priorities in our backlog to merge before we can move forward with this one.","commit_id":"eb477d1c7f9236ca18aa77ae56cd7d55fa1742ee"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"44781edcb75178a98fff577949996fa640e9cdf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5583da2a_dc60b028","updated":"2023-02-13 17:06:58.000000000","message":"These sorts of things are a lot of pain for very little gain. IMHO, this is not a sufficiently valuable rename to justify the amount of change and the conflicts as a result. If there was some severe confusion over what is being live migrated or something, then maybe, but I don\u0027t think this meets that bar.\n\nI\u0027d prefer we just not do this.","commit_id":"eb477d1c7f9236ca18aa77ae56cd7d55fa1742ee"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c29671fc7522579d8deb81e5b692d5bd4870c800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d617ca6_910e3e8a","updated":"2022-11-29 16:57:17.000000000","message":"Trivial cleanup. LGTM","commit_id":"eb477d1c7f9236ca18aa77ae56cd7d55fa1742ee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d9c84d5f600edb7398196de78dcbbabd813e66ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"11783cca_a3b36fa9","updated":"2022-11-29 17:54:20.000000000","message":"the only real concern i have with this is the impact on backports but i guess this is ok\n+1 so we can see what other think about that.\n\nwe started teh refactor in \nhttps://github.com/openstack/nova/commit/ecff78e05d40b0bcb9237d4cfea53fd3223f37a0\nso i guess we should complete it but im wondering if we want to backport this or not.","commit_id":"eb477d1c7f9236ca18aa77ae56cd7d55fa1742ee"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6b9ba2d098190122e113ae6620c8e2b7de8b8822","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5ca5250_83afba45","updated":"2022-12-08 11:30:24.000000000","message":"ya i like the idea of holding this till FF\n\n\nthe impact is actually less then i thought for backports initially since\nolder release will have\n\n_live_migrate_server \u003d _live_migrate\n\nso _live_migrate_server should be ok.","commit_id":"eb477d1c7f9236ca18aa77ae56cd7d55fa1742ee"}]}