)]}'
{"id":"openstack%2Fnova~866090","triplet_id":"openstack%2Fnova~stable%2Ftrain~I741cb6b29a67da8c60708c6251c441d778ca74d0","project":"openstack/nova","branch":"stable/train","topic":"bug/1978444","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2023-09-01 16:51:32.000000000","reason":"Change was abandoned"},"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2023-09-01 16:51:32.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I741cb6b29a67da8c60708c6251c441d778ca74d0","subject":"Fix the wrong exception used to retry detach API calls","status":"ABANDONED","created":"2022-11-29 23:19:15.000000000","updated":"2023-09-01 16:51:32.000000000","total_comment_count":9,"unresolved_comment_count":3,"has_review_started":true,"meta_rev_id":"bb87e49a70b7a9b5288f4a194d33213a2cf0d576","_number":866090,"virtual_id_number":866090,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"tag":"autogenerated:zuul:check","value":1,"date":"2022-12-07 03:12:13.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":1,"date":"2022-12-07 18:56:32.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":2,"date":"2022-12-15 09:18:45.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-03-26 15:50:51.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"CC":[{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-29 23:19:15.000000000","updated_by":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"reviewer":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"state":"CC"},{"updated":"2022-11-30 01:19:49.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-07 18:56:32.000000000","updated_by":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2022-12-15 09:18:45.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2023-03-26 15:50:51.000000000","updated_by":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"reviewer":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"state":"REVIEWER"}],"messages":[{"id":"c665fdfdc93939bd970d9b7d516939e3e697f5ec","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2022-11-29 23:19:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f580f83922036ea8e71216f3c08aee07efabfdb5","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-30 01:19:49.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/42ab41604eb14bfc8b359e1a91a76730\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/0ec175caf6694bd49ccd03c225becb1b : SUCCESS in 59m 25s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/479d963db8904988a3168c9e78156a9b : SUCCESS in 43m 44s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5c0c3b3dd7fa48dd94db3291621b5d0a : SUCCESS in 17m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/27d9f76e19de48ceadf491ab96bcdc32 : SUCCESS in 10m 02s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/80f58ef3e41b46959611e6b1fa9066ee : FAILURE in 12m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d02045f6aa2840ea94c4f71bc667d1f3 : SUCCESS in 11m 30s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/28f2cc815802465583ae0034b0149de3 : SUCCESS in 11m 51s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2664073473204fee94c2c4e7f0b8e6e8 : SUCCESS in 9m 00s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/b358d730eab445688b83eeda15ac702f : SUCCESS in 56m 43s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/b3d531d4bc7c43a09ff3cb282e808942 : SUCCESS in 1h 19m 43s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/0ef9e956f8764820aed533c3f7c61aeb : SUCCESS in 44m 07s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/b8cca7bffa154d27b079384f08a498ad : SUCCESS in 48m 17s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/91ab122391874d96985c2fb65d764e7e : SUCCESS in 1h 06m 47s\n- nova-next https://zuul.opendev.org/t/openstack/build/ecf82b64865c4703af0f025616f20c2c : SUCCESS in 1h 04m 19s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/9ae5bc26dfd4474cae65ed61a6b6916a : SUCCESS in 18m 47s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/66cc7cfc895b49b3aef3291288b6bbbe : SUCCESS in 20m 20s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/74d468aa0050427b88ed01f2a506578c : FAILURE in 5m 18s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/2d3558e22309443591601dbb79720252 : SUCCESS in 1h 55m 45s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/827e823a69da4733be02c2c0280d4d00 : SUCCESS in 1h 02m 40s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/9918c4d2fa0c45a0a6936ba0f7984171 : SUCCESS in 52m 47s","accounts_in_message":[],"_revision_number":1},{"id":"50d57f4fb82ca6a32bea96ecf11b4cda793a694c","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2022-11-30 01:40:31.000000000","message":"Patch Set 1: Workflow-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"420ee95988450575d3460417ccb1cf3b23ea3cca","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2022-12-06 04:26:48.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"73ca6af583fec3e14d5966ee76aad7be34e59b24","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2022-12-07 01:09:57.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4074abe2a1aec10b161f8bfd753d3fb103617d50","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-07 03:12:13.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/6ec5fc90785b4b16a448f73fcffef78a\n\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/93d89f86c8fd4daab60bc951589b2fd2 : SUCCESS in 1h 18m 26s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/70bd39c1d14c448789af53f4cfee96b0 : SUCCESS in 51m 45s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/52ab2e1ca8cb45d7870c36f58197fab5 : SUCCESS in 18m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3fcc40ad6e4f44c3ac3fcddbc17dc2b1 : SUCCESS in 9m 40s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/b444e4fc73e34f34b779540068feaeea : SUCCESS in 12m 32s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/457a1e2488814f7a950cc3b8c4aec656 : SUCCESS in 10m 56s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/d7b7d2f0ebf14cd4b3b5bd78a16c8de6 : SUCCESS in 12m 24s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/15abc9acd4d0453baa936c4c1aaa629b : SUCCESS in 9m 52s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/d4e5c5bc80804d70b75fe8faf33c51b1 : SUCCESS in 1h 12m 50s (non-voting)\n- devstack-plugin-ceph-tempest https://zuul.opendev.org/t/openstack/build/b01a740f14764762b3ec1e7975d833ab : SUCCESS in 1h 18m 51s (non-voting)\n- neutron-grenade-multinode https://zuul.opendev.org/t/openstack/build/658301a4fb634fce9c63b29eb0a6f13f : SUCCESS in 52m 09s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/e3bb4ecfce1446bd8c8c1979ae1f18d8 : SUCCESS in 47m 31s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/4dd26a99b9ce46d5adb8f5d081f34be8 : SUCCESS in 1h 24m 17s\n- nova-next https://zuul.opendev.org/t/openstack/build/2ce52669153241219640ceb0394e21c0 : SUCCESS in 1h 03m 35s\n- nova-tox-functional https://zuul.opendev.org/t/openstack/build/4e91172d613647a0b362ef4e30e456f4 : SUCCESS in 18m 32s\n- nova-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/5753557167f0448f8a2e4090f49edb3c : SUCCESS in 16m 22s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/d403e2393e3c42aeba1c922c02e87d7f : FAILURE in 4m 48s (non-voting)\n- tempest-slow-py3 https://zuul.opendev.org/t/openstack/build/74f41b00497d4f7eb8279b905a17a1a6 : SUCCESS in 1h 57m 21s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/62c4570433b54985b5a972da8a07af58 : SUCCESS in 1h 01m 06s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/478f715e04644f299d2c255f2f67f7b2 : SUCCESS in 43m 56s","accounts_in_message":[],"_revision_number":2},{"id":"a3af092b163e86f9d4ebe8412583056d4b2eda96","author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"date":"2022-12-07 18:56:32.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"e7a37f401a5d4785d6768cc3fb94ee97928d543d","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2022-12-07 21:44:54.000000000","message":"Patch Set 2:\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"df5b2233bf8e60c5f6c42df439220b7d3a851899","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2022-12-15 09:18:45.000000000","message":"Patch Set 2: Code-Review+2\n\n(4 comments)","accounts_in_message":[],"_revision_number":2},{"id":"9081757cbcb9d99cf11fdb8f82b003e798c2d625","author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"date":"2023-03-26 15:50:51.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"bb87e49a70b7a9b5288f4a194d33213a2cf0d576","tag":"autogenerated:gerrit:abandon","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-09-01 16:51:32.000000000","message":"Abandoned\n\nstable/train branch of nova projects\u0027 have been tagged as End of Life. All open patches have to be abandoned in order to be able to delete the branch.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"56ae96c0f999046cfa9c15c5206ff73989d8f313","revisions":{"ba03c7cc33843d263b35f86d123877cf16ac9add":{"kind":"REWORK","_number":1,"created":"2022-11-29 23:19:15.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/90/866090/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/90/866090/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/866090/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/866090/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/866090/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/90/866090/1"}}},"commit":{"parents":[{"commit":"d3b46af01b7afa1a9051cb440a7986bfcb1a59b1","subject":"func: Add _live_migrate helper to InstanceHelperMixin","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d3b46af01b7afa1a9051cb440a7986bfcb1a59b1"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-09-18 15:06:56.000000000","tz":540},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2022-11-29 23:18:42.000000000","tz":0},"subject":"Fix the wrong exception used to retry detach API calls","message":"Fix the wrong exception used to retry detach API calls\n\nWhen cinderclient receives an error response from API, it raises one\nof the exceptions from the cinderclient.exceptions module instead of\nthe cinderclient.apiclient.exceptions module.\n\nThis change fixes the wrong exception used to detect 500 error from\ncinder API, so that API calls to detach volumes are properly retried.\n\nCloses-Bug: #1944043\nChange-Id: I741cb6b29a67da8c60708c6251c441d778ca74d0\n(cherry picked from commit f6206269b71d9bcaf65aa0313c21cc6b75a54fb3)\n(cherry picked from commit 513241a7e4f3f3246c75e66a910db6c864c3981e)\n(cherry picked from commit 7168314dd125fca8d1cecac035477ea0314ab828)\n(cherry picked from commit ba3a6f385512c352374425972791084cb54ab7ee)\n(cherry picked from commit 7c4ee8097c6a194e0968ef45482045d74a82c43f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba03c7cc33843d263b35f86d123877cf16ac9add"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba03c7cc33843d263b35f86d123877cf16ac9add"}]},"branch":"refs/heads/stable/train"},"56ae96c0f999046cfa9c15c5206ff73989d8f313":{"kind":"REWORK","_number":2,"created":"2022-12-07 01:09:57.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/90/866090/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/90/866090/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/866090/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/866090/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/90/866090/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/90/866090/2"}}},"commit":{"parents":[{"commit":"d3b46af01b7afa1a9051cb440a7986bfcb1a59b1","subject":"func: Add _live_migrate helper to InstanceHelperMixin","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d3b46af01b7afa1a9051cb440a7986bfcb1a59b1"}]}],"author":{"name":"Takashi Kajinami","email":"tkajinam@redhat.com","date":"2021-09-18 15:06:56.000000000","tz":540},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2022-12-07 00:52:10.000000000","tz":0},"subject":"Fix the wrong exception used to retry detach API calls","message":"Fix the wrong exception used to retry detach API calls\n\nWhen cinderclient receives an error response from API, it raises one\nof the exceptions from the cinderclient.exceptions module instead of\nthe cinderclient.apiclient.exceptions module.\n\nThis change fixes the wrong exception used to detect 500 error from\ncinder API, so that API calls to detach volumes are properly retried.\n\nNOTE(melwitt): The difference from the cherry picked change is due to\none unit test failing under python 2.7 with the following error:\n\n      [...]\n\n      File \"/usr/lib/python2.7/copy.py\", line 257, in _deepcopy_dict\n        y[deepcopy(key, memo)] \u003d deepcopy(value, memo)\n      File \"/usr/lib/python2.7/copy.py\", line 190, in deepcopy\n        y \u003d _reconstruct(x, rv, 1, memo)\n      File \"/usr/lib/python2.7/copy.py\", line 329, in _reconstruct\n        y \u003d callable(*args)\n    TypeError: __init__() takes at least 2 arguments (1 given)\n\nThe error was raised in test_detach_internal_server_error from the\nunmocked nova.volume.cinder.API.get() method. Because the error was\nbeing raised from get() and get() is unrelated to the detach() test and\nshould be mocked anyway, this cherry pick was modified to also mock\nnova.volume.cinder.API.get() to avoid the error.\n\nCloses-Bug: #1944043\nChange-Id: I741cb6b29a67da8c60708c6251c441d778ca74d0\n(cherry picked from commit f6206269b71d9bcaf65aa0313c21cc6b75a54fb3)\n(cherry picked from commit 513241a7e4f3f3246c75e66a910db6c864c3981e)\n(cherry picked from commit 7168314dd125fca8d1cecac035477ea0314ab828)\n(cherry picked from commit ba3a6f385512c352374425972791084cb54ab7ee)\n(cherry picked from commit 7c4ee8097c6a194e0968ef45482045d74a82c43f)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56ae96c0f999046cfa9c15c5206ff73989d8f313"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/56ae96c0f999046cfa9c15c5206ff73989d8f313"}]},"branch":"refs/heads/stable/train"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}