)]}'
{"id":"openstack%2Fnova~866193","triplet_id":"openstack%2Fnova~stable%2Fxena~I27441d15cc6fa2ff7715ba15aa900961aadbf54a","project":"openstack/nova","branch":"stable/xena","topic":"bug/1986545","attention_set":{},"removed_from_attention_set":{"4690":{"account":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"last_update":"2023-01-10 14:04:12.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I27441d15cc6fa2ff7715ba15aa900961aadbf54a","subject":"Adapt websocketproxy tests for SimpleHTTPServer fix","status":"MERGED","created":"2022-11-30 17:20:35.000000000","updated":"2023-01-10 14:06:48.000000000","submitted":"2023-01-10 14:04:12.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"866193-bug/1986545","meta_rev_id":"426606056daa716c9575d72c32deffa919cfb6e6","_number":866193,"virtual_id_number":866193,"owner":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2023-01-10 14:04:12.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-01-10 12:43:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":2,"date":"2022-12-20 13:08:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2023-01-10 12:43:30.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"value":0,"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-30 18:06:09.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-12-20 13:08:57.000000000","updated_by":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"reviewer":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"state":"REVIEWER"},{"updated":"2023-01-10 12:43:30.000000000","updated_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"reviewer":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"state":"REVIEWER"}],"messages":[{"id":"1471b3245902bc82e842cf84010e3a12f6e7b8f4","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"date":"2022-11-30 17:20:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d80acd3d5f59299c18f0eb40579f300530d58560","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-30 18:06:09.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/0a98a2ad17b840539d79e36b6870369c\n\n- tempest-integrated-compute-centos-8-stream https://zuul.opendev.org/t/openstack/build/f8b5066bd7e948748c2fe2f90ad5ec83 : FAILURE in 38m 43s (non-voting)\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b4c36d46cf0d41c986a55f38d336549f : SUCCESS in 15m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a6ad49eddb1c49d9a2df9d5f335dc958 : SUCCESS in 7m 33s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d8529299360d4da5908345b797e35b7c : SUCCESS in 11m 28s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0493983f75bb4c5dad18d7ac53bf1027 : SUCCESS in 11m 10s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/459fc1b5518b40ed8699453222abfcd3 : SUCCESS in 12m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/48d4bd652ef7495aaec2f9c313952813 : SUCCESS in 8m 39s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/eb32a7612343466fb3aac396a6ed1f02 : FAILURE in 5m 47s (non-voting)\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/2d6be298bab94756bd4c32359aff00ab : SUCCESS in 21m 39s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/de3185458a394b6dbb0fc286083124dc : SUCCESS in 19m 48s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/fce4fc08cb2846408a12f3809ef88609 : SUCCESS in 21m 13s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"9dff7d57e9f3b32fd35a8fd357bd79458b13502c","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-30 20:42:30.000000000","message":"Patch Set 1:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/51ac4ddd1273406aaab263967bb2dacf\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/150f94f651904c26b3daf36e4b4af08a : SUCCESS in 25m 44s (non-voting)\n- openstack-tox-py39-arm64 https://zuul.opendev.org/t/openstack/build/a947aefdcf9e45b08828c3d2da6e4ee7 : SUCCESS in 28m 34s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"a0859f6eaa9ce68989c285af2c0310eaaf6e5d81","author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"date":"2022-12-20 13:08:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4d6d1c0ece74f63c5d0eec36762f9f5c1afa36cc","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-01-10 12:43:30.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fe228ec8eba2404b84f42674ba6df5be4a8ca783","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-10 12:44:03.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"fb8ea8ede7c4248bac3ab3a601efa069c437d87a","author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"date":"2023-01-10 12:52:12.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"5df7e67e9cc050407efe8a0469c716ee8205e176","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-10 14:04:12.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/df9aeb7488b24ead98920f3ed095c291\n\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0918783837d4430d9ea31a7e1d92e04d : SUCCESS in 9m 42s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/742a93c7f57e469daa4d9560909cf189 : SUCCESS in 12m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/411005c5dba14250b2bec6a54dafe676 : SUCCESS in 11m 00s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/47e3d8e219f5412cad31c14a50228db6 : SUCCESS in 8m 21s\n- nova-tox-functional-centos8-py36 https://zuul.opendev.org/t/openstack/build/9048e8f1f1cc4a939db34ab19e4c8451 : SUCCESS in 22m 47s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/4374c92e3dc14e58afa3b8b655ba0a91 : SUCCESS in 17m 08s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/1787ec2653914ae780af5b6a4cb2005c : SUCCESS in 7m 58s","accounts_in_message":[],"_revision_number":1},{"id":"6c61e4c2e23c479cd6b709f3257caf03d2aeb675","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-10 14:04:12.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"426606056daa716c9575d72c32deffa919cfb6e6","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-10 14:06:48.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/b9ee64d08fa44871a4ea8cc119dba0df\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/815c0e211ab64c32808f34bb9499c486 : SUCCESS in 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"0e4a257e8636a979605c614a35e79ba47b74d870","revisions":{"0e4a257e8636a979605c614a35e79ba47b74d870":{"kind":"REWORK","_number":1,"created":"2022-11-30 17:20:35.000000000","uploader":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"ref":"refs/changes/93/866193/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/93/866193/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/866193/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/866193/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/93/866193/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/93/866193/1"}}},"commit":{"parents":[{"commit":"15502ddedc23e6591ace4e73fa8ce5b18b5644b0","subject":"[compute] always set instance.host in post_livemigration","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/15502ddedc23e6591ace4e73fa8ce5b18b5644b0"}]}],"author":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2022-08-16 06:49:53.000000000","tz":0},"committer":{"name":"melanie witt","email":"melwittt@gmail.com","date":"2022-11-30 17:20:12.000000000","tz":0},"subject":"Adapt websocketproxy tests for SimpleHTTPServer fix","message":"Adapt websocketproxy tests for SimpleHTTPServer fix\n\nIn response to bug 1927677 we added a workaround to\nNovaProxyRequestHandler to respond with a 400 Bad Request if an open\nredirect is attempted:\n\n  Ie36401c782f023d1d5f2623732619105dc2cfa24\n  I95f68be76330ff09e5eabb5ef8dd9a18f5547866\n\nRecently in python 3.10.6, a fix has landed in cpython to respond with\na 301 Moved Permanently to a sanitized URL that has had extra leading\n\u0027/\u0027 characters removed.\n\nThis breaks our existing unit tests which assume a 400 Bad Request as\nthe only expected response.\n\nThis adds handling of a 301 Moved Permanently response and asserts that\nthe redirect location is the expected sanitized URL. Doing this instead\nof checking for a given python version will enable the tests to continue\nto work if and when the cpython fix gets backported to older python\nversions.\n\nWhile updating the tests, the opportunity was taken to commonize the\ncode of two unit tests that were nearly identical.\n\nRelated-Bug: #1927677\nCloses-Bug: #1986545\n\nChange-Id: I27441d15cc6fa2ff7715ba15aa900961aadbf54a\n(cherry picked from commit 15769b883ed4a86d62b141ea30d3f1590565d8e0)\n(cherry picked from commit 4a2b44c7cf55d1d79d5a2dd638bd0def3af0f5af)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0e4a257e8636a979605c614a35e79ba47b74d870"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0e4a257e8636a979605c614a35e79ba47b74d870"}]},"branch":"refs/heads/stable/xena"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[]}