)]}'
{".zuul.yaml":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"45e8cbc2bf2292639a97d0c8fc154badd4aa2c26","unresolved":true,"context_lines":[{"line_number":692,"context_line":"        # need to keep scope check disable for keystone."},{"line_number":693,"context_line":"        #"},{"line_number":694,"context_line":"        # By default, Nova service has enabled the scope and new defaults so"},{"line_number":695,"context_line":"        # we do not need to explicitly enable those."},{"line_number":696,"context_line":"        CINDER_ENFORCE_SCOPE: true"},{"line_number":697,"context_line":"        GLANCE_ENFORCE_SCOPE: true"},{"line_number":698,"context_line":"        NEUTRON_ENFORCE_SCOPE: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"420ceac3_0cccc048","line":695,"updated":"2023-01-10 22:22:42.000000000","message":"Right, but don\u0027t we need to do something to the regular job to make sure we\u0027re still testing that the old defaults work? Until we have a release where we expect rules to work, on by default, etc we need to keep the old rules from breaking right? Since you\u0027re flipping the defaults in code, doesn\u0027t that mean both this and the regular job(s) are running with new defaults?","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ca842f4570c372c6f450901dffa444b00bc1aee7","unresolved":true,"context_lines":[{"line_number":692,"context_line":"        # need to keep scope check disable for keystone."},{"line_number":693,"context_line":"        #"},{"line_number":694,"context_line":"        # By default, Nova service has enabled the scope and new defaults so"},{"line_number":695,"context_line":"        # we do not need to explicitly enable those."},{"line_number":696,"context_line":"        CINDER_ENFORCE_SCOPE: true"},{"line_number":697,"context_line":"        GLANCE_ENFORCE_SCOPE: true"},{"line_number":698,"context_line":"        NEUTRON_ENFORCE_SCOPE: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"67e9d5b3_e3315465","line":695,"in_reply_to":"420ceac3_0cccc048","updated":"2023-01-11 03:26:34.000000000","message":"yeah, that is good point. we can keep existing jobs keep running with old defaults. I need to flip the setting in devstack for that. I will push the patch. And once we release the new default enableing then we can do reverse (runing all jobs on new default and have one job testing old defaults).","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c06ef5247eb1ad741770b27abf9d9d21a3132ce4","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        # need to keep scope check disable for keystone."},{"line_number":693,"context_line":"        #"},{"line_number":694,"context_line":"        # By default, Nova service has enabled the scope and new defaults so"},{"line_number":695,"context_line":"        # we do not need to explicitly enable those."},{"line_number":696,"context_line":"        CINDER_ENFORCE_SCOPE: true"},{"line_number":697,"context_line":"        GLANCE_ENFORCE_SCOPE: true"},{"line_number":698,"context_line":"        NEUTRON_ENFORCE_SCOPE: true"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"403803d0_ab162ae9","line":695,"in_reply_to":"67e9d5b3_e3315465","updated":"2023-01-11 15:47:09.000000000","message":"done in https://review.opendev.org/c/openstack/devstack/+/869781\n\nNow all existing jobs run on old defaults and tempest-integrated-compute-enforce-scope-new-defaults job with new defaults. On release of this change we can flip the test running.","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"afc868ad9f997b23d4f1d36a859b61e024ffddde","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        CINDER_ENFORCE_SCOPE: true"},{"line_number":695,"context_line":"        GLANCE_ENFORCE_SCOPE: true"},{"line_number":696,"context_line":"        NEUTRON_ENFORCE_SCOPE: true"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"- project:"},{"line_number":699,"context_line":"    # Please try to keep the list of job names sorted alphabetically."},{"line_number":700,"context_line":"    templates:"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"4d0c144f_818bb3ca","line":697,"updated":"2023-01-13 15:13:56.000000000","message":"++","commit_id":"d97af33c0639b548f8a66ab14019259e9b4210be"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"6103f8ca53f5b4733cb27579c996dcfd3684b54a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e2de3237_2886f820","updated":"2022-12-09 19:03:39.000000000","message":"still need to fix the functional tests.","commit_id":"3b96c322677edf45a6e73db2244ccf6a0ef54806"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"81326471c45b15f48bc6dc2c7c4e8b6c4c4553eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1fbf3141_fa0a2620","updated":"2022-12-27 03:46:05.000000000","message":"still WIP as functional test need updates to move to actual policy.","commit_id":"3ca026ba8727542ff2a71b3ca3f8dafdc652a1e1"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"951ce4f6f7b560e457fa39caac56bac51888761a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"12ce4445_11e5fab1","updated":"2023-01-08 20:17:02.000000000","message":"seems we are hitting missing interpreter again? \n\nfunctional-py38: 503 E failed with could not find python interpreter matching any of the specs functional-py38","commit_id":"6b01d2061a5ee487a2d2fbd7a51d70874b334fff"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"45e8cbc2bf2292639a97d0c8fc154badd4aa2c26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0f02bc66_9226415a","updated":"2023-01-10 22:22:42.000000000","message":"Definitely in favor of switching this early. I\u0027m not quite sure I get the new job and the new defaults, but I\u0027m sure gmann knows what he\u0027s doing :)","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"030e23e8ec821f4944b5e45493eecec8bb2ccaaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f11920e0_2e45a4ad","updated":"2023-01-10 17:01:24.000000000","message":"I should add this in commit msg but this is tempest integration job enabling new rbac https://zuul.openstack.org/builds?job_name\u003dtempest-full-enforce-scope-new-defaults\u0026skip\u003d0","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5c46acc4ebe6065afacd98454ba5a3b33682c5b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ad843b33_14a054d8","updated":"2023-01-10 16:59:13.000000000","message":"agreed on the priority. If we wanna flip, the earlier the better.","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c94d9a62680a7cbb235d1481317da8c9840582be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"35b6389a_8b3811e6","updated":"2023-01-10 16:41:43.000000000","message":"making it priority as we should switch the defaults as early as possible and not during the end of cycle.","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f3ec805a474d9a551ba998e4bd5422622c499746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"16c168a9_a9f045cd","updated":"2023-01-09 19:32:58.000000000","message":"recheck deps updated","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"afc868ad9f997b23d4f1d36a859b61e024ffddde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6bba4a02_2ee8573e","updated":"2023-01-13 15:13:56.000000000","message":"OK, it looks to me a legit modification.","commit_id":"d97af33c0639b548f8a66ab14019259e9b4210be"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"045c563f95cdd1bbe5ac33af8528d9eb2eb57445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"c3efc602_61fbfa40","updated":"2023-01-12 22:25:03.000000000","message":"The old job is running with new defaults off, the new job with new defaults on. Nova and tempest configs match, so I think this is actually testing what we think it\u0027s testing.\n\nThanks gmann!","commit_id":"d97af33c0639b548f8a66ab14019259e9b4210be"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"934ee7d5567a2e8640341084e5d08023eb105eaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"20e08e52_05b15cd5","updated":"2023-01-16 19:02:00.000000000","message":"recheck compute integration jobs seems timeout","commit_id":"d97af33c0639b548f8a66ab14019259e9b4210be"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c3f6151aaac0e08d4b36f20b07476d0384113c04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"27cd2522_48383c84","updated":"2023-01-13 23:01:46.000000000","message":"recheck deps merged","commit_id":"d97af33c0639b548f8a66ab14019259e9b4210be"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"9880199bdb0b842ef7bf09a0c39474b0b89fdeff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e08a77e0_0bc52b7e","updated":"2023-01-14 22:10:15.000000000","message":"recheck py310 job failing for service conflict","commit_id":"d97af33c0639b548f8a66ab14019259e9b4210be"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"c2f612f4275de948f0f2bb1adfdd8eddcc7b20a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8a6d4692_53f0f01a","updated":"2023-01-14 12:15:15.000000000","message":"recheck test_new_compute_init_with_pci_devs","commit_id":"d97af33c0639b548f8a66ab14019259e9b4210be"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"7aee13a7b5291f200a95039719cc263381e10a33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6f1fd6ca_5328a395","updated":"2023-01-14 03:06:53.000000000","message":"recheck test_resize_confirm_from_stopped import issue","commit_id":"d97af33c0639b548f8a66ab14019259e9b4210be"}],"nova/tests/unit/api/openstack/compute/test_server_groups.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"45e8cbc2bf2292639a97d0c8fc154badd4aa2c26","unresolved":true,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_create_server_group_with_new_policy_before_264(self):"},{"line_number":132,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027, roles\u003d[\u0027member\u0027, \u0027reader\u0027],"},{"line_number":133,"context_line":"                                      version\u003d\u00272.63\u0027)"},{"line_number":134,"context_line":"        policy \u003d \u0027anti-affinity\u0027"},{"line_number":135,"context_line":"        rules \u003d {\u0027max_server_per_host\u0027: 3}"},{"line_number":136,"context_line":"        # \u0027policy\u0027 isn\u0027t an acceptable request key before 2.64"}],"source_content_type":"text/x-python","patch_set":12,"id":"86ac98ad_bd095fac","line":133,"updated":"2023-01-10 22:22:42.000000000","message":"Seems like this is a bit of a recipe for forgetting to do this in all the places we need to override the microversion. I wonder if we could either modify self.member_req here to change the version, or have some helper method replace self.member_req:\n\n def member_req(self, version\u003dNone):\n     return fakes.HTTPRequest.blank(\u0027\u0027, roles\u003d[\u0027member\u0027, \u0027reader],\n                                    version\u003dversion)\n\nor maybe something in fakes? Not a huge deal I guess, I just can imagine this being failure-prone to remember to select the right roles each time.","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ca842f4570c372c6f450901dffa444b00bc1aee7","unresolved":true,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_create_server_group_with_new_policy_before_264(self):"},{"line_number":132,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027, roles\u003d[\u0027member\u0027, \u0027reader\u0027],"},{"line_number":133,"context_line":"                                      version\u003d\u00272.63\u0027)"},{"line_number":134,"context_line":"        policy \u003d \u0027anti-affinity\u0027"},{"line_number":135,"context_line":"        rules \u003d {\u0027max_server_per_host\u0027: 3}"},{"line_number":136,"context_line":"        # \u0027policy\u0027 isn\u0027t an acceptable request key before 2.64"}],"source_content_type":"text/x-python","patch_set":12,"id":"b84aadad_8a15ad43","line":133,"in_reply_to":"86ac98ad_bd095fac","updated":"2023-01-11 03:26:34.000000000","message":"that will be easy. done.","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"c06ef5247eb1ad741770b27abf9d9d21a3132ce4","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def test_create_server_group_with_new_policy_before_264(self):"},{"line_number":132,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027\u0027, roles\u003d[\u0027member\u0027, \u0027reader\u0027],"},{"line_number":133,"context_line":"                                      version\u003d\u00272.63\u0027)"},{"line_number":134,"context_line":"        policy \u003d \u0027anti-affinity\u0027"},{"line_number":135,"context_line":"        rules \u003d {\u0027max_server_per_host\u0027: 3}"},{"line_number":136,"context_line":"        # \u0027policy\u0027 isn\u0027t an acceptable request key before 2.64"}],"source_content_type":"text/x-python","patch_set":12,"id":"43b43b2a_ab4942f6","line":133,"in_reply_to":"b84aadad_8a15ad43","updated":"2023-01-11 15:47:09.000000000","message":"Done","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"}],"nova/tests/unit/api/openstack/fakes.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"45e8cbc2bf2292639a97d0c8fc154badd4aa2c26","unresolved":true,"context_lines":[{"line_number":240,"context_line":"    def blank(cls, *args, **kwargs):"},{"line_number":241,"context_line":"        defaults \u003d {\u0027base_url\u0027: \u0027http://localhost/v2\u0027}"},{"line_number":242,"context_line":"        use_admin_context \u003d kwargs.pop(\u0027use_admin_context\u0027, False)"},{"line_number":243,"context_line":"        roles \u003d kwargs.pop(\u0027roles\u0027, [])"},{"line_number":244,"context_line":"        if use_admin_context:"},{"line_number":245,"context_line":"            roles.append(\u0027admin\u0027)"},{"line_number":246,"context_line":"        project_id \u003d kwargs.pop(\u0027project_id\u0027, FAKE_PROJECT_ID)"}],"source_content_type":"text/x-python","patch_set":12,"id":"f599c416_1fbd08d1","line":243,"updated":"2023-01-10 22:22:42.000000000","message":"So if we don\u0027t pass roles, we get an empty set, which should always fail pretty much every policy rule? If so, maybe that\u0027s enough to not forget about roles.","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"afc868ad9f997b23d4f1d36a859b61e024ffddde","unresolved":true,"context_lines":[{"line_number":240,"context_line":"    def blank(cls, *args, **kwargs):"},{"line_number":241,"context_line":"        defaults \u003d {\u0027base_url\u0027: \u0027http://localhost/v2\u0027}"},{"line_number":242,"context_line":"        use_admin_context \u003d kwargs.pop(\u0027use_admin_context\u0027, False)"},{"line_number":243,"context_line":"        roles \u003d kwargs.pop(\u0027roles\u0027, [])"},{"line_number":244,"context_line":"        if use_admin_context:"},{"line_number":245,"context_line":"            roles.append(\u0027admin\u0027)"},{"line_number":246,"context_line":"        project_id \u003d kwargs.pop(\u0027project_id\u0027, FAKE_PROJECT_ID)"}],"source_content_type":"text/x-python","patch_set":12,"id":"d99157b8_69e058fb","line":243,"in_reply_to":"0a7d5572_d2ad44ed","updated":"2023-01-13 15:13:56.000000000","message":"Yes, so that\u0027s why you provided member_req and reader_get for providing the roles by default on our tests, gotcha.","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ca842f4570c372c6f450901dffa444b00bc1aee7","unresolved":true,"context_lines":[{"line_number":240,"context_line":"    def blank(cls, *args, **kwargs):"},{"line_number":241,"context_line":"        defaults \u003d {\u0027base_url\u0027: \u0027http://localhost/v2\u0027}"},{"line_number":242,"context_line":"        use_admin_context \u003d kwargs.pop(\u0027use_admin_context\u0027, False)"},{"line_number":243,"context_line":"        roles \u003d kwargs.pop(\u0027roles\u0027, [])"},{"line_number":244,"context_line":"        if use_admin_context:"},{"line_number":245,"context_line":"            roles.append(\u0027admin\u0027)"},{"line_number":246,"context_line":"        project_id \u003d kwargs.pop(\u0027project_id\u0027, FAKE_PROJECT_ID)"}],"source_content_type":"text/x-python","patch_set":12,"id":"0a7d5572_d2ad44ed","line":243,"in_reply_to":"f599c416_1fbd08d1","updated":"2023-01-11 03:26:34.000000000","message":"yes, use_admin_context will add \u0027admin\u0027 to roles(L245) otherwise every test needs to send correct set of roles now.","commit_id":"41ba483a2bd0c0b989b376ee741c3ac098148653"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"045c563f95cdd1bbe5ac33af8528d9eb2eb57445","unresolved":true,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    @classmethod"},{"line_number":263,"context_line":"    def reader_req(cls, *args, **kwargs):"},{"line_number":264,"context_line":"        return cls.blank(*args, roles\u003d[\u0027reader\u0027], **kwargs)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"class HTTPRequestV21(HTTPRequest):"}],"source_content_type":"text/x-python","patch_set":13,"id":"8f9839df_97be7c39","line":264,"updated":"2023-01-12 22:25:03.000000000","message":"Thanks for doing this, I think this is better.","commit_id":"d97af33c0639b548f8a66ab14019259e9b4210be"}]}