)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20733,"name":"Rajesh Tailor","email":"ratailor@redhat.com","username":"rajesht"},"change_message_id":"dbc0a14db1d407bc566e71d00f3011e4101e7256","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7ae8a68a_9c68f24e","updated":"2022-12-12 07:33:10.000000000","message":"It would be good to add unit tests for this. otherwise LGTM.","commit_id":"167fe92d2549dff53a70ada3318c648ce34d26a3"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"77288eed9cd5c9fd5dc8345e4938e0654559d2d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"80c5eae4_2a897766","updated":"2022-12-12 09:52:44.000000000","message":"Thank you this fix, could you also provide unittests?","commit_id":"167fe92d2549dff53a70ada3318c648ce34d26a3"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"57ea9c7f3bd7feee2713c0de7941ed9ea8e071bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b32eccb_84c95c74","updated":"2022-12-11 12:14:52.000000000","message":"recheck","commit_id":"167fe92d2549dff53a70ada3318c648ce34d26a3"},{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"a92e1385ae9ec9434d7c24a02a5dd5f801d8ff23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dbd2b574_79bc9392","updated":"2022-12-08 10:00:04.000000000","message":"recheck","commit_id":"167fe92d2549dff53a70ada3318c648ce34d26a3"}],"nova/compute/manager.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"77288eed9cd5c9fd5dc8345e4938e0654559d2d7","unresolved":true,"context_lines":[{"line_number":4606,"context_line":"                    # in placement by deleting them here..."},{"line_number":4607,"context_line":"                    self._delete_allocation_after_move("},{"line_number":4608,"context_line":"                        context, instance, migration)"},{"line_number":4609,"context_line":"                    if not instance.host \u003d\u003d self.host:"},{"line_number":4610,"context_line":"                        # ...inform the scheduler about the move..."},{"line_number":4611,"context_line":"                        self._delete_scheduler_instance_info("},{"line_number":4612,"context_line":"                            context, instance.uuid)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4f5bfc82_2489afde","line":4609,"updated":"2022-12-12 09:52:44.000000000","message":"I would have added this check inside the function delete_scheduler_instance_info. And passed to it instance instead of instance_uuid","commit_id":"167fe92d2549dff53a70ada3318c648ce34d26a3"}]}