)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d59fdce46204831ad72802d3adfc0f4318322a25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab69833d_a0fa02a0","updated":"2022-12-08 07:17:05.000000000","message":"Hey, Since this is a bug fix, could you open a bug report and sharing some details and logs?\nThis would help to review your fix.","commit_id":"ecf70e154f404b63a76df2a55edb3a226208776c"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"2c3a4e1357ed508107c6dd7a056727e2aeb2eb2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4af90eab_2102520a","updated":"2022-12-12 12:15:28.000000000","message":"Sounds good thank you, but looks like you need to fix tests \n\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9be/866960/4/check/openstack-tox-py38/9be4e4e/testr_results.html","commit_id":"03b3abba7c721b9a269fac52696f631f8617b17b"}],"nova/compute/manager.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"6f000f6f0e27d05c8c40949837c386835b2a9355","unresolved":true,"context_lines":[{"line_number":1108,"context_line":"            instance.task_state in [task_states.REBUILDING,"},{"line_number":1109,"context_line":"                                    task_states.REBUILD_BLOCK_DEVICE_MAPPING,"},{"line_number":1110,"context_line":"                                    task_states.REBUILD_SPAWNING]):"},{"line_number":1111,"context_line":"            # NOTE(yangzhipeng): if the instance state is not latested,"},{"line_number":1112,"context_line":"            # the instance maybe reset error incorrectly, so refresh instance."},{"line_number":1113,"context_line":"            instance.refresh()"},{"line_number":1114,"context_line":"            if instance.task_state is None and \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"c3c112e7_d0074de3","line":1111,"updated":"2022-12-08 10:14:08.000000000","message":"According the bug you have reported it looks like an edge case when an instance get evacuated and the compute service on source restart at same time. Some sort of race condition.\n\nCalling refresh and so doing a double check before to set the instance in error could make sense.\n\nI would have make this refresh when entering in the function","commit_id":"e7cbfdff3566236d06b67dfb891bdfaae8fb04d5"},{"author":{"_account_id":35549,"name":"yzp","display_name":"yangzhipeng","email":"yangzhipeng@cmss.chinamobile.com","username":"yzp"},"change_message_id":"cade3b74d5fe81f65e92324b4b5edf3993dad536","unresolved":false,"context_lines":[{"line_number":1108,"context_line":"            instance.task_state in [task_states.REBUILDING,"},{"line_number":1109,"context_line":"                                    task_states.REBUILD_BLOCK_DEVICE_MAPPING,"},{"line_number":1110,"context_line":"                                    task_states.REBUILD_SPAWNING]):"},{"line_number":1111,"context_line":"            # NOTE(yangzhipeng): if the instance state is not latested,"},{"line_number":1112,"context_line":"            # the instance maybe reset error incorrectly, so refresh instance."},{"line_number":1113,"context_line":"            instance.refresh()"},{"line_number":1114,"context_line":"            if instance.task_state is None and \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"71e81591_1d50a792","line":1111,"in_reply_to":"b47686e6_b027dfeb","updated":"2022-12-08 10:32:00.000000000","message":"Done","commit_id":"e7cbfdff3566236d06b67dfb891bdfaae8fb04d5"},{"author":{"_account_id":35549,"name":"yzp","display_name":"yangzhipeng","email":"yangzhipeng@cmss.chinamobile.com","username":"yzp"},"change_message_id":"b1c4d909e376009c7517fbc5f63155467c64e26e","unresolved":true,"context_lines":[{"line_number":1108,"context_line":"            instance.task_state in [task_states.REBUILDING,"},{"line_number":1109,"context_line":"                                    task_states.REBUILD_BLOCK_DEVICE_MAPPING,"},{"line_number":1110,"context_line":"                                    task_states.REBUILD_SPAWNING]):"},{"line_number":1111,"context_line":"            # NOTE(yangzhipeng): if the instance state is not latested,"},{"line_number":1112,"context_line":"            # the instance maybe reset error incorrectly, so refresh instance."},{"line_number":1113,"context_line":"            instance.refresh()"},{"line_number":1114,"context_line":"            if instance.task_state is None and \\"}],"source_content_type":"text/x-python","patch_set":3,"id":"b47686e6_b027dfeb","line":1111,"in_reply_to":"c3c112e7_d0074de3","updated":"2022-12-08 10:31:46.000000000","message":"accept","commit_id":"e7cbfdff3566236d06b67dfb891bdfaae8fb04d5"}]}