)]}'
{"nova/virt/ironic/driver.py":[{"author":{"_account_id":10342,"name":"Jay Faulkner","display_name":"JayF","email":"jay@jvf.cc","username":"JayF","status":"youtube.com/@oss-gr / podcast.gr-oss.io"},"change_message_id":"89b150e9d7076de501a3b98b78f84fd72ebc5f19","unresolved":true,"context_lines":[{"line_number":1396,"context_line":"                         instance\u003dinstance)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"        if hard:"},{"line_number":1399,"context_line":"            self.ironic_connection.set_node_power_state(node.uuid, \u0027reboot\u0027)"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":1402,"context_line":"                    self._wait_for_power_state, instance, \u0027reboot\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"c01cffba_483ae33c","line":1399,"updated":"2023-12-06 20:18:18.000000000","message":"Just a general comment; not really feedback for this change; but I\u0027m surprised we don\u0027t have constants for power states. We probably should do that (maybe even in the SDK).","commit_id":"4bffd6fc2108ee94f264d2b6f77bff6c5aff163a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"12aaf83c59dfdc3f095761be024ccb60cf59c5a9","unresolved":true,"context_lines":[{"line_number":1396,"context_line":"                         instance\u003dinstance)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"        if hard:"},{"line_number":1399,"context_line":"            self.ironic_connection.set_node_power_state(node.uuid, \u0027reboot\u0027)"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":1402,"context_line":"                    self._wait_for_power_state, instance, \u0027reboot\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"df0481cd_ffd331d7","line":1399,"in_reply_to":"c01cffba_483ae33c","updated":"2023-12-07 10:53:53.000000000","message":"Good point. Patches more than welcome. I think an Enum would be an appropriate container for this.","commit_id":"4bffd6fc2108ee94f264d2b6f77bff6c5aff163a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"c15ab6c5652bd1e65c3731f6fabd2d1f021fe8a6","unresolved":true,"context_lines":[{"line_number":1396,"context_line":"                         instance\u003dinstance)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"        if hard:"},{"line_number":1399,"context_line":"            self.ironic_connection.set_node_power_state(node.uuid, \u0027reboot\u0027)"},{"line_number":1400,"context_line":""},{"line_number":1401,"context_line":"        timer \u003d loopingcall.FixedIntervalLoopingCall("},{"line_number":1402,"context_line":"                    self._wait_for_power_state, instance, \u0027reboot\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"96ead88d_8c3403f2","line":1399,"in_reply_to":"df0481cd_ffd331d7","updated":"2023-12-07 11:09:05.000000000","message":"ya putting them in the sdk would make sensse \nwe could creat a constants file for the ironic driver but im ok with just passiing the string for now. this can always be done as a cleanup patch at the end fo the serise too.","commit_id":"4bffd6fc2108ee94f264d2b6f77bff6c5aff163a"}]}