)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"98007c406d12552156653e7e5eec5025f0ccff5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4107a3be_6e1d6f70","updated":"2023-08-04 23:37:13.000000000","message":"LGTM, demonstrates the current problematic behavior in preparation for the fix.","commit_id":"e5766446e5513aba6a64f6944e50b9effa3bff52"}],"nova/tests/unit/compute/test_compute_mgr.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a10bf6e3b7c894a159bc8a86f0aedc5d58e99bfe","unresolved":true,"context_lines":[{"line_number":2218,"context_line":"        instance \u003d objects.Instance(self.context)"},{"line_number":2219,"context_line":"        instance.uuid \u003d uuids.instance"},{"line_number":2220,"context_line":"        instance.vm_state \u003d vm_states.ACTIVE"},{"line_number":2221,"context_line":"        instance.task_state \u003d task_states.REBOOTING_HARD"},{"line_number":2222,"context_line":"        instance.power_state \u003d power_state.RUNNING"},{"line_number":2223,"context_line":""},{"line_number":2224,"context_line":"        # To uncomment once bug #1999674 is fixed and remove all the code below"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf2b80d3_79f63001","line":2221,"updated":"2023-01-04 18:55:55.000000000","message":"Can you add another case for REBOOT_PENDING and REBOOT_PENDING_HARD? I\u0027m okay if it\u0027s at the end of this series. I just think it\u0027s probably best to codify our intent in the tests so that it doesn\u0027t get removed from the allowed list later and no tests fail as a result.","commit_id":"b4254c3a51257ccb3acd67cce058ff6a1cbb27e6"},{"author":{"_account_id":29037,"name":"Pierre-Samuel Le Stang","email":"pierre-samuel.le-stang@ovhcloud.com","username":"pslestang"},"change_message_id":"3430e5150c05c19a83e03ca9bf5c91af7c38a466","unresolved":false,"context_lines":[{"line_number":2218,"context_line":"        instance \u003d objects.Instance(self.context)"},{"line_number":2219,"context_line":"        instance.uuid \u003d uuids.instance"},{"line_number":2220,"context_line":"        instance.vm_state \u003d vm_states.ACTIVE"},{"line_number":2221,"context_line":"        instance.task_state \u003d task_states.REBOOTING_HARD"},{"line_number":2222,"context_line":"        instance.power_state \u003d power_state.RUNNING"},{"line_number":2223,"context_line":""},{"line_number":2224,"context_line":"        # To uncomment once bug #1999674 is fixed and remove all the code below"}],"source_content_type":"text/x-python","patch_set":1,"id":"5cfe5176_be51c1ec","line":2221,"in_reply_to":"bf2b80d3_79f63001","updated":"2023-01-05 16:34:50.000000000","message":"I did not implemented tests on REBOOT_PENDING and REBOOT_PENDING_HARD as those task_states are not passing in the corresponding code.","commit_id":"b4254c3a51257ccb3acd67cce058ff6a1cbb27e6"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"98007c406d12552156653e7e5eec5025f0ccff5b","unresolved":true,"context_lines":[{"line_number":2146,"context_line":"                continue"},{"line_number":2147,"context_line":"            instance.vm_state \u003d state"},{"line_number":2148,"context_line":"            self._test_init_instance_retries_reboot(instance, \u0027HARD\u0027,"},{"line_number":2149,"context_line":"                                                    power_state.RUNNING)"},{"line_number":2150,"context_line":""},{"line_number":2151,"context_line":"    def test_init_instance_retries_reboot_pending_soft_became_hard(self):"},{"line_number":2152,"context_line":"        instance \u003d objects.Instance(self.context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f885fe1a_a32d9bf0","line":2149,"updated":"2023-08-04 23:37:13.000000000","message":"AFAICT the two tests above cover the REBOOT_PENDING and REBOOT_PENDING_HARD behavior to retry a reboot.","commit_id":"e5766446e5513aba6a64f6944e50b9effa3bff52"}]}