)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"51c80a3c6821b6fc4f9f77eb10801844d0f48673","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2ce65700_3a85ac3b","line":42,"updated":"2022-12-16 00:42:36.000000000","message":"this is missing the cherry picked form line for zed","commit_id":"97ceea402ce3854b663dfbbcce89dfc1cecacc0d"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"5ad281f0a87dfc25750616b7929784e388433886","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e7286546_5a89a803","line":42,"in_reply_to":"2ce65700_3a85ac3b","updated":"2022-12-16 13:52:02.000000000","message":"Good catch! I started this PR via the UI; would have thought it would automagically appear. Unless I accidentally deleted it. Anyway, I added it.","commit_id":"97ceea402ce3854b663dfbbcce89dfc1cecacc0d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"17b112b1f975136d63cea482d395d5ba0c702e70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5e78453c_c2c58d1d","line":42,"in_reply_to":"8b516a52_d04531e7","updated":"2023-01-10 14:12:41.000000000","message":"Actually the UI adds it IFF the cherry picked patch has merged (so the trick is to wait until a given patch merged on an N+1 branch then cherry pick it via the UI to branch N, and so the \u0027cherry-picked from\u0027 lines will be OK) if i remember correctly (I almost never use this on the GUI).","commit_id":"97ceea402ce3854b663dfbbcce89dfc1cecacc0d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ad3949f8bdc2bb8fb64ac5c61e6430a5eda20ed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8b516a52_d04531e7","line":42,"in_reply_to":"e7286546_5a89a803","updated":"2022-12-16 17:28:01.000000000","message":"the ui  will add it onece and only once.\nso for the first cherrypick it will added the first line but not add it for the rest.\n\nthat always catches me out too when i start form the ui.","commit_id":"97ceea402ce3854b663dfbbcce89dfc1cecacc0d"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"17b112b1f975136d63cea482d395d5ba0c702e70","unresolved":true,"context_lines":[{"line_number":34,"context_line":"deleted before reserving the resources in Placement."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Git conflict in nova/conf/workarounds.py due to yoga not having"},{"line_number":37,"context_line":"the \u0027skip_hypervisor_version_check_on_lm\u0027 config option."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Closes-Bug: #1974070"},{"line_number":40,"context_line":"Change-Id: Iab92124b5776a799c7f90d07281d28fcf191c8fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"2fd0fdc6_20740b4f","line":37,"updated":"2023-01-10 14:12:41.000000000","message":"nit: the git cherry pick command adds the \u0027Conflicts:\u0027 with list of files. It is more visible if we keep that.\n\nSomething like this:\n\nConflicts:\n    nova/conf/workarounds.py\n\nNOTE: conflict in workaround.py is due to yoga not having the \u0027skip_hypervisor_version_check_on_lm\u0027 config option.","commit_id":"aff91724231e4c4e3b26bd94d76d732a5ee23d83"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"ad3949f8bdc2bb8fb64ac5c61e6430a5eda20ed8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"afa995f3_0f1f2055","updated":"2022-12-16 17:28:01.000000000","message":"other then the trivial conflict in the workarounds config options which is called out in the commit this is a clean backport so looks good to me.\nthis is not merged yet on the newer release but is approved and is rerunning after hitting a know issue with cirros so i expect it to merge shortly.","commit_id":"c3e434b920a2edf7ccc439f182c19991ec686cd7"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"17b112b1f975136d63cea482d395d5ba0c702e70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"22429357_75cac714","updated":"2023-01-10 14:12:41.000000000","message":"I have a question inline (about default config value) to other stable cores. Giving -1 to highlight my concern.","commit_id":"aff91724231e4c4e3b26bd94d76d732a5ee23d83"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"03943c67111de3b6ecb26d27c5c18524079a9046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4be3cae9_9f67aac9","updated":"2022-12-16 17:58:00.000000000","message":"my bad, I had the wrong cherry-pick commit (too many windows open, le sigh.)","commit_id":"aff91724231e4c4e3b26bd94d76d732a5ee23d83"}],"nova/conf/workarounds.py":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"17b112b1f975136d63cea482d395d5ba0c702e70","unresolved":true,"context_lines":[{"line_number":412,"context_line":"\"\"\"),"},{"line_number":413,"context_line":"    cfg.BoolOpt("},{"line_number":414,"context_line":"        \u0027skip_reserve_in_use_ironic_nodes\u0027,"},{"line_number":415,"context_line":"        default\u003dFalse,"},{"line_number":416,"context_line":"        help\u003d\"\"\""},{"line_number":417,"context_line":"This may be useful if you use the Ironic driver, but don\u0027t have"},{"line_number":418,"context_line":"automatic cleaning enabled in Ironic. Nova, by default, will mark"}],"source_content_type":"text/x-python","patch_set":5,"id":"93b50550_13a2771f","line":415,"range":{"start_line":415,"start_character":16,"end_line":415,"end_character":21},"updated":"2023-01-10 14:12:41.000000000","message":"If I understand correctly the original behaviour is when \u0027skip_reserve_in_use_ironic_nodes\u0027 is True. In backports we should keep the original behaviour, rather than opt-out possibility. So This is strange to me a bit. Should we use True here instead?\n\nNote: I see this was already merged in stable/zed, but we are still at yoga and we did not do a release out of it on stable/zed, so it might worth to consider the above and fix it in stable/zed as well.","commit_id":"aff91724231e4c4e3b26bd94d76d732a5ee23d83"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"df2402791dfc9c896431e3d89a0c90d0ca44c867","unresolved":true,"context_lines":[{"line_number":412,"context_line":"\"\"\"),"},{"line_number":413,"context_line":"    cfg.BoolOpt("},{"line_number":414,"context_line":"        \u0027skip_reserve_in_use_ironic_nodes\u0027,"},{"line_number":415,"context_line":"        default\u003dFalse,"},{"line_number":416,"context_line":"        help\u003d\"\"\""},{"line_number":417,"context_line":"This may be useful if you use the Ironic driver, but don\u0027t have"},{"line_number":418,"context_line":"automatic cleaning enabled in Ironic. Nova, by default, will mark"}],"source_content_type":"text/x-python","patch_set":5,"id":"ae018ccc_25b4a3af","line":415,"range":{"start_line":415,"start_character":16,"end_line":415,"end_character":21},"in_reply_to":"93b50550_13a2771f","updated":"2023-01-10 16:56:21.000000000","message":"my personally opipion is no we shoudl not change the value.\n\ni belive the current value is the correct one for the majority of our users.\nit wil close the exisitng race which causes operational over head for deployments\nadn in the edgecase where cleanign is not used this behavior change will be captured in teh release notes and then can overriede it.\n\n\ni understand that in general we maintain the old behaivor in backports to make such changes opt in but we have precident for not doing that when we know the old behaivor is broken such as blocking numa live migrations.","commit_id":"aff91724231e4c4e3b26bd94d76d732a5ee23d83"}]}