)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8864,"name":"Artom Lifshitz","email":"notartom@gmail.com","username":"artom"},"change_message_id":"081cdd5b3bf25666226101e745b49a0e25f99941","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7cd4e796_13dc8ac6","updated":"2022-12-19 15:16:05.000000000","message":"Fix looks good and relies on previous work to fail gracefully. I still have a small beef with the func test reproducer below this patch ;)","commit_id":"61b3112c8a73a5e2871876cb4b3e57f10dbb45ea"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ef2631d4229ff6a7b7fbc8c340fe3b4465236aed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3555f7cb_69f84a3d","updated":"2022-12-19 15:01:50.000000000","message":"It would be good to have a release notes as well. But this fix looks good to me.","commit_id":"61b3112c8a73a5e2871876cb4b3e57f10dbb45ea"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e425c7861a5d77349b454bcb81bc2c922e26d2ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b8d6a656_960ec8ff","updated":"2023-04-07 07:45:58.000000000","message":"Honestly, I think we\u0027re all good here.","commit_id":"a87b80fb39a65140c7e6c3ed87edf10b1df70be8"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"ae14f1cd0a44890a43df4f0d046504ae33dda642","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"9fc976ea_29ddd339","updated":"2023-01-02 15:25:05.000000000","message":"recheck","commit_id":"a87b80fb39a65140c7e6c3ed87edf10b1df70be8"}],"nova/compute/manager.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7b16770f5cad9c02d6b809b9346ca22069bc95a3","unresolved":true,"context_lines":[{"line_number":9191,"context_line":"            # affect cleaning up source node."},{"line_number":9192,"context_line":"            LOG.exception(\"Post live migration at destination %s failed\","},{"line_number":9193,"context_line":"                          dest, instance\u003dinstance, error\u003derror)"},{"line_number":9194,"context_line":"            raise(error)"},{"line_number":9195,"context_line":""},{"line_number":9196,"context_line":"        self.instance_events.clear_events_for_instance(instance)"},{"line_number":9197,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c09c4af7_51ca1026","line":9194,"updated":"2022-12-19 14:32:35.000000000","message":"It seems this is a good fix\n\n* please remove the redundant parenthesis `raise` is not a functional call. Also you can remove `error` and only say `raise` as it will re-raise the actual error being handled by the `except` block\n* please change the comment above that stats that we don\u0027t want to break _post_live_migration as by raising this we won\u0027t break it because there is a try:except: in the not too old _post_live_migration_update_host().","commit_id":"3a90d4bf85b5be997338b30ce4d8f2edeba22140"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"867b0ba130955ec8a2ba870577e141b501d984c3","unresolved":false,"context_lines":[{"line_number":9191,"context_line":"            # affect cleaning up source node."},{"line_number":9192,"context_line":"            LOG.exception(\"Post live migration at destination %s failed\","},{"line_number":9193,"context_line":"                          dest, instance\u003dinstance, error\u003derror)"},{"line_number":9194,"context_line":"            raise(error)"},{"line_number":9195,"context_line":""},{"line_number":9196,"context_line":"        self.instance_events.clear_events_for_instance(instance)"},{"line_number":9197,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ab8d7e6_7cc0ac85","line":9194,"in_reply_to":"c09c4af7_51ca1026","updated":"2022-12-19 14:58:06.000000000","message":"Done","commit_id":"3a90d4bf85b5be997338b30ce4d8f2edeba22140"},{"author":{"_account_id":26286,"name":"huanhongda","email":"hongda.xun@easystack.cn","username":"huanhongda"},"change_message_id":"0e5bd614c1a6f9fec3d02cfb519cb744b7f3f0f4","unresolved":true,"context_lines":[{"line_number":9180,"context_line":""},{"line_number":9181,"context_line":"        # Define domain at destination host, without doing it,"},{"line_number":9182,"context_line":"        # pause/suspend/terminate do not work."},{"line_number":9183,"context_line":"        post_at_dest_success \u003d True"},{"line_number":9184,"context_line":"        try:"},{"line_number":9185,"context_line":"            self.compute_rpcapi.post_live_migration_at_destination(ctxt,"},{"line_number":9186,"context_line":"                    instance, block_migration, dest)"}],"source_content_type":"text/x-python","patch_set":8,"id":"f8e9c1c1_e819cb1e","line":9183,"range":{"start_line":9183,"start_character":8,"end_line":9183,"end_character":28},"updated":"2025-01-10 06:12:17.000000000","message":"This parameter is useless.","commit_id":"a87b80fb39a65140c7e6c3ed87edf10b1df70be8"}],"nova/tests/functional/regressions/test_bug_2143972.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e425c7861a5d77349b454bcb81bc2c922e26d2ae","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"            server \u003d self._live_migrate("},{"line_number":81,"context_line":"                server, migration_expected_state\u003d\u0027error\u0027,"},{"line_number":82,"context_line":"                server_expected_state\u003d\u0027ERROR\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"            self.assertEqual(self.dest.host, server[\u0027OS-EXT-SRV-ATTR:host\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"b92be5bc_30f056b7","line":82,"updated":"2023-04-07 07:45:58.000000000","message":"++","commit_id":"a87b80fb39a65140c7e6c3ed87edf10b1df70be8"}]}