)]}'
{".zuul.yaml":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"684a56822cba485b1350faf31220e66efaf63d2b","unresolved":false,"context_lines":[{"line_number":376,"context_line":"              # normal"},{"line_number":377,"context_line":"              wait_for_vif_plugged_event_during_hard_reboot: normal"},{"line_number":378,"context_line":"              # Use lower TB cache then default(1GiB), only applicable with"},{"line_number":379,"context_line":"              # libvirt\u003e\u003d8.0.0"},{"line_number":380,"context_line":"              libvirt_tb_cache_size: 128"},{"line_number":381,"context_line":"          $NOVA_CONF:"},{"line_number":382,"context_line":"            quota:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"81d76208_22fcb57a","line":379,"updated":"2023-05-12 14:59:01.000000000","message":"nit: this is for nova-next so all good to me.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"36865fe5d273fa63d996bac53448b9ce99fb85a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"48448e23_3d32e0e9","updated":"2022-12-22 15:22:05.000000000","message":"im not opposed to enabling this but im leanign to adding a new config option in the libvirt section with a default value fo either 32 or 128","commit_id":"eb522f1ddd317cb7c57a7a7b5b9caef34517b15a"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"62d2407cd27e916b3663034b1d9aa361561a4d6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a37b18f5_b09b3dc3","in_reply_to":"48448e23_3d32e0e9","updated":"2023-03-30 10:18:17.000000000","message":"Thanks sean, yes will do that, the patch was pushed to see how much it helps lowering the values in neutron jobs, will get the results first and then update.","commit_id":"eb522f1ddd317cb7c57a7a7b5b9caef34517b15a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7264ce671033e4ea3b9831157f29bedd016f7315","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1418adaa_acb0b672","updated":"2023-04-28 10:15:42.000000000","message":"can you update the nova-next job to use this","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cfa82d501e9d30d704ecccfc9c0d27284b84a84c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7b8fa8fc_90b4788f","in_reply_to":"1418adaa_acb0b672","updated":"2023-04-28 12:14:45.000000000","message":"Done","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2653942c5b9e3e3be0d43b9b3b7a889572a988d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"78788a80_8c419b3d","updated":"2023-05-02 11:52:03.000000000","message":"this shoudl work but the semantics are not quite right.\n\ncan you move the check as i suggested\n\na functional test would be nice but not required as long as the negitive an postive test cases for _supports_tb_cache_size  or init hosts are provided as unit tests.\n\nso overall im happy with the approch once the startup behavior is updated to exit for invlaid config.","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0b1cc4613074fe6d5e63f4a8ba44e09ff9643f3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a614ea65_0d6c5974","in_reply_to":"78788a80_8c419b3d","updated":"2023-05-02 13:46:06.000000000","message":"Thanks done as suggested.","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb031911b7ce36482006bec7653392dc76e4b887","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6a559a9d_d822c205","updated":"2023-05-02 15:16:04.000000000","message":"i think this is almost ready to merge so setting RP+2 since i would like other to start reviewing this.\n\none final issue in line","commit_id":"58dba1ee640b5384837b82dfd2fe11e53b5cb361"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"684a56822cba485b1350faf31220e66efaf63d2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d5f80d82_a82d6ad0","updated":"2023-05-12 14:59:01.000000000","message":"I\u0027m mostly ok with the change, but I have two nits.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"71108a9d66a248ca842c5eaa6d5f7c7b3a2d22b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bd361f6a_f86485c0","updated":"2023-07-12 17:47:18.000000000","message":"IMO, raising warning instead of exception is enough in this case. adding my comment inline.","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b506df8addc88731e7797beec3e751d93a420eaf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4038b0be_a6d3eaa4","updated":"2023-07-13 16:54:48.000000000","message":"I am still in favor of warning instead of exception but yes let\u0027s get other opnion what they prefer and we can go accordingly.","commit_id":"3f7cc63d942bbb7cbda3aae9718fa21f61deecf0"}],"nova/conf/libvirt.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"684a56822cba485b1350faf31220e66efaf63d2b","unresolved":true,"context_lines":[{"line_number":118,"context_line":"* ``disk_prefix``: depends on this"},{"line_number":119,"context_line":"* ``cpu_mode``: depends on this"},{"line_number":120,"context_line":"* ``cpu_models``: depends on this"},{"line_number":121,"context_line":"* ``[workarounds]/libvirt_tb_cache_size``: depends on this"},{"line_number":122,"context_line":"\"\"\"),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027connection_uri\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"63eaceb6_5d1318c9","line":121,"updated":"2023-05-12 14:59:01.000000000","message":"see my comment on the file itself.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5b9ffc2960b266f54d0619c106768524e03ef3d","unresolved":false,"context_lines":[{"line_number":118,"context_line":"* ``disk_prefix``: depends on this"},{"line_number":119,"context_line":"* ``cpu_mode``: depends on this"},{"line_number":120,"context_line":"* ``cpu_models``: depends on this"},{"line_number":121,"context_line":"* ``[workarounds]/libvirt_tb_cache_size``: depends on this"},{"line_number":122,"context_line":"\"\"\"),"},{"line_number":123,"context_line":"    cfg.StrOpt(\u0027connection_uri\u0027,"},{"line_number":124,"context_line":"               default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"74a8938f_4e55e0dc","line":121,"in_reply_to":"63eaceb6_5d1318c9","updated":"2023-07-17 18:27:53.000000000","message":"Ack","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"}],"nova/conf/workarounds.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7264ce671033e4ea3b9831157f29bedd016f7315","unresolved":true,"context_lines":[{"line_number":462,"context_line":"new Nova instance."},{"line_number":463,"context_line":"\"\"\"),"},{"line_number":464,"context_line":"    cfg.IntOpt(\u0027libvirt_tb_cache_size\u0027,"},{"line_number":465,"context_line":"                default\u003dNone,"},{"line_number":466,"context_line":"                min\u003d0,"},{"line_number":467,"context_line":"                help\u003d\"\"\""},{"line_number":468,"context_line":"Qemu\u003e\u003d5.0.0 bumped the default tb-cache size to 1GiB(from 32MiB) and this"}],"source_content_type":"text/x-python","patch_set":5,"id":"8a360a14_a5759975","line":465,"range":{"start_line":465,"start_character":16,"end_line":465,"end_character":29},"updated":"2023-04-28 10:15:42.000000000","message":"nit: you can just leave this unset","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cfa82d501e9d30d704ecccfc9c0d27284b84a84c","unresolved":false,"context_lines":[{"line_number":462,"context_line":"new Nova instance."},{"line_number":463,"context_line":"\"\"\"),"},{"line_number":464,"context_line":"    cfg.IntOpt(\u0027libvirt_tb_cache_size\u0027,"},{"line_number":465,"context_line":"                default\u003dNone,"},{"line_number":466,"context_line":"                min\u003d0,"},{"line_number":467,"context_line":"                help\u003d\"\"\""},{"line_number":468,"context_line":"Qemu\u003e\u003d5.0.0 bumped the default tb-cache size to 1GiB(from 32MiB) and this"}],"source_content_type":"text/x-python","patch_set":5,"id":"8ece33c1_200b484b","line":465,"range":{"start_line":465,"start_character":16,"end_line":465,"end_character":29},"in_reply_to":"8a360a14_a5759975","updated":"2023-04-28 12:14:45.000000000","message":"Done","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"684a56822cba485b1350faf31220e66efaf63d2b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a3201a8a_a449b373","updated":"2023-05-12 14:59:01.000000000","message":"since the knob will exist for a long time, why do we add the conf option as a workaround ? Should just be in [libvirt] group, nope ?","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"579052ce57d9dcc28a946e4c7cade4a35ccd6cda","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ea4eaf00_4a4212f4","in_reply_to":"a3201a8a_a449b373","updated":"2023-05-19 09:41:27.000000000","message":"Actually when it was discussed it was for the CI issue as that\u0027s where it would be mostly used. IIRC sean suggested to add workarounds option, but if required can be moved to other group.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ce781bf1eee668ff75338756b774f4064b51cd76","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7562cafd_9b12d130","in_reply_to":"bd96662a_a847d14b","updated":"2023-05-19 15:03:25.000000000","message":"Ok sure will update, that would make it more general and long lasting.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"403351a64d351df4c053162b3974b2ee613c9386","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bd96662a_a847d14b","in_reply_to":"ea4eaf00_4a4212f4","updated":"2023-05-19 12:37:02.000000000","message":"its only relevent for the qemu virt type i.e. when not using kvm\nwe could move it to the libvirt section if you perfer.\n\ni genrealy did not think we would see this set in produciton much.\ni guess if your use the emulation feature you may want to set it but this\nis mainly for ci/developement usage.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7264ce671033e4ea3b9831157f29bedd016f7315","unresolved":true,"context_lines":[{"line_number":21347,"context_line":"        disk_info \u003d blockinfo.get_disk_info("},{"line_number":21348,"context_line":"            CONF.libvirt.virt_type, instance_ref, image_meta)"},{"line_number":21349,"context_line":""},{"line_number":21350,"context_line":"        cfg \u003d drvr._get_guest_config("},{"line_number":21351,"context_line":"            instance_ref, _fake_network_info(self), image_meta, disk_info)"},{"line_number":21352,"context_line":""},{"line_number":21353,"context_line":"        self.assertEqual(3, len(cfg.features))"},{"line_number":21354,"context_line":"        for idx, device_type in enumerate(["},{"line_number":21355,"context_line":"            vconfig.LibvirtConfigGuestFeatureACPI,"},{"line_number":21356,"context_line":"            vconfig.LibvirtConfigGuestFeatureAPIC,"},{"line_number":21357,"context_line":"            vconfig.LibvirtConfigGuestFeatureVMCoreInfo,"},{"line_number":21358,"context_line":"        ]):"},{"line_number":21359,"context_line":"            self.assertIsInstance(cfg.features[idx], device_type)"},{"line_number":21360,"context_line":""},{"line_number":21361,"context_line":"        self.flags(libvirt_tb_cache_size\u003d10, group\u003d\u0027workarounds\u0027)"},{"line_number":21362,"context_line":"        cfg \u003d drvr._get_guest_config("}],"source_content_type":"text/x-python","patch_set":5,"id":"8d4872d2_6193321e","line":21359,"range":{"start_line":21350,"start_character":3,"end_line":21359,"end_character":65},"updated":"2023-04-28 10:15:42.000000000","message":"this is not relevent to the cache config.\n\nyou should either delete this or put it in a differnt test.","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cfa82d501e9d30d704ecccfc9c0d27284b84a84c","unresolved":false,"context_lines":[{"line_number":21347,"context_line":"        disk_info \u003d blockinfo.get_disk_info("},{"line_number":21348,"context_line":"            CONF.libvirt.virt_type, instance_ref, image_meta)"},{"line_number":21349,"context_line":""},{"line_number":21350,"context_line":"        cfg \u003d drvr._get_guest_config("},{"line_number":21351,"context_line":"            instance_ref, _fake_network_info(self), image_meta, disk_info)"},{"line_number":21352,"context_line":""},{"line_number":21353,"context_line":"        self.assertEqual(3, len(cfg.features))"},{"line_number":21354,"context_line":"        for idx, device_type in enumerate(["},{"line_number":21355,"context_line":"            vconfig.LibvirtConfigGuestFeatureACPI,"},{"line_number":21356,"context_line":"            vconfig.LibvirtConfigGuestFeatureAPIC,"},{"line_number":21357,"context_line":"            vconfig.LibvirtConfigGuestFeatureVMCoreInfo,"},{"line_number":21358,"context_line":"        ]):"},{"line_number":21359,"context_line":"            self.assertIsInstance(cfg.features[idx], device_type)"},{"line_number":21360,"context_line":""},{"line_number":21361,"context_line":"        self.flags(libvirt_tb_cache_size\u003d10, group\u003d\u0027workarounds\u0027)"},{"line_number":21362,"context_line":"        cfg \u003d drvr._get_guest_config("}],"source_content_type":"text/x-python","patch_set":5,"id":"17bc9b88_8acce44f","line":21359,"range":{"start_line":21350,"start_character":3,"end_line":21359,"end_character":65},"in_reply_to":"8d4872d2_6193321e","updated":"2023-04-28 12:14:45.000000000","message":"Done","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7264ce671033e4ea3b9831157f29bedd016f7315","unresolved":true,"context_lines":[{"line_number":21362,"context_line":"        cfg \u003d drvr._get_guest_config("},{"line_number":21363,"context_line":"            instance_ref, _fake_network_info(self), image_meta, disk_info)"},{"line_number":21364,"context_line":""},{"line_number":21365,"context_line":"        self.assertEqual(4, len(cfg.features))"},{"line_number":21366,"context_line":"        for idx, device_type in enumerate(["},{"line_number":21367,"context_line":"            vconfig.LibvirtConfigGuestFeatureACPI,"},{"line_number":21368,"context_line":"            vconfig.LibvirtConfigGuestFeatureAPIC,"},{"line_number":21369,"context_line":"            vconfig.LibvirtConfigGuestFeatureTCG,"},{"line_number":21370,"context_line":"            vconfig.LibvirtConfigGuestFeatureVMCoreInfo,"},{"line_number":21371,"context_line":"        ]):"},{"line_number":21372,"context_line":"            self.assertIsInstance(cfg.features[idx], device_type)"},{"line_number":21373,"context_line":""},{"line_number":21374,"context_line":"        expected \u003d \u0027\u003ctcg\u003e\u003ctb-cache unit\u003d\"MiB\"\u003e10\u003c/tb-cache\u003e\u003c/tcg\u003e\u0027"},{"line_number":21375,"context_line":"        self.assertXmlEqual(expected, cfg.features[2].to_xml())"}],"source_content_type":"text/x-python","patch_set":5,"id":"419032ae_7adbd9cd","line":21372,"range":{"start_line":21365,"start_character":0,"end_line":21372,"end_character":65},"updated":"2023-04-28 10:15:42.000000000","message":"you can also remove this","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cfa82d501e9d30d704ecccfc9c0d27284b84a84c","unresolved":false,"context_lines":[{"line_number":21362,"context_line":"        cfg \u003d drvr._get_guest_config("},{"line_number":21363,"context_line":"            instance_ref, _fake_network_info(self), image_meta, disk_info)"},{"line_number":21364,"context_line":""},{"line_number":21365,"context_line":"        self.assertEqual(4, len(cfg.features))"},{"line_number":21366,"context_line":"        for idx, device_type in enumerate(["},{"line_number":21367,"context_line":"            vconfig.LibvirtConfigGuestFeatureACPI,"},{"line_number":21368,"context_line":"            vconfig.LibvirtConfigGuestFeatureAPIC,"},{"line_number":21369,"context_line":"            vconfig.LibvirtConfigGuestFeatureTCG,"},{"line_number":21370,"context_line":"            vconfig.LibvirtConfigGuestFeatureVMCoreInfo,"},{"line_number":21371,"context_line":"        ]):"},{"line_number":21372,"context_line":"            self.assertIsInstance(cfg.features[idx], device_type)"},{"line_number":21373,"context_line":""},{"line_number":21374,"context_line":"        expected \u003d \u0027\u003ctcg\u003e\u003ctb-cache unit\u003d\"MiB\"\u003e10\u003c/tb-cache\u003e\u003c/tcg\u003e\u0027"},{"line_number":21375,"context_line":"        self.assertXmlEqual(expected, cfg.features[2].to_xml())"}],"source_content_type":"text/x-python","patch_set":5,"id":"7fbbf15c_1c6b2f68","line":21372,"range":{"start_line":21365,"start_character":0,"end_line":21372,"end_character":65},"in_reply_to":"419032ae_7adbd9cd","updated":"2023-04-28 12:14:45.000000000","message":"Done","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7264ce671033e4ea3b9831157f29bedd016f7315","unresolved":true,"context_lines":[{"line_number":21374,"context_line":"        expected \u003d \u0027\u003ctcg\u003e\u003ctb-cache unit\u003d\"MiB\"\u003e10\u003c/tb-cache\u003e\u003c/tcg\u003e\u0027"},{"line_number":21375,"context_line":"        self.assertXmlEqual(expected, cfg.features[2].to_xml())"},{"line_number":21376,"context_line":""},{"line_number":21377,"context_line":"        with mock.patch.object(drvr._conn, \u0027getLibVersion\u0027) as mock_getver:"},{"line_number":21378,"context_line":"            mock_getver.return_value \u003d \\"},{"line_number":21379,"context_line":"                versionutils.convert_version_to_int("},{"line_number":21380,"context_line":"                libvirt_driver.MIN_LIBVIRT_TB_CACHE_SIZE) - 1"},{"line_number":21381,"context_line":""},{"line_number":21382,"context_line":"            self.assertRaises(exception.NovaException,"},{"line_number":21383,"context_line":"                              drvr._get_guest_config, instance_ref,"},{"line_number":21384,"context_line":"                              _fake_network_info(self), image_meta, disk_info)"},{"line_number":21385,"context_line":""},{"line_number":21386,"context_line":""},{"line_number":21387,"context_line":"class TestGuestConfigSysinfoSerialOS(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"0dcc751e_fc36fbba","line":21384,"range":{"start_line":21377,"start_character":7,"end_line":21384,"end_character":78},"updated":"2023-04-28 10:15:42.000000000","message":"this shoudl be in a seperate test","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"cfa82d501e9d30d704ecccfc9c0d27284b84a84c","unresolved":false,"context_lines":[{"line_number":21374,"context_line":"        expected \u003d \u0027\u003ctcg\u003e\u003ctb-cache unit\u003d\"MiB\"\u003e10\u003c/tb-cache\u003e\u003c/tcg\u003e\u0027"},{"line_number":21375,"context_line":"        self.assertXmlEqual(expected, cfg.features[2].to_xml())"},{"line_number":21376,"context_line":""},{"line_number":21377,"context_line":"        with mock.patch.object(drvr._conn, \u0027getLibVersion\u0027) as mock_getver:"},{"line_number":21378,"context_line":"            mock_getver.return_value \u003d \\"},{"line_number":21379,"context_line":"                versionutils.convert_version_to_int("},{"line_number":21380,"context_line":"                libvirt_driver.MIN_LIBVIRT_TB_CACHE_SIZE) - 1"},{"line_number":21381,"context_line":""},{"line_number":21382,"context_line":"            self.assertRaises(exception.NovaException,"},{"line_number":21383,"context_line":"                              drvr._get_guest_config, instance_ref,"},{"line_number":21384,"context_line":"                              _fake_network_info(self), image_meta, disk_info)"},{"line_number":21385,"context_line":""},{"line_number":21386,"context_line":""},{"line_number":21387,"context_line":"class TestGuestConfigSysinfoSerialOS(test.NoDBTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5c398424_26f0a5e6","line":21384,"range":{"start_line":21377,"start_character":7,"end_line":21384,"end_character":78},"in_reply_to":"0dcc751e_fc36fbba","updated":"2023-04-28 12:14:45.000000000","message":"Done","commit_id":"b9cc189e8839d0ebe575ba792a58d357cf73b865"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2653942c5b9e3e3be0d43b9b3b7a889572a988d","unresolved":false,"context_lines":[{"line_number":21355,"context_line":""},{"line_number":21356,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getLibVersion\u0027,"},{"line_number":21357,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("},{"line_number":21358,"context_line":"                            libvirt_driver.MIN_LIBVIRT_TB_CACHE_SIZE) - 1)"},{"line_number":21359,"context_line":"    def test_get_guest_config_feature_tcg_fail(self, mock_getversion):"},{"line_number":21360,"context_line":"        self.flags(virt_type\u003d\u0027qemu\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":21361,"context_line":"        self.flags(libvirt_tb_cache_size\u003d10, group\u003d\u0027workarounds\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"00cfa44a_4f3c9ba5","line":21358,"updated":"2023-05-02 11:52:03.000000000","message":"ack ya that works\n\nalthough there is one test case missing which is if the libvirt version is less the the requried one and you have the cofnig option set then the agent should fail to start in init hosts.\n\nso we shoudl never get to this point in real code because the agent should stop start up due to the invalid config.","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0b1cc4613074fe6d5e63f4a8ba44e09ff9643f3e","unresolved":false,"context_lines":[{"line_number":21355,"context_line":""},{"line_number":21356,"context_line":"    @mock.patch.object(fakelibvirt.Connection, \u0027getLibVersion\u0027,"},{"line_number":21357,"context_line":"                       return_value\u003dversionutils.convert_version_to_int("},{"line_number":21358,"context_line":"                            libvirt_driver.MIN_LIBVIRT_TB_CACHE_SIZE) - 1)"},{"line_number":21359,"context_line":"    def test_get_guest_config_feature_tcg_fail(self, mock_getversion):"},{"line_number":21360,"context_line":"        self.flags(virt_type\u003d\u0027qemu\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":21361,"context_line":"        self.flags(libvirt_tb_cache_size\u003d10, group\u003d\u0027workarounds\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"b11e4151_512a0165","line":21358,"in_reply_to":"00cfa44a_4f3c9ba5","updated":"2023-05-02 13:46:06.000000000","message":"Done","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"}],"nova/virt/libvirt/config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25666cba2c1db0b620fa580c0674594b0b9d4c51","unresolved":true,"context_lines":[{"line_number":2744,"context_line":""},{"line_number":2745,"context_line":"    def format_dom(self):"},{"line_number":2746,"context_line":"        root \u003d super(LibvirtConfigGuestFeatureTCG, self).format_dom()"},{"line_number":2747,"context_line":"        root.append(self._text_node(\"tb-cache\", \"32\","},{"line_number":2748,"context_line":"                                    unit\u003d\"MiB\"))"},{"line_number":2749,"context_line":""},{"line_number":2750,"context_line":"        return root"}],"source_content_type":"text/x-python","patch_set":1,"id":"72fa8e99_ffcdbbff","line":2747,"updated":"2022-12-22 15:21:00.000000000","message":"32 is the value used for 32bit hosts.\nnova removed support for 32bit architecure about 4 years ago.\n\n128mb is the value intended for 64bit hosts intending to run user-mode binaries.\n\nhttps://github.com/qemu/qemu/commit/600e17b26#diff-33efcf96522a43f6f5041f7b3a045a7c508ca5eb5a06ccfc6a2e208bedf0f422R940\n\n\nif we are to hard code a value for nova i think 128 would be more correct that said we should consider fi this should be a host configuration option. This value directly contibutes to the qemu overhead and needs to be accounted for by the host reserved memory configuration options.","commit_id":"eb522f1ddd317cb7c57a7a7b5b9caef34517b15a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7264ce671033e4ea3b9831157f29bedd016f7315","unresolved":false,"context_lines":[{"line_number":2744,"context_line":""},{"line_number":2745,"context_line":"    def format_dom(self):"},{"line_number":2746,"context_line":"        root \u003d super(LibvirtConfigGuestFeatureTCG, self).format_dom()"},{"line_number":2747,"context_line":"        root.append(self._text_node(\"tb-cache\", \"32\","},{"line_number":2748,"context_line":"                                    unit\u003d\"MiB\"))"},{"line_number":2749,"context_line":""},{"line_number":2750,"context_line":"        return root"}],"source_content_type":"text/x-python","patch_set":1,"id":"294b5ef1_9bfa1b33","line":2747,"in_reply_to":"72fa8e99_ffcdbbff","updated":"2023-04-28 10:15:42.000000000","message":"Ack","commit_id":"eb522f1ddd317cb7c57a7a7b5b9caef34517b15a"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"25666cba2c1db0b620fa580c0674594b0b9d4c51","unresolved":true,"context_lines":[{"line_number":6161,"context_line":"            if not CONF.workarounds.libvirt_disable_apic:"},{"line_number":6162,"context_line":"                guest.add_feature(vconfig.LibvirtConfigGuestFeatureAPIC())"},{"line_number":6163,"context_line":""},{"line_number":6164,"context_line":"        if CONF.libvirt.virt_type in (\u0027qemu\u0027):"},{"line_number":6165,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG())"},{"line_number":6166,"context_line":"        if CONF.libvirt.virt_type in (\u0027qemu\u0027, \u0027kvm\u0027) and os_type \u003d\u003d \u0027windows\u0027:"},{"line_number":6167,"context_line":"            hv \u003d vconfig.LibvirtConfigGuestFeatureHyperV()"}],"source_content_type":"text/x-python","patch_set":1,"id":"172233de_94855068","line":6164,"updated":"2022-12-22 15:21:00.000000000","message":"this is not quite correct as you are missing a min libvirt version check for libvirt 8.0.0","commit_id":"eb522f1ddd317cb7c57a7a7b5b9caef34517b15a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"7264ce671033e4ea3b9831157f29bedd016f7315","unresolved":false,"context_lines":[{"line_number":6161,"context_line":"            if not CONF.workarounds.libvirt_disable_apic:"},{"line_number":6162,"context_line":"                guest.add_feature(vconfig.LibvirtConfigGuestFeatureAPIC())"},{"line_number":6163,"context_line":""},{"line_number":6164,"context_line":"        if CONF.libvirt.virt_type in (\u0027qemu\u0027):"},{"line_number":6165,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG())"},{"line_number":6166,"context_line":"        if CONF.libvirt.virt_type in (\u0027qemu\u0027, \u0027kvm\u0027) and os_type \u003d\u003d \u0027windows\u0027:"},{"line_number":6167,"context_line":"            hv \u003d vconfig.LibvirtConfigGuestFeatureHyperV()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd2c7c1c_9ba90305","line":6164,"in_reply_to":"172233de_94855068","updated":"2023-04-28 10:15:42.000000000","message":"Done","commit_id":"eb522f1ddd317cb7c57a7a7b5b9caef34517b15a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2653942c5b9e3e3be0d43b9b3b7a889572a988d","unresolved":true,"context_lines":[{"line_number":728,"context_line":"                 {\u0027enabled\u0027: enabled, \u0027reason\u0027: reason})"},{"line_number":729,"context_line":"        self._set_host_enabled(enabled, reason)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    def init_host(self, host):"},{"line_number":732,"context_line":"        self._host.initialize()"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        self._update_host_specific_capabilities()"}],"source_content_type":"text/x-python","patch_set":6,"id":"c11bd028_6d7cf129","line":731,"updated":"2023-05-02 11:52:03.000000000","message":"you should add the version check here in init host\n\ncan you factor out the check into a function\n\ndef _supports_tb_cache_size(self):\n        if (\n            CONF.libvirt.virt_type \u003d\u003d \u0027qemu\u0027 and\n            CONF.workarounds.libvirt_tb_cache_size and\n            CONF.workarounds.libvirt_tb_cache_size \u003e 0\n        ):\n            if self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):\n                guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG(\n                    CONF.workarounds.libvirt_tb_cache_size))\n            else:\n                raise exception.InternalError(\n                    _(\"Nova requires libvirt version %s or greater \"\n                      \"with \u0027[workarounds] libvirt_tb_cache_size\u0027 \"\n                      \"configured.\") %\n                    libvirt_utils.version_to_string(MIN_LIBVIRT_TB_CACHE_SIZE))","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0b1cc4613074fe6d5e63f4a8ba44e09ff9643f3e","unresolved":true,"context_lines":[{"line_number":728,"context_line":"                 {\u0027enabled\u0027: enabled, \u0027reason\u0027: reason})"},{"line_number":729,"context_line":"        self._set_host_enabled(enabled, reason)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    def init_host(self, host):"},{"line_number":732,"context_line":"        self._host.initialize()"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        self._update_host_specific_capabilities()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fdf5a4b8_907bfd0d","line":731,"in_reply_to":"c11bd028_6d7cf129","updated":"2023-05-02 13:46:06.000000000","message":"Done","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"981cdd2a2f98b6e2e0d737e37985eefc84ac1625","unresolved":false,"context_lines":[{"line_number":728,"context_line":"                 {\u0027enabled\u0027: enabled, \u0027reason\u0027: reason})"},{"line_number":729,"context_line":"        self._set_host_enabled(enabled, reason)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    def init_host(self, host):"},{"line_number":732,"context_line":"        self._host.initialize()"},{"line_number":733,"context_line":""},{"line_number":734,"context_line":"        self._update_host_specific_capabilities()"}],"source_content_type":"text/x-python","patch_set":6,"id":"4f926afe_8039edd3","line":731,"in_reply_to":"fdf5a4b8_907bfd0d","updated":"2023-05-02 15:17:40.000000000","message":"Done","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2653942c5b9e3e3be0d43b9b3b7a889572a988d","unresolved":true,"context_lines":[{"line_number":744,"context_line":"        self._check_file_backed_memory_support()"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"        self._check_my_ip()"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027 and"},{"line_number":749,"context_line":"                not (CONF.libvirt.uid_maps and CONF.libvirt.gid_maps)):"},{"line_number":750,"context_line":"            LOG.warning(\"Running libvirt-lxc without user namespaces is \""}],"source_content_type":"text/x-python","patch_set":6,"id":"f3fff3b0_611b3cbe","line":747,"updated":"2023-05-02 11:52:03.000000000","message":"then just call self._supports_tb_cache_size() here","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0b1cc4613074fe6d5e63f4a8ba44e09ff9643f3e","unresolved":false,"context_lines":[{"line_number":744,"context_line":"        self._check_file_backed_memory_support()"},{"line_number":745,"context_line":""},{"line_number":746,"context_line":"        self._check_my_ip()"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027 and"},{"line_number":749,"context_line":"                not (CONF.libvirt.uid_maps and CONF.libvirt.gid_maps)):"},{"line_number":750,"context_line":"            LOG.warning(\"Running libvirt-lxc without user namespaces is \""}],"source_content_type":"text/x-python","patch_set":6,"id":"196c653f_ff7761c3","line":747,"in_reply_to":"f3fff3b0_611b3cbe","updated":"2023-05-02 13:46:06.000000000","message":"Done","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d2653942c5b9e3e3be0d43b9b3b7a889572a988d","unresolved":true,"context_lines":[{"line_number":6177,"context_line":"            if not CONF.workarounds.libvirt_disable_apic:"},{"line_number":6178,"context_line":"                guest.add_feature(vconfig.LibvirtConfigGuestFeatureAPIC())"},{"line_number":6179,"context_line":""},{"line_number":6180,"context_line":"        if ("},{"line_number":6181,"context_line":"            CONF.libvirt.virt_type \u003d\u003d \u0027qemu\u0027 and"},{"line_number":6182,"context_line":"            CONF.workarounds.libvirt_tb_cache_size and"},{"line_number":6183,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"b8132a45_a7a56c23","line":6180,"updated":"2023-05-02 11:52:03.000000000","message":"you can then replace this with \n\nself._supports_tb_cache_size()\n\ni guess although it should nto be strictly requried since the agent should exit on startup.","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"0b1cc4613074fe6d5e63f4a8ba44e09ff9643f3e","unresolved":false,"context_lines":[{"line_number":6177,"context_line":"            if not CONF.workarounds.libvirt_disable_apic:"},{"line_number":6178,"context_line":"                guest.add_feature(vconfig.LibvirtConfigGuestFeatureAPIC())"},{"line_number":6179,"context_line":""},{"line_number":6180,"context_line":"        if ("},{"line_number":6181,"context_line":"            CONF.libvirt.virt_type \u003d\u003d \u0027qemu\u0027 and"},{"line_number":6182,"context_line":"            CONF.workarounds.libvirt_tb_cache_size and"},{"line_number":6183,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"}],"source_content_type":"text/x-python","patch_set":6,"id":"ae2e371b_ede39c08","line":6180,"in_reply_to":"b8132a45_a7a56c23","updated":"2023-05-02 13:46:06.000000000","message":"Done","commit_id":"768c990de6b5adf180fbff9a9161a5ebe98b2bdb"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb031911b7ce36482006bec7653392dc76e4b887","unresolved":true,"context_lines":[{"line_number":745,"context_line":""},{"line_number":746,"context_line":"        self._check_my_ip()"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        self._supports_tb_cache_size()"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027 and"},{"line_number":751,"context_line":"                not (CONF.libvirt.uid_maps and CONF.libvirt.gid_maps)):"}],"source_content_type":"text/x-python","patch_set":7,"id":"a8608dfe_3a0fd417","line":748,"updated":"2023-05-02 15:16:04.000000000","message":"nit: it would be nice to add a comment to remove this when we raise our min libvirt version but there is non need to respine for just that.","commit_id":"58dba1ee640b5384837b82dfd2fe11e53b5cb361"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"719f335710a3cf212fd46b80c9733ef356db6ca6","unresolved":false,"context_lines":[{"line_number":745,"context_line":""},{"line_number":746,"context_line":"        self._check_my_ip()"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        self._supports_tb_cache_size()"},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027 and"},{"line_number":751,"context_line":"                not (CONF.libvirt.uid_maps and CONF.libvirt.gid_maps)):"}],"source_content_type":"text/x-python","patch_set":7,"id":"34391e3e_febbc607","line":748,"in_reply_to":"a8608dfe_3a0fd417","updated":"2023-05-05 07:19:46.000000000","message":"Done","commit_id":"58dba1ee640b5384837b82dfd2fe11e53b5cb361"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cb031911b7ce36482006bec7653392dc76e4b887","unresolved":true,"context_lines":[{"line_number":6195,"context_line":"            if not CONF.workarounds.libvirt_disable_apic:"},{"line_number":6196,"context_line":"                guest.add_feature(vconfig.LibvirtConfigGuestFeatureAPIC())"},{"line_number":6197,"context_line":""},{"line_number":6198,"context_line":"        if self._supports_tb_cache_size():"},{"line_number":6199,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG("},{"line_number":6200,"context_line":"                CONF.workarounds.libvirt_tb_cache_size))"},{"line_number":6201,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"6cc051e0_260e52ce","line":6198,"range":{"start_line":6198,"start_character":7,"end_line":6198,"end_character":42},"updated":"2023-05-02 15:16:04.000000000","message":"so this is not actully correct.\n\nwe only want to add this elemnt if \n\n\nCONF.libvirt.virt_type \u003d \u0027qemu\u0027 and  \u0027libvirt_tb_cache_size\u0027 in CONF.workarounds and CONF.workarounds.libvirt_tb_cache_size \u003e 0 :\n\nwe do not need to check if the libvirt version suspprot it at this point since that was checked at init_host.","commit_id":"58dba1ee640b5384837b82dfd2fe11e53b5cb361"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"719f335710a3cf212fd46b80c9733ef356db6ca6","unresolved":false,"context_lines":[{"line_number":6195,"context_line":"            if not CONF.workarounds.libvirt_disable_apic:"},{"line_number":6196,"context_line":"                guest.add_feature(vconfig.LibvirtConfigGuestFeatureAPIC())"},{"line_number":6197,"context_line":""},{"line_number":6198,"context_line":"        if self._supports_tb_cache_size():"},{"line_number":6199,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG("},{"line_number":6200,"context_line":"                CONF.workarounds.libvirt_tb_cache_size))"},{"line_number":6201,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"a9453f00_83859de7","line":6198,"range":{"start_line":6198,"start_character":7,"end_line":6198,"end_character":42},"in_reply_to":"6cc051e0_260e52ce","updated":"2023-05-05 07:19:46.000000000","message":"Done","commit_id":"58dba1ee640b5384837b82dfd2fe11e53b5cb361"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"684a56822cba485b1350faf31220e66efaf63d2b","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                return True"},{"line_number":1233,"context_line":"            else:"},{"line_number":1234,"context_line":"                raise exception.InternalError("},{"line_number":1235,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""}],"source_content_type":"text/x-python","patch_set":8,"id":"1c185388_fac9c4a5","line":1232,"updated":"2023-05-12 14:59:01.000000000","message":"mmm, you don\u0027t really need to return a boolean.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ce781bf1eee668ff75338756b774f4064b51cd76","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                return True"},{"line_number":1233,"context_line":"            else:"},{"line_number":1234,"context_line":"                raise exception.InternalError("},{"line_number":1235,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""}],"source_content_type":"text/x-python","patch_set":8,"id":"fb14f872_4cebec8b","line":1232,"in_reply_to":"108e8d7f_29ca44a0","updated":"2023-05-19 15:03:25.000000000","message":"Ohkk Thanks, got it, updated.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"579052ce57d9dcc28a946e4c7cade4a35ccd6cda","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                return True"},{"line_number":1233,"context_line":"            else:"},{"line_number":1234,"context_line":"                raise exception.InternalError("},{"line_number":1235,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""}],"source_content_type":"text/x-python","patch_set":8,"id":"4e6cbd5c_1f0a6ccd","line":1232,"in_reply_to":"1c185388_fac9c4a5","updated":"2023-05-19 09:41:27.000000000","message":"sorry not sure what you mean, you mean return something else than boolean? I see multiple cases boolean is returned in nova/virt/libvirt/driver.py so confused.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"403351a64d351df4c053162b3974b2ee613c9386","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                return True"},{"line_number":1233,"context_line":"            else:"},{"line_number":1234,"context_line":"                raise exception.InternalError("},{"line_number":1235,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""}],"source_content_type":"text/x-python","patch_set":8,"id":"108e8d7f_29ca44a0","line":1232,"in_reply_to":"4e6cbd5c_1f0a6ccd","updated":"2023-05-19 12:37:02.000000000","message":"@yatin sylvain mains that since the function raises an error if the condtions are not made you can use excptions as contolflow which we are actully doing above in init_host\nhttps://review.opendev.org/c/openstack/nova/+/868419/8/nova/virt/libvirt/driver.py#749\n\nso technially you dont need to return True or false.\n\nif the function does not raise it passes and if it does it failes.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"684a56822cba485b1350faf31220e66efaf63d2b","unresolved":true,"context_lines":[{"line_number":1236,"context_line":"                      \"with \u0027[workarounds] libvirt_tb_cache_size\u0027 \""},{"line_number":1237,"context_line":"                      \"configured.\") %"},{"line_number":1238,"context_line":"                    libvirt_utils.version_to_string(MIN_LIBVIRT_TB_CACHE_SIZE))"},{"line_number":1239,"context_line":"        return False"},{"line_number":1240,"context_line":""},{"line_number":1241,"context_line":"    def _prepare_migration_flags(self):"},{"line_number":1242,"context_line":"        migration_flags \u003d 0"}],"source_content_type":"text/x-python","patch_set":8,"id":"b06b0cef_70a8ee47","line":1239,"updated":"2023-05-12 14:59:01.000000000","message":"ditto here.","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"684a56822cba485b1350faf31220e66efaf63d2b","unresolved":true,"context_lines":[{"line_number":6200,"context_line":"            CONF.libvirt.virt_type \u003d\u003d \u0027qemu\u0027 and"},{"line_number":6201,"context_line":"            CONF.workarounds.libvirt_tb_cache_size and"},{"line_number":6202,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"},{"line_number":6203,"context_line":"        ):"},{"line_number":6204,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG("},{"line_number":6205,"context_line":"                CONF.workarounds.libvirt_tb_cache_size))"},{"line_number":6206,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"85f34ff2_6aa1dcee","line":6203,"updated":"2023-05-12 14:59:01.000000000","message":"as an alternative, you could use the returned boolean above in _supports_tb_cache_size() to be present as an object instance field like self.tb_cachesize_set and a conditional like \n```\n if self.tb_cachesize_set():\n   guest.add_feature\n```\n\nThe other option is just to call out a second time _supports_tb_cache_size()\n```\n  if self._supports_tb_cache_size():\n    guest.add_feature\n```","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"579052ce57d9dcc28a946e4c7cade4a35ccd6cda","unresolved":true,"context_lines":[{"line_number":6200,"context_line":"            CONF.libvirt.virt_type \u003d\u003d \u0027qemu\u0027 and"},{"line_number":6201,"context_line":"            CONF.workarounds.libvirt_tb_cache_size and"},{"line_number":6202,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"},{"line_number":6203,"context_line":"        ):"},{"line_number":6204,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG("},{"line_number":6205,"context_line":"                CONF.workarounds.libvirt_tb_cache_size))"},{"line_number":6206,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ffee14c5_ed504c9f","line":6203,"in_reply_to":"85f34ff2_6aa1dcee","updated":"2023-05-19 09:41:27.000000000","message":"Actually it used to be that way in previous PS but changed https://review.opendev.org/c/openstack/nova/+/868419/7..8/nova/virt/libvirt/driver.py#b6198","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ce781bf1eee668ff75338756b774f4064b51cd76","unresolved":false,"context_lines":[{"line_number":6200,"context_line":"            CONF.libvirt.virt_type \u003d\u003d \u0027qemu\u0027 and"},{"line_number":6201,"context_line":"            CONF.workarounds.libvirt_tb_cache_size and"},{"line_number":6202,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"},{"line_number":6203,"context_line":"        ):"},{"line_number":6204,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG("},{"line_number":6205,"context_line":"                CONF.workarounds.libvirt_tb_cache_size))"},{"line_number":6206,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"89ce5c65_2f8db80f","line":6203,"in_reply_to":"958a1b7b_151ff3e3","updated":"2023-05-19 15:03:25.000000000","message":"Done","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"403351a64d351df4c053162b3974b2ee613c9386","unresolved":true,"context_lines":[{"line_number":6200,"context_line":"            CONF.libvirt.virt_type \u003d\u003d \u0027qemu\u0027 and"},{"line_number":6201,"context_line":"            CONF.workarounds.libvirt_tb_cache_size and"},{"line_number":6202,"context_line":"            CONF.workarounds.libvirt_tb_cache_size \u003e 0"},{"line_number":6203,"context_line":"        ):"},{"line_number":6204,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG("},{"line_number":6205,"context_line":"                CONF.workarounds.libvirt_tb_cache_size))"},{"line_number":6206,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"958a1b7b_151ff3e3","line":6203,"in_reply_to":"ffee14c5_ed504c9f","updated":"2023-05-19 12:37:02.000000000","message":"ya that would be incorrect we do not want to raise here if tis not suported.\n\nwe coudl alos add a try excpt block but that woudl be less clean in my view","commit_id":"c67d8b1b98d7f4db3166601e6c20dc900f0ce7be"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"71108a9d66a248ca842c5eaa6d5f7c7b3a2d22b8","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"            CONF.libvirt.tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if not self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                raise exception.InternalError("},{"line_number":1233,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""},{"line_number":1234,"context_line":"                      \"with \u0027[libvirt] tb_cache_size\u0027 \""},{"line_number":1235,"context_line":"                      \"configured.\") %"}],"source_content_type":"text/x-python","patch_set":9,"id":"859c3ce7_2dfbaecf","line":1232,"range":{"start_line":1232,"start_character":32,"end_line":1232,"end_character":45},"updated":"2023-07-12 17:47:18.000000000","message":"if we go with raising the exception (see my below comment) then it should be InvalidConfiguration error not the InternalError as it is config mistake not nova server intenal failure.","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7b5d34f68f74506d745b2d0117d732ffacbbdeb8","unresolved":true,"context_lines":[{"line_number":1229,"context_line":"            CONF.libvirt.tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if not self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                raise exception.InternalError("},{"line_number":1233,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""},{"line_number":1234,"context_line":"                      \"with \u0027[libvirt] tb_cache_size\u0027 \""},{"line_number":1235,"context_line":"                      \"configured.\") %"}],"source_content_type":"text/x-python","patch_set":9,"id":"23a89a18_b5deed62","line":1232,"range":{"start_line":1232,"start_character":32,"end_line":1232,"end_character":45},"in_reply_to":"859c3ce7_2dfbaecf","updated":"2023-07-13 14:13:43.000000000","message":"Done","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"71108a9d66a248ca842c5eaa6d5f7c7b3a2d22b8","unresolved":true,"context_lines":[{"line_number":1228,"context_line":"            CONF.libvirt.tb_cache_size and"},{"line_number":1229,"context_line":"            CONF.libvirt.tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if not self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                raise exception.InternalError("},{"line_number":1233,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""},{"line_number":1234,"context_line":"                      \"with \u0027[libvirt] tb_cache_size\u0027 \""},{"line_number":1235,"context_line":"                      \"configured.\") %"},{"line_number":1236,"context_line":"                    libvirt_utils.version_to_string(MIN_LIBVIRT_TB_CACHE_SIZE))"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"    def _prepare_migration_flags(self):"},{"line_number":1239,"context_line":"        migration_flags \u003d 0"}],"source_content_type":"text/x-python","patch_set":9,"id":"7cb8f246_9380e400","line":1236,"range":{"start_line":1231,"start_character":0,"end_line":1236,"end_character":79},"updated":"2023-07-12 17:47:18.000000000","message":"I am thinking do we really need to raise error here or a warning is enough and go with the default value qemu version has. If anyone set tb_cache_size for some compute with libvirt\u003c8.0.0 (by mistake or copy paste config file) then we can just add a warning saying that \"tb_cache_size is not set because that is not supported in your libvirt version, either upgrade to libvirt \u003c 8.0.0 or unset this value.\"\n\nBecause anyone configured and we are not setting that does not change the default behaviour what we have currently, I mean it will not break the things (except trying multiple VMs no low memory system and have Qemu\u003e\u003d5.0.0.)","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"b506df8addc88731e7797beec3e751d93a420eaf","unresolved":true,"context_lines":[{"line_number":1228,"context_line":"            CONF.libvirt.tb_cache_size and"},{"line_number":1229,"context_line":"            CONF.libvirt.tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if not self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                raise exception.InternalError("},{"line_number":1233,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""},{"line_number":1234,"context_line":"                      \"with \u0027[libvirt] tb_cache_size\u0027 \""},{"line_number":1235,"context_line":"                      \"configured.\") %"},{"line_number":1236,"context_line":"                    libvirt_utils.version_to_string(MIN_LIBVIRT_TB_CACHE_SIZE))"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"    def _prepare_migration_flags(self):"},{"line_number":1239,"context_line":"        migration_flags \u003d 0"}],"source_content_type":"text/x-python","patch_set":9,"id":"b44c121b_5539ce58","line":1236,"range":{"start_line":1231,"start_character":0,"end_line":1236,"end_character":79},"in_reply_to":"1f67ec31_67e13e0f","updated":"2023-07-13 16:54:48.000000000","message":"yeah I know. My point is because this misconfiguration does not lead to any failure at any level, the only thing is that we will not set the value on libvirt ver does not support this ability. In that case just throwing warning is enough and keep system working for users.","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"50e86630a2c8694ac66f02979bf708a0a13e4b62","unresolved":true,"context_lines":[{"line_number":1228,"context_line":"            CONF.libvirt.tb_cache_size and"},{"line_number":1229,"context_line":"            CONF.libvirt.tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if not self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                raise exception.InternalError("},{"line_number":1233,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""},{"line_number":1234,"context_line":"                      \"with \u0027[libvirt] tb_cache_size\u0027 \""},{"line_number":1235,"context_line":"                      \"configured.\") %"},{"line_number":1236,"context_line":"                    libvirt_utils.version_to_string(MIN_LIBVIRT_TB_CACHE_SIZE))"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"    def _prepare_migration_flags(self):"},{"line_number":1239,"context_line":"        migration_flags \u003d 0"}],"source_content_type":"text/x-python","patch_set":9,"id":"b70d25ad_4e238901","line":1236,"range":{"start_line":1231,"start_character":0,"end_line":1236,"end_character":79},"in_reply_to":"705abedf_688f2a61","updated":"2023-07-17 17:18:09.000000000","message":"ok, thanks for the link, i missed that meeting.\n\nI am ok now to fail because default value is 0 and anyone explicitly setting that knows what they are doing.","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"7b5d34f68f74506d745b2d0117d732ffacbbdeb8","unresolved":true,"context_lines":[{"line_number":1228,"context_line":"            CONF.libvirt.tb_cache_size and"},{"line_number":1229,"context_line":"            CONF.libvirt.tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if not self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                raise exception.InternalError("},{"line_number":1233,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""},{"line_number":1234,"context_line":"                      \"with \u0027[libvirt] tb_cache_size\u0027 \""},{"line_number":1235,"context_line":"                      \"configured.\") %"},{"line_number":1236,"context_line":"                    libvirt_utils.version_to_string(MIN_LIBVIRT_TB_CACHE_SIZE))"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"    def _prepare_migration_flags(self):"},{"line_number":1239,"context_line":"        migration_flags \u003d 0"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f67ec31_67e13e0f","line":1236,"range":{"start_line":1231,"start_character":0,"end_line":1236,"end_character":79},"in_reply_to":"7cb8f246_9380e400","updated":"2023-07-13 14:13:43.000000000","message":"Actually the idea here was to error out and stop instead of just log warning and move, and use the config option only when it\u0027s really needed. But if others too think warning is better i will update in next PS.","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9db1693966a15cf09793bc380a5b4b8dd1efbf44","unresolved":true,"context_lines":[{"line_number":1228,"context_line":"            CONF.libvirt.tb_cache_size and"},{"line_number":1229,"context_line":"            CONF.libvirt.tb_cache_size \u003e 0"},{"line_number":1230,"context_line":"        ):"},{"line_number":1231,"context_line":"            if not self._host.has_min_version(MIN_LIBVIRT_TB_CACHE_SIZE):"},{"line_number":1232,"context_line":"                raise exception.InternalError("},{"line_number":1233,"context_line":"                    _(\"Nova requires libvirt version %s or greater \""},{"line_number":1234,"context_line":"                      \"with \u0027[libvirt] tb_cache_size\u0027 \""},{"line_number":1235,"context_line":"                      \"configured.\") %"},{"line_number":1236,"context_line":"                    libvirt_utils.version_to_string(MIN_LIBVIRT_TB_CACHE_SIZE))"},{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"    def _prepare_migration_flags(self):"},{"line_number":1239,"context_line":"        migration_flags \u003d 0"}],"source_content_type":"text/x-python","patch_set":9,"id":"705abedf_688f2a61","line":1236,"range":{"start_line":1231,"start_character":0,"end_line":1236,"end_character":79},"in_reply_to":"b44c121b_5539ce58","updated":"2023-07-17 06:50:07.000000000","message":"@gmann also for context it was discussed originally in nova meeting[1] and there it was suggested to raise error and hard fail.\nJust adding background context on this and seeking feedback before changing it.\n\n[1] https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2023-04-25.log.html#t2023-04-25T16:17:29","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"71108a9d66a248ca842c5eaa6d5f7c7b3a2d22b8","unresolved":true,"context_lines":[{"line_number":6193,"context_line":"            if not CONF.workarounds.libvirt_disable_apic:"},{"line_number":6194,"context_line":"                guest.add_feature(vconfig.LibvirtConfigGuestFeatureAPIC())"},{"line_number":6195,"context_line":""},{"line_number":6196,"context_line":"        if ("},{"line_number":6197,"context_line":"            CONF.libvirt.virt_type \u003d\u003d \u0027qemu\u0027 and"},{"line_number":6198,"context_line":"            CONF.libvirt.tb_cache_size and"},{"line_number":6199,"context_line":"            CONF.libvirt.tb_cache_size \u003e 0"},{"line_number":6200,"context_line":"        ):"},{"line_number":6201,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG("},{"line_number":6202,"context_line":"                CONF.libvirt.tb_cache_size))"},{"line_number":6203,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"be2dd469_07ff50d7","line":6200,"range":{"start_line":6196,"start_character":0,"end_line":6200,"end_character":10},"updated":"2023-07-12 17:47:18.000000000","message":"and here we can check libvirt version \u003e8.0.0 otherwise no setting the value.","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5b9ffc2960b266f54d0619c106768524e03ef3d","unresolved":true,"context_lines":[{"line_number":6193,"context_line":"            if not CONF.workarounds.libvirt_disable_apic:"},{"line_number":6194,"context_line":"                guest.add_feature(vconfig.LibvirtConfigGuestFeatureAPIC())"},{"line_number":6195,"context_line":""},{"line_number":6196,"context_line":"        if ("},{"line_number":6197,"context_line":"            CONF.libvirt.virt_type \u003d\u003d \u0027qemu\u0027 and"},{"line_number":6198,"context_line":"            CONF.libvirt.tb_cache_size and"},{"line_number":6199,"context_line":"            CONF.libvirt.tb_cache_size \u003e 0"},{"line_number":6200,"context_line":"        ):"},{"line_number":6201,"context_line":"            guest.add_feature(vconfig.LibvirtConfigGuestFeatureTCG("},{"line_number":6202,"context_line":"                CONF.libvirt.tb_cache_size))"},{"line_number":6203,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"d1dc4020_e20b3528","line":6200,"range":{"start_line":6196,"start_character":0,"end_line":6200,"end_character":10},"in_reply_to":"be2dd469_07ff50d7","updated":"2023-07-17 18:27:53.000000000","message":"we would still need to check if its enabeld. in the config.\n\nsince the rais in init_host stops the agent form starting if the min versio nis not met we dont need to check it here.\n\nwe jsut need to check if its enabled in the config.","commit_id":"d29a193fc108f1cab668a2d0d3142cdab896b0c7"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d5b9ffc2960b266f54d0619c106768524e03ef3d","unresolved":true,"context_lines":[{"line_number":746,"context_line":"        self._check_my_ip()"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"        # TODO(ykarel) This can be dropped when MIN_LIBVIRT_VERSION\u003e\u003d8.0.0"},{"line_number":749,"context_line":"        self._supports_tb_cache_size()"},{"line_number":750,"context_line":""},{"line_number":751,"context_line":"        if (CONF.libvirt.virt_type \u003d\u003d \u0027lxc\u0027 and"},{"line_number":752,"context_line":"                not (CONF.libvirt.uid_maps and CONF.libvirt.gid_maps)):"}],"source_content_type":"text/x-python","patch_set":10,"id":"d00513e8_48d60ce8","line":749,"updated":"2023-07-17 18:27:53.000000000","message":"this will cause the agent to fail to start if there is a misconfiguration\nwhich is the intended behavior.","commit_id":"3f7cc63d942bbb7cbda3aae9718fa21f61deecf0"}]}