)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ee01fd8fc9b614f1b1d40fa645be5dc8fff0c57","unresolved":true,"context_lines":[{"line_number":12,"context_line":"Custom CPU models which would be consider compatible from libvirt"},{"line_number":13,"context_line":"with certain hypervisor cpu which no longer have mpx."},{"line_number":14,"context_line":"Such as Ice Lake."},{"line_number":15,"context_line":"Cause nova-compute to crash at _check_cpu_compatibility when"},{"line_number":16,"context_line":"a compatible model is configured."},{"line_number":17,"context_line":"This workaround adds -mpx to the feature flags when running"},{"line_number":18,"context_line":"_check_cpu_compatibility."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"90afb666_fdcad377","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":56},"updated":"2023-01-09 13:59:34.000000000","message":"could you point to the stack trace of the crash?","commit_id":"834874d9814b7ced2e9ef04558f1776e3c4a4ca6"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"1ee01fd8fc9b614f1b1d40fa645be5dc8fff0c57","unresolved":true,"context_lines":[{"line_number":16,"context_line":"a compatible model is configured."},{"line_number":17,"context_line":"This workaround adds -mpx to the feature flags when running"},{"line_number":18,"context_line":"_check_cpu_compatibility."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I654e3d9dba09bfb4574f2c44a23b27585addf14a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"51871174_aa81ff21","line":19,"updated":"2023-01-09 13:59:34.000000000","message":"Have you filed a bug? If so please link it here via\nCloses-Bug: #\u003claunchpad-bug-number\u003e","commit_id":"834874d9814b7ced2e9ef04558f1776e3c4a4ca6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"81b71a11c0e3c26880a0336bf549c22f88bb1225","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6d7dc983_9a2bd513","updated":"2023-01-09 17:59:13.000000000","message":"Instead of these workarounds specific to CPU flags, I suggest to remove the CPU compat check altogether, as libvirt will do the right thing.  This is also the recommendation of libvirt developers.\n\nI proposed a test change here for review:\n\nhttps://review.opendev.org/c/openstack/nova/+/869587 — \"libvirt: Remove compareCPU() check in _check_cpu_compatiblity()\"","commit_id":"834874d9814b7ced2e9ef04558f1776e3c4a4ca6"}]}