)]}'
{"id":"openstack%2Fnova~869587","triplet_id":"openstack%2Fnova~master~Icdecd8700a2dfa20685f617b84d6065292e8cb36","project":"openstack/nova","branch":"master","topic":"remove_cpu_compat_check","attention_set":{"6962":{"account":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"last_update":"2023-01-11 11:26:00.000000000","reason":"\u003cGERRIT_ACCOUNT_9708\u003e replied on the change","reason_account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},"11604":{"account":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"last_update":"2023-01-11 11:26:00.000000000","reason":"\u003cGERRIT_ACCOUNT_9708\u003e replied on the change","reason_account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}}},"removed_from_attention_set":{"9708":{"account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"last_update":"2023-01-11 11:26:00.000000000","reason":"\u003cGERRIT_ACCOUNT_9708\u003e replied on the change","reason_account":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}}},"hashtags":[],"change_id":"Icdecd8700a2dfa20685f617b84d6065292e8cb36","subject":"libvirt: Remove compareCPU() check in _check_cpu_compatibility()","status":"NEW","created":"2023-01-09 17:57:41.000000000","updated":"2023-03-02 12:36:23.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":17,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d96d971ec803d963e8ad37d24bc597b892d11180","_number":869587,"virtual_id_number":869587,"owner":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"tag":"autogenerated:zuul:check","value":-1,"date":"2023-01-11 13:01:54.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2023-01-11 11:26:00.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"value":0,"permitted_voting_range":{"min":0,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":0,"max":2},"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},{"_account_id":30028,"name":"James Troup","email":"ubuntu@elmo.tasta.io","username":"elmo"}],"REVIEWER":[{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2023-01-09 17:58:19.000000000","updated_by":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"reviewer":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"state":"CC"},{"updated":"2023-01-09 20:23:35.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2023-01-10 10:34:03.000000000","updated_by":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"CC"},{"updated":"2023-01-11 10:01:28.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"state":"REVIEWER"},{"updated":"2023-01-11 11:26:00.000000000","updated_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"reviewer":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"state":"REVIEWER"},{"updated":"2023-03-02 12:36:23.000000000","updated_by":{"_account_id":30028,"name":"James Troup","email":"ubuntu@elmo.tasta.io","username":"elmo"},"reviewer":{"_account_id":30028,"name":"James Troup","email":"ubuntu@elmo.tasta.io","username":"elmo"},"state":"CC"}],"messages":[{"id":"c3d18a55bf2cf59fa0c6ff92ec4c664dc1e08fab","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-09 17:57:41.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6192d7a00b3f864cc9a47b162db62dbea296ae7c","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2023-01-09 17:58:19.000000000","message":"Patch Set 1:\n\nBuild Failed \n\n* openstack-sriov-nova-master-macvtap http://13.74.249.42/refs/changes/87/869587/1/openstack-sriov-nova-master-macvtap : FAILURE\n\n* openstack-sriov-nova-master-direct http://13.74.249.42/refs/changes/87/869587/1/openstack-sriov-nova-master-direct : FAILURE","accounts_in_message":[],"_revision_number":1},{"id":"435b4d39c62140ed72b1f26717134a1c828298bf","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-09 18:01:38.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"359c9e377642c3b12b592d1fb0649eebc87908ae","tag":"autogenerated:jenkins-gerrit-trigger","author":{"_account_id":9732,"name":"Mellanox CI","email":"mlnx-openstack-ci@dev.mellanox.co.il","username":"mellanox","tags":["SERVICE_USER"]},"date":"2023-01-09 18:02:11.000000000","message":"Patch Set 2:\n\nBuild Failed \n\n* openstack-sriov-nova-master-macvtap http://13.74.249.42/refs/changes/87/869587/2/openstack-sriov-nova-master-macvtap : FAILURE\n\n* openstack-sriov-nova-master-direct http://13.74.249.42/refs/changes/87/869587/2/openstack-sriov-nova-master-direct : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"241a562327c2eaf3e8817c68009354330a63b39e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-09 20:23:35.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/c6ea4a4f1aea4c2c809fdadd0ced7321\n\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/4555d6e68dc34edeb6054892828e92c6 : SUCCESS in 54m 31s (non-voting)\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/d925cd6c65a443d3b4800604103116c2 : SUCCESS in 1h 26m 56s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/f0f53b17ee024237b8f2067c109fc97e : SUCCESS in 50m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/ef04737348fe48c98e76067f1d020593 : FAILURE in 13m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0974a070971149c896c19047be8d14c7 : SUCCESS in 12m 35s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/0222cf1619234516a8589b06760072c5 : FAILURE in 12m 53s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/44f4368334e44baaa864e731ca27534f : FAILURE in 13m 34s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/37e790e9ecfe448e85f22ce7552b13ec : SUCCESS in 11m 08s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/5602acbc72374996a6417431b64f4721 : SUCCESS in 20m 33s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/72d91acf8c134978899c91640668c7a8 : SUCCESS in 50m 58s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/c4edc5ec523c48968f1f1714863f177f : TIMED_OUT in 2h 02m 43s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/95a2dae7709f4fe68b028159e0bcd20b : SUCCESS in 43m 37s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/43bc6beb05964eba993f2fce3275b6cb : SUCCESS in 32m 38s (non-voting)\n- nova-lvm https://zuul.opendev.org/t/openstack/build/3ee93d00b9fe48829b3e24225ce0948f : SUCCESS in 1h 08m 24s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/014d6ce0eda24bc5b9d3653294f2a64b : SUCCESS in 1h 38m 05s\n- nova-next https://zuul.opendev.org/t/openstack/build/07909968477248e6925282f0bc90681b : SUCCESS in 2h 14m 53s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/bbd00a22a8ed47b68a461312028ed0db : SUCCESS in 47m 56s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/4a0358519bbb403987c92f6ad393975e : SUCCESS in 4m 23s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/689849aafd164e57b3c72f07bd68b188 : FAILURE in 4m 44s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d1720fc3809c4043bbfe0fe9d13e10bb : FAILURE in 5m 03s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/cd5c88313880448d8c5dad4b8cf0b95b : FAILURE in 3m 58s\n- tempest-integrated-compute-ubuntu-focal https://zuul.opendev.org/t/openstack/build/696ca41e02ee4022873fa43dd741f39b : SUCCESS in 1h 58m 51s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/1cda5088468a450c9dced4ee017d4049 : SUCCESS in 1h 15m 20s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/2fe344c83c2746ceb9826afc0a8127c9 : SUCCESS in 55m 22s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/5eedf549196044e1a3bd835be5335044 : SUCCESS in 24m 22s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/d4daaf82f1d54cbaae62af945d880f0a : SUCCESS in 26m 34s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"4f4424f4d092341e5b8dfa0176592db6a5ceca19","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-09 21:18:26.000000000","message":"Patch Set 2:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/bb54a77febb346a18e79a56fc76b30fe\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/ddc6cce11d044fd5b63c80c29424ffd8 : FAILURE in 53m 15s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/d899022157a54d36aa2bfb25cc6eede5 : FAILURE in 39m 21s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"23a9a1dc5c789ce9534c311f418ec8fa02b51c07","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-10 08:52:22.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"6039e5267830359105e114d9ee88ed6cc20607ce","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-10 10:09:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"12da0424052d293ed9c7ff345cacaf4d2f1d095e","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-10 11:24:27.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/09135a2286ed47d4a108ffc8ca0bf50f\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/4515af164a82476787410bda4596b1c7 : SUCCESS in 31m 38s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/ed3d654174f8405fb4b629e689bda2a4 : SUCCESS in 28m 37s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"9497ca8a0dcfccd4dd81bd9620cbfe17896fafce","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-10 11:59:24.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/d4c8d01af8ca40fead8c7a395870a488\n\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/346c623fcb4b48a0b2f5acc01e875de8 : SUCCESS in 1h 07m 50s (non-voting)\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/00be2b2d66ef45b795580422817acd85 : SUCCESS in 1h 42m 42s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/7149fb1a3dba4092b1fa3ae8c14eafa9 : SUCCESS in 1h 05m 20s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/5f28eb99a64f4cbd88a32abe736d8a8a : SUCCESS in 17m 20s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2c8e82f886c7488bb86f15cbe7703fb1 : SUCCESS in 12m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/76378c69a9e345e99839a692148b9eaf : SUCCESS in 17m 32s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/94800850423848d6a48b6dbac201aaeb : SUCCESS in 17m 38s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e8c7f670ae494ffdb1b04c4ee8e11d0d : SUCCESS in 10m 44s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/55ea5142383d4cdf9dbf3fb1eba85a9a : SUCCESS in 34m 47s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/65637f88de054abfbd3e8cf5e1fcb31e : SUCCESS in 1h 02m 27s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/0147053edd374260893e7f9d4ea120b1 : SUCCESS in 1h 14m 47s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/5e9fda0f257d4c9695bbe5286771d4d8 : SUCCESS in 1h 01m 36s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/8d581dd802ca487195fa2d6316ac3432 : SUCCESS in 41m 36s (non-voting)\n- nova-lvm https://zuul.opendev.org/t/openstack/build/a6b398f41696496fbc502f576c619193 : SUCCESS in 52m 19s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/37f15865eda841c5b2c05e8b492475d9 : SUCCESS in 1h 37m 41s\n- nova-next https://zuul.opendev.org/t/openstack/build/0e0568cad1bd4441a383822683112865 : SUCCESS in 1h 34m 15s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/e315f5b815734617b4411345242c486c : SUCCESS in 47m 00s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/5046ae870f444f10b0acccb734a12787 : SUCCESS in 4m 35s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/21785a8539e34c65aad0038a6cae0cde : FAILURE in 3m 31s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/4ec39b5de26a43d9bc3bd704f751115f : FAILURE in 4m 55s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/48ebb0fdaac748a9b14780c188973342 : FAILURE in 3m 38s\n- tempest-integrated-compute-ubuntu-focal https://zuul.opendev.org/t/openstack/build/59d0b02c092b46f4bde606688aa00f7b : SUCCESS in 1h 23m 00s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/77f568d139004aafb9d76da5f590a774 : SUCCESS in 1h 04m 22s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/232c28d42ba04dfd9c918fcc8688a3a6 : SUCCESS in 43m 24s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/f2cc23e8225d4888aeb800d8826ed1e3 : SUCCESS in 23m 41s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/80a4dea57f024b78bc68a2116ce85ca8 : SUCCESS in 28m 45s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"29769efe4f51d61f1e0051e589db9aa9d5fceee0","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-10 12:52:16.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"13707272ee36f7bc13757065bffa5377a714643d","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-10 14:07:43.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"853b5acc33dca1708ff287c12d5fd31e705841ae","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-10 16:23:22.000000000","message":"Patch Set 3:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/583fac68e4104e05a6b6b397911d5e0b\n\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/6753adeb127145d18344d3ae05698236 : SUCCESS in 1h 11m 14s (non-voting)\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/8b07fa0b71c94fb6abb2b350c5c84c74 : TIMED_OUT in 2h 04m 36s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/8bd7d77fc35c4b1abf9821052ed1580b : SUCCESS in 1h 00m 22s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/689e284c249c43229e6c657a2dc33bb4 : SUCCESS in 19m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ecf7e9265fc64d2598eaeb49cac8f1ed : SUCCESS in 11m 17s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4764f39f8c524d5caca82f8d668dcdfa : SUCCESS in 14m 43s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/9fe9287ef3f149ddb25ce1000288969c : SUCCESS in 12m 42s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c0697b51d098454ea527db0919e97fc3 : SUCCESS in 11m 13s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/174341f1bf714fa0976d9ae1c0787f86 : SUCCESS in 24m 24s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/6bf3420a1c95427ab63eec8690dc6041 : SUCCESS in 1h 07m 20s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/2f20fc67838a45dca007c20d2f5a4f2b : TIMED_OUT in 2h 03m 22s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/89c9b28688d14cf685af63c05b82bc2f : SUCCESS in 59m 27s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/bb18dca7376747509b4a770279d2d4f6 : POST_FAILURE in 1h 05m 57s (non-voting)\n- nova-lvm https://zuul.opendev.org/t/openstack/build/a58bfb844f7049a398af54559907e6a4 : SUCCESS in 1h 02m 25s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/ebafeb72f75747c29a79beb0f0c04517 : SUCCESS in 1h 42m 10s\n- nova-next https://zuul.opendev.org/t/openstack/build/7e328d51b76e4eaf89e7c213bccd6f74 : SUCCESS in 2h 07m 07s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/341107f5d2664fb9823c8fe25112b9a2 : SUCCESS in 57m 33s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/2778b699dc01439a938a13c0084254bf : SUCCESS in 5m 14s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/629ef74728a3412abbff34ca30f5dd1b : SUCCESS in 22m 23s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/d134fda5b7c143d6ac708eb83c93ae4d : SUCCESS in 24m 40s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/93e401dbe4f24a43ae3b2e36f3de6c0c : SUCCESS in 22m 36s\n- tempest-integrated-compute-ubuntu-focal https://zuul.opendev.org/t/openstack/build/59e2f70c205e4b09a9464e33be25931f : SUCCESS in 1h 35m 02s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/93e6a32dd69a4d2d9f98a8b1323e2279 : SUCCESS in 1h 06m 40s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/b58ca21d022f4862ab318ebbfe716b03 : SUCCESS in 1h 08m 36s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/8533bee0ec074480b39f95a9a41c7e85 : SUCCESS in 32m 14s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/de5d6b0eb5b748eeb02857a74c9afce2 : SUCCESS in 51m 25s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"f2e61b9103d407162aabf5cb7cba2a9cb482a45b","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-10 17:51:38.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/33e053b782304412aefef2be8ac77923\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/f8a834044c4c425f90efdada9c3e2ad3 : FAILURE in 43m 52s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/40366b14578d492d8a3f0f5695f031ea : FAILURE in 50m 43s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"3ec5fea862e82e6d4d3d76856bc31c138d15a8b9","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-11 09:51:24.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"a47985bc8ede5e16ef6a430c16fb9d0488123a9c","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2023-01-11 10:01:28.000000000","message":"Patch Set 3: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":3},{"id":"a03292d314900eafc6750fef4d97f3e5da1947da","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-11 10:12:43.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"dbc2572cde20d2b5637dcbee1e89b3052a1315d8","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-11 10:16:14.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"8f7001e4384c76328265c78c35552b89de64cbe6","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-11 10:32:52.000000000","message":"Patch Set 3:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/85481697b33b44b3a587caff7aa0c2e6\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/d5cc1d4a32a0463b99dbd921f8634f0e : SUCCESS in 39m 11s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/d39591b531ec4a1e8db7a702edefefb7 : SUCCESS in 29m 36s (non-voting)","accounts_in_message":[],"_revision_number":3},{"id":"02e0b89afa18e690105caada780846887faf9f39","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2023-01-11 10:42:06.000000000","message":"Patch Set 3:\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"b24027671ca2e24977100cb09458870aaa7a465e","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-11 11:11:52.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"a9e49d5b75f2b3ee2f85c1369a9f8b4f88857c34","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"date":"2023-01-11 11:22:57.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"1dbab5dc1025ce715abaa3a9b668e4228eccd9a9","author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"date":"2023-01-11 11:26:00.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"67b0c4ecab41141d09ec2616cfc2006024f30d43","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-11 13:01:54.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\nhttps://zuul.opendev.org/t/openstack/buildset/80efd4d396eb438789e4fb6310bce7b4\n\n- grenade-skip-level https://zuul.opendev.org/t/openstack/build/77387299085c4e7a924408b63837ef95 : SUCCESS in 1h 12m 52s (non-voting)\n- tempest-integrated-compute https://zuul.opendev.org/t/openstack/build/3ce2c7104f5f485b8b9d3193162c94af : SUCCESS in 1h 31m 57s\n- openstacksdk-functional-devstack https://zuul.opendev.org/t/openstack/build/e06f4ef9946b42d8bba3195aa1dbd794 : SUCCESS in 58m 27s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4c2ceea7b7024338ae5ccbb3ed6f71a1 : SUCCESS in 21m 14s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/559de4f7d11f4796b8ced476ac598e73 : SUCCESS in 10m 44s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d438cb65e934496d866b0787b9316d44 : SUCCESS in 11m 46s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/5cc71635f7ca4f76b86ae5eeac16b5c5 : SUCCESS in 15m 16s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/b033c7c3a1e945e8a44452c8dc59b302 : SUCCESS in 9m 38s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/88bce747f6c5426e8022a5b2cb375eed : SUCCESS in 24m 28s\n- ironic-tempest-ipa-wholedisk-bios-agent_ipmitool-tinyipa https://zuul.opendev.org/t/openstack/build/1be67ae6eff6493981b660011aca6e2f : SUCCESS in 1h 02m 38s (non-voting)\n- nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/4205e7acfc9e492f899c7b7e4453d19a : SUCCESS in 1h 18m 55s\n- nova-live-migration https://zuul.opendev.org/t/openstack/build/04e5d79561fe4fec8d080a953d5c4b8c : SUCCESS in 46m 00s\n- nova-live-migration-ceph https://zuul.opendev.org/t/openstack/build/0ef614bb9fc543daa9db1680d260e8e0 : SUCCESS in 51m 49s (non-voting)\n- nova-lvm https://zuul.opendev.org/t/openstack/build/4205f255c7f5406c8e77e6395c17d04c : SUCCESS in 1h 06m 29s\n- nova-multi-cell https://zuul.opendev.org/t/openstack/build/736e98b79dfb4b858b99a889a44d6ba2 : SUCCESS in 1h 21m 54s\n- nova-next https://zuul.opendev.org/t/openstack/build/97117e153bdc4e1f968479c7b59506ce : SUCCESS in 1h 31m 41s\n- nova-ovs-hybrid-plug https://zuul.opendev.org/t/openstack/build/4f6b3ec3391e48f499f8145ca0d60d18 : SUCCESS in 49m 35s\n- nova-tox-validate-backport https://zuul.opendev.org/t/openstack/build/a1a85b0ca15e4fb38a3ecb176ac67bda : SUCCESS in 4m 51s (non-voting)\n- nova-tox-functional-py38 https://zuul.opendev.org/t/openstack/build/e5c73838ff30429092cf70fb471ea375 : SUCCESS in 22m 12s\n- nova-tox-functional-py39 https://zuul.opendev.org/t/openstack/build/2574a6d13d3a449e9b80ad7fcbef89fe : SUCCESS in 21m 59s\n- nova-tox-functional-py310 https://zuul.opendev.org/t/openstack/build/b2bd5caa9382442cb3d7f74e554ad6fb : SUCCESS in 23m 15s\n- tempest-integrated-compute-ubuntu-focal https://zuul.opendev.org/t/openstack/build/ea7e3bc68b274238b407bde9e7cae2ae : SUCCESS in 1h 33m 34s\n- nova-grenade-multinode https://zuul.opendev.org/t/openstack/build/83ab17759b144db9a6d2b4a05a9c00c6 : FAILURE in 1h 08m 02s\n- tempest-ipv6-only https://zuul.opendev.org/t/openstack/build/1af172b39f5241929959629dc49e553b : SUCCESS in 53m 56s\n- cyborg-tempest https://zuul.opendev.org/t/openstack/build/112329d36fe3489c80086c1bf970d2fb : SUCCESS in 30m 44s (non-voting)\n- barbican-tempest-plugin-simple-crypto https://zuul.opendev.org/t/openstack/build/e898926607bc4a72a275edbdfd219101 : SUCCESS in 36m 42s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"9090ba4a06e6ca44ed0336a7f75ccc981ce8ccc1","tag":"autogenerated:zuul:check-arm64","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2023-01-11 13:02:37.000000000","message":"Patch Set 4:\n\nBuild succeeded (ARM64 pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/28d22516df254658b73fedafb709c284\n\n- openstack-tox-py38-arm64 https://zuul.opendev.org/t/openstack/build/da83f97045ef4fb793111670e778a98b : FAILURE in 40m 42s (non-voting)\n- openstack-tox-py310-arm64 https://zuul.opendev.org/t/openstack/build/54b33456630d435ba2009186fc241741 : FAILURE in 39m 53s (non-voting)","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"a34494b852d2e0c9bd48f699ab5b0fb788c9544e","revisions":{"6df43f96c4621a55ea03698eeb1f628930538745":{"kind":"REWORK","_number":1,"created":"2023-01-09 17:57:41.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/87/869587/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/869587/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/869587/1"}}},"commit":{"parents":[{"commit":"ba9d4c909beff4e9ab86911a35dd5db8d8ce08d6","subject":"Merge \"Support cold migrate and resize with PCI tracking in placement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba9d4c909beff4e9ab86911a35dd5db8d8ce08d6"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-09 15:14:08.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-09 17:56:50.000000000","tz":60},"subject":"libvirt: Remove compareCPU() check in _check_cpu_compatiblity()","message":"libvirt: Remove compareCPU() check in _check_cpu_compatiblity()\n\nNova\u0027s use of libvirt\u0027s compareCPU() API is now no longer valid, and\nfurther, the CPU comparison code in Nova\u0027s _check_cpu_compatibility()\nmethod is now causing unwanted grief.\n\nHowever, over the past years, libvirt (and QEMU) has gained a number of\nimprovements in CPU modelling area.  More specifically, with QEMU \u003e\u003d2.9\nand libvirt \u003e\u003d 4.4.0, libvirt will do the \"right thing\" in terms of\nchecking guest CPU compatibility.  Nova satisfies the said minimum\nversion requirements by a good margin, and thus can skip the\ncompareCPU() call.  This is also the advice[1] of libvirt CPU modelling\nmaintainers -- i.e. to do away with compareCPU() check and delegate the\nwork to libvirt.  (Alternative: complete the larger work[2] of switching\nto newer libvirt CPU APIs.  But that work has stalled and is more\nerror-prone.)\n\nToday we already allow skipping compareCPU() check during live migration\nvia a workaround[3].  Same rationale.\n\nThis patch removes the CPU comparison check in\n_check_cpu_compatibility() and lets libvirt to do the work.  This gives\na bigger benefit with a much smaller change in Nova.\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d2138381#c7\n[2] https://review.opendev.org/c/openstack/nova/+/762330\n[3] https://opendev.org/openstack/nova/commit/267a4066 -- libvirt: Add a\n    workaround to skip compareCPU() on destination\n\nChange-Id: Icdecd8700a2dfa20685f617b84d6065292e8cb36\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6df43f96c4621a55ea03698eeb1f628930538745"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6df43f96c4621a55ea03698eeb1f628930538745"}]},"branch":"refs/heads/master"},"830671e771f539b57fdf865246610f1aa04ad9f4":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2023-01-09 18:01:38.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/87/869587/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/869587/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/869587/2"}}},"commit":{"parents":[{"commit":"ba9d4c909beff4e9ab86911a35dd5db8d8ce08d6","subject":"Merge \"Support cold migrate and resize with PCI tracking in placement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba9d4c909beff4e9ab86911a35dd5db8d8ce08d6"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-09 15:14:08.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-09 18:01:22.000000000","tz":60},"subject":"libvirt: Remove compareCPU() check in _check_cpu_compatibility()","message":"libvirt: Remove compareCPU() check in _check_cpu_compatibility()\n\nNova\u0027s use of libvirt\u0027s compareCPU() API is now no longer valid, and\nfurther, the CPU comparison code in Nova\u0027s _check_cpu_compatibility()\nmethod is now causing unwanted grief.\n\nHowever, over the past years, libvirt (and QEMU) has gained a number of\nimprovements in CPU modelling area.  More specifically, with QEMU \u003e\u003d2.9\nand libvirt \u003e\u003d 4.4.0, libvirt will do the \"right thing\" in terms of\nchecking guest CPU compatibility.  Nova satisfies the said minimum\nversion requirements by a good margin, and thus can skip the\ncompareCPU() call.  This is also the advice[1] of libvirt CPU modelling\nmaintainers -- i.e. to do away with compareCPU() check and delegate the\nwork to libvirt.  (Alternative: complete the larger work[2] of switching\nto newer libvirt CPU APIs.  But that work has stalled and is more\nerror-prone.)\n\nToday we already allow skipping compareCPU() check during live migration\nvia a workaround[3].  Same rationale.\n\nThis patch removes the CPU comparison check in\n_check_cpu_compatibility() and lets libvirt to do the work.  This gives\na bigger benefit with a much smaller change in Nova.\n\n[1] https://bugzilla.redhat.com/show_bug.cgi?id\u003d2138381#c7\n[2] https://review.opendev.org/c/openstack/nova/+/762330\n[3] https://opendev.org/openstack/nova/commit/267a4066 -- libvirt: Add a\n    workaround to skip compareCPU() on destination\n\nChange-Id: Icdecd8700a2dfa20685f617b84d6065292e8cb36\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/830671e771f539b57fdf865246610f1aa04ad9f4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/830671e771f539b57fdf865246610f1aa04ad9f4"}]},"branch":"refs/heads/master"},"54e35926a41fe1e294066f19e3b012dd5a859c4d":{"kind":"REWORK","_number":3,"created":"2023-01-10 10:09:45.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/87/869587/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/869587/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/869587/3"}}},"commit":{"parents":[{"commit":"ba9d4c909beff4e9ab86911a35dd5db8d8ce08d6","subject":"Merge \"Support cold migrate and resize with PCI tracking in placement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba9d4c909beff4e9ab86911a35dd5db8d8ce08d6"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-09 15:14:08.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-10 10:07:05.000000000","tz":60},"subject":"libvirt: Remove compareCPU() check in _check_cpu_compatibility()","message":"libvirt: Remove compareCPU() check in _check_cpu_compatibility()\n\nNova\u0027s use of libvirt\u0027s compareCPU() API is now no longer valid, and\nfurther, the CPU comparison code in Nova\u0027s _check_cpu_compatibility()\nmethod is now causing unwanted grief[1][2][3].\n\nHowever, over the past years, libvirt (and QEMU) has gained a number of\nimprovements in CPU modelling area.  More specifically, with QEMU \u003e\u003d2.9\nand libvirt \u003e\u003d 4.4.0, libvirt will do the \"right thing\" in terms of\nchecking guest CPU compatibility.  Nova satisfies the said minimum\nversion requirements by a good margin, and thus can skip the\ncompareCPU() call.  This is also the advice[4] of libvirt CPU modelling\nmaintainers -- i.e. to do away with compareCPU() check and delegate the\nwork to libvirt.  (Alternative: complete the larger work[5] of switching\nto newer libvirt CPU APIs.  But that work has stalled and is more\nerror-prone.)\n\nToday we already allow skipping compareCPU() check during live migration\nvia a workaround[6].  Same rationale.  (We should also deprecate the\nworkaround in check_can_live_migrate_destination() followed by removal\nof the compareCPU() call.)\n\nThis patch does the following:\n\n  - Removes the CPU comparison check in _check_cpu_compatibility() and\n    lets libvirt to do the work.  This gives a bigger benefit with a\n    much smaller change in Nova\n  - Removes the unit tests that are now rendered invalid\n\n[1] https://listman.redhat.com/archives/libvir-list/2022-December/236134.html\n[2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d2138381 -- Unacceptable\n    CPU info: CPU doesn\u0027t have compatibility\n[3] https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1978064 --\n    IceLake CPU model not recognized\n[4] https://bugzilla.redhat.com/show_bug.cgi?id\u003d2138381#c7\n[5] https://review.opendev.org/c/openstack/nova/+/762330\n[6] https://opendev.org/openstack/nova/commit/267a4066 -- libvirt: Add a\n    workaround to skip compareCPU() on destination\n\nChange-Id: Icdecd8700a2dfa20685f617b84d6065292e8cb36\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/54e35926a41fe1e294066f19e3b012dd5a859c4d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/54e35926a41fe1e294066f19e3b012dd5a859c4d"}]},"branch":"refs/heads/master"},"a34494b852d2e0c9bd48f699ab5b0fb788c9544e":{"kind":"REWORK","_number":4,"created":"2023-01-11 11:22:57.000000000","uploader":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"ref":"refs/changes/87/869587/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/87/869587/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/87/869587/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/87/869587/4"}}},"commit":{"parents":[{"commit":"ba9d4c909beff4e9ab86911a35dd5db8d8ce08d6","subject":"Merge \"Support cold migrate and resize with PCI tracking in placement\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ba9d4c909beff4e9ab86911a35dd5db8d8ce08d6"}]}],"author":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-09 15:14:08.000000000","tz":60},"committer":{"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","date":"2023-01-11 11:14:27.000000000","tz":60},"subject":"libvirt: Remove compareCPU() check in _check_cpu_compatibility()","message":"libvirt: Remove compareCPU() check in _check_cpu_compatibility()\n\nNova\u0027s use of libvirt\u0027s compareCPU() API is now no longer valid, and\nfurther, the CPU comparison code in Nova\u0027s _check_cpu_compatibility()\nmethod is now causing unwanted grief[1][2][3].\n\nHowever, over the past years, libvirt (and QEMU) has gained a number of\nimprovements in CPU modelling area.  More specifically, with QEMU \u003e\u003d2.9\nand libvirt \u003e\u003d 4.4.0, libvirt will do the \"right thing\" in terms of\nchecking guest CPU compatibility.  Nova satisfies the said minimum\nversion requirements by a good margin, and thus can skip the\ncompareCPU() call.  This is also the advice[4] of libvirt CPU modelling\nmaintainers -- i.e. to do away with compareCPU() check and delegate the\nwork to libvirt.  (Alternative: complete the larger work[5] of switching\nto newer libvirt CPU APIs.  But that work has stalled and is more\nerror-prone.)\n\nToday we already allow skipping compareCPU() check during live migration\nvia a workaround[6].  Same rationale.  (We should also deprecate the\nworkaround in check_can_live_migrate_destination() followed by removal\nof the compareCPU() call.)\n\nThis patch:\n\n  - Removes the CPU comparison check (and related code that\u0027s rendered\n    dead) in _check_cpu_compatibility() and lets libvirt to do the work.\n    This gives a bigger benefit with a much smaller change in Nova\n  - Removes the unit tests that are now rendered invalid\n\n[1] https://listman.redhat.com/archives/libvir-list/2022-December/236134.html\n[2] https://bugzilla.redhat.com/show_bug.cgi?id\u003d2138381 -- Unacceptable\n    CPU info: CPU doesn\u0027t have compatibility\n[3] https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1978064 --\n    IceLake CPU model not recognized\n[4] https://bugzilla.redhat.com/show_bug.cgi?id\u003d2138381#c7\n[5] https://review.opendev.org/c/openstack/nova/+/762330\n[6] https://opendev.org/openstack/nova/commit/267a4066 -- libvirt: Add a\n    workaround to skip compareCPU() on destination\n\nChange-Id: Icdecd8700a2dfa20685f617b84d6065292e8cb36\nSigned-off-by: Kashyap Chamarthy \u003ckchamart@redhat.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a34494b852d2e0c9bd48f699ab5b0fb788c9544e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a34494b852d2e0c9bd48f699ab5b0fb788c9544e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"}},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dMAX"],"failing_atoms":["label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review Priority","status":"NOT_APPLICABLE","is_legacy":false,"applicability_expression_result":{"fulfilled":false,"status":"FAIL"},"submittability_expression_result":{"expression":"is:true","fulfilled":true,"status":"NOT_EVALUATED","passing_atoms":[],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}