)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2ff75a57ff5448d8c31ccddb2105c9039ed80ae4","unresolved":true,"context_lines":[{"line_number":23,"context_line":"image itself."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Reference:"},{"line_number":26,"context_line":"https://github.com/libvirt/libvirt/blob/master/tests/qemuxml2xmloutdata/luks-disks-source-qcow2.x86_64-latest.xml#L77-L95"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I333dc16145079d9c1f2d8edc2425fcd92e3e1da0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"6cc46b00_41a945ab","line":26,"range":{"start_line":26,"start_character":113,"end_line":26,"end_character":121},"updated":"2023-02-03 13:58:35.000000000","message":"This isn\u0027t a stable link and will point to something different in the future.","commit_id":"385daf82fe5733f7fc47bca11c6c589434762f3f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"57f475202d147f24b7c50b89fe042e3ee29e95d8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"image itself."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Reference:"},{"line_number":26,"context_line":"https://github.com/libvirt/libvirt/blob/master/tests/qemuxml2xmloutdata/luks-disks-source-qcow2.x86_64-latest.xml#L77-L95"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: I333dc16145079d9c1f2d8edc2425fcd92e3e1da0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1bfdcd96_3f702006","line":26,"range":{"start_line":26,"start_character":113,"end_line":26,"end_character":121},"in_reply_to":"6cc46b00_41a945ab","updated":"2023-02-10 10:12:42.000000000","message":"Done","commit_id":"385daf82fe5733f7fc47bca11c6c589434762f3f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"f21580f7339fcdd501987cb5dfe22214513a9ee8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9a992d7e_9add8cf6","updated":"2023-02-15 11:05:13.000000000","message":"\u003e nova-ceph-multistore https://zuul.opendev.org/t/openstack/build/18c228fff69e4df0b77fabda5ccf962c : FAILURE in 1h 08m 43s \n\nFour tests are failing with the same error `TypeError: retry_bad_request() missing 1 required positional argument: \u0027fn\u0027` when calling self._check_set_location(). Looks like glance was unable to fetch the remote image via HTTP and not really related with this patch. How can I handle this CI failure?","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"92f06f2249fc1339d4ee5b82d57411d9b086b5d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4c83fe9b_804a1740","updated":"2023-03-29 16:59:10.000000000","message":"Eric\u0027s review has pointed out that there is more work needed on this patch. Specifically, the patch does not currently support qcow2 images with multiple snapshots, contrary to what the code assumes. \n\nUnfortunately, my devstack environment is not functioning properly at the moment, so I am unable to check this scenario. However, I plan to investigate this further after the PTG.","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"789338c555d0460cd08bad17f43cd691e43e4207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7514f8f7_4eba1ddd","updated":"2023-02-20 09:54:29.000000000","message":"Zuul is failing randomly. ","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"897d6ff06066faffdbde57bffe53f2444e39351e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cd1ba031_1e7304a8","updated":"2023-03-23 14:40:57.000000000","message":"just did a quick skim pass i have not had time to review this properly today but just wanted to ask a few questions before the ptg.","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e2f9ad834b17d7bd4d07b3900decabc9bb34d614","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"13a6d3b9_e9ef3679","updated":"2023-02-20 09:54:37.000000000","message":"recheck","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"30a3ad30dfeaf85dea5703b8a78b4108ff563beb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a7c4d351_f94fdd16","updated":"2023-02-13 13:48:04.000000000","message":"recheck","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e396aabd758ee9f20d8389fbadb21cd27c989115","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1606f716_5f7d162e","updated":"2023-02-15 11:05:42.000000000","message":"recheck nova-ceph-multistore","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"7f26db51fdfa814ecdf8b874fa6445d086ccee23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"cfa57dd0_14e61ac6","updated":"2023-02-10 12:54:17.000000000","message":"recheck nova-ceph-multistore","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"}],"nova/tests/unit/virt/libvirt/test_config.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"897d6ff06066faffdbde57bffe53f2444e39351e","unresolved":true,"context_lines":[{"line_number":1443,"context_line":"              \u003cformat type\u003d\"qcow2\"/\u003e"},{"line_number":1444,"context_line":"              \u003csource file\u003d\"/tmp/hello\"/\u003e"},{"line_number":1445,"context_line":"              \u003cencryption format\u003d\"luks\"\u003e"},{"line_number":1446,"context_line":"                \u003csecret type\u003d\"passphrase\""},{"line_number":1447,"context_line":"                        uuid\u003d\"12345678-1234-1234-1234-123456789012\"/\u003e"},{"line_number":1448,"context_line":"              \u003c/encryption\u003e"},{"line_number":1449,"context_line":"            \u003c/backingStore\u003e\"\"\")"},{"line_number":1450,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"aa3be674_54125cb4","line":1447,"range":{"start_line":1446,"start_character":16,"end_line":1447,"end_character":69},"updated":"2023-03-23 14:40:57.000000000","message":"how is this secert created is it added to libvirt?\n\nos-brick? or is this added by nova from the connection info/attachemtns.","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"92f06f2249fc1339d4ee5b82d57411d9b086b5d6","unresolved":true,"context_lines":[{"line_number":1443,"context_line":"              \u003cformat type\u003d\"qcow2\"/\u003e"},{"line_number":1444,"context_line":"              \u003csource file\u003d\"/tmp/hello\"/\u003e"},{"line_number":1445,"context_line":"              \u003cencryption format\u003d\"luks\"\u003e"},{"line_number":1446,"context_line":"                \u003csecret type\u003d\"passphrase\""},{"line_number":1447,"context_line":"                        uuid\u003d\"12345678-1234-1234-1234-123456789012\"/\u003e"},{"line_number":1448,"context_line":"              \u003c/encryption\u003e"},{"line_number":1449,"context_line":"            \u003c/backingStore\u003e\"\"\")"},{"line_number":1450,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"e3807892_b83a0392","line":1447,"range":{"start_line":1446,"start_character":16,"end_line":1447,"end_character":69},"in_reply_to":"aa3be674_54125cb4","updated":"2023-03-29 16:59:10.000000000","message":"Since this is a unittest that only checks the formatting of the XML, I have used a hard-coded string. However, should I replace it with uuids.secret to match the approach taken by other tests?","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"}],"nova/virt/libvirt/volume/volume.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"897d6ff06066faffdbde57bffe53f2444e39351e","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            conf.encryption.format \u003d \u0027luks\u0027"},{"line_number":131,"context_line":"            conf.encryption.secret \u003d secret"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # Code to support BackingStore for volume encryption"},{"line_number":134,"context_line":"        # generation. This is used by the libvirt driver to generate"},{"line_number":135,"context_line":"        # the BackingStore xml for the volume encryption."},{"line_number":136,"context_line":"        if libvirt_utils.is_luks_inside_qcow2_snapshot(connection_info):"},{"line_number":137,"context_line":"            conf.backing_store \u003d vconfig.LibvirtConfigGuestDiskBackingStore()"},{"line_number":138,"context_line":"            bs_secret \u003d vconfig.LibvirtConfigGuestDiskEncryptionSecret()"},{"line_number":139,"context_line":"            bs_secret.type \u003d \u0027passphrase\u0027"},{"line_number":140,"context_line":"            bs_secret.uuid \u003d volume_secret.UUIDString()"},{"line_number":141,"context_line":"            bs_encryption \u003d vconfig.LibvirtConfigGuestDiskEncryption()"},{"line_number":142,"context_line":"            bs_encryption.format \u003d \u0027luks\u0027"},{"line_number":143,"context_line":"            bs_encryption.secret \u003d bs_secret"},{"line_number":144,"context_line":"            conf.backing_store.encryption \u003d bs_encryption"},{"line_number":145,"context_line":"            conf.backing_store.driver_format \u003d \u0027qcow2\u0027"},{"line_number":146,"context_line":"            conf.backing_store.source_file \u003d volume_id"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return conf"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"0110daa6_1a7ac226","line":146,"range":{"start_line":133,"start_character":7,"end_line":146,"end_character":54},"updated":"2023-03-23 14:40:57.000000000","message":"so this is generating the xml snippit that refenece the secret but im still missign wehre we get this form barbican or cinder to ensure its created in libvirt in the first place.\n\nare you relying on exting common code for that","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"06a5a8f9ea509214c52fefadb4b318152907b537","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            conf.encryption.format \u003d \u0027luks\u0027"},{"line_number":131,"context_line":"            conf.encryption.secret \u003d secret"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # Code to support BackingStore for volume encryption"},{"line_number":134,"context_line":"        # generation. This is used by the libvirt driver to generate"},{"line_number":135,"context_line":"        # the BackingStore xml for the volume encryption."},{"line_number":136,"context_line":"        if libvirt_utils.is_luks_inside_qcow2_snapshot(connection_info):"},{"line_number":137,"context_line":"            conf.backing_store \u003d vconfig.LibvirtConfigGuestDiskBackingStore()"},{"line_number":138,"context_line":"            bs_secret \u003d vconfig.LibvirtConfigGuestDiskEncryptionSecret()"},{"line_number":139,"context_line":"            bs_secret.type \u003d \u0027passphrase\u0027"},{"line_number":140,"context_line":"            bs_secret.uuid \u003d volume_secret.UUIDString()"},{"line_number":141,"context_line":"            bs_encryption \u003d vconfig.LibvirtConfigGuestDiskEncryption()"},{"line_number":142,"context_line":"            bs_encryption.format \u003d \u0027luks\u0027"},{"line_number":143,"context_line":"            bs_encryption.secret \u003d bs_secret"},{"line_number":144,"context_line":"            conf.backing_store.encryption \u003d bs_encryption"},{"line_number":145,"context_line":"            conf.backing_store.driver_format \u003d \u0027qcow2\u0027"},{"line_number":146,"context_line":"            conf.backing_store.source_file \u003d volume_id"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return conf"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"510e1e4f_6ab16722","line":146,"range":{"start_line":133,"start_character":7,"end_line":146,"end_character":54},"in_reply_to":"0110daa6_1a7ac226","updated":"2023-03-24 13:37:38.000000000","message":"In line L124 we get the secret and i using it on this xml again.","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a246dcafe00141f1d3fbee058f8e3020e572f53c","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            conf.encryption.format \u003d \u0027luks\u0027"},{"line_number":131,"context_line":"            conf.encryption.secret \u003d secret"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # Code to support BackingStore for volume encryption"},{"line_number":134,"context_line":"        # generation. This is used by the libvirt driver to generate"},{"line_number":135,"context_line":"        # the BackingStore xml for the volume encryption."},{"line_number":136,"context_line":"        if libvirt_utils.is_luks_inside_qcow2_snapshot(connection_info):"},{"line_number":137,"context_line":"            conf.backing_store \u003d vconfig.LibvirtConfigGuestDiskBackingStore()"},{"line_number":138,"context_line":"            bs_secret \u003d vconfig.LibvirtConfigGuestDiskEncryptionSecret()"},{"line_number":139,"context_line":"            bs_secret.type \u003d \u0027passphrase\u0027"},{"line_number":140,"context_line":"            bs_secret.uuid \u003d volume_secret.UUIDString()"},{"line_number":141,"context_line":"            bs_encryption \u003d vconfig.LibvirtConfigGuestDiskEncryption()"},{"line_number":142,"context_line":"            bs_encryption.format \u003d \u0027luks\u0027"},{"line_number":143,"context_line":"            bs_encryption.secret \u003d bs_secret"},{"line_number":144,"context_line":"            conf.backing_store.encryption \u003d bs_encryption"},{"line_number":145,"context_line":"            conf.backing_store.driver_format \u003d \u0027qcow2\u0027"},{"line_number":146,"context_line":"            conf.backing_store.source_file \u003d volume_id"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return conf"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"a6cca61e_b1386601","line":146,"range":{"start_line":133,"start_character":7,"end_line":146,"end_character":54},"in_reply_to":"510e1e4f_6ab16722","updated":"2023-03-28 15:42:36.000000000","message":"so this is using a secreat that was stored in barbican and retrived and stored in libvirt by generic code correct.\n\nit makes sense that this would be common and reused i just wanted to confrim that.","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"92f06f2249fc1339d4ee5b82d57411d9b086b5d6","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            conf.encryption.format \u003d \u0027luks\u0027"},{"line_number":131,"context_line":"            conf.encryption.secret \u003d secret"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        # Code to support BackingStore for volume encryption"},{"line_number":134,"context_line":"        # generation. This is used by the libvirt driver to generate"},{"line_number":135,"context_line":"        # the BackingStore xml for the volume encryption."},{"line_number":136,"context_line":"        if libvirt_utils.is_luks_inside_qcow2_snapshot(connection_info):"},{"line_number":137,"context_line":"            conf.backing_store \u003d vconfig.LibvirtConfigGuestDiskBackingStore()"},{"line_number":138,"context_line":"            bs_secret \u003d vconfig.LibvirtConfigGuestDiskEncryptionSecret()"},{"line_number":139,"context_line":"            bs_secret.type \u003d \u0027passphrase\u0027"},{"line_number":140,"context_line":"            bs_secret.uuid \u003d volume_secret.UUIDString()"},{"line_number":141,"context_line":"            bs_encryption \u003d vconfig.LibvirtConfigGuestDiskEncryption()"},{"line_number":142,"context_line":"            bs_encryption.format \u003d \u0027luks\u0027"},{"line_number":143,"context_line":"            bs_encryption.secret \u003d bs_secret"},{"line_number":144,"context_line":"            conf.backing_store.encryption \u003d bs_encryption"},{"line_number":145,"context_line":"            conf.backing_store.driver_format \u003d \u0027qcow2\u0027"},{"line_number":146,"context_line":"            conf.backing_store.source_file \u003d volume_id"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"        return conf"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"c24328d4_cc086909","line":146,"range":{"start_line":133,"start_character":7,"end_line":146,"end_character":54},"in_reply_to":"a6cca61e_b1386601","updated":"2023-03-29 16:59:10.000000000","message":"Hello Sean, that is correct. I am reusing the same secret for both the backing file and the disk because they both need the same one.","commit_id":"641f7d0ab136ee16bd501d86845170e0f84302b4"}]}