)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"a4365465e371fc5935907902d47d12700f060f5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b901e61b_4a01d1b0","updated":"2023-07-06 12:31:43.000000000","message":"-2 based on comemnt in spec lest discuss this when your are back and have had time to catch up on the comments.","commit_id":"bce460ad1ad2165f56f1b9da41b8c798d8dc3e2d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8d1a0ac5f66e628fec1856f5bca6aae4d6cf978f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"37514e78_28fa7b55","updated":"2023-07-11 16:08:39.000000000","message":"removing -2 i spoke to melaine and she expliad that she is alwasy create a new secrete when takign a snap shot and propsoed an update to the spec to detail that here https://review.opendev.org/c/openstack/nova-specs/+/887905","commit_id":"bce460ad1ad2165f56f1b9da41b8c798d8dc3e2d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cbe6e3e0ca736a4df4cefc0b607c742effa0af77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"6c258893_b0cae1b1","updated":"2024-01-31 09:56:47.000000000","message":"this looks fine but it needs to be reordered","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"25af102c29adef3e32827c8bbc5e861d9cd1c6ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"2b861537_c027143e","updated":"2024-02-06 22:16:45.000000000","message":"recheck https://review.opendev.org/c/openstack/nova/+/908182 has merged","commit_id":"e2ae2922f8439d8faf7dda504742dd6802efe4d8"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"d038e48b46e90920d2825ffd36047c94515d17e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"0496671d_1804c196","updated":"2024-02-14 10:24:09.000000000","message":"Sounds good to me. I verified that the introduction of the new object parameter has corresponding compatibility code and updated checksum.","commit_id":"d0d2e08aa844fae18e5629f26e483b28c371a59f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"47ae66c187d141aa07e9e6c16ba0173967a51909","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"eb29652f_825460fe","updated":"2024-03-01 15:45:22.000000000","message":"recheck DB timeout\n\nLooks like mysql stopped responding to some of the nodes (quick enough) at some point in the test which caused at least one case of a service failing to update its record.","commit_id":"740d5bb53131843fce667f042656c3ece126db1d"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"0db3ee2b34500a990e9871014f222fa223094356","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"467b74de_122e0b0d","updated":"2024-02-29 18:22:05.000000000","message":"still looks fine this was just rebased to account for the address space change.","commit_id":"740d5bb53131843fce667f042656c3ece126db1d"}],"nova/notifications/objects/image.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cbe6e3e0ca736a4df4cefc0b607c742effa0af77","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    # Version 1.11: Added \u0027hw_locked_memory\u0027 field"},{"line_number":132,"context_line":"    # Version 1.12: Added \u0027hw_viommu_model\u0027 field"},{"line_number":133,"context_line":"    # Version 1.13: Added \u0027hw_virtio_packed_ring\u0027 field"},{"line_number":134,"context_line":"    # Version 1.14: Added \u0027hw_ephemeral_encryption_secret_uuid\u0027 field"},{"line_number":135,"context_line":"    VERSION \u003d \u00271.14\u0027"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":26,"id":"7d574b72_cd9a3a89","line":134,"updated":"2024-01-31 09:56:47.000000000","message":"im a little conflicted about this.\n\nthe secret uuid is like adding a username to the notification.\n\nis a visable property on the image and you dont actully have the secret data\n\nbut i wonder if it would be better to filter this out.\n\nits not really a security issue but im also not certin there is a usecase for consuming it via the notifcation objects.","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"603fc28e288f4373f9180994de80895bc8ac6f99","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    # Version 1.11: Added \u0027hw_locked_memory\u0027 field"},{"line_number":132,"context_line":"    # Version 1.12: Added \u0027hw_viommu_model\u0027 field"},{"line_number":133,"context_line":"    # Version 1.13: Added \u0027hw_virtio_packed_ring\u0027 field"},{"line_number":134,"context_line":"    # Version 1.14: Added \u0027hw_ephemeral_encryption_secret_uuid\u0027 field"},{"line_number":135,"context_line":"    VERSION \u003d \u00271.14\u0027"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":26,"id":"a3e889e6_6888e67d","line":134,"in_reply_to":"386a4af1_4b2c54e9","updated":"2024-02-13 05:42:09.000000000","message":"Done","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b998a3fec5e2abc014c5e51986ccf255056be50e","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    # Version 1.11: Added \u0027hw_locked_memory\u0027 field"},{"line_number":132,"context_line":"    # Version 1.12: Added \u0027hw_viommu_model\u0027 field"},{"line_number":133,"context_line":"    # Version 1.13: Added \u0027hw_virtio_packed_ring\u0027 field"},{"line_number":134,"context_line":"    # Version 1.14: Added \u0027hw_ephemeral_encryption_secret_uuid\u0027 field"},{"line_number":135,"context_line":"    VERSION \u003d \u00271.14\u0027"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":26,"id":"386a4af1_4b2c54e9","line":134,"in_reply_to":"5f5402fd_7fa18bcc","updated":"2024-02-01 09:01:18.000000000","message":"see below it pretty simple\nyou just need to filter then drop the version bump","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f38358940b3a5f1936c373d9aef8df33b4e550cf","unresolved":true,"context_lines":[{"line_number":131,"context_line":"    # Version 1.11: Added \u0027hw_locked_memory\u0027 field"},{"line_number":132,"context_line":"    # Version 1.12: Added \u0027hw_viommu_model\u0027 field"},{"line_number":133,"context_line":"    # Version 1.13: Added \u0027hw_virtio_packed_ring\u0027 field"},{"line_number":134,"context_line":"    # Version 1.14: Added \u0027hw_ephemeral_encryption_secret_uuid\u0027 field"},{"line_number":135,"context_line":"    VERSION \u003d \u00271.14\u0027"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    SCHEMA \u003d {"}],"source_content_type":"text/x-python","patch_set":26,"id":"5f5402fd_7fa18bcc","line":134,"in_reply_to":"7d574b72_cd9a3a89","updated":"2024-02-01 02:19:17.000000000","message":"Oh, yeah, that\u0027s a good point. I don\u0027t think it should be visible in a notification ... I didn\u0027t even realize it. Hopefully it\u0027s possible/supported to add an ImageMetaProps without adding it to notifications.","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b998a3fec5e2abc014c5e51986ccf255056be50e","unresolved":true,"context_lines":[{"line_number":135,"context_line":"    VERSION \u003d \u00271.14\u0027"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    SCHEMA \u003d {"},{"line_number":138,"context_line":"        k: (\u0027image_meta_props\u0027, k) for k in image_meta.ImageMetaProps.fields}"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # NOTE(efried): This logic currently relies on all of the fields of"},{"line_number":141,"context_line":"    # ImageMetaProps being initialized with no arguments. See the docstring."}],"source_content_type":"text/x-python","patch_set":26,"id":"99275dea_3637883d","line":138,"updated":"2024-02-01 09:01:18.000000000","message":"move this after fileds and loop over the fields key on this object\n\ni.e. image_meta.ImageMetaProps.fields -\u003e just fields\n\nif that does not work just filter it the same as i suggest below","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"603fc28e288f4373f9180994de80895bc8ac6f99","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    VERSION \u003d \u00271.14\u0027"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    SCHEMA \u003d {"},{"line_number":138,"context_line":"        k: (\u0027image_meta_props\u0027, k) for k in image_meta.ImageMetaProps.fields}"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    # NOTE(efried): This logic currently relies on all of the fields of"},{"line_number":141,"context_line":"    # ImageMetaProps being initialized with no arguments. See the docstring."}],"source_content_type":"text/x-python","patch_set":26,"id":"9bf8e1fb_9a1ef088","line":138,"in_reply_to":"99275dea_3637883d","updated":"2024-02-13 05:42:09.000000000","message":"Done","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"b998a3fec5e2abc014c5e51986ccf255056be50e","unresolved":true,"context_lines":[{"line_number":144,"context_line":"    #  But it is not clear that OVO can tolerate the same *instance* of a type"},{"line_number":145,"context_line":"    #  class being used in more than one place."},{"line_number":146,"context_line":"    fields \u003d {"},{"line_number":147,"context_line":"        k: v.__class__() for k, v in image_meta.ImageMetaProps.fields.items()}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, image_meta_props):"},{"line_number":150,"context_line":"        super(ImageMetaPropsPayload, self).__init__()"}],"source_content_type":"text/x-python","patch_set":26,"id":"57eaf425_4fd685ca","line":147,"updated":"2024-02-01 09:01:18.000000000","message":"add\nif k not in (‘hw_ephmeral_encryption_secret_uuid’,)\n\nto the dict comprehention to fileter it out.","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"603fc28e288f4373f9180994de80895bc8ac6f99","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    #  But it is not clear that OVO can tolerate the same *instance* of a type"},{"line_number":145,"context_line":"    #  class being used in more than one place."},{"line_number":146,"context_line":"    fields \u003d {"},{"line_number":147,"context_line":"        k: v.__class__() for k, v in image_meta.ImageMetaProps.fields.items()}"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def __init__(self, image_meta_props):"},{"line_number":150,"context_line":"        super(ImageMetaPropsPayload, self).__init__()"}],"source_content_type":"text/x-python","patch_set":26,"id":"5ae6cf31_032ff16d","line":147,"in_reply_to":"57eaf425_4fd685ca","updated":"2024-02-13 05:42:09.000000000","message":"Done","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"}],"nova/objects/image_meta.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"cbe6e3e0ca736a4df4cefc0b607c742effa0af77","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        \u0027hw_ephemeral_encryption_format\u0027:"},{"line_number":480,"context_line":"            fields.BlockDeviceEncryptionFormatTypeField(),"},{"line_number":481,"context_line":"        # encryption secret uuid string for passphrase in the image"},{"line_number":482,"context_line":"        \u0027hw_ephemeral_encryption_secret_uuid\u0027: fields.UUIDField(),"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        # boolean - If true, this will enable the virtio packed ring feature"},{"line_number":485,"context_line":"        \u0027hw_virtio_packed_ring\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":26,"id":"5cca9227_eb3a8384","line":482,"updated":"2024-01-31 09:56:47.000000000","message":"you are adding this here but you are trying to used this in a previous path form the instance system metadata table.\n\nso that code should proably be after this code as it wont be set prior to this.","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"603fc28e288f4373f9180994de80895bc8ac6f99","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        \u0027hw_ephemeral_encryption_format\u0027:"},{"line_number":480,"context_line":"            fields.BlockDeviceEncryptionFormatTypeField(),"},{"line_number":481,"context_line":"        # encryption secret uuid string for passphrase in the image"},{"line_number":482,"context_line":"        \u0027hw_ephemeral_encryption_secret_uuid\u0027: fields.UUIDField(),"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        # boolean - If true, this will enable the virtio packed ring feature"},{"line_number":485,"context_line":"        \u0027hw_virtio_packed_ring\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":26,"id":"17a80789_2a2dd9e8","line":482,"in_reply_to":"24d5eb06_0d8f24a9","updated":"2024-02-13 05:42:09.000000000","message":"Acknowledged","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f38358940b3a5f1936c373d9aef8df33b4e550cf","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        \u0027hw_ephemeral_encryption_format\u0027:"},{"line_number":480,"context_line":"            fields.BlockDeviceEncryptionFormatTypeField(),"},{"line_number":481,"context_line":"        # encryption secret uuid string for passphrase in the image"},{"line_number":482,"context_line":"        \u0027hw_ephemeral_encryption_secret_uuid\u0027: fields.UUIDField(),"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        # boolean - If true, this will enable the virtio packed ring feature"},{"line_number":485,"context_line":"        \u0027hw_virtio_packed_ring\u0027: fields.FlexibleBooleanField(),"}],"source_content_type":"text/x-python","patch_set":26,"id":"24d5eb06_0d8f24a9","line":482,"in_reply_to":"5cca9227_eb3a8384","updated":"2024-02-01 02:19:17.000000000","message":"Yeah, sorry, that was a mess up.","commit_id":"44f81e9804f681031dfeb5879af10c0f36550346"}]}