)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3e865dc87bd783d2b4c1f341d2dcd1483cf50f6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"2eadf240_f2dbd31a","updated":"2024-01-31 10:51:09.000000000","message":"can we start working on the release notes from the point the first patch that can create a vm with encypted local storage.","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dbf5838ad1c117131649de74769439e52ae2b83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"2c8dbfc1_2e1152e7","updated":"2024-02-13 08:11:45.000000000","message":"+1 beacue of missing functionatl test but i know you have not got to this point in the serise with them\n\ni have tested shelve manually and i saw the secrete were removed properly adn restored so over all i think we could merge this if needed and we could add the functiall tests after feature freeze","commit_id":"8d8da99f95b03a12628e307ee71456fbb1ba7ea3"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"b9173e4c2a892eac77e36d014a564521512a8218","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"18aa97cb_b35e86b3","updated":"2024-02-23 20:57:26.000000000","message":"recheck nova-ceph-multistore TIMED_OUT and nova-lvm urllib3.exceptions.ReadTimeoutError: HTTPSConnectionPool(host\u003d\u002710.209.131.99\u0027, port\u003d443): Read timed out. (read timeout\u003d60)","commit_id":"5a05eaf014e57a09330b7e3a350d17677b3c46a1"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"992aa34444b0f69f16e641f76de134e2cdbc38eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"ac987bbb_de4d3be8","updated":"2024-02-23 12:27:17.000000000","message":"recheck nova-next","commit_id":"5a05eaf014e57a09330b7e3a350d17677b3c46a1"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"89fc79b783153e8b1286fde7328697cb85e37a2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"615be154_1a232fe9","updated":"2024-06-06 06:19:40.000000000","message":"recheck nova-ceph-multistore TIMED_OUT","commit_id":"0640c20421dd322c2205c59627f462f9a2ef9b7b"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"8d78d03a908f2b752fb2b07a07d1a8f895506c0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"8a92ed58_cbd8e0cc","updated":"2024-06-26 13:18:10.000000000","message":"im not sure if the nova-next failure is relate to this patch or not but im sing some evidance that the isntace is trying to use ide during the rebuild tests\n\nhowever i think i have see this on other patches too. im just leaving this here whie i dig into this futher \n\nthe imporant part is \n\nimage_disk_format\u003d\u0027qcow2\u0027,image_hw_cdrom_bus\u003d\u0027ide\u0027,image_hw_disk_bus\u003d\u0027virtio\u0027,image_hw_input_bus\u003dNone,image_hw_machine_type\u003d\u0027q35\u0027\n\nimage_hw_cdrom_bus shoudl be sata.\n\nce\u003dNone,default_swap_device\u003dNone,deleted\u003dFalse,deleted_at\u003dNone,device_metadata\u003d\u003c?\u003e,disable_terminate\u003dFalse,display_description\u003d\u0027tempest-ServerActionsTestJSON-server-1398515698\u0027,display_name\u003d\u0027tempest-ServerActionsTestJSON-server-1398515698\u0027,ec2_ids\u003d\u003c?\u003e,ephemeral_gb\u003d0,ephemeral_key_uuid\u003dNone,fault\u003d\u003c?\u003e,flavor\u003dFlavor(12),hidden\u003dFalse,host\u003d\u0027np0037812213\u0027,hostname\u003d\u0027tempest-serveractionstestjson-server-1398515698\u0027,id\u003d145,image_ref\u003d\u002788e40bdd-5857-4719-9125-fc2be6f2f6f0\u0027,info_cache\u003dInstanceInfoCache,instance_type_id\u003d12,kernel_id\u003d\u0027\u0027,key_data\u003d\u0027ecdsa-sha2-nistp384 AAAAE2VjZHNhLXNoYTItbmlzdHAzODQAAAAIbmlzdHAzODQAAABhBMnlWxpzboyjG/KMvhUTi5NqHP+eWZ4YyVRS00jyIf68n3K3OudJTYxx/PMk2vJq4nq7CR2yidScZV3A8Qy2Yt2PbZD5DQ/RjuqSZ15yLDLOZ0KkSlbDO50FjqjyTIaXAg\u003d\u003d\u0027,key_name\u003d\u0027tempest-keypair-1906001232\u0027,keypairs\u003d\u003c?\u003e,launch_index\u003d0,launched_at\u003d2024-06-26T07:35:22Z,launched_on\u003d\u0027np0037812214\u0027,locked\u003dFalse,locked_by\u003dNone,memory_mb\u003d192,metadata\u003d{},migration_context\u003d\u003c?\u003e,new_flavor\u003dFlavor(12),node\u003d\u0027np0037812213\u0027,numa_topology\u003dNone,old_flavor\u003dFlavor(11),os_type\u003dNone,pci_devices\u003d\u003c?\u003e,pci_requests\u003d\u003c?\u003e,power_state\u003d1,progress\u003d0,project_id\u003d\u00279d2f85ffd0504de3b0eeeb483e139841\u0027,ramdisk_id\u003d\u0027\u0027,reservation_id\u003d\u0027r-0f22ol4k\u0027,resources\u003dNone,root_device_name\u003d\u0027/dev/vda\u0027,root_gb\u003d1,security_groups\u003dSecurityGroupList,services\u003d\u003c?\u003e,shutdown_terminate\u003dFalse,system_metadata\u003d{boot_roles\u003d\u0027member,reader\u0027,image_base_image_ref\u003d\u002788e40bdd-5857-4719-9125-fc2be6f2f6f0\u0027,image_container_format\u003d\u0027bare\u0027,image_disk_format\u003d\u0027qcow2\u0027,image_hw_cdrom_bus\u003d\u0027ide\u0027,image_hw_disk_bus\u003d\u0027virtio\u0027,image_hw_input_bus\u003dNone,image_hw_machine_type\u003d\u0027q35\u0027,image_hw_pointer_model\u003dNone,image_hw_rng_model\u003d\u0027virtio\u0027,image_hw_scsi_model\u003d\u0027virtio-scsi\u0027,image_hw_video_model\u003d\u0027virtio\u0027,image_hw_vif_model\u003d\u0027virtio\u0027,image_min_disk\u003d\u00271\u0027,image_min_ram\u003d\u00270\u0027,image_owner_specified.openstack.md5\u003d\u0027\u0027,image_owner_specified.openstack.object\u003d\u0027images/cirros-0.6.2-x86_64-disk\u0027,image_owner_specified.openstack.sha256\u003d\u0027\u0027,old_vm_state\u003d\u0027active\u0027,owner_project_name\u003d\u0027tempest-ServerActionsTestJSON-687093648\u0027,owner_user_name\u003d\u0027tempest-ServerActionsTestJSON-687093648-project-member\u0027},tags\u003d\u003c?\u003e,task_state\u003d\u0027resize_reverting\u0027,terminated_at\u003dNone,trusted_certs\u003d\u003c?\u003e,updated_at\u003d2024-06-26T07:35:22Z,user_data\u003d\u0027IyEvYmluL3NoCmVjaG8gIlByaW50aW5nIGNpcnJvcyB1c2VyIGF1dGhvcml6ZWQga2V5cyIKY2F0IH5jaXJyb3MvLnNzaC9hdXRob3JpemVkX2tleXMgfHwgdHJ1ZQo\u003d\u0027,user_id\u003d\u00271d1a100987c149f48720f1f87af86d0e\u0027,uuid\u003d116b4883-18d5-46bb-b688-fbe4c5ce6cb9,vcpu_model\u003d\u003c?\u003e,vcpus\u003d1,vm_mode\u003dNone,vm_state\u003d\u0027resized\u0027) vif\u003d{\"id\": \"734e0551-02a6-4f8c-a1ad-6b555fe153ff\", \"address\": \"fa:16:3e:0c:bd:31\", \"network\": {\"id\": \"3211e832-e45b-4223-8a50-e83e505331b9\", \"bridge\": \"br-int\", \"label\": \"tempest-ServerActionsTestJSON-1987090314-network\", \"subnets\": [{\"cidr\": \"10.1.0.0/28\", \"dns\": [], \"gateway\": {\"address\": \"10.1.0.1\", \"type\": \"gateway\", \"version\": 4, \"meta\": {}}, \"ips\": [{\"address\": \"10.1.0.5\", \"type\": \"fixed\", \"version\": 4, \"meta\": {}, \"floating_ips\": [{\"address\": \"172.24.5.197\", \"type\": \"floating\", \"version\": 4, \"meta\": {}}]}], \"routes\": [], \"version\": 4, \"meta\": {\"enable_dhcp\": true, \"dhcp_server\": \"10.1.0.2\"}}], \"meta\": {\"injected\": false, \"tenant_id\": \"9d2f85ffd0504de3b0eeeb483e139841\", \"mtu\": 1380, \"physical_network\": null, \"tunneled\": true}}, \"type\": \"ovs\", \"details\": {\"connectivity\": \"l2\", \"port_filter\": true, \"ovs_hybrid_plug\": false, \"datapath_type\": \"system\", \"bridge_name\": \"br-int\", \"bound_drivers\": {\"0\": \"openvswitch\"}}, \"devname\": \"tap734e0551-02\", \"ovs_interfaceid\": \"734e0551-02a6-4f8c-a1ad-6b555fe153ff\", \"qbh_params\": null, \"qbg_params\": null, \"active\": true, \"vnic_type\": \"normal\", \"profile\": {}, \"preserve_on_delete\": false, \"delegate_create\": true, \"meta\": {}} {{(pid\u003d90653) unplug /opt/stack/nova/nova/virt/libvirt/vif.py:837}}\nJun 26 07:35:27.185425 np0037812213 nova-compute[90653]: DEBUG nova.network.os_vif_util [None req-962aa11b-e1f8-4274-90ac-7d357629df02 tempest-ServerActionsTestJSON-687093648 tempest-ServerActionsTestJSON-687093648-project-member] Converting VIF {\"id\": \"734e0551-02a6-4f8c-a1ad-6b555fe153ff\", \"address\": \"fa:16:3e:0c:bd:31\", \"network\": {\"id\": \"3211e832-e45b-4223-8a50-e83e505331b9\", \"bridge\": \"br-int\", \"label\": \"tempest-ServerActionsTestJSON-1987090314-network\", \"subnets\": [{\"cidr\": \"10.1.0.0/28\", \"dns\": [], \"gateway\": {\"address\": \"10.1.0.1\", \"type\": \"gateway\", \"version\": 4, \"meta\": {}}, \"ips\": [{\"address\": \"10.1.0.5\", \"type\": \"fixed\", \"version\": 4, \"meta\": {}, \"floating_ips\": [{\"address\": \"172.24.5.197\", \"type\": \"floating\", \"version\": 4, \"meta\": {}}]}], \"routes\": [], \"version\": 4, \"meta\": {\"enable_dhcp\": true, \"dhcp_server\": \"10.1.0.2\"}}], \"meta\": {\"injected\": false, \"tenant_id\": \"9d2f85ffd0504de3b0eeeb483e139841\", \"mtu\": 1380, \"physical_network\": null, \"tunneled\": true}}, \"type\": \"ovs\", \"details\": {\"connectivity\": \"l2\", \"port_filter\": true, \"ovs_hybrid_plug\": false, \"datapath_type\": \"system\", \"bridge_name\": \"br-int\", \"bound_drivers\": {\"0\": \"openvswitch\"}}, \"devname\": \"tap734e0551-02\", \"ovs_interfaceid\": \"734e0551-02a6-4f8c-a1ad-6b555fe153ff\", \"qbh_params\": null, \"qbg_params\": null, \"active\": true, \"vnic_type\": \"normal\", \"profile\": {}, \"preserve_on_delete\": false, \"delegate_create\": true, \"meta\": {}} {{(pid\u003d90653) nova_to_osvif_vif /opt/stack/nova/nova/network/os_vif_util.py:511}}","commit_id":"21912add81ecb78c1340e68f31b66a48383e518a"}],"nova/compute/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3e865dc87bd783d2b4c1f341d2dcd1483cf50f6e","unresolved":true,"context_lines":[{"line_number":3457,"context_line":"                # to generate new encryption secrets for the local disks we are"},{"line_number":3458,"context_line":"                # about to create, and we only create new secrets when"},{"line_number":3459,"context_line":"                # encryption_secret_uuid \u003d None."},{"line_number":3460,"context_line":"                if bdm.is_local:"},{"line_number":3461,"context_line":"                    if \u0027encryption_secret_uuid\u0027 in bdm:"},{"line_number":3462,"context_line":"                        bdm.encryption_secret_uuid \u003d None"},{"line_number":3463,"context_line":"                mapping.append(bdm.get_image_mapping())"}],"source_content_type":"text/x-python","patch_set":24,"id":"5750436d_acb0acfe","line":3460,"updated":"2024-01-31 10:51:09.000000000","message":"isnt this implied as its the else of an is_volume check.\nimages_type\u003drbd would be local in this context too right.\n\ncan we remove the is_local check and just check for the encryption secret uuid","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ecd5f63e1336c99008a0e2a2e5847a1380845df7","unresolved":true,"context_lines":[{"line_number":3457,"context_line":"                # to generate new encryption secrets for the local disks we are"},{"line_number":3458,"context_line":"                # about to create, and we only create new secrets when"},{"line_number":3459,"context_line":"                # encryption_secret_uuid \u003d None."},{"line_number":3460,"context_line":"                if bdm.is_local:"},{"line_number":3461,"context_line":"                    if \u0027encryption_secret_uuid\u0027 in bdm:"},{"line_number":3462,"context_line":"                        bdm.encryption_secret_uuid \u003d None"},{"line_number":3463,"context_line":"                mapping.append(bdm.get_image_mapping())"}],"source_content_type":"text/x-python","patch_set":24,"id":"d184ddeb_a7179e46","line":3460,"in_reply_to":"5750436d_acb0acfe","updated":"2024-01-31 22:00:48.000000000","message":"Hm yeah, I think you\u0027re right. I\u0027ll remove it.","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dbf5838ad1c117131649de74769439e52ae2b83","unresolved":false,"context_lines":[{"line_number":3457,"context_line":"                # to generate new encryption secrets for the local disks we are"},{"line_number":3458,"context_line":"                # about to create, and we only create new secrets when"},{"line_number":3459,"context_line":"                # encryption_secret_uuid \u003d None."},{"line_number":3460,"context_line":"                if bdm.is_local:"},{"line_number":3461,"context_line":"                    if \u0027encryption_secret_uuid\u0027 in bdm:"},{"line_number":3462,"context_line":"                        bdm.encryption_secret_uuid \u003d None"},{"line_number":3463,"context_line":"                mapping.append(bdm.get_image_mapping())"}],"source_content_type":"text/x-python","patch_set":24,"id":"d431eb80_a64c288b","line":3460,"in_reply_to":"d184ddeb_a7179e46","updated":"2024-02-13 08:11:45.000000000","message":"Done","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"}],"nova/tests/fixtures/libvirt_imagebackend.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3e865dc87bd783d2b4c1f341d2dcd1483cf50f6e","unresolved":true,"context_lines":[{"line_number":189,"context_line":"                disk.exists.return_value \u003d True"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"            # Default to no ephemeral encryption"},{"line_number":192,"context_line":"            disk.get_encryption.side_effect \u003d lambda ctxt: None"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"            return disk"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"f46e335a_84339c40","line":192,"updated":"2024-01-31 10:51:09.000000000","message":"im pretty sure this is the same as return_value\u003dNone\nwhich i think is also the default so is this actully needed?\n\na function with no call to return returns None in python\nso i dont see how this lambda is differnt.","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dbf5838ad1c117131649de74769439e52ae2b83","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                disk.exists.return_value \u003d True"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"            # Default to no ephemeral encryption"},{"line_number":192,"context_line":"            disk.get_encryption.side_effect \u003d lambda ctxt: None"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"            return disk"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"e149db17_d865704b","line":192,"in_reply_to":"5d3cf960_9ccafb1b","updated":"2024-02-13 08:11:45.000000000","message":"Done","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ecd5f63e1336c99008a0e2a2e5847a1380845df7","unresolved":true,"context_lines":[{"line_number":189,"context_line":"                disk.exists.return_value \u003d True"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"            # Default to no ephemeral encryption"},{"line_number":192,"context_line":"            disk.get_encryption.side_effect \u003d lambda ctxt: None"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"            return disk"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"5d3cf960_9ccafb1b","line":192,"in_reply_to":"f46e335a_84339c40","updated":"2024-01-31 22:00:48.000000000","message":"OK, I\u0027ll try that.","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2dbf5838ad1c117131649de74769439e52ae2b83","unresolved":false,"context_lines":[{"line_number":9496,"context_line":"            expected_dest_encryption[\u0027secret\u0027] \u003d mock.sentinel.src_secret"},{"line_number":9497,"context_line":"            expected_props[\u0027hw_ephemeral_encryption_secret_uuid\u0027] \u003d ("},{"line_number":9498,"context_line":"                uuids.src_secret)"},{"line_number":9499,"context_line":"            mock_create_secret.assert_not_called()"},{"line_number":9500,"context_line":""},{"line_number":9501,"context_line":"        self.assertEqual("},{"line_number":9502,"context_line":"            (expected_dest_encryption, expected_props),"}],"source_content_type":"text/x-python","patch_set":28,"id":"2b108c73_56b87c73","line":9499,"updated":"2024-02-13 08:11:45.000000000","message":"ack so for a normal snapshot we create a new secrete to decouple the image form the current instance but for shelve we keep the same secret because logically is the same disk. yep that sounds like the execpted behavior","commit_id":"8d8da99f95b03a12628e307ee71456fbb1ba7ea3"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"3e865dc87bd783d2b4c1f341d2dcd1483cf50f6e","unresolved":true,"context_lines":[{"line_number":3144,"context_line":"            # NOTE(melwitt): Live snapshot doesn\u0027t work with ephemeral"},{"line_number":3145,"context_line":"            # encryption because there is no way to provide the secret to"},{"line_number":3146,"context_line":"            # libvirt blockRebase(), which is used by _live_snapshot."},{"line_number":3147,"context_line":"            not encryption"},{"line_number":3148,"context_line":"        ):"},{"line_number":3149,"context_line":"            live_snapshot \u003d True"},{"line_number":3150,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":24,"id":"d51d22c4_f666dd3e","line":3147,"updated":"2024-01-31 10:51:09.000000000","message":"We should add a note to the api ref for this or otherwise have a doc for this.\n\nwith that said the snapshot api is not guarnetted to be live anyway so its not a behavioral change in that regard.\n\nperhaps mentioning this in the release not for this feature is enough.\n\nby the way i would suggest creating the release note ellier in the series and modifyging it as we go and add features like snapshot.\n\nalso i think the blockrebase is not relevnet for images_type\u003drbd \n\nim not sure about lvm.\n\ni would expect use to be able to live snapshots for rbd?","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ecd5f63e1336c99008a0e2a2e5847a1380845df7","unresolved":true,"context_lines":[{"line_number":3144,"context_line":"            # NOTE(melwitt): Live snapshot doesn\u0027t work with ephemeral"},{"line_number":3145,"context_line":"            # encryption because there is no way to provide the secret to"},{"line_number":3146,"context_line":"            # libvirt blockRebase(), which is used by _live_snapshot."},{"line_number":3147,"context_line":"            not encryption"},{"line_number":3148,"context_line":"        ):"},{"line_number":3149,"context_line":"            live_snapshot \u003d True"},{"line_number":3150,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":24,"id":"fd23dd35_d71309b9","line":3147,"in_reply_to":"d51d22c4_f666dd3e","updated":"2024-01-31 22:00:48.000000000","message":"While I agree about documenting this behavior, I thought it might be weird to publish a release note before the image backend starts reporting support? To me the release note is for the user\u0027s perspective and from the user perspective at this stage, nothing has been released yet, users can\u0027t use it yet. I thought it might be confusing?\n\nDirect snapshots for rbd are also not doable, for a completely different reason 😕:\n\nhttps://review.opendev.org/c/openstack/nova/+/889912/23/nova/virt/libvirt/driver.py#3178","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"910c05293c89dd12096d54d6f8714c1b81a91e8d","unresolved":false,"context_lines":[{"line_number":3144,"context_line":"            # NOTE(melwitt): Live snapshot doesn\u0027t work with ephemeral"},{"line_number":3145,"context_line":"            # encryption because there is no way to provide the secret to"},{"line_number":3146,"context_line":"            # libvirt blockRebase(), which is used by _live_snapshot."},{"line_number":3147,"context_line":"            not encryption"},{"line_number":3148,"context_line":"        ):"},{"line_number":3149,"context_line":"            live_snapshot \u003d True"},{"line_number":3150,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":24,"id":"10744be0_391dad9d","line":3147,"in_reply_to":"fd23dd35_d71309b9","updated":"2024-02-01 09:08:25.000000000","message":"oh right i remember you saying that before.\n\nso the release note can only be added when it start being usable i agree\nthis just comes down to the api gating vs only enable at the end approch\n\neither is fine so ill just mark this resolved.","commit_id":"f2a22942703f0f197bb3e2f986adddd0650f3948"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"21dcc794453cdf301ce83e6511f20183e6541565","unresolved":true,"context_lines":[{"line_number":3554,"context_line":"                disk_xml \u003d self._get_xml_for_live_snapshot_with_encryption("},{"line_number":3555,"context_line":"                    guest, disk_path, disk_delta, source_format, secret_uuid,"},{"line_number":3556,"context_line":"                    encryption)"},{"line_number":3557,"context_line":"                dev.copy(disk_xml, reuse_ext\u003dTrue, shallow\u003dTrue)"},{"line_number":3558,"context_line":""},{"line_number":3559,"context_line":"            while not dev.is_job_complete():"},{"line_number":3560,"context_line":"                time.sleep(0.5)"}],"source_content_type":"text/x-python","patch_set":33,"id":"b38822eb_91e4d809","line":3557,"updated":"2024-02-22 09:56:12.000000000","message":"ok nice imporvement over the last version which i beivle required us to stop the vm for snapshot","commit_id":"5a05eaf014e57a09330b7e3a350d17677b3c46a1"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"8909eac2eed772e9676b7592279f6f53840e8364","unresolved":false,"context_lines":[{"line_number":721,"context_line":"            if image_encryption_secret_uuid:"},{"line_number":722,"context_line":"                secret \u003d self.key_manager.get("},{"line_number":723,"context_line":"                    context, image_encryption_secret_uuid).get_encoded()"},{"line_number":724,"context_line":"                image_encryption \u003d {\u0027secret\u0027: secret}"},{"line_number":725,"context_line":""},{"line_number":726,"context_line":"            prepare_template("},{"line_number":727,"context_line":"                target\u003dbase, encryption\u003dimage_encryption, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5911e25c_a018a07c","line":724,"updated":"2023-02-07 15:30:19.000000000","message":"I \"think\" I can clean up this mess ... fingers crossed.","commit_id":"0922a9cce4b15c5a602823438211028f14515843"}]}