)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"72285fd328763fa08d8f9d5b12ee0fe1623f5e2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"b4c41245_64814330","updated":"2024-01-31 11:10:29.000000000","message":"-1 for lack of functional test coverage","commit_id":"30a2dffa98bcca8930e6dcf34ac9ce487c9ff9c8"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9414867844abd8ca2a51bda79a072deabade9c09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"1633dbac_11921ba7","updated":"2024-02-06 23:28:56.000000000","message":"recheck https://review.opendev.org/c/openstack/nova/+/908182 has merged","commit_id":"d411e4bebae2b801b244bf9205995706082f4525"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"76c3d4a1_9064dcda","updated":"2024-02-13 07:44:26.000000000","message":"+1 in general i dont see anything that would block this form merging\n\ni do think at this point its worth factoring out the common code in the fucntional tests and it would be nice to break them up more.\n\nthere is a lot of repeated code.\n\nsome notes in line +1 since there are pathes below this that i have a -1 on so im\nexpecting a respine anyway","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"c38848a03bb85f1c0ff7629d4f5e120d4969f665","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"3db642e2_32442ea3","updated":"2024-02-14 14:37:53.000000000","message":"Looks good to me.","commit_id":"99bf0c4f4ebb99a6ac637b396c2d647ad76e8128"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9341880db8330457b71ff1a6cf6d3de165932983","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"95efe611_20afc258","updated":"2024-02-23 22:07:38.000000000","message":"recheck [   11.771055] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode\u003d0x00001000 ]---","commit_id":"a0095ed839aeed3107c60a95aaabc9c159bdf31a"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"d3ff3cb8123ba424156302df3d40b593ceee07d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"6b7258a0_0f50132c","updated":"2024-02-23 12:25:53.000000000","message":"recheck nova-next","commit_id":"a0095ed839aeed3107c60a95aaabc9c159bdf31a"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"9bfbe23fead843550dd8b7ac855019bb39f16360","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"6ec28d8c_fc66ca5b","updated":"2024-02-23 19:58:28.000000000","message":"recheck tempest-integrated-compute-rbac-old-defaults TIMED_OUT","commit_id":"a0095ed839aeed3107c60a95aaabc9c159bdf31a"}],"nova/compute/api.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":4230,"context_line":"        # This will validate hw:ephemeral_encryption and"},{"line_number":4231,"context_line":"        # hw_ephemeral_encryption."},{"line_number":4232,"context_line":"        encryption_requested \u003d hardware.get_ephemeral_encryption_constraint("},{"line_number":4233,"context_line":"            flavor, image_meta)"},{"line_number":4234,"context_line":"        # This will validate hw:ephemeral_encryption_format and"},{"line_number":4235,"context_line":"        # hw_ephemeral_encryption_format."},{"line_number":4236,"context_line":"        flavor_format \u003d flavor.get(\u0027extra_specs\u0027, {}).get("}],"source_content_type":"text/x-python","patch_set":30,"id":"df62a21c_38b9d79c","line":4233,"updated":"2024-02-13 07:44:26.000000000","message":"this will check if the image/flavor conflcit so you don tneed to do that below","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"f90064d9c7f37a9fbc4cf851c16f6998aa524938","unresolved":false,"context_lines":[{"line_number":4230,"context_line":"        # This will validate hw:ephemeral_encryption and"},{"line_number":4231,"context_line":"        # hw_ephemeral_encryption."},{"line_number":4232,"context_line":"        encryption_requested \u003d hardware.get_ephemeral_encryption_constraint("},{"line_number":4233,"context_line":"            flavor, image_meta)"},{"line_number":4234,"context_line":"        # This will validate hw:ephemeral_encryption_format and"},{"line_number":4235,"context_line":"        # hw_ephemeral_encryption_format."},{"line_number":4236,"context_line":"        flavor_format \u003d flavor.get(\u0027extra_specs\u0027, {}).get("}],"source_content_type":"text/x-python","patch_set":30,"id":"a6d64af9_919176e7","line":4233,"in_reply_to":"df62a21c_38b9d79c","updated":"2024-02-14 08:06:14.000000000","message":"Done","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"}],"nova/tests/functional/libvirt/test_ephemeral_encryption.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"class EphemeralEncryptionTestRebuild(EphemeralEncryptionTestBase):"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":"    def test_rebuild_server_encryption_from_flavor(self):"},{"line_number":514,"context_line":"        compute \u003d self.start_compute()"},{"line_number":515,"context_line":"        driver \u003d self.computes[compute].driver"},{"line_number":516,"context_line":"        self._run_periodics()"}],"source_content_type":"text/x-python","patch_set":30,"id":"ee030a38_ea703fa4","line":513,"updated":"2024-02-13 07:44:26.000000000","message":"just a meta comment\n\nthese tests are often testing multiple things and are quite long\n\ni would general prefer if you have one test per test case.","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":539,"context_line":"        # Rebuild the server without changing the image."},{"line_number":540,"context_line":"        image_id \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"},{"line_number":541,"context_line":"        self._rebuild_server(server, image_id)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        # The image should not have changed."},{"line_number":544,"context_line":"        image_id_after_rebuild \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"},{"line_number":545,"context_line":"        self.assertEqual(image_id, image_id_after_rebuild)"}],"source_content_type":"text/x-python","patch_set":30,"id":"f296b38f_0cf4c964","line":542,"updated":"2024-02-13 07:44:26.000000000","message":"so this would be the first test case.","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"589bdd6150229c81de9d15e4cec2d69e91fea4f0","unresolved":false,"context_lines":[{"line_number":539,"context_line":"        # Rebuild the server without changing the image."},{"line_number":540,"context_line":"        image_id \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"},{"line_number":541,"context_line":"        self._rebuild_server(server, image_id)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"        # The image should not have changed."},{"line_number":544,"context_line":"        image_id_after_rebuild \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"},{"line_number":545,"context_line":"        self.assertEqual(image_id, image_id_after_rebuild)"}],"source_content_type":"text/x-python","patch_set":30,"id":"e237cc1e_cb3f68bf","line":542,"in_reply_to":"f296b38f_0cf4c964","updated":"2024-02-14 10:15:40.000000000","message":"Done","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"        # Rebuild the server with a new image requesting encryption."},{"line_number":554,"context_line":"        image \u003d self._create_image({\u0027hw_ephemeral_encryption\u0027: \u0027true\u0027})"},{"line_number":555,"context_line":"        self._rebuild_server(server, image[\u0027id\u0027])"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        # The image should have changed."},{"line_number":558,"context_line":"        image_id_after_rebuild \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"7edee969_10ca7cf9","line":555,"updated":"2024-02-13 07:44:26.000000000","message":"this is the second","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"589bdd6150229c81de9d15e4cec2d69e91fea4f0","unresolved":false,"context_lines":[{"line_number":552,"context_line":""},{"line_number":553,"context_line":"        # Rebuild the server with a new image requesting encryption."},{"line_number":554,"context_line":"        image \u003d self._create_image({\u0027hw_ephemeral_encryption\u0027: \u0027true\u0027})"},{"line_number":555,"context_line":"        self._rebuild_server(server, image[\u0027id\u0027])"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        # The image should have changed."},{"line_number":558,"context_line":"        image_id_after_rebuild \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"425e27e5_27746734","line":555,"in_reply_to":"7edee969_10ca7cf9","updated":"2024-02-14 10:15:40.000000000","message":"Done","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        # Rebuild the server with a new image not requesting encryption."},{"line_number":568,"context_line":"        image \u003d self._create_image({})"},{"line_number":569,"context_line":"        self._rebuild_server(server, image[\u0027id\u0027])"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        # The image should have changed."},{"line_number":572,"context_line":"        image_id_after_rebuild \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"16a45fee_ba7a92e3","line":569,"updated":"2024-02-13 07:44:26.000000000","message":"this is a third test case","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"589bdd6150229c81de9d15e4cec2d69e91fea4f0","unresolved":false,"context_lines":[{"line_number":566,"context_line":""},{"line_number":567,"context_line":"        # Rebuild the server with a new image not requesting encryption."},{"line_number":568,"context_line":"        image \u003d self._create_image({})"},{"line_number":569,"context_line":"        self._rebuild_server(server, image[\u0027id\u0027])"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        # The image should have changed."},{"line_number":572,"context_line":"        image_id_after_rebuild \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"28afca20_37c6817a","line":569,"in_reply_to":"16a45fee_ba7a92e3","updated":"2024-02-14 10:15:40.000000000","message":"Done","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        # Rebuild the server with a new image not requesting encryption."},{"line_number":650,"context_line":"        image \u003d self._create_image({})"},{"line_number":651,"context_line":"        self._rebuild_server(server, image[\u0027id\u0027])"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        # The image should have changed."},{"line_number":654,"context_line":"        image_id_after_rebuild \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"dd9a0848_7a97ea82","line":651,"updated":"2024-02-13 07:44:26.000000000","message":"ack, so in this case because we have not requested encypting in the flavor this is allowed oterwise it would be blocked.\n\nim calling this out because this is the third testcase in the functionand the server create is scroold off the screen so you dont have context regarding how the server was created anymore.","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"589bdd6150229c81de9d15e4cec2d69e91fea4f0","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        # Rebuild the server with a new image not requesting encryption."},{"line_number":650,"context_line":"        image \u003d self._create_image({})"},{"line_number":651,"context_line":"        self._rebuild_server(server, image[\u0027id\u0027])"},{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        # The image should have changed."},{"line_number":654,"context_line":"        image_id_after_rebuild \u003d self._show_server(server)[\u0027image\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":30,"id":"bbbde2f4_4516056f","line":651,"in_reply_to":"dd9a0848_7a97ea82","updated":"2024-02-14 10:15:40.000000000","message":"Acknowledged","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"}],"nova/tests/functional/test_ephemeral_encryption.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":540,"context_line":"    }"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    @ddt.data("},{"line_number":543,"context_line":"        (uuidsentinel.eph_encryption_flavor,"},{"line_number":544,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":545,"context_line":"        (uuidsentinel.eph_encryption_luks_flavor,"},{"line_number":546,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":547,"context_line":"        (uuidsentinel.eph_encryption_plain_flavor,"},{"line_number":548,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":549,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":550,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027}),"},{"line_number":551,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"}],"source_content_type":"text/x-python","patch_set":30,"id":"90b41729_1b22b424","line":548,"range":{"start_line":543,"start_character":3,"end_line":548,"end_character":47},"updated":"2024-02-13 07:44:26.000000000","message":"ack so here we have explictly requested encyption in the falvor while disabling it in the image","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"589bdd6150229c81de9d15e4cec2d69e91fea4f0","unresolved":false,"context_lines":[{"line_number":540,"context_line":"    }"},{"line_number":541,"context_line":""},{"line_number":542,"context_line":"    @ddt.data("},{"line_number":543,"context_line":"        (uuidsentinel.eph_encryption_flavor,"},{"line_number":544,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":545,"context_line":"        (uuidsentinel.eph_encryption_luks_flavor,"},{"line_number":546,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":547,"context_line":"        (uuidsentinel.eph_encryption_plain_flavor,"},{"line_number":548,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":549,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":550,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027}),"},{"line_number":551,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"}],"source_content_type":"text/x-python","patch_set":30,"id":"51b2b180_fe843af4","line":548,"range":{"start_line":543,"start_character":3,"end_line":548,"end_character":47},"in_reply_to":"90b41729_1b22b424","updated":"2024-02-14 10:15:40.000000000","message":"Acknowledged","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":546,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":547,"context_line":"        (uuidsentinel.eph_encryption_plain_flavor,"},{"line_number":548,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":549,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":550,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027}),"},{"line_number":551,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":552,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":553,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027luks\u0027}),"},{"line_number":554,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":555,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":556,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027plain\u0027}),"},{"line_number":557,"context_line":"        (uuidsentinel.eph_encryption_luks_flavor,"},{"line_number":558,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":559,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027plain\u0027}),"}],"source_content_type":"text/x-python","patch_set":30,"id":"85f9a86d_f0f912fb","line":556,"range":{"start_line":549,"start_character":8,"end_line":556,"end_character":54},"updated":"2024-02-13 07:44:26.000000000","message":"and this is the reverse enabled in the image and disables in the flavor","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"589bdd6150229c81de9d15e4cec2d69e91fea4f0","unresolved":false,"context_lines":[{"line_number":546,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":547,"context_line":"        (uuidsentinel.eph_encryption_plain_flavor,"},{"line_number":548,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027False\u0027}),"},{"line_number":549,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":550,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027}),"},{"line_number":551,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":552,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":553,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027luks\u0027}),"},{"line_number":554,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":555,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":556,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027plain\u0027}),"},{"line_number":557,"context_line":"        (uuidsentinel.eph_encryption_luks_flavor,"},{"line_number":558,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":559,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027plain\u0027}),"}],"source_content_type":"text/x-python","patch_set":30,"id":"0a208af6_3adda095","line":556,"range":{"start_line":549,"start_character":8,"end_line":556,"end_character":54},"in_reply_to":"85f9a86d_f0f912fb","updated":"2024-02-14 10:15:40.000000000","message":"Acknowledged","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":554,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":555,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":556,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027plain\u0027}),"},{"line_number":557,"context_line":"        (uuidsentinel.eph_encryption_luks_flavor,"},{"line_number":558,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":559,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027plain\u0027}),"},{"line_number":560,"context_line":"        (uuidsentinel.eph_encryption_plain_flavor,"},{"line_number":561,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":562,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027luks\u0027}))"},{"line_number":563,"context_line":"    @ddt.unpack"},{"line_number":564,"context_line":"    def test_flavor_image_mismatch(self, flavor_id, image_meta):"},{"line_number":565,"context_line":"        # Test a scenario where a rebuild with a new image is requested and the"}],"source_content_type":"text/x-python","patch_set":30,"id":"e598f3a0_e5dda89b","line":562,"range":{"start_line":557,"start_character":0,"end_line":562,"end_character":53},"updated":"2024-02-13 07:44:26.000000000","message":"finally we test the format confilcit case","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"589bdd6150229c81de9d15e4cec2d69e91fea4f0","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        (uuidsentinel.eph_encryption_disabled_flavor,"},{"line_number":555,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":556,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027plain\u0027}),"},{"line_number":557,"context_line":"        (uuidsentinel.eph_encryption_luks_flavor,"},{"line_number":558,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":559,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027plain\u0027}),"},{"line_number":560,"context_line":"        (uuidsentinel.eph_encryption_plain_flavor,"},{"line_number":561,"context_line":"         {\u0027hw_ephemeral_encryption\u0027: \u0027True\u0027,"},{"line_number":562,"context_line":"          \u0027hw_ephemeral_encryption_format\u0027: \u0027luks\u0027}))"},{"line_number":563,"context_line":"    @ddt.unpack"},{"line_number":564,"context_line":"    def test_flavor_image_mismatch(self, flavor_id, image_meta):"},{"line_number":565,"context_line":"        # Test a scenario where a rebuild with a new image is requested and the"}],"source_content_type":"text/x-python","patch_set":30,"id":"2201d2e7_9725e239","line":562,"range":{"start_line":557,"start_character":0,"end_line":562,"end_character":53},"in_reply_to":"e598f3a0_e5dda89b","updated":"2024-02-14 10:15:40.000000000","message":"Acknowledged","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":569,"context_line":"        ex \u003d self.assertRaises("},{"line_number":570,"context_line":"            api_client.OpenStackApiException, self._rebuild_server, server,"},{"line_number":571,"context_line":"            image[\u0027id\u0027])"},{"line_number":572,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    @ddt.data("},{"line_number":575,"context_line":"        (uuidsentinel.eph_encryption_flavor,"}],"source_content_type":"text/x-python","patch_set":30,"id":"60271f16_0549c1e9","line":572,"updated":"2024-02-13 07:44:26.000000000","message":"+1 i belive this covers all the conficts properly","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"589bdd6150229c81de9d15e4cec2d69e91fea4f0","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        ex \u003d self.assertRaises("},{"line_number":570,"context_line":"            api_client.OpenStackApiException, self._rebuild_server, server,"},{"line_number":571,"context_line":"            image[\u0027id\u0027])"},{"line_number":572,"context_line":"        self.assertEqual(400, ex.response.status_code)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"    @ddt.data("},{"line_number":575,"context_line":"        (uuidsentinel.eph_encryption_flavor,"}],"source_content_type":"text/x-python","patch_set":30,"id":"332827c9_9892c1c3","line":572,"in_reply_to":"60271f16_0549c1e9","updated":"2024-02-14 10:15:40.000000000","message":"Acknowledged","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"2bb72b72ad8d25eeca1843e5491f29f501862b9c","unresolved":true,"context_lines":[{"line_number":608,"context_line":"        server \u003d self._create_server(flavor_id\u003dflavor_id, networks\u003d[])"},{"line_number":609,"context_line":"        image \u003d self._create_image(image_meta)"},{"line_number":610,"context_line":"        # Rebuild should not be rejected."},{"line_number":611,"context_line":"        self._rebuild_server(server, image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":30,"id":"73998658_e9b5db77","line":611,"updated":"2024-02-13 07:44:26.000000000","message":"so this is not really rebuild specifics\n\neverythign you are testing here should be enforced by \nhardware.get_ephemeral_encryption_constraint\n\nso it should apply to spawn, resize and rebuild equally.","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"589bdd6150229c81de9d15e4cec2d69e91fea4f0","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        server \u003d self._create_server(flavor_id\u003dflavor_id, networks\u003d[])"},{"line_number":609,"context_line":"        image \u003d self._create_image(image_meta)"},{"line_number":610,"context_line":"        # Rebuild should not be rejected."},{"line_number":611,"context_line":"        self._rebuild_server(server, image[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":30,"id":"0f80846a_8ba9402f","line":611,"in_reply_to":"73998658_e9b5db77","updated":"2024-02-14 10:15:40.000000000","message":"Acknowledged","commit_id":"632d7f42e09f42e01161878ac05c731144f05fb4"}],"nova/tests/unit/compute/test_shelve.py":[{"author":{"_account_id":16207,"name":"ribaudr","display_name":"uggla","email":"rene.ribaud@gmail.com","username":"uggla","status":"Red Hat"},"change_message_id":"c38848a03bb85f1c0ff7629d4f5e120d4969f665","unresolved":true,"context_lines":[{"line_number":301,"context_line":"                      mock_get_power_state, mock_spawn,"},{"line_number":302,"context_line":"                      mock_prep_block_device, mock_notify_instance_usage,"},{"line_number":303,"context_line":"                      mock_notify_instance_action,"},{"line_number":304,"context_line":"                      mock_get_bdms, accel_uuids\u003dNone, instance\u003dNone):"},{"line_number":305,"context_line":"        mock_bdms \u003d mock.Mock()"},{"line_number":306,"context_line":"        mock_get_bdms.return_value \u003d mock_bdms"},{"line_number":307,"context_line":"        instance \u003d instance or self._create_fake_instance_obj()"}],"source_content_type":"text/x-python","patch_set":31,"id":"87f93195_2fbce6be","line":304,"range":{"start_line":304,"start_character":22,"end_line":304,"end_character":68},"updated":"2024-02-14 14:37:53.000000000","message":"Nit: change not needed.","commit_id":"99bf0c4f4ebb99a6ac637b396c2d647ad76e8128"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"a968eb18725d2b5266ccda545f58dd73a1a2e15a","unresolved":true,"context_lines":[{"line_number":301,"context_line":"                      mock_get_power_state, mock_spawn,"},{"line_number":302,"context_line":"                      mock_prep_block_device, mock_notify_instance_usage,"},{"line_number":303,"context_line":"                      mock_notify_instance_action,"},{"line_number":304,"context_line":"                      mock_get_bdms, accel_uuids\u003dNone, instance\u003dNone):"},{"line_number":305,"context_line":"        mock_bdms \u003d mock.Mock()"},{"line_number":306,"context_line":"        mock_get_bdms.return_value \u003d mock_bdms"},{"line_number":307,"context_line":"        instance \u003d instance or self._create_fake_instance_obj()"}],"source_content_type":"text/x-python","patch_set":31,"id":"89d300a5_07adbddd","line":304,"range":{"start_line":304,"start_character":22,"end_line":304,"end_character":68},"in_reply_to":"87f93195_2fbce6be","updated":"2024-02-14 17:37:27.000000000","message":"Oops, didn\u0027t mean to do this. Will fix in the next respin.","commit_id":"99bf0c4f4ebb99a6ac637b396c2d647ad76e8128"}]}