)]}'
{"nova/objects/instance_group.py":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"f751795d6144ee2e0933553c5ab80a2d691e8497","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        raise exception.InstanceGroupNotFound(group_uuid\u003dname)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @base.remotable_classmethod"},{"line_number":85,"context_line":"    def get_by_hint(cls, context, hint):"},{"line_number":86,"context_line":"        if uuidutils.is_uuid_like(hint):"},{"line_number":87,"context_line":"            return cls.get_by_uuid(context, hint)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FTU8%3D","line":84,"updated":"2014-04-15 13:41:12.000000000","message":"I think this can just be a local helper.  The other methods called in here are remotable already.  If it\u0027s just local, I don\u0027t think a version bump is required.","commit_id":"d505acc9619ef3a74b33f777292177da8e879196"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"adb310228231a0d1733482764786c182fee96e97","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        raise exception.InstanceGroupNotFound(group_uuid\u003dname)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @base.remotable_classmethod"},{"line_number":85,"context_line":"    def get_by_hint(cls, context, hint):"},{"line_number":86,"context_line":"        if uuidutils.is_uuid_like(hint):"},{"line_number":87,"context_line":"            return cls.get_by_uuid(context, hint)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FRyQ%3D","line":84,"in_reply_to":"AAAAW3%2F%2FTU8%3D","updated":"2014-04-16 04:54:02.000000000","message":"good point","commit_id":"d505acc9619ef3a74b33f777292177da8e879196"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ea6744466069bdc7ae1e19ed2fc282d44d9af5b5","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if uuidutils.is_uuid_like(hint):"},{"line_number":86,"context_line":"            return cls.get_by_uuid(context, hint)"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            return cls.get_by_name(context, hint)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @base.remotable"},{"line_number":91,"context_line":"    def save(self, context):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAW3%2F%2FQdc%3D","line":88,"updated":"2014-04-15 18:21:03.000000000","message":"FWIW, I really hate this. But, since it\u0027s not remotable, it\u0027s not encoded into the RPC API forever, so I\u0027ll let it slide this time :)","commit_id":"bff8604fd27fee588facbd429aaedcf227cd5871"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f2bdc26df9a21d5d240fb0f27305d983d4195490","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if uuidutils.is_uuid_like(hint):"},{"line_number":86,"context_line":"            return cls.get_by_uuid(context, hint)"},{"line_number":87,"context_line":"        else:"},{"line_number":88,"context_line":"            return cls.get_by_name(context, hint)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    @base.remotable"},{"line_number":91,"context_line":"    def save(self, context):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F%2FhU%3D","line":88,"in_reply_to":"AAAAW3%2F%2FQdc%3D","updated":"2014-04-16 01:32:47.000000000","message":"Dan, what do you hate about it? The pattern of using classmethods, or the uuid-like checking behavior? Or something else?","commit_id":"bff8604fd27fee588facbd429aaedcf227cd5871"}],"nova/tests/objects/test_instance_group.py":[{"author":{"_account_id":8430,"name":"Christopher Lefelhocz","email":"christopher.lefelhoc@rackspace.com","username":"leif"},"change_message_id":"93c66e3e7b681b0e6be758aa32ed0875ec6de5f1","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def _populate_instances(self):"},{"line_number":182,"context_line":"        instances \u003d [(str(uuid.uuid4()), \u0027f1\u0027, \u0027p1\u0027),"},{"line_number":183,"context_line":"                     (str(uuid.uuid4()), \u0027f2\u0027, \u0027p1\u0027),"},{"line_number":184,"context_line":"                     (str(uuid.uuid4()), \u0027f3\u0027, \u0027p2\u0027),"},{"line_number":185,"context_line":"                     (str(uuid.uuid4()), \u0027f4\u0027, \u0027p2\u0027)]"},{"line_number":186,"context_line":"        for instance in instances:"},{"line_number":187,"context_line":"            values \u003d self._get_default_values()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAW3%2F%2FamE%3D","line":184,"updated":"2014-04-14 18:18:53.000000000","message":"Wouldn\u0027t it be worthwhile to test same name different groups returns right uuid?","commit_id":"d505acc9619ef3a74b33f777292177da8e879196"}]}
