)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8f39330753e76aae5faad37743ca12f34c06e731","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc8630e8_5c1b2f1e","updated":"2023-02-01 14:38:14.000000000","message":"Since this is not critical, let\u0027s use it to run another check of the experimental stuff for ironic coverage.","commit_id":"e394da46e178b1bddca10c8698cd81da23b27bac"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"faebf14ccf87086664567d38c2b784e3c9e34db6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"87bde833_16e2f119","updated":"2023-02-01 10:54:36.000000000","message":"Thanks!","commit_id":"e394da46e178b1bddca10c8698cd81da23b27bac"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6cf228d4b81f66a9b5f48834f1713f9d02a0e93d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c0723a3_0ed7aac3","updated":"2023-02-01 14:38:32.000000000","message":"check experimental","commit_id":"e394da46e178b1bddca10c8698cd81da23b27bac"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"4c83c1fc5feaa0bdc77bd52151abd16bfa1b1757","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"52eba810_8035ca8c","updated":"2023-02-01 05:39:07.000000000","message":"i woke up in the midel of the night so im going to try and make use fo this time by redeploying the series form this revsiion and re doing the manual test again.\n\n\nill update the etherpad with my findings and report back but i think at this point the feature is complete in a very useful way.\n\nassuming my manual testing passes i will be very happy to see this merge.\nthanks dan for taking on board the feedback i provided eailier and adding more checks.","commit_id":"e394da46e178b1bddca10c8698cd81da23b27bac"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"77d22853d90b2d35c8abb4bed55383f9300368a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4e1416d7_3b175dc9","updated":"2023-01-31 21:57:48.000000000","message":"recheck functional failure unrelated","commit_id":"e394da46e178b1bddca10c8698cd81da23b27bac"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6c910acce3173cb3d7c563758c746565f03bb341","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"886dcda8_31cdcca0","in_reply_to":"52eba810_8035ca8c","updated":"2023-02-01 08:12:38.000000000","message":"ok finished my manual testing you get a 9.5/10\n\nall testcases that matter passed\ntest 4 which is actully indistiguishable form a green filed where two host have the same name is the only one that i want to call your attention to  explictly although you might wnat to read over my other notes\n\nhttps://etherpad.opendev.org/p/Stable-compute-uuid-manual-testing#L476\n\nin this case we are still not catching the duplicate key error form the compute node creation in the perodic task.\n\nif you still have energy for this as a follow up it would be nice to catch that and log a better error.\n\nwe changed breilfly about aborting the agent form the perodic and we were not sure that was a good idea.\n\nI would be happy to merge this series as is based on this testing. happier if that traceback was caught and logged with a nicer error but thats not requried.\n\nthanks for working on this dan.","commit_id":"e394da46e178b1bddca10c8698cd81da23b27bac"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"95a3be4c2f62f3f7184c702b75a2753982697057","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"12fe0d3e_cd52a9f2","in_reply_to":"6762d31c_97da291c","updated":"2023-02-02 14:44:30.000000000","message":"Ack","commit_id":"e394da46e178b1bddca10c8698cd81da23b27bac"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f504858ad633e5df557bc0810ab167fe435adc6f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6762d31c_97da291c","in_reply_to":"886dcda8_31cdcca0","updated":"2023-02-01 15:04:39.000000000","message":"\u003e ok finished my manual testing you get a 9.5/10\n\u003e \n\u003e all testcases that matter passed\n\u003e test 4 which is actully indistiguishable form a green filed where two host have the same name is the only one that i want to call your attention to  explictly although you might wnat to read over my other notes\n\u003e \n\u003e https://etherpad.opendev.org/p/Stable-compute-uuid-manual-testing#L476\n\u003e \n\u003e in this case we are still not catching the duplicate key error form the compute node creation in the perodic task.\n\u003e \n\u003e if you still have energy for this as a follow up it would be nice to catch that and log a better error.\n\u003e \n\u003e we changed breilfly about aborting the agent form the perodic and we were not sure that was a good idea.\n\nI\u0027ve been looking into this since we talked and we actually *are* running the update method during startup, after init_host and before we enter the running phase of the service. I have yet to figure out *why* we\u0027re not aborting startup there, but are the next time we run it. So yeah, I\u0027m still chasing it down.\n\nAlso, however, it doesn\u0027t appear that we\u0027ll be able to get away with anything other than a traceback if we abort the startup. I\u0027ve tried a couple ways to get oslo.service to not continue startup (like self.stop()) and nothing seems to work other than a raise (without a change to oslo of course).","commit_id":"e394da46e178b1bddca10c8698cd81da23b27bac"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"107fbb413736cda4e62ba6652adde9863d80f660","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"849f7b57_088b5e16","updated":"2023-02-03 22:36:14.000000000","message":"Looks good","commit_id":"5934f85fb9e7d18a05ef7e8a6217697bed753d4f"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"42b56feccf4b8a2a310aa80cf8276296ee077f2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4c5c5280_48f53dc3","updated":"2023-02-03 22:36:49.000000000","message":"Oops, didn\u0027t notice Sean already approved","commit_id":"5934f85fb9e7d18a05ef7e8a6217697bed753d4f"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0e993a1dcbf9260bf29f9402757e6e54f122f20f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"08a375a8_28734a01","updated":"2023-02-05 22:10:03.000000000","message":"recheck","commit_id":"5934f85fb9e7d18a05ef7e8a6217697bed753d4f"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"07445c18fe9d0ad74b68c59cae9b9f462d6b351f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b93cb014_ef1e7b80","updated":"2023-02-07 08:55:00.000000000","message":"recheck parent merged","commit_id":"5934f85fb9e7d18a05ef7e8a6217697bed753d4f"}]}