)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"224ac08eca61dcd6c97590cbafdf89ef69986041","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c73d6bc4_0e42f978","updated":"2023-02-03 22:34:58.000000000","message":"This LGTM, nice tests.","commit_id":"b10685afbdc6e2f286069cac6e8fb98ef2c72655"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"b91a349cae984b5b5382d6287255ae040d3a2306","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"916a0dd5_c7039773","updated":"2023-02-05 22:10:30.000000000","message":"recheck","commit_id":"b10685afbdc6e2f286069cac6e8fb98ef2c72655"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5dc60788f335da865bc85306ac35ae2cc0f9c2e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"443321c5_0cd5eae3","updated":"2023-02-02 14:25:35.000000000","message":"recheck failed a glance test","commit_id":"b10685afbdc6e2f286069cac6e8fb98ef2c72655"}],"nova/tests/functional/test_service.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"224ac08eca61dcd6c97590cbafdf89ef69986041","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        self.useFixture(nova_fixtures.GlanceFixture(self))"},{"line_number":155,"context_line":"        self.useFixture(func_fixtures.PlacementFixture())"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        self._local_uuid \u003d str(uuids.node)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":160,"context_line":"            \u0027nova.virt.node.get_local_node_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a2e4a913_65b2f185","line":157,"range":{"start_line":157,"start_character":27,"end_line":157,"end_character":30},"updated":"2023-02-03 22:34:58.000000000","message":"Pretty sure uuids.node is already a string but obviously this doesn\u0027t hurt :)","commit_id":"b10685afbdc6e2f286069cac6e8fb98ef2c72655"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"4fa6aad5160448a09511ceadec92e2d8e9127e3b","unresolved":true,"context_lines":[{"line_number":154,"context_line":"        self.useFixture(nova_fixtures.GlanceFixture(self))"},{"line_number":155,"context_line":"        self.useFixture(func_fixtures.PlacementFixture())"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        self._local_uuid \u003d str(uuids.node)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        self.useFixture(fixtures.MockPatch("},{"line_number":160,"context_line":"            \u0027nova.virt.node.get_local_node_uuid\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"f28c0545_6c91a464","line":157,"range":{"start_line":157,"start_character":27,"end_line":157,"end_character":30},"in_reply_to":"a2e4a913_65b2f185","updated":"2023-02-06 15:17:50.000000000","message":"They were (at one point) uuid.UUID4 objects, but yeah, looks like after the oslo move (at least) they\u0027re using the oslo uuid (string) generator. Mah bad.","commit_id":"b10685afbdc6e2f286069cac6e8fb98ef2c72655"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"534bb1f780c922f83b3a224ed7658756dd55bd99","unresolved":true,"context_lines":[{"line_number":221,"context_line":"        # useful error message about why."},{"line_number":222,"context_line":"        exc \u003d self.assertRaises(exception.InvalidConfiguration,"},{"line_number":223,"context_line":"                                self.start_service, \u0027compute\u0027)"},{"line_number":224,"context_line":"        self.assertIn(\u0027Duplicate compute node record\u0027, str(exc))"}],"source_content_type":"text/x-python","patch_set":2,"id":"35664fed_243a657d","line":224,"updated":"2023-02-03 12:32:07.000000000","message":"+1\n\nyou could add changing CONF.host to these test but this nicly cpatures most of the edgecaches nova now gurads against\n\nthats tested eairler in the series but its kind of nice to have them all here too.","commit_id":"b10685afbdc6e2f286069cac6e8fb98ef2c72655"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"880083411b9efda8675c2a6d2f7b1e2538fc0b58","unresolved":true,"context_lines":[{"line_number":221,"context_line":"        # useful error message about why."},{"line_number":222,"context_line":"        exc \u003d self.assertRaises(exception.InvalidConfiguration,"},{"line_number":223,"context_line":"                                self.start_service, \u0027compute\u0027)"},{"line_number":224,"context_line":"        self.assertIn(\u0027Duplicate compute node record\u0027, str(exc))"}],"source_content_type":"text/x-python","patch_set":2,"id":"e00e10e1_c0ad5b3e","line":224,"in_reply_to":"35664fed_243a657d","updated":"2023-02-03 14:55:53.000000000","message":"The \"hostname_changed\" one above is the case you\u0027re looking for. When we start the services via the test harness in this way, we\u0027re commanding their `manager.host` value, which is what gets set from `CONF.host` normally. I confirmed that with one of these test cases where I flip `CONF.host` around and it doesn\u0027t notice. If I was using the libvirt driver or something, it\u0027s possible that there is a deeper case of looking at it, but not with the fake driver like this.","commit_id":"b10685afbdc6e2f286069cac6e8fb98ef2c72655"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"caf518331789d8f9b635d0aea9fe564566a2c8da","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        # useful error message about why."},{"line_number":222,"context_line":"        exc \u003d self.assertRaises(exception.InvalidConfiguration,"},{"line_number":223,"context_line":"                                self.start_service, \u0027compute\u0027)"},{"line_number":224,"context_line":"        self.assertIn(\u0027Duplicate compute node record\u0027, str(exc))"}],"source_content_type":"text/x-python","patch_set":2,"id":"738f2d62_dcdb10f0","line":224,"in_reply_to":"e00e10e1_c0ad5b3e","updated":"2023-02-03 15:03:20.000000000","message":"Ack","commit_id":"b10685afbdc6e2f286069cac6e8fb98ef2c72655"}]}